[INFO] cloning repository https://github.com/JYeswak/100minds-mcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JYeswak/100minds-mcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJYeswak%2F100minds-mcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJYeswak%2F100minds-mcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2ab050e097090dc0f51932ba309b872e81dd28f8 [INFO] linting JYeswak/100minds-mcp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJYeswak%2F100minds-mcp" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/JYeswak/100minds-mcp [INFO] finished tweaking git repo https://github.com/JYeswak/100minds-mcp [INFO] tweaked toml for git repo https://github.com/JYeswak/100minds-mcp written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JYeswak/100minds-mcp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JYeswak/100minds-mcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hmac-sha256 v1.1.13 [INFO] [stderr] Downloaded ort-sys v2.0.0-rc.11 [INFO] [stderr] Downloaded ureq v3.1.4 [INFO] [stderr] Downloaded libloading v0.9.0 [INFO] [stderr] Downloaded statrs v0.17.1 [INFO] [stderr] Downloaded webpki-root-certs v1.0.5 [INFO] [stderr] Downloaded tokenizers v0.20.4 [INFO] [stderr] Downloaded ort v2.0.0-rc.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fb8f5ecf65b2bc86d88f5385700a383a704c6fa1b925370cf76b482ac32fb3f [INFO] running `Command { std: "docker" "start" "-a" "6fb8f5ecf65b2bc86d88f5385700a383a704c6fa1b925370cf76b482ac32fb3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fb8f5ecf65b2bc86d88f5385700a383a704c6fa1b925370cf76b482ac32fb3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fb8f5ecf65b2bc86d88f5385700a383a704c6fa1b925370cf76b482ac32fb3f", kill_on_drop: false }` [INFO] [stdout] 6fb8f5ecf65b2bc86d88f5385700a383a704c6fa1b925370cf76b482ac32fb3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ffe0f08c45e0a16e2c10b30f4cb1b6cd16d2549da5f9040d80a8de11147e1ac [INFO] running `Command { std: "docker" "start" "-a" "5ffe0f08c45e0a16e2c10b30f4cb1b6cd16d2549da5f9040d80a8de11147e1ac", kill_on_drop: false }` [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Compiling zerocopy v0.8.35 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling zerocopy-derive v0.8.35 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling base64ct v1.8.3 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling rustls-pki-types v1.14.0 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling openssl-probe v0.1.6 [INFO] [stderr] Compiling utf-8 v0.7.6 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling pem-rfc7468 v0.7.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling hmac-sha256 v1.1.13 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling webpki-root-certs v1.0.5 [INFO] [stderr] Compiling der v0.7.10 [INFO] [stderr] Compiling lzma-rust2 v0.15.7 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling http v1.4.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling socks v0.3.4 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling monostate-impl v0.1.18 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.2.2 [INFO] [stderr] Compiling ureq-proto v0.5.3 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Compiling esaxx-rs v0.1.10 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking macro_rules_attribute v0.2.2 [INFO] [stderr] Checking monostate v0.1.18 [INFO] [stderr] Checking rayon-cond v0.3.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking ndarray v0.17.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking spm_precompiled v0.1.4 [INFO] [stderr] Checking libloading v0.9.0 [INFO] [stderr] Checking unicode-normalization-alignments v0.1.12 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking tokio-test v0.4.5 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling ureq v3.1.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking tokenizers v0.20.4 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Compiling ort-sys v2.0.0-rc.11 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking ort v2.0.0-rc.11 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking hf-hub v0.3.2 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking statrs v0.17.1 [INFO] [stderr] Checking minds-mcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/eval/data_driven.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/neural_posterior.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vocab` [INFO] [stdout] --> src/neural_posterior.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | let vocab = NeuralVocab { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_vocab` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(effective_obs as u32)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/eval/swarm_posterior.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 93 | self.observations = (effective_obs as u32).max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(effective_obs as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/db.rs:872:17 [INFO] [stdout] | [INFO] [stdout] 872 | assert!(sample >= 0.0 && sample <= 1.0, "Sample should be in [0, 1]"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/db.rs:880:17 [INFO] [stdout] | [INFO] [stdout] 880 | assert!(sample >= 0.0 && sample <= 1.0, "Sample should be in [0, 1]"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/eval/bandit.rs:556:17 [INFO] [stdout] | [INFO] [stdout] 556 | assert!(sample >= 0.0 && sample <= 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/eval/data_driven.rs:385:17 [INFO] [stdout] | [INFO] [stdout] 385 | assert!(score >= 2.0 && score <= 5.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2.0..=5.0).contains(&score)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/eval/llm_judge.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | assert!(judgment.weaknesses.len() >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!judgment.weaknesses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(effective_obs as u32)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/eval/swarm_posterior.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 93 | self.observations = (effective_obs as u32).max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(effective_obs as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mcp.rs:1076:17 [INFO] [stdout] | [INFO] [stdout] 1076 | assert!(analysis.blind_spots.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!analysis.blind_spots.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:2569:13 [INFO] [stdout] | [INFO] [stdout] 2569 | sorted.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2569 - sorted.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 2569 + sorted.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:3057:17 [INFO] [stdout] | [INFO] [stdout] 3057 | / if i + 1 < args.len() { [INFO] [stdout] 3058 | | i += 1; [INFO] [stdout] 3059 | | principles = args[i].split(',').map(|s| s.trim().to_string()).collect(); [INFO] [stdout] 3060 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3056 ~ "--principles" [INFO] [stdout] 3057 ~ if i + 1 < args.len() => { [INFO] [stdout] 3058 | i += 1; [INFO] [stdout] 3059 | principles = args[i].split(',').map(|s| s.trim().to_string()).collect(); [INFO] [stdout] 3060 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:3063:17 [INFO] [stdout] | [INFO] [stdout] 3063 | / if i + 1 < args.len() { [INFO] [stdout] 3064 | | i += 1; [INFO] [stdout] 3065 | | notes = args[i].clone(); [INFO] [stdout] 3066 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3062 ~ "--notes" [INFO] [stdout] 3063 ~ if i + 1 < args.len() => { [INFO] [stdout] 3064 | i += 1; [INFO] [stdout] 3065 | notes = args[i].clone(); [INFO] [stdout] 3066 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:3069:17 [INFO] [stdout] | [INFO] [stdout] 3069 | / if i + 1 < args.len() { [INFO] [stdout] 3070 | | i += 1; [INFO] [stdout] 3071 | | context_pattern = Some(args[i].clone()); [INFO] [stdout] 3072 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3068 ~ "--context" [INFO] [stdout] 3069 ~ if i + 1 < args.len() => { [INFO] [stdout] 3070 | i += 1; [INFO] [stdout] 3071 | context_pattern = Some(args[i].clone()); [INFO] [stdout] 3072 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:2569:13 [INFO] [stdout] | [INFO] [stdout] 2569 | sorted.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2569 - sorted.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 2569 + sorted.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:3057:17 [INFO] [stdout] | [INFO] [stdout] 3057 | / if i + 1 < args.len() { [INFO] [stdout] 3058 | | i += 1; [INFO] [stdout] 3059 | | principles = args[i].split(',').map(|s| s.trim().to_string()).collect(); [INFO] [stdout] 3060 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3056 ~ "--principles" [INFO] [stdout] 3057 ~ if i + 1 < args.len() => { [INFO] [stdout] 3058 | i += 1; [INFO] [stdout] 3059 | principles = args[i].split(',').map(|s| s.trim().to_string()).collect(); [INFO] [stdout] 3060 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:3063:17 [INFO] [stdout] | [INFO] [stdout] 3063 | / if i + 1 < args.len() { [INFO] [stdout] 3064 | | i += 1; [INFO] [stdout] 3065 | | notes = args[i].clone(); [INFO] [stdout] 3066 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3062 ~ "--notes" [INFO] [stdout] 3063 ~ if i + 1 < args.len() => { [INFO] [stdout] 3064 | i += 1; [INFO] [stdout] 3065 | notes = args[i].clone(); [INFO] [stdout] 3066 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:3069:17 [INFO] [stdout] | [INFO] [stdout] 3069 | / if i + 1 < args.len() { [INFO] [stdout] 3070 | | i += 1; [INFO] [stdout] 3071 | | context_pattern = Some(args[i].clone()); [INFO] [stdout] 3072 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3068 ~ "--context" [INFO] [stdout] 3069 ~ if i + 1 < args.len() => { [INFO] [stdout] 3070 | i += 1; [INFO] [stdout] 3071 | context_pattern = Some(args[i].clone()); [INFO] [stdout] 3072 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.99s [INFO] running `Command { std: "docker" "inspect" "5ffe0f08c45e0a16e2c10b30f4cb1b6cd16d2549da5f9040d80a8de11147e1ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ffe0f08c45e0a16e2c10b30f4cb1b6cd16d2549da5f9040d80a8de11147e1ac", kill_on_drop: false }` [INFO] [stdout] 5ffe0f08c45e0a16e2c10b30f4cb1b6cd16d2549da5f9040d80a8de11147e1ac