[INFO] cloning repository https://github.com/JEck05/conways_game_of_life [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JEck05/conways_game_of_life" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJEck05%2Fconways_game_of_life", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJEck05%2Fconways_game_of_life'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0e3bb5c6ea7e2dbf677811e4cd0b3495f910f08e [INFO] linting JEck05/conways_game_of_life against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJEck05%2Fconways_game_of_life" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JEck05/conways_game_of_life [INFO] finished tweaking git repo https://github.com/JEck05/conways_game_of_life [INFO] tweaked toml for git repo https://github.com/JEck05/conways_game_of_life written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JEck05/conways_game_of_life on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JEck05/conways_game_of_life already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7016731e18218a1f3bd720b120678908ef27f5989a4e92d59dcada9162434d53 [INFO] running `Command { std: "docker" "start" "-a" "7016731e18218a1f3bd720b120678908ef27f5989a4e92d59dcada9162434d53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7016731e18218a1f3bd720b120678908ef27f5989a4e92d59dcada9162434d53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7016731e18218a1f3bd720b120678908ef27f5989a4e92d59dcada9162434d53", kill_on_drop: false }` [INFO] [stdout] 7016731e18218a1f3bd720b120678908ef27f5989a4e92d59dcada9162434d53 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 801a033557e9db7f17442ab81eb3dcde3b3075550dd595762bc4a0adb5420dd5 [INFO] running `Command { std: "docker" "start" "-a" "801a033557e9db7f17442ab81eb3dcde3b3075550dd595762bc4a0adb5420dd5", kill_on_drop: false }` [INFO] [stderr] Checking conways_game_of_life v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/board.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | if !(x >= width) && !(y >= height) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(x < width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/board.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | if !(x >= width) && !(y >= height) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(y < height)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/game/board.rs:47:39 [INFO] [stdout] | [INFO] [stdout] 47 | if curr_cell.alive && (num_of_neighbors < 2 || num_of_neighbors > 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2..=3).contains(&num_of_neighbors)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/game/board.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 62 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/board.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | if !(x >= width) && !(y >= height) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(x < width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/board.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | if !(x >= width) && !(y >= height) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(y < height)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/game/board.rs:47:39 [INFO] [stdout] | [INFO] [stdout] 47 | if curr_cell.alive && (num_of_neighbors < 2 || num_of_neighbors > 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2..=3).contains(&num_of_neighbors)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/game/board.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 62 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> src/game.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> Self { [INFO] [stdout] 17 | | let default_handler: Rc = Rc::new(ConsoleOutputHandler::new()); [INFO] [stdout] 18 | | Game { output_observers: RefCell::new(vec![Rc::downgrade(&default_handler)]), board: RefCell::new(None), default_handler} [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for Game { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Game` [INFO] [stdout] --> src/game.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> Self { [INFO] [stdout] 17 | | let default_handler: Rc = Rc::new(ConsoleOutputHandler::new()); [INFO] [stdout] 18 | | Game { output_observers: RefCell::new(vec![Rc::downgrade(&default_handler)]), board: RefCell::new(None), default_handler} [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for Game { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game.rs:53:53 [INFO] [stdout] | [INFO] [stdout] 53 | !Weak::ptr_eq(observers, &Rc::downgrade(&observer)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `observer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game.rs:53:53 [INFO] [stdout] | [INFO] [stdout] 53 | !Weak::ptr_eq(observers, &Rc::downgrade(&observer)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `observer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | / match observer.upgrade() { [INFO] [stdout] 63 | | Some(value) => value.display(&board), [INFO] [stdout] 64 | | None=> (), [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(value) = observer.upgrade() { value.display(&board) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConsoleOutputHandler` [INFO] [stdout] --> src/board_output_handlers/console_output_handler.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new() -> Self { [INFO] [stdout] 8 | | ConsoleOutputHandler [INFO] [stdout] 9 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for ConsoleOutputHandler { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | / match observer.upgrade() { [INFO] [stdout] 63 | | Some(value) => value.display(&board), [INFO] [stdout] 64 | | None=> (), [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(value) = observer.upgrade() { value.display(&board) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConsoleOutputHandler` [INFO] [stdout] --> src/board_output_handlers/console_output_handler.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new() -> Self { [INFO] [stdout] 8 | | ConsoleOutputHandler [INFO] [stdout] 9 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 6 + impl Default for ConsoleOutputHandler { [INFO] [stdout] 7 + fn default() -> Self { [INFO] [stdout] 8 + Self::new() [INFO] [stdout] 9 + } [INFO] [stdout] 10 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/board_output_handlers.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | fn display(&self, board: &Vec>); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/board_output_handlers.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | fn display(&self, board: &Vec>); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/main.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let _gosper_glider = vec![(7+24, 20+0), (7+22, 20+1), (7+24, 20+1), [INFO] [stdout] | ^^^^ help: consider reducing it to: `20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/main.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | (7+0, 20+4), (7+1, 20+4), (7+10, 20+4), (7+16, 20+4), (7+20, 20+4), (7+21, 20+4), [INFO] [stdout] | ^^^ help: consider reducing it to: `7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/main.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 22 | (7+0, 20+5), (7+1, 20+5), (7+10, 20+5), (7+14, 20+5), (7+16, 20+5), (7+17, 20+5), (7+22, 20+5), (7+24, 20+5), [INFO] [stdout] | ^^^ help: consider reducing it to: `7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/bin/main.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / let _ = Game::new() [INFO] [stdout] 28 | | [INFO] [stdout] 29 | | .add_output_handlers(Rc::new(TextOutputHandler::new(String::from("Hello")))) [INFO] [stdout] 30 | | .initialize_board(10, 10, vec1) [INFO] [stdout] 31 | | .start_game(10); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 27 - let _ = Game::new() [INFO] [stdout] 27 + Game::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/main.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | let _vec = vec![(4,4), (4, 5), (4, 6)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[(4,4), (4, 5), (4, 6)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/main.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | let _vec2 = vec![(0, 3), (0, 4), (2, 3), (2, 4), (1, 2), (1 ,5)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[(0, 3), (0, 4), (2, 3), (2, 4), (1, 2), (1 ,5)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/main.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | let _vec4 = vec![(0, 0), (0, 1), (0, 2), (0, 3), (1, 2)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[(0, 0), (0, 1), (0, 2), (0, 3), (1, 2)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/main.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let _gosper_glider = vec![(7+24, 20+0), (7+22, 20+1), (7+24, 20+1), [INFO] [stdout] | ^^^^ help: consider reducing it to: `20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/main.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | (7+0, 20+4), (7+1, 20+4), (7+10, 20+4), (7+16, 20+4), (7+20, 20+4), (7+21, 20+4), [INFO] [stdout] | ^^^ help: consider reducing it to: `7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/main.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 22 | (7+0, 20+5), (7+1, 20+5), (7+10, 20+5), (7+14, 20+5), (7+16, 20+5), (7+17, 20+5), (7+22, 20+5), (7+24, 20+5), [INFO] [stdout] | ^^^ help: consider reducing it to: `7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/bin/main.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / let _ = Game::new() [INFO] [stdout] 28 | | [INFO] [stdout] 29 | | .add_output_handlers(Rc::new(TextOutputHandler::new(String::from("Hello")))) [INFO] [stdout] 30 | | .initialize_board(10, 10, vec1) [INFO] [stdout] 31 | | .start_game(10); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 27 - let _ = Game::new() [INFO] [stdout] 27 + Game::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/main.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | let _vec = vec![(4,4), (4, 5), (4, 6)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[(4,4), (4, 5), (4, 6)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/main.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | let _vec2 = vec![(0, 3), (0, 4), (2, 3), (2, 4), (1, 2), (1 ,5)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[(0, 3), (0, 4), (2, 3), (2, 4), (1, 2), (1 ,5)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/bin/main.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | let _vec4 = vec![(0, 0), (0, 1), (0, 2), (0, 3), (1, 2)]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[(0, 0), (0, 1), (0, 2), (0, 3), (1, 2)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s [INFO] running `Command { std: "docker" "inspect" "801a033557e9db7f17442ab81eb3dcde3b3075550dd595762bc4a0adb5420dd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "801a033557e9db7f17442ab81eb3dcde3b3075550dd595762bc4a0adb5420dd5", kill_on_drop: false }` [INFO] [stdout] 801a033557e9db7f17442ab81eb3dcde3b3075550dd595762bc4a0adb5420dd5