[INFO] cloning repository https://github.com/IvanLi-CN/codex-vibe-monitor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IvanLi-CN/codex-vibe-monitor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvanLi-CN%2Fcodex-vibe-monitor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvanLi-CN%2Fcodex-vibe-monitor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3eba4d25f2d30e1b167fd03060c0843a92dec914 [INFO] linting IvanLi-CN/codex-vibe-monitor against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvanLi-CN%2Fcodex-vibe-monitor" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-6-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/IvanLi-CN/codex-vibe-monitor [INFO] finished tweaking git repo https://github.com/IvanLi-CN/codex-vibe-monitor [INFO] tweaked toml for git repo https://github.com/IvanLi-CN/codex-vibe-monitor written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IvanLi-CN/codex-vibe-monitor on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IvanLi-CN/codex-vibe-monitor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cc v1.2.43 [INFO] [stderr] Downloaded rustls v0.23.34 [INFO] [stderr] Downloaded chrono-tz v0.10.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5dda05f223133b162f4f2c9fc7b9050f118aef1c9e42e0bed669f4ffcd3f3e2 [INFO] running `Command { std: "docker" "start" "-a" "c5dda05f223133b162f4f2c9fc7b9050f118aef1c9e42e0bed669f4ffcd3f3e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5dda05f223133b162f4f2c9fc7b9050f118aef1c9e42e0bed669f4ffcd3f3e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5dda05f223133b162f4f2c9fc7b9050f118aef1c9e42e0bed669f4ffcd3f3e2", kill_on_drop: false }` [INFO] [stdout] c5dda05f223133b162f4f2c9fc7b9050f118aef1c9e42e0bed669f4ffcd3f3e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4bded6f659d9ed61565c98a589c94e44c1dfe0280e243d7ecc5c0a29efc7378c [INFO] running `Command { std: "docker" "start" "-a" "4bded6f659d9ed61565c98a589c94e44c1dfe0280e243d7ecc5c0a29efc7378c", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Compiling cc v1.2.43 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling rustls v0.23.34 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking phf_shared v0.12.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Compiling indexmap v2.12.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling tokio v1.48.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking webpki-roots v1.0.3 [INFO] [stderr] Compiling chrono-tz v0.10.4 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking phf v0.12.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling axum-macros v0.4.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Compiling sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking codex-vibe-monitor v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `sha2::digest::generic_array::GenericArray::::as_slice`: please upgrade to generic-array 1.x [INFO] [stdout] --> src/tests/mod.rs:2822:48 [INFO] [stdout] | [INFO] [stdout] 2822 | let cipher = Aes256Gcm::new_from_slice(key.as_slice()).expect("valid aes key"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `sha2::digest::generic_array::GenericArray::::from_slice`: please upgrade to generic-array 1.x [INFO] [stdout] --> src/tests/mod.rs:2834:34 [INFO] [stdout] | [INFO] [stdout] 2834 | .encrypt(aes_gcm::Nonce::from_slice(&nonce), plaintext.as_ref()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AccountLastActivityRow` is never constructed [INFO] [stdout] --> src/upstream_accounts/mod.rs:759:8 [INFO] [stdout] | [INFO] [stdout] 759 | struct AccountLastActivityRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `load_account_last_activity_map` is never used [INFO] [stdout] --> src/upstream_accounts/mod.rs:4167:21 [INFO] [stdout] | [INFO] [stdout] 4167 | pub(crate) async fn load_account_last_activity_map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/api/mod.rs:2390:5 [INFO] [stdout] | [INFO] [stdout] 2390 | items.sort_by(|a, b| b.count.cmp(&a.count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2390 - items.sort_by(|a, b| b.count.cmp(&a.count)); [INFO] [stdout] 2390 + items.sort_by_key(|b| std::cmp::Reverse(b.count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/forward_proxy/mod.rs:2201:50 [INFO] [stdout] | [INFO] [stdout] 2201 | for endpoint in manual.into_iter().chain(subscription_endpoints.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 2201 - for endpoint in manual.into_iter().chain(subscription_endpoints.into_iter()) { [INFO] [stdout] 2201 + for endpoint in manual.into_iter().chain(subscription_endpoints) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/oauth_bridge.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | / pub(crate) async fn send_oauth_upstream_request( [INFO] [stdout] 65 | | client: &Client, [INFO] [stdout] 66 | | method: Method, [INFO] [stdout] 67 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 73 | | chatgpt_account_id: Option<&str>, [INFO] [stdout] 74 | | ) -> Response { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/oauth_bridge.rs:328:1 [INFO] [stdout] | [INFO] [stdout] 328 | / async fn oauth_passthrough( [INFO] [stdout] 329 | | client: &Client, [INFO] [stdout] 330 | | method: Method, [INFO] [stdout] 331 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 336 | | chatgpt_account_id: Option<&str>, [INFO] [stdout] 337 | | ) -> Response { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/oauth_bridge.rs:573:5 [INFO] [stdout] | [INFO] [stdout] 573 | / if let Ok(value) = serde_json::from_slice::(bytes) { [INFO] [stdout] 574 | | if let Some(message) = value [INFO] [stdout] 575 | | .get("error") [INFO] [stdout] 576 | | .and_then(|error| error.get("message")) [INFO] [stdout] ... | [INFO] [stdout] 585 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 573 ~ if let Ok(value) = serde_json::from_slice::(bytes) [INFO] [stdout] 574 ~ && let Some(message) = value [INFO] [stdout] 575 | .get("error") [INFO] [stdout] ... [INFO] [stdout] 583 | } [INFO] [stdout] 584 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/upstream_accounts/mod.rs:3842:42 [INFO] [stdout] | [INFO] [stdout] 3842 | sync_account_tag_links_with_executor(&mut *tx, account_id, tag_ids).await?; [INFO] [stdout] | ^^^^^^^^ help: try: `&mut tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:6856:25 [INFO] [stdout] | [INFO] [stdout] 6856 | / let Some((path, remaining, file)) = state else { [INFO] [stdout] 6857 | | return None; [INFO] [stdout] 6858 | | }; [INFO] [stdout] | |__________________________^ help: replace it with: `let (path, remaining, file) = state?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/main.rs:7021:1 [INFO] [stdout] | [INFO] [stdout] 7021 | / async fn send_pool_request_with_failover( [INFO] [stdout] 7022 | | state: Arc, [INFO] [stdout] 7023 | | method: Method, [INFO] [stdout] 7024 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 7030 | | same_account_attempts: u8, [INFO] [stdout] 7031 | | ) -> Result { [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/main.rs:7510:1 [INFO] [stdout] | [INFO] [stdout] 7510 | / async fn continue_or_retry_pool_live_request( [INFO] [stdout] 7511 | | state: Arc, [INFO] [stdout] 7512 | | method: Method, [INFO] [stdout] 7513 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 7520 | | first_error: PoolUpstreamError, [INFO] [stdout] 7521 | | ) -> Result { [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:9059:13 [INFO] [stdout] | [INFO] [stdout] 9059 | &original_uri, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `original_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:10912:5 [INFO] [stdout] | [INFO] [stdout] 10912 | models.sort_by(|(a, _), (b, _)| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10912 - models.sort_by(|(a, _), (b, _)| a.cmp(b)); [INFO] [stdout] 10912 + models.sort_by_key(|(a, _)| *a); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `spawn_pool_http_failure_upstream` is never used [INFO] [stdout] --> src/tests/mod.rs:9431:10 [INFO] [stdout] | [INFO] [stdout] 9431 | async fn spawn_pool_http_failure_upstream( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/api/mod.rs:2390:5 [INFO] [stdout] | [INFO] [stdout] 2390 | items.sort_by(|a, b| b.count.cmp(&a.count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 2390 - items.sort_by(|a, b| b.count.cmp(&a.count)); [INFO] [stdout] 2390 + items.sort_by_key(|b| std::cmp::Reverse(b.count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/forward_proxy/mod.rs:2201:50 [INFO] [stdout] | [INFO] [stdout] 2201 | for endpoint in manual.into_iter().chain(subscription_endpoints.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 2201 - for endpoint in manual.into_iter().chain(subscription_endpoints.into_iter()) { [INFO] [stdout] 2201 + for endpoint in manual.into_iter().chain(subscription_endpoints) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/oauth_bridge.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | / pub(crate) async fn send_oauth_upstream_request( [INFO] [stdout] 65 | | client: &Client, [INFO] [stdout] 66 | | method: Method, [INFO] [stdout] 67 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 73 | | chatgpt_account_id: Option<&str>, [INFO] [stdout] 74 | | ) -> Response { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/oauth_bridge.rs:328:1 [INFO] [stdout] | [INFO] [stdout] 328 | / async fn oauth_passthrough( [INFO] [stdout] 329 | | client: &Client, [INFO] [stdout] 330 | | method: Method, [INFO] [stdout] 331 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 336 | | chatgpt_account_id: Option<&str>, [INFO] [stdout] 337 | | ) -> Response { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/oauth_bridge.rs:573:5 [INFO] [stdout] | [INFO] [stdout] 573 | / if let Ok(value) = serde_json::from_slice::(bytes) { [INFO] [stdout] 574 | | if let Some(message) = value [INFO] [stdout] 575 | | .get("error") [INFO] [stdout] 576 | | .and_then(|error| error.get("message")) [INFO] [stdout] ... | [INFO] [stdout] 585 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 573 ~ if let Ok(value) = serde_json::from_slice::(bytes) [INFO] [stdout] 574 ~ && let Some(message) = value [INFO] [stdout] 575 | .get("error") [INFO] [stdout] ... [INFO] [stdout] 583 | } [INFO] [stdout] 584 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/tests/mod.rs:9544:9 [INFO] [stdout] | [INFO] [stdout] 9544 | let attempts = attempts.lock().expect("lock attempts"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/tests/mod.rs:9550:10 [INFO] [stdout] | [INFO] [stdout] 9550 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/tests/mod.rs:9594:9 [INFO] [stdout] | [INFO] [stdout] 9594 | let attempts = attempts.lock().expect("lock attempts"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/tests/mod.rs:9603:14 [INFO] [stdout] | [INFO] [stdout] 9603 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 9607 | wait_for_test_sticky_route_account_id(&state.pool, "sticky-002").await, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/tests/mod.rs:9650:9 [INFO] [stdout] | [INFO] [stdout] 9650 | let attempts = attempts.lock().expect("lock attempts"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/tests/mod.rs:9656:10 [INFO] [stdout] | [INFO] [stdout] 9656 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/tests/mod.rs:9700:9 [INFO] [stdout] | [INFO] [stdout] 9700 | let attempts = attempts.lock().expect("lock attempts"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/tests/mod.rs:9709:14 [INFO] [stdout] | [INFO] [stdout] 9709 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 9713 | wait_for_test_sticky_route_account_id(&state.pool, "sticky-004").await, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/tests/mod.rs:9766:9 [INFO] [stdout] | [INFO] [stdout] 9766 | let attempts = attempts.lock().expect("lock attempts"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/tests/mod.rs:9771:48 [INFO] [stdout] | [INFO] [stdout] 9771 | wait_for_codex_invocations(&state.pool, 1).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 9772 | assert_eq!(count_codex_invocations(&state.pool).await, 1); [INFO] [stdout] | ^^^^^ [INFO] [stdout] 9773 | assert_eq!(count_request_forward_proxy_attempts(&state.pool).await, 0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 9784 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 9805 | wait_for_test_sticky_route_account_id(&state.pool, "sticky-cap-001").await, [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/tests/mod.rs:16455:1 [INFO] [stdout] | [INFO] [stdout] 16455 | / async fn insert_invocation_rollup( [INFO] [stdout] 16456 | | pool: &SqlitePool, [INFO] [stdout] 16457 | | stats_date: NaiveDate, [INFO] [stdout] 16458 | | source: &str, [INFO] [stdout] ... | [INFO] [stdout] 16463 | | total_cost: f64, [INFO] [stdout] 16464 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/upstream_accounts/mod.rs:3842:42 [INFO] [stdout] | [INFO] [stdout] 3842 | sync_account_tag_links_with_executor(&mut *tx, account_id, tag_ids).await?; [INFO] [stdout] | ^^^^^^^^ help: try: `&mut tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&first_id).is_none()` [INFO] [stdout] --> src/upstream_accounts/mod.rs:7789:32 [INFO] [stdout] | [INFO] [stdout] 7789 | assert!(duplicate_info.get(&first_id).is_none()); [INFO] [stdout] | ---------------^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!duplicate_info.contains_key(&first_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&second_id).is_none()` [INFO] [stdout] --> src/upstream_accounts/mod.rs:7790:32 [INFO] [stdout] | [INFO] [stdout] 7790 | assert!(duplicate_info.get(&second_id).is_none()); [INFO] [stdout] | ---------------^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!duplicate_info.contains_key(&second_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:6856:25 [INFO] [stdout] | [INFO] [stdout] 6856 | / let Some((path, remaining, file)) = state else { [INFO] [stdout] 6857 | | return None; [INFO] [stdout] 6858 | | }; [INFO] [stdout] | |__________________________^ help: replace it with: `let (path, remaining, file) = state?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/main.rs:7021:1 [INFO] [stdout] | [INFO] [stdout] 7021 | / async fn send_pool_request_with_failover( [INFO] [stdout] 7022 | | state: Arc, [INFO] [stdout] 7023 | | method: Method, [INFO] [stdout] 7024 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 7030 | | same_account_attempts: u8, [INFO] [stdout] 7031 | | ) -> Result { [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/main.rs:7510:1 [INFO] [stdout] | [INFO] [stdout] 7510 | / async fn continue_or_retry_pool_live_request( [INFO] [stdout] 7511 | | state: Arc, [INFO] [stdout] 7512 | | method: Method, [INFO] [stdout] 7513 | | original_uri: &Uri, [INFO] [stdout] ... | [INFO] [stdout] 7520 | | first_error: PoolUpstreamError, [INFO] [stdout] 7521 | | ) -> Result { [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:9059:13 [INFO] [stdout] | [INFO] [stdout] 9059 | &original_uri, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `original_uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:10912:5 [INFO] [stdout] | [INFO] [stdout] 10912 | models.sort_by(|(a, _), (b, _)| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10912 - models.sort_by(|(a, _), (b, _)| a.cmp(b)); [INFO] [stdout] 10912 + models.sort_by_key(|(a, _)| *a); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `Command { std: "docker" "inspect" "4bded6f659d9ed61565c98a589c94e44c1dfe0280e243d7ecc5c0a29efc7378c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bded6f659d9ed61565c98a589c94e44c1dfe0280e243d7ecc5c0a29efc7378c", kill_on_drop: false }` [INFO] [stdout] 4bded6f659d9ed61565c98a589c94e44c1dfe0280e243d7ecc5c0a29efc7378c