[INFO] cloning repository https://github.com/IvanB101/world-generator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IvanB101/world-generator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvanB101%2Fworld-generator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvanB101%2Fworld-generator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 363923fe61597fe7b3a4d101e8011ecd913d3842 [INFO] linting IvanB101/world-generator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIvanB101%2Fworld-generator" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IvanB101/world-generator [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/IvanB101/world-generator [INFO] tweaked toml for git repo https://github.com/IvanB101/world-generator written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IvanB101/world-generator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IvanB101/world-generator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytemuck v1.19.0 [INFO] [stderr] Downloaded ordered-float v4.5.0 [INFO] [stderr] Downloaded allocator-api2 v0.2.20 [INFO] [stderr] Downloaded bevy_dylib v0.14.2 [INFO] [stderr] Downloaded bevy-inspector-egui-derive v0.27.0 [INFO] [stderr] Downloaded ecolor v0.29.1 [INFO] [stderr] Downloaded emath v0.29.1 [INFO] [stderr] Downloaded webbrowser v1.0.2 [INFO] [stderr] Downloaded bevy_framepace v0.17.1 [INFO] [stderr] Downloaded spin_sleep v1.2.1 [INFO] [stderr] Downloaded safe_arch v0.7.2 [INFO] [stderr] Downloaded wide v0.7.30 [INFO] [stderr] Downloaded epaint v0.29.1 [INFO] [stderr] Downloaded rapier3d v0.21.0 [INFO] [stderr] Downloaded bevy_egui v0.30.1 [INFO] [stderr] Downloaded bevy-inspector-egui v0.27.0 [INFO] [stderr] Downloaded parry3d v0.16.1 [INFO] [stderr] Downloaded bevy_rapier3d v0.27.0 [INFO] [stderr] Downloaded notify-debouncer-full v0.3.1 [INFO] [stderr] Downloaded file-id v0.2.1 [INFO] [stderr] Downloaded egui v0.29.1 [INFO] [stderr] Downloaded epaint_default_fonts v0.29.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7212aa760d4a56f07e253bed242e3e5b49450e2fd370c43df67cbbb8ef5e8d1d [INFO] running `Command { std: "docker" "start" "-a" "7212aa760d4a56f07e253bed242e3e5b49450e2fd370c43df67cbbb8ef5e8d1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7212aa760d4a56f07e253bed242e3e5b49450e2fd370c43df67cbbb8ef5e8d1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7212aa760d4a56f07e253bed242e3e5b49450e2fd370c43df67cbbb8ef5e8d1d", kill_on_drop: false }` [INFO] [stdout] 7212aa760d4a56f07e253bed242e3e5b49450e2fd370c43df67cbbb8ef5e8d1d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 190e2efca9dfdca72247b952bf71b04196312a1a0b4003e5a6d004fe296fe4e3 [INFO] running `Command { std: "docker" "start" "-a" "190e2efca9dfdca72247b952bf71b04196312a1a0b4003e5a6d004fe296fe4e3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling libc v0.2.164 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling hashbrown v0.15.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.20 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking fastrand v2.2.0 [INFO] [stderr] Compiling cc v1.2.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking futures-lite v2.5.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking fdeflate v0.3.6 [INFO] [stderr] Checking file-id v0.2.1 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Compiling rustix v0.38.40 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking svg_fmt v0.4.4 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking png v0.17.14 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking epaint_default_fonts v0.29.1 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling bevy_egui v0.30.1 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Compiling uuid v1.11.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking bevy_tasks v0.14.2 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking alsa-sys v0.3.1 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking libudev-sys v0.1.4 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking glyph_brush_layout v0.2.4 [INFO] [stderr] Checking taffy v0.5.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking ordered-float v4.5.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking pretty-type-name v1.0.1 [INFO] [stderr] Checking spin_sleep v1.2.1 [INFO] [stderr] Checking notify-debouncer-full v0.3.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Compiling bevy_macro_utils v0.14.2 [INFO] [stderr] Compiling encase_derive_impl v0.8.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling bytemuck_derive v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.14.2 [INFO] [stderr] Compiling bevy_reflect_derive v0.14.2 [INFO] [stderr] Compiling bevy_ecs_macros v0.14.2 [INFO] [stderr] Compiling bevy_derive v0.14.2 [INFO] [stderr] Compiling bevy_asset_macros v0.14.2 [INFO] [stderr] Compiling encase_derive v0.8.0 [INFO] [stderr] Compiling bevy_encase_derive v0.14.2 [INFO] [stderr] Compiling bevy_render_macros v0.14.2 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling gltf-derive v1.4.1 [INFO] [stderr] Compiling bevy_state_macros v0.14.2 [INFO] [stderr] Compiling bevy_gizmos_macros v0.14.2 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling bevy-inspector-egui-derive v0.27.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bytemuck v1.19.0 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking emath v0.29.1 [INFO] [stderr] Checking wide v0.7.30 [INFO] [stderr] Checking ecolor v0.29.1 [INFO] [stderr] Checking epaint v0.29.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking egui v0.29.1 [INFO] [stderr] Checking simba v0.9.0 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking wgpu-types v0.20.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking nix v0.29.0 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking bevy_utils v0.14.2 [INFO] [stderr] Checking gpu-descriptor v0.3.0 [INFO] [stderr] Checking spade v2.12.1 [INFO] [stderr] Checking gilrs-core v0.5.15 [INFO] [stderr] Checking gltf-json v1.4.1 [INFO] [stderr] Checking gilrs v0.10.10 [INFO] [stderr] Checking cpal v0.15.3 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking naga v0.20.0 [INFO] [stderr] Checking rodio v0.18.1 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking bevy_reflect v0.14.2 [INFO] [stderr] Checking encase v0.8.0 [INFO] [stderr] Checking bevy_mikktspace v0.14.2 [INFO] [stderr] Checking hexasphere v12.0.0 [INFO] [stderr] Checking nalgebra v0.33.2 [INFO] [stderr] Checking webbrowser v1.0.2 [INFO] [stderr] Checking gltf v1.4.1 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking winit v0.30.5 [INFO] [stderr] Checking arboard v3.4.1 [INFO] [stderr] Checking bevy_ecs v0.14.2 [INFO] [stderr] Checking bevy_math v0.14.2 [INFO] [stderr] Checking wgpu-hal v0.21.1 [INFO] [stderr] Checking naga_oil v0.14.0 [INFO] [stderr] Checking accesskit_winit v0.20.4 [INFO] [stderr] Checking parry3d v0.16.1 [INFO] [stderr] Checking bevy_color v0.14.3 [INFO] [stderr] Checking wgpu-core v0.21.1 [INFO] [stderr] Checking rapier3d v0.21.0 [INFO] [stderr] Checking bevy_app v0.14.2 [INFO] [stderr] Checking wgpu v0.20.1 [INFO] [stderr] Checking bevy_core v0.14.2 [INFO] [stderr] Checking bevy_time v0.14.2 [INFO] [stderr] Checking bevy_a11y v0.14.2 [INFO] [stderr] Checking bevy_asset v0.14.2 [INFO] [stderr] Checking bevy_input v0.14.2 [INFO] [stderr] Checking bevy_log v0.14.2 [INFO] [stderr] Checking bevy_window v0.14.2 [INFO] [stderr] Checking bevy_hierarchy v0.14.2 [INFO] [stderr] Checking bevy_transform v0.14.2 [INFO] [stderr] Checking bevy_state v0.14.2 [INFO] [stderr] Checking bevy_diagnostic v0.14.2 [INFO] [stderr] Checking bevy_gilrs v0.14.2 [INFO] [stderr] Checking bevy_winit v0.14.2 [INFO] [stderr] Checking bevy_render v0.14.2 [INFO] [stderr] Checking bevy_audio v0.14.2 [INFO] [stderr] Checking bevy_core_pipeline v0.14.2 [INFO] [stderr] Checking bevy_scene v0.14.2 [INFO] [stderr] Checking bevy_animation v0.14.2 [INFO] [stderr] Checking bevy_framepace v0.17.1 [INFO] [stderr] Checking bevy_sprite v0.14.2 [INFO] [stderr] Checking bevy_pbr v0.14.2 [INFO] [stderr] Checking bevy_text v0.14.2 [INFO] [stderr] Checking bevy_ui v0.14.2 [INFO] [stderr] Checking bevy_gltf v0.14.2 [INFO] [stderr] Checking bevy_gizmos v0.14.2 [INFO] [stderr] Checking bevy-inspector-egui v0.27.0 [INFO] [stderr] Checking bevy_internal v0.14.2 [INFO] [stderr] Checking bevy v0.14.2 [INFO] [stderr] Checking bevy_dylib v0.14.2 [INFO] [stderr] Checking bevy_rapier3d v0.27.0 [INFO] [stderr] Checking procedural_generation v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/utils/noise/value.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | let samples = n << n_layers - i + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `n << (n_layers - i + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/utils/noise/value.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | let samples = n << n_layers - i + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `n << (n_layers - i + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/noise/perlin.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return ((6_f32 * t - 15_f32) * t + 10_f32) * t * t * t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return ((6_f32 * t - 15_f32) * t + 10_f32) * t * t * t; [INFO] [stdout] 95 + ((6_f32 * t - 15_f32) * t + 10_f32) * t * t * t [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/noise/perlin.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return ((6_f32 * t - 15_f32) * t + 10_f32) * t * t * t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return ((6_f32 * t - 15_f32) * t + 10_f32) * t * t * t; [INFO] [stdout] 95 + ((6_f32 * t - 15_f32) * t + 10_f32) * t * t * t [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `layers` [INFO] [stdout] --> src/utils/noise/value.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | for k in 0..n_layers { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for k in 0..n_layers { [INFO] [stdout] 39 + for (k, ) in layers.iter().enumerate().take(n_layers) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `layers` [INFO] [stdout] --> src/utils/noise/value.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | for k in 0..n_layers { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for k in 0..n_layers { [INFO] [stdout] 39 + for (k, ) in layers.iter().enumerate().take(n_layers) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/visualization/noise/../../common/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | transform: transform, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/visualization/noise/../../common/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | transform: transform, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/visualization/noise/../../common/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | transform: transform, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use bevy_dylib; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/utils/noise/value.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | let samples = n << n_layers - i + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `n << (n_layers - i + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use bevy_dylib; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/utils/noise/value.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | let samples = n << n_layers - i + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `n << (n_layers - i + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/compute_shader.rs:69:14 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|x| x.to_ne_bytes()) [INFO] [stdout] | ______________^ [INFO] [stdout] 70 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.to_ne_bytes())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/player/movement.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | cameraholder_q: Query< [INFO] [stdout] | _____________________^ [INFO] [stdout] 27 | | &Transform, [INFO] [stdout] 28 | | (With, (Without, Without)), [INFO] [stdout] 29 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/player/movement.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / pub(super) fn move_player( [INFO] [stdout] 23 | | fixed_time: Res>, [INFO] [stdout] 24 | | keyboard_input: Res>, [INFO] [stdout] 25 | | keybindings: Res, [INFO] [stdout] ... | [INFO] [stdout] 45 | | rapier_configuration: Res, [INFO] [stdout] 46 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/post_processing.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 107 | ..default() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `height_map` [INFO] [stdout] --> src/terrain/height_map.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | for x in 0..samples { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 75 - for x in 0..samples { [INFO] [stdout] 75 + for (x, ) in height_map.iter().enumerate().take(samples) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `z` is used to index `height_map` [INFO] [stdout] --> src/terrain/height_map.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 76 | for z in 0..samples { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 76 - for z in 0..samples { [INFO] [stdout] 76 + for (z, ) in height_map.iter().enumerate().take(samples) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ui/menu/mod.rs:35:28 [INFO] [stdout] | [INFO] [stdout] 35 | mut interaction_query: Query< [INFO] [stdout] | ____________________________^ [INFO] [stdout] 36 | | ( [INFO] [stdout] 37 | | &Interaction, [INFO] [stdout] 38 | | &mut BackgroundColor, [INFO] [stdout] ... | [INFO] [stdout] 42 | | (Changed, With