[INFO] cloning repository https://github.com/ItzGuuh/rust-playground [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ItzGuuh/rust-playground" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FItzGuuh%2Frust-playground", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FItzGuuh%2Frust-playground'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f8ad2e21de6bf96f927f56fb377476a5806ecd03 [INFO] linting ItzGuuh/rust-playground against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FItzGuuh%2Frust-playground" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ItzGuuh/rust-playground [INFO] finished tweaking git repo https://github.com/ItzGuuh/rust-playground [INFO] tweaked toml for git repo https://github.com/ItzGuuh/rust-playground written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ItzGuuh/rust-playground on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ItzGuuh/rust-playground already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d35eb446f6b36c4c979d9a4934aac4dccef3ae43e6e3b3320fb84156de728456 [INFO] running `Command { std: "docker" "start" "-a" "d35eb446f6b36c4c979d9a4934aac4dccef3ae43e6e3b3320fb84156de728456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d35eb446f6b36c4c979d9a4934aac4dccef3ae43e6e3b3320fb84156de728456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d35eb446f6b36c4c979d9a4934aac4dccef3ae43e6e3b3320fb84156de728456", kill_on_drop: false }` [INFO] [stdout] d35eb446f6b36c4c979d9a4934aac4dccef3ae43e6e3b3320fb84156de728456 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d80ea65b1f4ee7c5b710ba1ae7a3f2f64df61b69307f2cfdf92c3c618a6e94f6 [INFO] running `Command { std: "docker" "start" "-a" "d80ea65b1f4ee7c5b710ba1ae7a3f2f64df61b69307f2cfdf92c3c618a6e94f6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking deck_of_cards v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `my_cards` [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let my_cards = new_deck.get_cards().get_n_cards_from_top(Some(5)); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_my_cards` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hand` is never constructed [INFO] [stdout] --> src/card_holder/card/hand.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct Hand { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder/card/deck.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.mount.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.mount.clone(); [INFO] [stdout] 16 + self.mount.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder/card/deck.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return deck; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return deck; [INFO] [stdout] 42 + deck [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.amount - self.cards.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.amount - self.cards.len(); [INFO] [stdout] 16 + self.amount - self.cards.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/card_holder.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if !(self.allow_more_cards() < cards.cards.len()) { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.allow_more_cards() >= cards.cards.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return CardHolder { cards: retreived_cards, amount: n_top_numbers}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return CardHolder { cards: retreived_cards, amount: n_top_numbers}; [INFO] [stdout] 48 + CardHolder { cards: retreived_cards, amount: n_top_numbers} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return CardHolder { cards: new_cards, amount } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return CardHolder { cards: new_cards, amount } [INFO] [stdout] 55 + CardHolder { cards: new_cards, amount } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `my_cards` [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let my_cards = new_deck.get_cards().get_n_cards_from_top(Some(5)); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_my_cards` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hand` is never constructed [INFO] [stdout] --> src/card_holder/card/hand.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct Hand { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder/card/deck.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.mount.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.mount.clone(); [INFO] [stdout] 16 + self.mount.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder/card/deck.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return deck; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return deck; [INFO] [stdout] 42 + deck [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.amount - self.cards.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.amount - self.cards.len(); [INFO] [stdout] 16 + self.amount - self.cards.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/card_holder.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if !(self.allow_more_cards() < cards.cards.len()) { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.allow_more_cards() >= cards.cards.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return CardHolder { cards: retreived_cards, amount: n_top_numbers}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return CardHolder { cards: retreived_cards, amount: n_top_numbers}; [INFO] [stdout] 48 + CardHolder { cards: retreived_cards, amount: n_top_numbers} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/card_holder.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return CardHolder { cards: new_cards, amount } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return CardHolder { cards: new_cards, amount } [INFO] [stdout] 55 + CardHolder { cards: new_cards, amount } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.25s [INFO] running `Command { std: "docker" "inspect" "d80ea65b1f4ee7c5b710ba1ae7a3f2f64df61b69307f2cfdf92c3c618a6e94f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d80ea65b1f4ee7c5b710ba1ae7a3f2f64df61b69307f2cfdf92c3c618a6e94f6", kill_on_drop: false }` [INFO] [stdout] d80ea65b1f4ee7c5b710ba1ae7a3f2f64df61b69307f2cfdf92c3c618a6e94f6