[INFO] cloning repository https://github.com/ItsMeViipeR/json [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ItsMeViipeR/json" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FItsMeViipeR%2Fjson", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FItsMeViipeR%2Fjson'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 07ac7a780543a0d7090e67c0c4e684c739abeea7 [INFO] linting ItsMeViipeR/json against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FItsMeViipeR%2Fjson" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ItsMeViipeR/json [INFO] finished tweaking git repo https://github.com/ItsMeViipeR/json [INFO] tweaked toml for git repo https://github.com/ItsMeViipeR/json written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ItsMeViipeR/json on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ItsMeViipeR/json already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 669fbf1110ec32bc2e8391217d7aa498c149c623776dba2aec25f8846f35673c [INFO] running `Command { std: "docker" "start" "-a" "669fbf1110ec32bc2e8391217d7aa498c149c623776dba2aec25f8846f35673c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "669fbf1110ec32bc2e8391217d7aa498c149c623776dba2aec25f8846f35673c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "669fbf1110ec32bc2e8391217d7aa498c149c623776dba2aec25f8846f35673c", kill_on_drop: false }` [INFO] [stdout] 669fbf1110ec32bc2e8391217d7aa498c149c623776dba2aec25f8846f35673c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d479a1cafd60cf493df6ff810f8788671b93167e913e1c7b6baa66eb907e96e [INFO] running `Command { std: "docker" "start" "-a" "6d479a1cafd60cf493df6ff810f8788671b93167e913e1c7b6baa66eb907e96e", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling syn v2.0.35 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking ezjson v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !self.json_data.get(key).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.json_data.get(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | Err(_) => return Err(Box::new(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 62 | | std::io::ErrorKind::NotFound, [INFO] [stdout] 63 | | "File not found", [INFO] [stdout] 64 | | ))) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Err(_) => Err(Box::new(std::io::Error::new( [INFO] [stdout] 62 + std::io::ErrorKind::NotFound, [INFO] [stdout] 63 + "File not found", [INFO] [stdout] 64 + ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | let mut file = match File::create(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:197:37 [INFO] [stdout] | [INFO] [stdout] 197 | let file = match File::open(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if !self.json_data.get(key).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.json_data.get(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | Err(_) => return Err(Box::new(std::io::Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 62 | | std::io::ErrorKind::NotFound, [INFO] [stdout] 63 | | "File not found", [INFO] [stdout] 64 | | ))) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Err(_) => Err(Box::new(std::io::Error::new( [INFO] [stdout] 62 + std::io::ErrorKind::NotFound, [INFO] [stdout] 63 + "File not found", [INFO] [stdout] 64 + ))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | let mut file = match File::create(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:197:37 [INFO] [stdout] | [INFO] [stdout] 197 | let file = match File::open(&self.path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.06s [INFO] running `Command { std: "docker" "inspect" "6d479a1cafd60cf493df6ff810f8788671b93167e913e1c7b6baa66eb907e96e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d479a1cafd60cf493df6ff810f8788671b93167e913e1c7b6baa66eb907e96e", kill_on_drop: false }` [INFO] [stdout] 6d479a1cafd60cf493df6ff810f8788671b93167e913e1c7b6baa66eb907e96e