[INFO] cloning repository https://github.com/IndianBoy42/shelltyper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IndianBoy42/shelltyper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIndianBoy42%2Fshelltyper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIndianBoy42%2Fshelltyper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fce28d4a3c29229d3a7a93ab81dcdd700af10802 [INFO] linting IndianBoy42/shelltyper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIndianBoy42%2Fshelltyper" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IndianBoy42/shelltyper [INFO] finished tweaking git repo https://github.com/IndianBoy42/shelltyper [INFO] tweaked toml for git repo https://github.com/IndianBoy42/shelltyper written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IndianBoy42/shelltyper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IndianBoy42/shelltyper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pico-args v0.4.1 [INFO] [stderr] Downloaded crossterm_winapi v0.7.0 [INFO] [stderr] Downloaded signal-hook v0.1.17 [INFO] [stderr] Downloaded tui v0.15.0 [INFO] [stderr] Downloaded crossterm v0.19.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e46c7fd860eaa98257587f7b59557468e5e112a0a329d4c958da68371e5b724d [INFO] running `Command { std: "docker" "start" "-a" "e46c7fd860eaa98257587f7b59557468e5e112a0a329d4c958da68371e5b724d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e46c7fd860eaa98257587f7b59557468e5e112a0a329d4c958da68371e5b724d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e46c7fd860eaa98257587f7b59557468e5e112a0a329d4c958da68371e5b724d", kill_on_drop: false }` [INFO] [stdout] e46c7fd860eaa98257587f7b59557468e5e112a0a329d4c958da68371e5b724d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 374ceb281ddc8fb240c60e18aded76d05769dc0cd087a87846c3b103ee675cde [INFO] running `Command { std: "docker" "start" "-a" "374ceb281ddc8fb240c60e18aded76d05769dc0cd087a87846c3b103ee675cde", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking pico-args v0.4.1 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking crossterm v0.19.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking tui v0.15.0 [INFO] [stderr] Checking shelltyper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `target_is_infinite` is never used [INFO] [stdout] --> src/main.rs:262:8 [INFO] [stdout] | [INFO] [stdout] 214 | impl App { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 262 | fn target_is_infinite(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `ENGLISH_1K` is never used [INFO] [stdout] --> src/dict.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub static ENGLISH_1K: [&str; 1000] = [ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | .map(|x| TargetStringType::Timed(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TargetStringType::Timed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|x| TargetStringType::Words(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TargetStringType::Words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/main.rs:98:15 [INFO] [stdout] | [INFO] [stdout] 98 | ..dargs [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `target_is_infinite` is never used [INFO] [stdout] --> src/main.rs:262:8 [INFO] [stdout] | [INFO] [stdout] 214 | impl App { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 262 | fn target_is_infinite(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `ENGLISH_1K` is never used [INFO] [stdout] --> src/dict.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub static ENGLISH_1K: [&str; 1000] = [ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | / let ok = match key { [INFO] [stdout] 329 | | KeyCode::Char(' ') | KeyCode::Right | KeyCode::Enter => { [INFO] [stdout] 330 | | if self.running == TestState::Running { [INFO] [stdout] 331 | | if self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] ... | [INFO] [stdout] 384 | | KeyCode::Null => {} [INFO] [stdout] 385 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 328 ~ match key { [INFO] [stdout] 329 | KeyCode::Char(' ') | KeyCode::Right | KeyCode::Enter => { [INFO] [stdout] ... [INFO] [stdout] 386 | [INFO] [stdout] 387 ~ Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:330:17 [INFO] [stdout] | [INFO] [stdout] 330 | / if self.running == TestState::Running { [INFO] [stdout] 331 | | if self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] 332 | | self.enterd_str.push(' '); [INFO] [stdout] ... | [INFO] [stdout] 341 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 330 ~ if self.running == TestState::Running [INFO] [stdout] 331 ~ && self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] 332 | self.enterd_str.push(' '); [INFO] [stdout] ... [INFO] [stdout] 339 | } [INFO] [stdout] 340 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/main.rs:331:24 [INFO] [stdout] | [INFO] [stdout] 331 | if self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!self.enterd_str.ends_with(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:502:34 [INFO] [stdout] | [INFO] [stdout] 502 | let len = if totallen < width.into() || false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `totallen < width.into()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:483:28 [INFO] [stdout] | [INFO] [stdout] 483 | if wrong.len() == 0 && incomplete.len() <= 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wrong.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:504:28 [INFO] [stdout] | [INFO] [stdout] 504 | if complete.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!complete.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:507:28 [INFO] [stdout] | [INFO] [stdout] 507 | if wrong.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wrong.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:510:28 [INFO] [stdout] | [INFO] [stdout] 510 | if incomplete.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!incomplete.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:524:18 [INFO] [stdout] | [INFO] [stdout] 524 | .map(|line| Spans::from(line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Spans::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | .map(|x| TargetStringType::Timed(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TargetStringType::Timed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|x| TargetStringType::Words(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TargetStringType::Words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/main.rs:98:15 [INFO] [stdout] | [INFO] [stdout] 98 | ..dargs [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:474:34 [INFO] [stdout] | [INFO] [stdout] 474 | unreachable!(STRINGS_CLEARED_BEFORE_FINISH) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 474 | unreachable!("{}", STRINGS_CLEARED_BEFORE_FINISH) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | / let ok = match key { [INFO] [stdout] 329 | | KeyCode::Char(' ') | KeyCode::Right | KeyCode::Enter => { [INFO] [stdout] 330 | | if self.running == TestState::Running { [INFO] [stdout] 331 | | if self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] ... | [INFO] [stdout] 384 | | KeyCode::Null => {} [INFO] [stdout] 385 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 328 ~ match key { [INFO] [stdout] 329 | KeyCode::Char(' ') | KeyCode::Right | KeyCode::Enter => { [INFO] [stdout] ... [INFO] [stdout] 386 | [INFO] [stdout] 387 ~ Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:330:17 [INFO] [stdout] | [INFO] [stdout] 330 | / if self.running == TestState::Running { [INFO] [stdout] 331 | | if self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] 332 | | self.enterd_str.push(' '); [INFO] [stdout] ... | [INFO] [stdout] 341 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 330 ~ if self.running == TestState::Running [INFO] [stdout] 331 ~ && self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] 332 | self.enterd_str.push(' '); [INFO] [stdout] ... [INFO] [stdout] 339 | } [INFO] [stdout] 340 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/main.rs:331:24 [INFO] [stdout] | [INFO] [stdout] 331 | if self.enterd_str.chars().last() != Some(' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!self.enterd_str.ends_with(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:502:34 [INFO] [stdout] | [INFO] [stdout] 502 | let len = if totallen < width.into() || false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `totallen < width.into()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:483:28 [INFO] [stdout] | [INFO] [stdout] 483 | if wrong.len() == 0 && incomplete.len() <= 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wrong.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:504:28 [INFO] [stdout] | [INFO] [stdout] 504 | if complete.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!complete.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:507:28 [INFO] [stdout] | [INFO] [stdout] 507 | if wrong.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wrong.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:510:28 [INFO] [stdout] | [INFO] [stdout] 510 | if incomplete.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!incomplete.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:524:18 [INFO] [stdout] | [INFO] [stdout] 524 | .map(|line| Spans::from(line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Spans::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:474:34 [INFO] [stdout] | [INFO] [stdout] 474 | unreachable!(STRINGS_CLEARED_BEFORE_FINISH) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 474 | unreachable!("{}", STRINGS_CLEARED_BEFORE_FINISH) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.64s [INFO] running `Command { std: "docker" "inspect" "374ceb281ddc8fb240c60e18aded76d05769dc0cd087a87846c3b103ee675cde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "374ceb281ddc8fb240c60e18aded76d05769dc0cd087a87846c3b103ee675cde", kill_on_drop: false }` [INFO] [stdout] 374ceb281ddc8fb240c60e18aded76d05769dc0cd087a87846c3b103ee675cde