[INFO] cloning repository https://github.com/ImTheSquid/subsync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ImTheSquid/subsync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FImTheSquid%2Fsubsync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FImTheSquid%2Fsubsync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c97b212c7bbf3c5015470aad5f2ba5fbcf4b3a94 [INFO] linting ImTheSquid/subsync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FImTheSquid%2Fsubsync" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ImTheSquid/subsync [INFO] finished tweaking git repo https://github.com/ImTheSquid/subsync [INFO] tweaked toml for git repo https://github.com/ImTheSquid/subsync written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ImTheSquid/subsync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ImTheSquid/subsync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded inquire v0.7.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0233c75ff543dbd8e41f8ebf2e34f471c30e70345b2d1d13d7091c39935bd233 [INFO] running `Command { std: "docker" "start" "-a" "0233c75ff543dbd8e41f8ebf2e34f471c30e70345b2d1d13d7091c39935bd233", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0233c75ff543dbd8e41f8ebf2e34f471c30e70345b2d1d13d7091c39935bd233", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0233c75ff543dbd8e41f8ebf2e34f471c30e70345b2d1d13d7091c39935bd233", kill_on_drop: false }` [INFO] [stdout] 0233c75ff543dbd8e41f8ebf2e34f471c30e70345b2d1d13d7091c39935bd233 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7328cf8e3f268b7760c30e7ff215af7ba62dc8b4c9a3ef9c65268ebcf9ba6fe [INFO] running `Command { std: "docker" "start" "-a" "d7328cf8e3f268b7760c30e7ff215af7ba62dc8b4c9a3ef9c65268ebcf9ba6fe", kill_on_drop: false }` [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking subsync v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | .filter(|de| !de.path().is_dir() && !de.path().extension().is_some_and(|e| e == "srt")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `de.path().extension().is_none_or(|e| e != "srt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:225:16 [INFO] [stdout] | [INFO] [stdout] 225 | dest_file: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 225 - dest_file: &PathBuf, [INFO] [stdout] 225 + dest_file: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::slice::Iter<'_, std::fs::DirEntry>` [INFO] [stdout] --> src/main.rs:276:27 [INFO] [stdout] | [INFO] [stdout] 276 | let choices = subtitle_files [INFO] [stdout] | ___________________________^ [INFO] [stdout] 277 | | .iter() [INFO] [stdout] 278 | | .into_iter() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 276 ~ let choices = subtitle_files [INFO] [stdout] 277 + .iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:82:49 [INFO] [stdout] | [INFO] [stdout] 82 | .filter(|de| !de.path().is_dir() && !de.path().extension().is_some_and(|e| e == "srt")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `de.path().extension().is_none_or(|e| e != "srt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:225:16 [INFO] [stdout] | [INFO] [stdout] 225 | dest_file: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 225 - dest_file: &PathBuf, [INFO] [stdout] 225 + dest_file: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::slice::Iter<'_, std::fs::DirEntry>` [INFO] [stdout] --> src/main.rs:276:27 [INFO] [stdout] | [INFO] [stdout] 276 | let choices = subtitle_files [INFO] [stdout] | ___________________________^ [INFO] [stdout] 277 | | .iter() [INFO] [stdout] 278 | | .into_iter() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 276 ~ let choices = subtitle_files [INFO] [stdout] 277 + .iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.62s [INFO] running `Command { std: "docker" "inspect" "d7328cf8e3f268b7760c30e7ff215af7ba62dc8b4c9a3ef9c65268ebcf9ba6fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7328cf8e3f268b7760c30e7ff215af7ba62dc8b4c9a3ef9c65268ebcf9ba6fe", kill_on_drop: false }` [INFO] [stdout] d7328cf8e3f268b7760c30e7ff215af7ba62dc8b4c9a3ef9c65268ebcf9ba6fe