[INFO] cloning repository https://github.com/IlyaPyatkin/advent-of-code-2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IlyaPyatkin/advent-of-code-2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIlyaPyatkin%2Fadvent-of-code-2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIlyaPyatkin%2Fadvent-of-code-2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a29f8e797e6ff76aa8f061ddc394daa52ddbd788 [INFO] linting IlyaPyatkin/advent-of-code-2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIlyaPyatkin%2Fadvent-of-code-2023" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IlyaPyatkin/advent-of-code-2023 [INFO] finished tweaking git repo https://github.com/IlyaPyatkin/advent-of-code-2023 [INFO] tweaked toml for git repo https://github.com/IlyaPyatkin/advent-of-code-2023 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IlyaPyatkin/advent-of-code-2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IlyaPyatkin/advent-of-code-2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded console v0.15.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91ca831591827812e4e65526047d3b5ce036772c5dcdf54b7c78b99c943a53c5 [INFO] running `Command { std: "docker" "start" "-a" "91ca831591827812e4e65526047d3b5ce036772c5dcdf54b7c78b99c943a53c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91ca831591827812e4e65526047d3b5ce036772c5dcdf54b7c78b99c943a53c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91ca831591827812e4e65526047d3b5ce036772c5dcdf54b7c78b99c943a53c5", kill_on_drop: false }` [INFO] [stdout] 91ca831591827812e4e65526047d3b5ce036772c5dcdf54b7c78b99c943a53c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 62d314ec25f79891aa4d2bdb70da451c4f7071cd9727e65d644ad190800a7627 [INFO] running `Command { std: "docker" "start" "-a" "62d314ec25f79891aa4d2bdb70da451c4f7071cd9727e65d644ad190800a7627", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking advent-of-code-2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/day14.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | / match direction { [INFO] [stdout] 72 | | Direction::North | Direction::South => true, [INFO] [stdout] 73 | | _ => false, [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 71 - match direction { [INFO] [stdout] 72 - Direction::North | Direction::South => true, [INFO] [stdout] 73 - _ => false, [INFO] [stdout] 74 - } [INFO] [stdout] 71 + matches!(direction, Direction::North | Direction::South) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day14.rs:84:11 [INFO] [stdout] | [INFO] [stdout] 84 | while is_reversed || !is_reversed && index < loops { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - while is_reversed || !is_reversed && index < loops { [INFO] [stdout] 84 + while !(!is_reversed && index >= loops) { [INFO] [stdout] | [INFO] [stdout] 84 - while is_reversed || !is_reversed && index < loops { [INFO] [stdout] 84 + while is_reversed || index < loops { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/day14.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / if last_empty_index.is_none() { [INFO] [stdout] 91 | | last_empty_index = Some(index) [INFO] [stdout] 92 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 89 ~ Some('.') [INFO] [stdout] 90 ~ if last_empty_index.is_none() => { [INFO] [stdout] 91 | last_empty_index = Some(index) [INFO] [stdout] 92 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day14.rs:123:34 [INFO] [stdout] | [INFO] [stdout] 123 | fn grid_to_platform_string(grid: &Vec>) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 123 - fn grid_to_platform_string(grid: &Vec>) -> String { [INFO] [stdout] 123 + fn grid_to_platform_string(grid: &[Vec]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/day14.rs:133:41 [INFO] [stdout] | [INFO] [stdout] 133 | let progress_bar = ProgressBar::new(cycles as u64); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `cycles` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/day14.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | / match direction { [INFO] [stdout] 72 | | Direction::North | Direction::South => true, [INFO] [stdout] 73 | | _ => false, [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 71 - match direction { [INFO] [stdout] 72 - Direction::North | Direction::South => true, [INFO] [stdout] 73 - _ => false, [INFO] [stdout] 74 - } [INFO] [stdout] 71 + matches!(direction, Direction::North | Direction::South) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day14.rs:84:11 [INFO] [stdout] | [INFO] [stdout] 84 | while is_reversed || !is_reversed && index < loops { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - while is_reversed || !is_reversed && index < loops { [INFO] [stdout] 84 + while !(!is_reversed && index >= loops) { [INFO] [stdout] | [INFO] [stdout] 84 - while is_reversed || !is_reversed && index < loops { [INFO] [stdout] 84 + while is_reversed || index < loops { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/day14.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / if last_empty_index.is_none() { [INFO] [stdout] 91 | | last_empty_index = Some(index) [INFO] [stdout] 92 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 89 ~ Some('.') [INFO] [stdout] 90 ~ if last_empty_index.is_none() => { [INFO] [stdout] 91 | last_empty_index = Some(index) [INFO] [stdout] 92 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day14.rs:123:34 [INFO] [stdout] | [INFO] [stdout] 123 | fn grid_to_platform_string(grid: &Vec>) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 123 - fn grid_to_platform_string(grid: &Vec>) -> String { [INFO] [stdout] 123 + fn grid_to_platform_string(grid: &[Vec]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/day14.rs:133:41 [INFO] [stdout] | [INFO] [stdout] 133 | let progress_bar = ProgressBar::new(cycles as u64); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `cycles` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.79s [INFO] running `Command { std: "docker" "inspect" "62d314ec25f79891aa4d2bdb70da451c4f7071cd9727e65d644ad190800a7627", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62d314ec25f79891aa4d2bdb70da451c4f7071cd9727e65d644ad190800a7627", kill_on_drop: false }` [INFO] [stdout] 62d314ec25f79891aa4d2bdb70da451c4f7071cd9727e65d644ad190800a7627