[INFO] cloning repository https://github.com/IgorMitico/kaktus [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IgorMitico/kaktus" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIgorMitico%2Fkaktus", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIgorMitico%2Fkaktus'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fe00dbb61f68dbcd5754bed9ac5bc7fa17d1291c [INFO] linting IgorMitico/kaktus/fe00dbb61f68dbcd5754bed9ac5bc7fa17d1291c against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIgorMitico%2Fkaktus" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IgorMitico/kaktus [INFO] finished tweaking git repo https://github.com/IgorMitico/kaktus [INFO] tweaked toml for git repo https://github.com/IgorMitico/kaktus written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IgorMitico/kaktus on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IgorMitico/kaktus already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasi v0.14.6+wasi-0.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f897228c85bd8bf4beab791d11c16b26f8c7198fe5ead3e752adb24b33dc2c2b [INFO] running `Command { std: "docker" "start" "-a" "f897228c85bd8bf4beab791d11c16b26f8c7198fe5ead3e752adb24b33dc2c2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f897228c85bd8bf4beab791d11c16b26f8c7198fe5ead3e752adb24b33dc2c2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f897228c85bd8bf4beab791d11c16b26f8c7198fe5ead3e752adb24b33dc2c2b", kill_on_drop: false }` [INFO] [stdout] f897228c85bd8bf4beab791d11c16b26f8c7198fe5ead3e752adb24b33dc2c2b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b817f9f6fe9b9a54cbbc523ef6cdfa348db90c3c97edc21095af3ca38ad1d32 [INFO] running `Command { std: "docker" "start" "-a" "0b817f9f6fe9b9a54cbbc523ef6cdfa348db90c3c97edc21095af3ca38ad1d32", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking kaktus v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/cards.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | for card in &self.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, card) in (1_u8..).zip(self.0.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cards.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 93 | if index % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `index.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/cards.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 94 - write!(f, "\n")?; [INFO] [stdout] 94 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/cards.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | writeln!(f, "") [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game.rs:31:16 [INFO] [stdout] | [INFO] [stdout] 31 | } else if min_value == n_value { [INFO] [stdout] | ________________^ [INFO] [stdout] 32 | | if k_player != winner { [INFO] [stdout] 33 | | if check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | | winner = n; [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ } else if min_value == n_value [INFO] [stdout] 32 ~ && k_player != winner { [INFO] [stdout] 33 | if check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | winner = n; [INFO] [stdout] 35 | } [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / if k_player != winner { [INFO] [stdout] 33 | | if check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | | winner = n; [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if k_player != winner [INFO] [stdout] 33 ~ && check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | winner = n; [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return true; [INFO] [stdout] 44 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return false; [INFO] [stdout] 46 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return false; [INFO] [stdout] 64 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/player.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 48 | / let player = Player { [INFO] [stdout] 49 | | hand: Hand::init(), [INFO] [stdout] 50 | | name: String::from(""), [INFO] [stdout] 51 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 52 | player [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 48 ~ [INFO] [stdout] 49 ~ Player { [INFO] [stdout] 50 + hand: Hand::init(), [INFO] [stdout] 51 + name: String::from(""), [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/cards.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | for card in &self.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, card) in (1_u8..).zip(self.0.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cards.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 93 | if index % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `index.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/cards.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 94 - write!(f, "\n")?; [INFO] [stdout] 94 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/cards.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | writeln!(f, "") [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game.rs:31:16 [INFO] [stdout] | [INFO] [stdout] 31 | } else if min_value == n_value { [INFO] [stdout] | ________________^ [INFO] [stdout] 32 | | if k_player != winner { [INFO] [stdout] 33 | | if check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | | winner = n; [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ } else if min_value == n_value [INFO] [stdout] 32 ~ && k_player != winner { [INFO] [stdout] 33 | if check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | winner = n; [INFO] [stdout] 35 | } [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / if k_player != winner { [INFO] [stdout] 33 | | if check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | | winner = n; [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if k_player != winner [INFO] [stdout] 33 ~ && check_winner(&players.players[n].hand, &players.players[winner].hand) { [INFO] [stdout] 34 | winner = n; [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return true; [INFO] [stdout] 44 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return false; [INFO] [stdout] 46 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return false; [INFO] [stdout] 64 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/player.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 48 | / let player = Player { [INFO] [stdout] 49 | | hand: Hand::init(), [INFO] [stdout] 50 | | name: String::from(""), [INFO] [stdout] 51 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 52 | player [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 48 ~ [INFO] [stdout] 49 ~ Player { [INFO] [stdout] 50 + hand: Hand::init(), [INFO] [stdout] 51 + name: String::from(""), [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.42s [INFO] running `Command { std: "docker" "inspect" "0b817f9f6fe9b9a54cbbc523ef6cdfa348db90c3c97edc21095af3ca38ad1d32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b817f9f6fe9b9a54cbbc523ef6cdfa348db90c3c97edc21095af3ca38ad1d32", kill_on_drop: false }` [INFO] [stdout] 0b817f9f6fe9b9a54cbbc523ef6cdfa348db90c3c97edc21095af3ca38ad1d32