[INFO] cloning repository https://github.com/IamCarbonMan/crusty [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IamCarbonMan/crusty" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIamCarbonMan%2Fcrusty", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIamCarbonMan%2Fcrusty'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 96c0a88b9a9ea27f8e3fabf0919c86572d4f8e4b [INFO] linting IamCarbonMan/crusty against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIamCarbonMan%2Fcrusty" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IamCarbonMan/crusty [INFO] finished tweaking git repo https://github.com/IamCarbonMan/crusty [INFO] tweaked toml for git repo https://github.com/IamCarbonMan/crusty written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IamCarbonMan/crusty on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IamCarbonMan/crusty already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d08d78899c0ccaeef0b5b2c0916d72354391878c626ffa66b87883f38d52565c [INFO] running `Command { std: "docker" "start" "-a" "d08d78899c0ccaeef0b5b2c0916d72354391878c626ffa66b87883f38d52565c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d08d78899c0ccaeef0b5b2c0916d72354391878c626ffa66b87883f38d52565c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d08d78899c0ccaeef0b5b2c0916d72354391878c626ffa66b87883f38d52565c", kill_on_drop: false }` [INFO] [stdout] d08d78899c0ccaeef0b5b2c0916d72354391878c626ffa66b87883f38d52565c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ffeefa9c92fb9347b3ecf17644bc8de529ddc5c169782aa4141838bdb34a7ed [INFO] running `Command { std: "docker" "start" "-a" "8ffeefa9c92fb9347b3ecf17644bc8de529ddc5c169782aa4141838bdb34a7ed", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crusty v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | ram: ram, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/gpu.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | canvas: canvas, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/gpu.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | scale: scale [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | ram: ram, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/gpu.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | canvas: canvas, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/gpu.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | scale: scale [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `while let` pattern [INFO] [stdout] --> src/main.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | while let keys = input.poll() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the loop will never exit [INFO] [stdout] = help: consider instead using a `loop { ... }` with a `let` inside it [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/cpu.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / for i in 0..FONT.len() { [INFO] [stdout] 44 | | ram[i] = FONT[i]; [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `ram[..FONT.len()].copy_from_slice(&FONT[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cpu.rs:64:34 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn load(&mut self, data: &Vec) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn load(&mut self, data: &Vec) { [INFO] [stdout] 64 + pub fn load(&mut self, data: &[u8]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return output; [INFO] [stdout] 103 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `keys` [INFO] [stdout] --> src/cpu.rs:86:22 [INFO] [stdout] | [INFO] [stdout] 86 | for i in 0..keys.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 86 - for i in 0..keys.len() { [INFO] [stdout] 86 + for (i, ) in keys.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | (opcode & 0xF000) >> 12 as u8, [INFO] [stdout] | ^^^^^^^^ help: try: `12_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:113:34 [INFO] [stdout] | [INFO] [stdout] 113 | (opcode & 0x0F00) >> 8 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `8_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:114:34 [INFO] [stdout] | [INFO] [stdout] 114 | (opcode & 0x00F0) >> 4 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `4_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `while let` pattern [INFO] [stdout] --> src/main.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 26 | while let keys = input.poll() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the loop will never exit [INFO] [stdout] = help: consider instead using a `loop { ... }` with a `let` inside it [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gpu.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return Gpu { [INFO] [stdout] 22 | | canvas: canvas, [INFO] [stdout] 23 | | scale: scale [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Gpu { [INFO] [stdout] 22 + canvas: canvas, [INFO] [stdout] 23 + scale: scale [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `vram` [INFO] [stdout] --> src/gpu.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | for y in 0..32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 31 - for y in 0..32 { [INFO] [stdout] 31 + for (y, ) in vram.iter().enumerate().take(32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `vram` [INFO] [stdout] --> src/gpu.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | for x in 0..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 32 - for x in 0..64 { [INFO] [stdout] 32 + for (x, ) in vram.iter().enumerate().take(64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / return audio.open_playback(None, &DESIRED_SPEC, |spec| { [INFO] [stdout] 36 | | SquareWave { [INFO] [stdout] 37 | | phase_inc: 440.0 / spec.freq as f32, [INFO] [stdout] 38 | | phase: 0.0, [INFO] [stdout] ... | [INFO] [stdout] 41 | | }).unwrap(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ audio.open_playback(None, &DESIRED_SPEC, |spec| { [INFO] [stdout] 36 + SquareWave { [INFO] [stdout] 37 + phase_inc: 440.0 / spec.freq as f32, [INFO] [stdout] 38 + phase: 0.0, [INFO] [stdout] 39 + volume: 0.25 [INFO] [stdout] 40 + } [INFO] [stdout] 41 ~ }).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !state.screen.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.screen.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `state.screen` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 28 | if !state.screen.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 29 | gpu.draw(&state.screen.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/cpu.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / for i in 0..FONT.len() { [INFO] [stdout] 44 | | ram[i] = FONT[i]; [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `ram[..FONT.len()].copy_from_slice(&FONT[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cpu.rs:64:34 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn load(&mut self, data: &Vec) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn load(&mut self, data: &Vec) { [INFO] [stdout] 64 + pub fn load(&mut self, data: &[u8]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return output; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return output; [INFO] [stdout] 103 + output [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `keys` [INFO] [stdout] --> src/cpu.rs:86:22 [INFO] [stdout] | [INFO] [stdout] 86 | for i in 0..keys.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 86 - for i in 0..keys.len() { [INFO] [stdout] 86 + for (i, ) in keys.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:112:34 [INFO] [stdout] | [INFO] [stdout] 112 | (opcode & 0xF000) >> 12 as u8, [INFO] [stdout] | ^^^^^^^^ help: try: `12_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:113:34 [INFO] [stdout] | [INFO] [stdout] 113 | (opcode & 0x0F00) >> 8 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `8_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:114:34 [INFO] [stdout] | [INFO] [stdout] 114 | (opcode & 0x00F0) >> 4 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `4_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gpu.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return Gpu { [INFO] [stdout] 22 | | canvas: canvas, [INFO] [stdout] 23 | | scale: scale [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Gpu { [INFO] [stdout] 22 + canvas: canvas, [INFO] [stdout] 23 + scale: scale [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `vram` [INFO] [stdout] --> src/gpu.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | for y in 0..32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 31 - for y in 0..32 { [INFO] [stdout] 31 + for (y, ) in vram.iter().enumerate().take(32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `vram` [INFO] [stdout] --> src/gpu.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | for x in 0..64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 32 - for x in 0..64 { [INFO] [stdout] 32 + for (x, ) in vram.iter().enumerate().take(64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / return audio.open_playback(None, &DESIRED_SPEC, |spec| { [INFO] [stdout] 36 | | SquareWave { [INFO] [stdout] 37 | | phase_inc: 440.0 / spec.freq as f32, [INFO] [stdout] 38 | | phase: 0.0, [INFO] [stdout] ... | [INFO] [stdout] 41 | | }).unwrap(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 ~ audio.open_playback(None, &DESIRED_SPEC, |spec| { [INFO] [stdout] 36 + SquareWave { [INFO] [stdout] 37 + phase_inc: 440.0 / spec.freq as f32, [INFO] [stdout] 38 + phase: 0.0, [INFO] [stdout] 39 + volume: 0.25 [INFO] [stdout] 40 + } [INFO] [stdout] 41 ~ }).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !state.screen.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.screen.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `state.screen` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 28 | if !state.screen.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 29 | gpu.draw(&state.screen.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.98s [INFO] running `Command { std: "docker" "inspect" "8ffeefa9c92fb9347b3ecf17644bc8de529ddc5c169782aa4141838bdb34a7ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ffeefa9c92fb9347b3ecf17644bc8de529ddc5c169782aa4141838bdb34a7ed", kill_on_drop: false }` [INFO] [stdout] 8ffeefa9c92fb9347b3ecf17644bc8de529ddc5c169782aa4141838bdb34a7ed