[INFO] cloning repository https://github.com/IVSOP/raynaldo
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IVSOP/raynaldo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIVSOP%2Fraynaldo", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIVSOP%2Fraynaldo'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0613e1b474bfc345159545a533e3f2a9f64a039c
[INFO] linting IVSOP/raynaldo against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIVSOP%2Fraynaldo" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/IVSOP/raynaldo
[INFO] finished tweaking git repo https://github.com/IVSOP/raynaldo
[INFO] tweaked toml for git repo https://github.com/IVSOP/raynaldo written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/IVSOP/raynaldo on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/IVSOP/raynaldo already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating git repository `https://github.com/ivsop/embree4-rs/`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded embree4-sys v0.0.12
[INFO] [stderr]   Downloaded glam v0.30.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 459675f92585c31e7312091f34b269508394d4914cf8887c556ecd5feb1325ac
[INFO] running `Command { std: "docker" "start" "-a" "459675f92585c31e7312091f34b269508394d4914cf8887c556ecd5feb1325ac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "459675f92585c31e7312091f34b269508394d4914cf8887c556ecd5feb1325ac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "459675f92585c31e7312091f34b269508394d4914cf8887c556ecd5feb1325ac", kill_on_drop: false }`
[INFO] [stdout] 459675f92585c31e7312091f34b269508394d4914cf8887c556ecd5feb1325ac
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a6796c01f665b73890985fe6b04f6a6ac9689c380fd1441f3091769775f37553
[INFO] running `Command { std: "docker" "start" "-a" "a6796c01f665b73890985fe6b04f6a6ac9689c380fd1441f3091769775f37553", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.94
[INFO] [stderr]    Compiling glob v0.3.2
[INFO] [stderr]    Compiling anyhow v1.0.97
[INFO] [stderr]    Compiling libc v0.2.171
[INFO] [stderr]    Compiling prettyplease v0.2.31
[INFO] [stderr]    Compiling regex-syntax v0.8.5
[INFO] [stderr]    Compiling linux-raw-sys v0.4.15
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling rustix v0.38.44
[INFO] [stderr]    Compiling bitflags v2.9.0
[INFO] [stderr]    Compiling libloading v0.8.6
[INFO] [stderr]    Compiling nom v7.1.3
[INFO] [stderr]    Compiling built v0.7.7
[INFO] [stderr]     Checking aligned-vec v0.5.0
[INFO] [stderr]    Compiling bindgen v0.68.1
[INFO] [stderr]     Checking rayon v1.10.0
[INFO] [stderr]    Compiling home v0.5.11
[INFO] [stderr]    Compiling peeking_take_while v0.1.2
[INFO] [stderr]    Compiling serde v1.0.219
[INFO] [stderr]     Checking itertools v0.12.1
[INFO] [stderr]     Checking bitstream-io v2.6.0
[INFO] [stderr]     Checking once_cell v1.21.1
[INFO] [stderr]    Compiling clang-sys v1.8.1
[INFO] [stderr]     Checking imgref v1.11.0
[INFO] [stderr]    Compiling serde_json v1.0.140
[INFO] [stderr]    Compiling rav1e v0.7.1
[INFO] [stderr]     Checking avif-serialize v0.8.3
[INFO] [stderr]     Checking loop9 v0.1.5
[INFO] [stderr]     Checking bytemuck v1.22.0
[INFO] [stderr]     Checking smallvec v1.14.0
[INFO] [stderr]     Checking rgb v0.8.50
[INFO] [stderr]    Compiling inflections v1.1.1
[INFO] [stderr]     Checking exr v1.73.0
[INFO] [stderr]    Compiling quote v1.0.40
[INFO] [stderr]     Checking zune-jpeg v0.4.14
[INFO] [stderr]     Checking qoi v0.4.1
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]    Compiling syn v2.0.100
[INFO] [stderr]     Checking v_frame v0.3.8
[INFO] [stderr]     Checking tiff v0.9.1
[INFO] [stderr]     Checking image-webp v0.2.1
[INFO] [stderr]    Compiling simd_helpers v0.1.0
[INFO] [stderr]    Compiling embree4-rs v0.0.7 (https://github.com/ivsop/embree4-rs/?rev=9317565638f6e25a592e3e42f26033bf203bd0b8#93175656)
[INFO] [stderr]    Compiling cexpr v0.6.0
[INFO] [stderr]     Checking urlencoding v2.1.3
[INFO] [stderr]     Checking glam v0.30.1
[INFO] [stderr]     Checking maybe-rayon v0.1.1
[INFO] [stderr]     Checking num-bigint v0.4.6
[INFO] [stderr]    Compiling regex-automata v0.4.9
[INFO] [stderr]    Compiling which v4.4.2
[INFO] [stderr]     Checking num-rational v0.4.2
[INFO] [stderr]     Checking av1-grain v0.2.3
[INFO] [stderr]    Compiling regex v1.11.1
[INFO] [stderr]    Compiling thiserror-impl v1.0.69
[INFO] [stderr]    Compiling profiling-procmacros v1.0.16
[INFO] [stderr]    Compiling arg_enum_proc_macro v0.3.4
[INFO] [stderr]    Compiling num-derive v0.4.2
[INFO] [stderr]    Compiling gltf-derive v1.4.1
[INFO] [stderr]    Compiling serde_derive v1.0.219
[INFO] [stderr]     Checking profiling v1.0.16
[INFO] [stderr]     Checking thiserror v1.0.69
[INFO] [stderr]     Checking gltf-json v1.4.1
[INFO] [stderr]    Compiling embree4-sys v0.0.12
[INFO] [stderr]     Checking ravif v0.11.11
[INFO] [stderr]     Checking image v0.25.5
[INFO] [stderr]     Checking gltf v1.4.1
[INFO] [stderr]     Checking raynaldo v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: method `transform` is never used
[INFO] [stdout]   --> src/geometry/mod.rs:82:12
[INFO] [stdout]    |
[INFO] [stdout] 45 | impl Geometry {
[INFO] [stdout]    | ------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 82 |     pub fn transform(&mut self, matrix: Mat4) {
[INFO] [stdout]    |            ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variants `Ambient` and `Point` are never constructed
[INFO] [stdout]    --> src/geometry/mod.rs:106:5
[INFO] [stdout]     |
[INFO] [stdout] 105 | pub enum LightType {
[INFO] [stdout]     |          --------- variants in this enum
[INFO] [stdout] 106 |     Ambient,
[INFO] [stdout]     |     ^^^^^^^
[INFO] [stdout] 107 |     Point(Vec3), // stores position
[INFO] [stdout]     |     ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated functions `new` and `with_normal` are never used
[INFO] [stdout]    --> src/geometry/mod.rs:119:12
[INFO] [stdout]     |
[INFO] [stdout] 118 | impl LightQuad {
[INFO] [stdout]     | -------------- associated functions in this implementation
[INFO] [stdout] 119 |     pub fn new(bottom_left: Vec3, u_vec: Vec3, v_vec: Vec3) -> Self {
[INFO] [stdout]     |            ^^^
[INFO] [stdout] ...
[INFO] [stdout] 129 |     pub fn with_normal(bottom_left: Vec3, u_vec: Vec3, v_vec: Vec3, normal: Vec3) -> Self {
[INFO] [stdout]     |            ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated constant `GREEN_MATERIAL` is never used
[INFO] [stdout]   --> src/geometry/material.rs:56:15
[INFO] [stdout]    |
[INFO] [stdout] 34 | impl Material {
[INFO] [stdout]    | ------------- associated constant in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 56 |     pub const GREEN_MATERIAL: Self = Self {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `render_par` is never used
[INFO] [stdout]   --> src/renderer.rs:21:12
[INFO] [stdout]    |
[INFO] [stdout] 20 | impl<T: RayTracer + Sync> Renderer<T> {
[INFO] [stdout]    | ------------------------------------- method in this implementation
[INFO] [stdout] 21 |     pub fn render_par(&self, camera: &Camera) -> Rgb32FImage {
[INFO] [stdout]    |            ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]    --> src/color.rs:105:1
[INFO] [stdout]     |
[INFO] [stdout] 105 | impl Into<image::Rgba<f32>> for Rgba {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
[INFO] [stdout]             https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout]     = note: `#[warn(clippy::from_over_into)]` on by default
[INFO] [stdout] help: replace the `Into` implementation with `From<color::Rgba>`
[INFO] [stdout]     |
[INFO] [stdout] 105 ~ impl From<Rgba> for image::Rgba<f32> {
[INFO] [stdout] 106 ~     fn from(val: Rgba) -> Self {
[INFO] [stdout] 107 ~         image::Rgba([val.r, val.g, val.b, val.a])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]    --> src/color.rs:111:1
[INFO] [stdout]     |
[INFO] [stdout] 111 | impl Into<image::Rgb<f32>> for Rgba {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
[INFO] [stdout]             https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<color::Rgba>`
[INFO] [stdout]     |
[INFO] [stdout] 111 ~ impl From<Rgba> for image::Rgb<f32> {
[INFO] [stdout] 112 ~     fn from(val: Rgba) -> Self {
[INFO] [stdout] 113 ~         image::Rgb([val.r, val.g, val.b])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]    --> src/color.rs:117:1
[INFO] [stdout]     |
[INFO] [stdout] 117 | impl Into<Rgba> for image::Rgba<f32> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<image::Rgba<f32>>`
[INFO] [stdout]     |
[INFO] [stdout] 117 ~ impl From<image::Rgba<f32>> for Rgba {
[INFO] [stdout] 118 ~     fn from(val: image::Rgba<f32>) -> Self {
[INFO] [stdout] 119 ~         let [r, g, b, a] = val.0;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/cornell.rs:278:16
[INFO] [stdout]     |
[INFO] [stdout] 278 |     gltf_buff: &Vec<gltf::buffer::Data>,
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 278 -     gltf_buff: &Vec<gltf::buffer::Data>,
[INFO] [stdout] 278 +     gltf_buff: &[gltf::buffer::Data],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/cornell.rs:385:9
[INFO] [stdout]     |
[INFO] [stdout] 385 |         let _ = store.add_geometry(geometry);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 385 -         let _ = store.add_geometry(geometry);
[INFO] [stdout] 385 +         store.add_geometry(geometry);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `transform` is never used
[INFO] [stdout]   --> src/geometry/mod.rs:82:12
[INFO] [stdout]    |
[INFO] [stdout] 45 | impl Geometry {
[INFO] [stdout]    | ------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 82 |     pub fn transform(&mut self, matrix: Mat4) {
[INFO] [stdout]    |            ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variants `Ambient` and `Point` are never constructed
[INFO] [stdout]    --> src/geometry/mod.rs:106:5
[INFO] [stdout]     |
[INFO] [stdout] 105 | pub enum LightType {
[INFO] [stdout]     |          --------- variants in this enum
[INFO] [stdout] 106 |     Ambient,
[INFO] [stdout]     |     ^^^^^^^
[INFO] [stdout] 107 |     Point(Vec3), // stores position
[INFO] [stdout]     |     ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated functions `new` and `with_normal` are never used
[INFO] [stdout]    --> src/geometry/mod.rs:119:12
[INFO] [stdout]     |
[INFO] [stdout] 118 | impl LightQuad {
[INFO] [stdout]     | -------------- associated functions in this implementation
[INFO] [stdout] 119 |     pub fn new(bottom_left: Vec3, u_vec: Vec3, v_vec: Vec3) -> Self {
[INFO] [stdout]     |            ^^^
[INFO] [stdout] ...
[INFO] [stdout] 129 |     pub fn with_normal(bottom_left: Vec3, u_vec: Vec3, v_vec: Vec3, normal: Vec3) -> Self {
[INFO] [stdout]     |            ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated constant `GREEN_MATERIAL` is never used
[INFO] [stdout]   --> src/geometry/material.rs:56:15
[INFO] [stdout]    |
[INFO] [stdout] 34 | impl Material {
[INFO] [stdout]    | ------------- associated constant in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 56 |     pub const GREEN_MATERIAL: Self = Self {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `render_par` is never used
[INFO] [stdout]   --> src/renderer.rs:21:12
[INFO] [stdout]    |
[INFO] [stdout] 20 | impl<T: RayTracer + Sync> Renderer<T> {
[INFO] [stdout]    | ------------------------------------- method in this implementation
[INFO] [stdout] 21 |     pub fn render_par(&self, camera: &Camera) -> Rgb32FImage {
[INFO] [stdout]    |            ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/geometry/storage.rs:98:9
[INFO] [stdout]     |
[INFO] [stdout]  98 | /         if let Texture::Solid(diff) = geom.material.texture {
[INFO] [stdout]  99 | |             if let Texture::Solid(emissive) = geom.material.emissive {
[INFO] [stdout] 100 | |                 return (diff, emissive);
[INFO] [stdout] 101 | |             }
[INFO] [stdout] 102 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  98 ~         if let Texture::Solid(diff) = geom.material.texture
[INFO] [stdout]  99 ~             && let Texture::Solid(emissive) = geom.material.emissive {
[INFO] [stdout] 100 |                 return (diff, emissive);
[INFO] [stdout] 101 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]    --> src/color.rs:105:1
[INFO] [stdout]     |
[INFO] [stdout] 105 | impl Into<image::Rgba<f32>> for Rgba {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
[INFO] [stdout]             https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout]     = note: `#[warn(clippy::from_over_into)]` on by default
[INFO] [stdout] help: replace the `Into` implementation with `From<color::Rgba>`
[INFO] [stdout]     |
[INFO] [stdout] 105 ~ impl From<Rgba> for image::Rgba<f32> {
[INFO] [stdout] 106 ~     fn from(val: Rgba) -> Self {
[INFO] [stdout] 107 ~         image::Rgba([val.r, val.g, val.b, val.a])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]    --> src/color.rs:111:1
[INFO] [stdout]     |
[INFO] [stdout] 111 | impl Into<image::Rgb<f32>> for Rgba {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
[INFO] [stdout]             https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<color::Rgba>`
[INFO] [stdout]     |
[INFO] [stdout] 111 ~ impl From<Rgba> for image::Rgb<f32> {
[INFO] [stdout] 112 ~     fn from(val: Rgba) -> Self {
[INFO] [stdout] 113 ~         image::Rgb([val.r, val.g, val.b])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/raytracer/embree.rs:32:21
[INFO] [stdout]    |
[INFO] [stdout] 32 |                     &self.device,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: change this to: `self.device`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/raytracer/embree.rs:40:21
[INFO] [stdout]    |
[INFO] [stdout] 40 |                     &self.device,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: change this to: `self.device`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]    --> src/color.rs:117:1
[INFO] [stdout]     |
[INFO] [stdout] 117 | impl Into<Rgba> for image::Rgba<f32> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<image::Rgba<f32>>`
[INFO] [stdout]     |
[INFO] [stdout] 117 ~ impl From<image::Rgba<f32>> for Rgba {
[INFO] [stdout] 118 ~     fn from(val: image::Rgba<f32>) -> Self {
[INFO] [stdout] 119 ~         let [r, g, b, a] = val.0;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]   --> src/raytracer/embree.rs:59:1
[INFO] [stdout]    |
[INFO] [stdout] 59 | impl Into<RTCRay> for Ray {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
[INFO] [stdout]            https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<raytracer::Ray>`
[INFO] [stdout]    |
[INFO] [stdout] 59 ~ impl From<Ray> for RTCRay {
[INFO] [stdout] 60 ~     fn from(val: Ray) -> Self {
[INFO] [stdout] 61 |         RTCRay {
[INFO] [stdout] 62 ~             org_x: val.origin.x,
[INFO] [stdout] 63 ~             org_y: val.origin.y,
[INFO] [stdout] 64 ~             org_z: val.origin.z,
[INFO] [stdout] 65 ~             dir_x: val.direction.x,
[INFO] [stdout] 66 ~             dir_y: val.direction.y,
[INFO] [stdout] 67 ~             dir_z: val.direction.z,
[INFO] [stdout] 68 ~             tfar: val.max_distance,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]   --> src/raytracer/embree.rs:74:1
[INFO] [stdout]    |
[INFO] [stdout] 74 | impl Into<RayHitResult> for RTCRayHit {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<embree4_sys::RTCRayHit>`
[INFO] [stdout]    |
[INFO] [stdout] 74 ~ impl From<RTCRayHit> for RayHitResult {
[INFO] [stdout] 75 ~     fn from(val: RTCRayHit) -> Self {
[INFO] [stdout] 76 ~         let origin = Vec3::new(val.ray.org_x, val.ray.org_y, val.ray.org_z);
[INFO] [stdout] 77 ~         let dir = Vec3::new(val.ray.dir_x, val.ray.dir_y, val.ray.dir_z).normalize();
[INFO] [stdout] 78 ~         let hit_point = origin + dir * val.ray.tfar;
[INFO] [stdout] 79 |         RayHitResult {
[INFO] [stdout] 80 |             hit_point,
[INFO] [stdout] 81 ~             normal: Vec3::new(val.hit.Ng_x, val.hit.Ng_y, val.hit.Ng_z).normalize(),
[INFO] [stdout] 82 ~             u: val.hit.u,
[INFO] [stdout] 83 ~             v: val.hit.v,
[INFO] [stdout] 84 ~             geometry_id: GeometryId(val.hit.geomID),
[INFO] [stdout] 85 ~             triangle_id: val.hit.primID,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/renderer.rs:100:12
[INFO] [stdout]     |
[INFO] [stdout] 100 |         if !(depth < self.config.min_depth) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(depth >= self.config.min_depth)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/renderer.rs:61:9
[INFO] [stdout]    |
[INFO] [stdout] 61 | /         if depth < self.config.min_depth || rand < self.config.over_depth_prob {
[INFO] [stdout] 62 | |             if let Some(hit) = self.scene.raytracer.intersect(ray) {
[INFO] [stdout] 63 | |                 let geometry: &Geometry = self
[INFO] [stdout] 64 | |                     .scene
[INFO] [stdout] ...  |
[INFO] [stdout] 98 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 61 ~         if (depth < self.config.min_depth || rand < self.config.over_depth_prob) {
[INFO] [stdout] 62 ~             && let Some(hit) = self.scene.raytracer.intersect(ray) {
[INFO] [stdout] 63 |                 let geometry: &Geometry = self
[INFO] [stdout] ...
[INFO] [stdout] 96 |                 color += emissive;
[INFO] [stdout] 97 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/renderer.rs:79:64
[INFO] [stdout]    |
[INFO] [stdout] 79 |                 color += self.direct_lighting(hit_pos, normal, &material, diff);
[INFO] [stdout]    |                                                                ^^^^^^^^^ help: change this to: `material`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/renderer.rs:131:5
[INFO] [stdout]     |
[INFO] [stdout] 131 | /     pub fn reflect(
[INFO] [stdout] 132 | |         &self,
[INFO] [stdout] 133 | |         hit: Vec3,
[INFO] [stdout] 134 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 139 | |         reflect: f32,
[INFO] [stdout] 140 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]    --> src/renderer.rs:164:5
[INFO] [stdout]     |
[INFO] [stdout] 164 | /     pub fn refract(
[INFO] [stdout] 165 | |         &self,
[INFO] [stdout] 166 | |         hit: Vec3,
[INFO] [stdout] 167 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 173 | |         refract: f32,
[INFO] [stdout] 174 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]    --> src/renderer.rs:213:5
[INFO] [stdout]     |
[INFO] [stdout] 213 | /     pub fn loop_scatter(
[INFO] [stdout] 214 | |         &self,
[INFO] [stdout] 215 | |         hit: Vec3,
[INFO] [stdout] 216 | |         normal: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 222 | |         num: u32,
[INFO] [stdout] 223 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]    --> src/renderer.rs:249:5
[INFO] [stdout]     |
[INFO] [stdout] 249 | /     pub fn scatter_rand(
[INFO] [stdout] 250 | |         &self,
[INFO] [stdout] 251 | |         hit: Vec3,
[INFO] [stdout] 252 | |         normal: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 258 | |         prob: f32,
[INFO] [stdout] 259 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/renderer.rs:286:5
[INFO] [stdout]     |
[INFO] [stdout] 286 | /     pub fn reflect_refract_scatter(
[INFO] [stdout] 287 | |         &self,
[INFO] [stdout] 288 | |         hit: Vec3,
[INFO] [stdout] 289 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 294 | |         depth: u32,
[INFO] [stdout] 295 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/renderer.rs:339:5
[INFO] [stdout]     |
[INFO] [stdout] 339 | /     pub fn random_reflect_refract_scatter(
[INFO] [stdout] 340 | |         &self,
[INFO] [stdout] 341 | |         hit: Vec3,
[INFO] [stdout] 342 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 347 | |         depth: u32,
[INFO] [stdout] 348 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]    --> src/renderer.rs:443:20
[INFO] [stdout]     |
[INFO] [stdout] 443 |             if let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout]     |             -------^^^^--------------------------------------------- help: try: `if self.scene.raytracer.intersect(shadow_ray).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/renderer.rs:500:17
[INFO] [stdout]     |
[INFO] [stdout] 500 | /                 if distance_to_light > 0.0 {
[INFO] [stdout] 501 | |                     if let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout] ...   |
[INFO] [stdout] 511 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 500 ~                 if distance_to_light > 0.0
[INFO] [stdout] 501 ~                     && let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout] 502 |                         // color of the light * color of object * cos from the object to the light
[INFO] [stdout] ...
[INFO] [stdout] 509 |                             * (dir_to_light.dot(square.normal)).abs();
[INFO] [stdout] 510 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]    --> src/renderer.rs:501:28
[INFO] [stdout]     |
[INFO] [stdout] 501 |                     if let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout]     |                     -------^^^^--------------------------------------------- help: try: `if self.scene.raytracer.intersect(shadow_ray).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/cornell.rs:278:16
[INFO] [stdout]     |
[INFO] [stdout] 278 |     gltf_buff: &Vec<gltf::buffer::Data>,
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 278 -     gltf_buff: &Vec<gltf::buffer::Data>,
[INFO] [stdout] 278 +     gltf_buff: &[gltf::buffer::Data],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/cornell.rs:385:9
[INFO] [stdout]     |
[INFO] [stdout] 385 |         let _ = store.add_geometry(geometry);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 385 -         let _ = store.add_geometry(geometry);
[INFO] [stdout] 385 +         store.add_geometry(geometry);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/main.rs:27:41
[INFO] [stdout]    |
[INFO] [stdout] 27 |       scene.add_textures_batch_from_files(&vec![
[INFO] [stdout]    |  _________________________________________^
[INFO] [stdout] 28 | |         "assets/textures/skybox/front.jpg",
[INFO] [stdout] 29 | |         "assets/textures/skybox/back.jpg",
[INFO] [stdout] 30 | |         "assets/textures/skybox/right.jpg",
[INFO] [stdout] ...  |
[INFO] [stdout] 33 | |         "assets/textures/skybox/bottom.jpg",
[INFO] [stdout] 34 | |     ])?;
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]    = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] help: you can use a slice directly
[INFO] [stdout]    |
[INFO] [stdout] 27 ~     scene.add_textures_batch_from_files(&["assets/textures/skybox/front.jpg",
[INFO] [stdout] 28 +         "assets/textures/skybox/back.jpg",
[INFO] [stdout] 29 +         "assets/textures/skybox/right.jpg",
[INFO] [stdout] 30 +         "assets/textures/skybox/left.jpg",
[INFO] [stdout] 31 +         "assets/textures/skybox/top.jpg",
[INFO] [stdout] 32 ~         "assets/textures/skybox/bottom.jpg"])?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/geometry/storage.rs:98:9
[INFO] [stdout]     |
[INFO] [stdout]  98 | /         if let Texture::Solid(diff) = geom.material.texture {
[INFO] [stdout]  99 | |             if let Texture::Solid(emissive) = geom.material.emissive {
[INFO] [stdout] 100 | |                 return (diff, emissive);
[INFO] [stdout] 101 | |             }
[INFO] [stdout] 102 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  98 ~         if let Texture::Solid(diff) = geom.material.texture
[INFO] [stdout]  99 ~             && let Texture::Solid(emissive) = geom.material.emissive {
[INFO] [stdout] 100 |                 return (diff, emissive);
[INFO] [stdout] 101 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/raytracer/embree.rs:32:21
[INFO] [stdout]    |
[INFO] [stdout] 32 |                     &self.device,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: change this to: `self.device`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/raytracer/embree.rs:40:21
[INFO] [stdout]    |
[INFO] [stdout] 40 |                     &self.device,
[INFO] [stdout]    |                     ^^^^^^^^^^^^ help: change this to: `self.device`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]   --> src/raytracer/embree.rs:59:1
[INFO] [stdout]    |
[INFO] [stdout] 59 | impl Into<RTCRay> for Ray {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
[INFO] [stdout]            https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<raytracer::Ray>`
[INFO] [stdout]    |
[INFO] [stdout] 59 ~ impl From<Ray> for RTCRay {
[INFO] [stdout] 60 ~     fn from(val: Ray) -> Self {
[INFO] [stdout] 61 |         RTCRay {
[INFO] [stdout] 62 ~             org_x: val.origin.x,
[INFO] [stdout] 63 ~             org_y: val.origin.y,
[INFO] [stdout] 64 ~             org_z: val.origin.z,
[INFO] [stdout] 65 ~             dir_x: val.direction.x,
[INFO] [stdout] 66 ~             dir_y: val.direction.y,
[INFO] [stdout] 67 ~             dir_z: val.direction.z,
[INFO] [stdout] 68 ~             tfar: val.max_distance,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
[INFO] [stdout]   --> src/raytracer/embree.rs:74:1
[INFO] [stdout]    |
[INFO] [stdout] 74 | impl Into<RayHitResult> for RTCRayHit {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
[INFO] [stdout] help: replace the `Into` implementation with `From<embree4_sys::RTCRayHit>`
[INFO] [stdout]    |
[INFO] [stdout] 74 ~ impl From<RTCRayHit> for RayHitResult {
[INFO] [stdout] 75 ~     fn from(val: RTCRayHit) -> Self {
[INFO] [stdout] 76 ~         let origin = Vec3::new(val.ray.org_x, val.ray.org_y, val.ray.org_z);
[INFO] [stdout] 77 ~         let dir = Vec3::new(val.ray.dir_x, val.ray.dir_y, val.ray.dir_z).normalize();
[INFO] [stdout] 78 ~         let hit_point = origin + dir * val.ray.tfar;
[INFO] [stdout] 79 |         RayHitResult {
[INFO] [stdout] 80 |             hit_point,
[INFO] [stdout] 81 ~             normal: Vec3::new(val.hit.Ng_x, val.hit.Ng_y, val.hit.Ng_z).normalize(),
[INFO] [stdout] 82 ~             u: val.hit.u,
[INFO] [stdout] 83 ~             v: val.hit.v,
[INFO] [stdout] 84 ~             geometry_id: GeometryId(val.hit.geomID),
[INFO] [stdout] 85 ~             triangle_id: val.hit.primID,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/renderer.rs:100:12
[INFO] [stdout]     |
[INFO] [stdout] 100 |         if !(depth < self.config.min_depth) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(depth >= self.config.min_depth)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/renderer.rs:61:9
[INFO] [stdout]    |
[INFO] [stdout] 61 | /         if depth < self.config.min_depth || rand < self.config.over_depth_prob {
[INFO] [stdout] 62 | |             if let Some(hit) = self.scene.raytracer.intersect(ray) {
[INFO] [stdout] 63 | |                 let geometry: &Geometry = self
[INFO] [stdout] 64 | |                     .scene
[INFO] [stdout] ...  |
[INFO] [stdout] 98 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 61 ~         if (depth < self.config.min_depth || rand < self.config.over_depth_prob) {
[INFO] [stdout] 62 ~             && let Some(hit) = self.scene.raytracer.intersect(ray) {
[INFO] [stdout] 63 |                 let geometry: &Geometry = self
[INFO] [stdout] ...
[INFO] [stdout] 96 |                 color += emissive;
[INFO] [stdout] 97 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/renderer.rs:79:64
[INFO] [stdout]    |
[INFO] [stdout] 79 |                 color += self.direct_lighting(hit_pos, normal, &material, diff);
[INFO] [stdout]    |                                                                ^^^^^^^^^ help: change this to: `material`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/renderer.rs:131:5
[INFO] [stdout]     |
[INFO] [stdout] 131 | /     pub fn reflect(
[INFO] [stdout] 132 | |         &self,
[INFO] [stdout] 133 | |         hit: Vec3,
[INFO] [stdout] 134 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 139 | |         reflect: f32,
[INFO] [stdout] 140 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]    --> src/renderer.rs:164:5
[INFO] [stdout]     |
[INFO] [stdout] 164 | /     pub fn refract(
[INFO] [stdout] 165 | |         &self,
[INFO] [stdout] 166 | |         hit: Vec3,
[INFO] [stdout] 167 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 173 | |         refract: f32,
[INFO] [stdout] 174 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]    --> src/renderer.rs:213:5
[INFO] [stdout]     |
[INFO] [stdout] 213 | /     pub fn loop_scatter(
[INFO] [stdout] 214 | |         &self,
[INFO] [stdout] 215 | |         hit: Vec3,
[INFO] [stdout] 216 | |         normal: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 222 | |         num: u32,
[INFO] [stdout] 223 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]    --> src/renderer.rs:249:5
[INFO] [stdout]     |
[INFO] [stdout] 249 | /     pub fn scatter_rand(
[INFO] [stdout] 250 | |         &self,
[INFO] [stdout] 251 | |         hit: Vec3,
[INFO] [stdout] 252 | |         normal: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 258 | |         prob: f32,
[INFO] [stdout] 259 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/renderer.rs:286:5
[INFO] [stdout]     |
[INFO] [stdout] 286 | /     pub fn reflect_refract_scatter(
[INFO] [stdout] 287 | |         &self,
[INFO] [stdout] 288 | |         hit: Vec3,
[INFO] [stdout] 289 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 294 | |         depth: u32,
[INFO] [stdout] 295 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/renderer.rs:339:5
[INFO] [stdout]     |
[INFO] [stdout] 339 | /     pub fn random_reflect_refract_scatter(
[INFO] [stdout] 340 | |         &self,
[INFO] [stdout] 341 | |         hit: Vec3,
[INFO] [stdout] 342 | |         incident_dir: Vec3,
[INFO] [stdout] ...   |
[INFO] [stdout] 347 | |         depth: u32,
[INFO] [stdout] 348 | |     ) -> Rgba {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]    --> src/renderer.rs:443:20
[INFO] [stdout]     |
[INFO] [stdout] 443 |             if let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout]     |             -------^^^^--------------------------------------------- help: try: `if self.scene.raytracer.intersect(shadow_ray).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/renderer.rs:500:17
[INFO] [stdout]     |
[INFO] [stdout] 500 | /                 if distance_to_light > 0.0 {
[INFO] [stdout] 501 | |                     if let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout] ...   |
[INFO] [stdout] 511 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 500 ~                 if distance_to_light > 0.0
[INFO] [stdout] 501 ~                     && let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout] 502 |                         // color of the light * color of object * cos from the object to the light
[INFO] [stdout] ...
[INFO] [stdout] 509 |                             * (dir_to_light.dot(square.normal)).abs();
[INFO] [stdout] 510 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]    --> src/renderer.rs:501:28
[INFO] [stdout]     |
[INFO] [stdout] 501 |                     if let None = self.scene.raytracer.intersect(shadow_ray) {
[INFO] [stdout]     |                     -------^^^^--------------------------------------------- help: try: `if self.scene.raytracer.intersect(shadow_ray).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/main.rs:27:41
[INFO] [stdout]    |
[INFO] [stdout] 27 |       scene.add_textures_batch_from_files(&vec![
[INFO] [stdout]    |  _________________________________________^
[INFO] [stdout] 28 | |         "assets/textures/skybox/front.jpg",
[INFO] [stdout] 29 | |         "assets/textures/skybox/back.jpg",
[INFO] [stdout] 30 | |         "assets/textures/skybox/right.jpg",
[INFO] [stdout] ...  |
[INFO] [stdout] 33 | |         "assets/textures/skybox/bottom.jpg",
[INFO] [stdout] 34 | |     ])?;
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]    = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] help: you can use a slice directly
[INFO] [stdout]    |
[INFO] [stdout] 27 ~     scene.add_textures_batch_from_files(&["assets/textures/skybox/front.jpg",
[INFO] [stdout] 28 +         "assets/textures/skybox/back.jpg",
[INFO] [stdout] 29 +         "assets/textures/skybox/right.jpg",
[INFO] [stdout] 30 +         "assets/textures/skybox/left.jpg",
[INFO] [stdout] 31 +         "assets/textures/skybox/top.jpg",
[INFO] [stdout] 32 ~         "assets/textures/skybox/bottom.jpg"])?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.42s
[INFO] running `Command { std: "docker" "inspect" "a6796c01f665b73890985fe6b04f6a6ac9689c380fd1441f3091769775f37553", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a6796c01f665b73890985fe6b04f6a6ac9689c380fd1441f3091769775f37553", kill_on_drop: false }`
[INFO] [stdout] a6796c01f665b73890985fe6b04f6a6ac9689c380fd1441f3091769775f37553