[INFO] cloning repository https://github.com/INDA24PlusPlus/avj-chess [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/INDA24PlusPlus/avj-chess" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FINDA24PlusPlus%2Favj-chess", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FINDA24PlusPlus%2Favj-chess'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4d5876ed761bf7daa8896b67a0f4c798a63181d8 [INFO] linting INDA24PlusPlus/avj-chess against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FINDA24PlusPlus%2Favj-chess" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/INDA24PlusPlus/avj-chess [INFO] finished tweaking git repo https://github.com/INDA24PlusPlus/avj-chess [INFO] tweaked toml for git repo https://github.com/INDA24PlusPlus/avj-chess written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/INDA24PlusPlus/avj-chess on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/INDA24PlusPlus/avj-chess already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7d98c6057c9f3aeed00f474847f40d83ddac8a3a89b838d0775d275a7f9a8da [INFO] running `Command { std: "docker" "start" "-a" "a7d98c6057c9f3aeed00f474847f40d83ddac8a3a89b838d0775d275a7f9a8da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7d98c6057c9f3aeed00f474847f40d83ddac8a3a89b838d0775d275a7f9a8da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7d98c6057c9f3aeed00f474847f40d83ddac8a3a89b838d0775d275a7f9a8da", kill_on_drop: false }` [INFO] [stdout] a7d98c6057c9f3aeed00f474847f40d83ddac8a3a89b838d0775d275a7f9a8da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73b815c108822fa9220d9f8cbf8ac2dd675512b447139251a9c24446ef6c3866 [INFO] running `Command { std: "docker" "start" "-a" "73b815c108822fa9220d9f8cbf8ac2dd675512b447139251a9c24446ef6c3866", kill_on_drop: false }` [INFO] [stderr] Checking chess_lib v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::any::Any` [INFO] [stdout] --> src/board/board.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::any::Any; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `get_legal_moves` [INFO] [stdout] --> src/board/board.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | get_legal_moves, get_pseudo_legal_moves, possible_moves_for_color, Color, Move, Piece, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/board/board.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | let board = Board { pieces: pieces }; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/board/parser.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | board::{self, Board}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Error` [INFO] [stdout] --> src/board/pieces.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/board/pieces.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::any::Any` [INFO] [stdout] --> src/board/board.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::any::Any; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `get_legal_moves` [INFO] [stdout] --> src/board/board.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | get_legal_moves, get_pseudo_legal_moves, possible_moves_for_color, Color, Move, Piece, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/board/board.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | let board = Board { pieces: pieces }; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/board/board.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `move_piece` and `self` [INFO] [stdout] --> src/board/board.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | self, [INFO] [stdout] | ^^^^ [INFO] [stdout] 246 | parser::{self, parse_fen_string, print_row}, [INFO] [stdout] 247 | pieces::{can_pawn_promote, castle_possible, get_legal_moves, move_piece, Move}, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/board/parser.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | board::{self, Board}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Error` [INFO] [stdout] --> src/board/pieces.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/board/pieces.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/board/board.rs:183:10 [INFO] [stdout] | [INFO] [stdout] 183 | for (index, possible_move) in possible_moves.iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/board/board.rs:226:10 [INFO] [stdout] | [INFO] [stdout] 226 | for (index, possible_move) in possible_moves.iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/board/pieces.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/board/pieces.rs:225:61 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn get_pseudo_legal_moves(board: Board, x: i32, y: i32, color: Color) -> Vec { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/board/pieces.rs:270:54 [INFO] [stdout] | [INFO] [stdout] 270 | pub fn get_legal_moves(board: Board, x: i32, y: i32, color: Color) -> Vec { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/board/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod board; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return parse_fen_string(fen.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return parse_fen_string(fen.unwrap()); [INFO] [stdout] 123 + parse_fen_string(fen.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return pawns; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return pawns; [INFO] [stdout] 134 + pawns [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return false; [INFO] [stdout] 146 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | return check; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return check; [INFO] [stdout] 193 + check [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/board/board.rs:171:10 [INFO] [stdout] | [INFO] [stdout] 171 | .map(|(_piece, index)| { [INFO] [stdout] | __________^ [INFO] [stdout] 172 | | let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 173 | | [INFO] [stdout] 174 | | let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] ... | [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 171 ~ .flat_map(|(_piece, index)| { [INFO] [stdout] 172 + let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 173 + [INFO] [stdout] 174 + let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] 175 + [INFO] [stdout] 176 + return pseudo_moves; [INFO] [stdout] 177 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | return pseudo_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return pseudo_moves; [INFO] [stdout] 176 + pseudo_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:232:5 [INFO] [stdout] | [INFO] [stdout] 232 | return check; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - return check; [INFO] [stdout] 232 + check [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/board/board.rs:216:10 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|(_piece, index)| { [INFO] [stdout] | __________^ [INFO] [stdout] 217 | | let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 218 | | [INFO] [stdout] 219 | | let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] 220 | | return pseudo_moves; [INFO] [stdout] 221 | | }) [INFO] [stdout] 222 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 216 ~ .flat_map(|(_piece, index)| { [INFO] [stdout] 217 + let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 218 + [INFO] [stdout] 219 + let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] 220 + return pseudo_moves; [INFO] [stdout] 221 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | return pseudo_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return pseudo_moves; [INFO] [stdout] 220 + pseudo_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/parser.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return board; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return board; [INFO] [stdout] 83 + board [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/board/parser.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 54 | board_row[(file + i) as usize] = Piece { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((file + i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/board/parser.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | offset_by_empty_spots = offset_by_empty_spots + (n_empty_spots as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset_by_empty_spots += (n_empty_spots as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&piece).is_some()` [INFO] [stdout] --> src/board/parser.rs:61:39 [INFO] [stdout] | [INFO] [stdout] 61 | } else if black_piece_map.get(&piece).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&piece)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&piece).is_some()` [INFO] [stdout] --> src/board/parser.rs:68:39 [INFO] [stdout] | [INFO] [stdout] 68 | } else if white_piece_map.get(&piece).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&piece)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/board/pieces.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | println!("x: {}, y: {}", self.0, self.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return false; [INFO] [stdout] 61 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | return legal_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return legal_moves; [INFO] [stdout] 120 + legal_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Board` which implements the `Copy` trait [INFO] [stdout] --> src/board/pieces.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | let mut board_copy = board.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | if !left_positions_in_check [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 144 | | && left_rook_pos.has_moved == false [INFO] [stdout] 145 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] ... | [INFO] [stdout] 148 | | && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] 149 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 142 - if !left_positions_in_check [INFO] [stdout] 143 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 144 - && left_rook_pos.has_moved == false [INFO] [stdout] 145 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 146 - && board.pieces[7][1].piece_type == PieceType::EMPTY [INFO] [stdout] 147 - && board.pieces[7][2].piece_type == PieceType::EMPTY [INFO] [stdout] 148 - && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] 149 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 142 + if !(left_positions_in_check || left_rook_pos.piece_type != PieceType::ROOK || left_rook_pos.has_moved != false || king_pos.piece_type != PieceType::KING || board.pieces[7][1].piece_type != PieceType::EMPTY || board.pieces[7][2].piece_type != PieceType::EMPTY || board.pieces[7][3].piece_type != PieceType::EMPTY) [INFO] [stdout] | [INFO] [stdout] 142 - if !left_positions_in_check [INFO] [stdout] 143 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 144 - && left_rook_pos.has_moved == false [INFO] [stdout] 145 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 146 - && board.pieces[7][1].piece_type == PieceType::EMPTY [INFO] [stdout] 147 - && board.pieces[7][2].piece_type == PieceType::EMPTY [INFO] [stdout] 148 - && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] 149 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 142 + if !left_positions_in_check && left_rook_pos.piece_type == PieceType::ROOK && left_rook_pos.has_moved == false && king_pos.piece_type == PieceType::KING && board.pieces[7][1].piece_type == PieceType::EMPTY && board.pieces[7][2].piece_type == PieceType::EMPTY && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | if !left_positions_in_check [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 | | && left_rook_pos.has_moved == false [INFO] [stdout] 182 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] ... | [INFO] [stdout] 185 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] 186 | | && king_pos.has_moved == false [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 186 - && king_pos.has_moved == false [INFO] [stdout] 179 + if !(left_positions_in_check || left_rook_pos.piece_type != PieceType::ROOK || left_rook_pos.has_moved != false || king_pos.piece_type != PieceType::KING || board.pieces[0][6].piece_type != PieceType::EMPTY || board.pieces[0][5].piece_type != PieceType::EMPTY || king_pos.has_moved != false) [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 186 - && king_pos.has_moved == false [INFO] [stdout] 179 + if !left_positions_in_check && left_rook_pos.piece_type == PieceType::ROOK && left_rook_pos.has_moved == false && king_pos.piece_type == PieceType::KING && board.pieces[0][6].piece_type == PieceType::EMPTY && board.pieces[0][5].piece_type == PieceType::EMPTY && king_pos.has_moved == false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | if !left_positions_in_check [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 | | && left_rook_pos.has_moved == false [INFO] [stdout] 182 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 | | && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 | | && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 179 + if !(left_positions_in_check || left_rook_pos.piece_type != PieceType::ROOK || left_rook_pos.has_moved != false || king_pos.piece_type != PieceType::KING || board.pieces[0][6].piece_type != PieceType::EMPTY || board.pieces[0][5].piece_type != PieceType::EMPTY) [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 179 + if !left_positions_in_check && left_rook_pos.piece_type == PieceType::ROOK && left_rook_pos.has_moved == false && king_pos.piece_type == PieceType::KING && board.pieces[0][6].piece_type == PieceType::EMPTY && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return (false, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return (false, false); [INFO] [stdout] 204 + (false, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:144:16 [INFO] [stdout] | [INFO] [stdout] 144 | && left_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!left_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | && right_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!right_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | && left_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!left_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | && right_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!right_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/board/board.rs:183:10 [INFO] [stdout] | [INFO] [stdout] 183 | for (index, possible_move) in possible_moves.iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:198:16 [INFO] [stdout] | [INFO] [stdout] 198 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 210 | if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 210 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 210 + if !(x <= 7 && y <= 7 && x >= 0) { [INFO] [stdout] | [INFO] [stdout] 210 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 210 + if x > 7 || y > 7 || x < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Ok(()); [INFO] [stdout] 222 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return moves; [INFO] [stdout] 267 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/board/board.rs:226:10 [INFO] [stdout] | [INFO] [stdout] 226 | for (index, possible_move) in possible_moves.iter().enumerate() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:262:13 [INFO] [stdout] | [INFO] [stdout] 262 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | return filter_illegal_moves(&board, moves, piece.color, x, y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return filter_illegal_moves(&board, moves, piece.color, x, y); [INFO] [stdout] 312 + filter_illegal_moves(&board, moves, piece.color, x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 283 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 300 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/board/pieces.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/board/pieces.rs:225:61 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn get_pseudo_legal_moves(board: Board, x: i32, y: i32, color: Color) -> Vec { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/board/pieces.rs:270:54 [INFO] [stdout] | [INFO] [stdout] 270 | pub fn get_legal_moves(board: Board, x: i32, y: i32, color: Color) -> Vec { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:364:5 [INFO] [stdout] | [INFO] [stdout] 364 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 364 - return None; [INFO] [stdout] 364 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/board/pieces.rs:351:12 [INFO] [stdout] | [INFO] [stdout] 351 | } else if color == Color::BLACK { [INFO] [stdout] | ____________^ [INFO] [stdout] 352 | | if game.white_moves[0].1 == PieceType::PAWN [INFO] [stdout] 353 | | && ((x > 0 [INFO] [stdout] 354 | | && game.board.pieces[4][x as usize - 1].piece_type == PieceType::PAWN [INFO] [stdout] ... | [INFO] [stdout] 363 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 351 ~ } else if color == Color::BLACK [INFO] [stdout] 352 ~ && game.white_moves[0].1 == PieceType::PAWN [INFO] [stdout] 353 | && ((x > 0 [INFO] [stdout] ... [INFO] [stdout] 361 | return Some((x, y)); [INFO] [stdout] 362 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/board/pieces.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | } else if color == Color::BLACK { [INFO] [stdout] | ____________^ [INFO] [stdout] 381 | | if game.black_en_passant.is_some() { [INFO] [stdout] 382 | | simulate_piece_move(&mut game.board, Move(x, y + 1), x, y + 1).ok(); [INFO] [stdout] ... | [INFO] [stdout] 392 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 380 ~ } else if color == Color::BLACK [INFO] [stdout] 381 ~ && game.black_en_passant.is_some() { [INFO] [stdout] 382 | simulate_piece_move(&mut game.board, Move(x, y + 1), x, y + 1).ok(); [INFO] [stdout] ... [INFO] [stdout] 390 | game.black_en_passant = None; [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:422:5 [INFO] [stdout] | [INFO] [stdout] 422 | return Err("Could not castle"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 422 - return Err("Could not castle"); [INFO] [stdout] 422 + Err("Could not castle") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:426:8 [INFO] [stdout] | [INFO] [stdout] 426 | if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 426 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 426 + if !(x <= 7 && y <= 7 && x >= 0) { [INFO] [stdout] | [INFO] [stdout] 426 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 426 + if x > 7 || y > 7 || x < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 458 - return Ok(()); [INFO] [stdout] 458 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | return Err("No pawn to promote"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return Err("No pawn to promote"); [INFO] [stdout] 538 + Err("No pawn to promote") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:619:5 [INFO] [stdout] | [INFO] [stdout] 619 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 619 - return valid_moves; [INFO] [stdout] 619 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:549:12 [INFO] [stdout] | [INFO] [stdout] 549 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:554:12 [INFO] [stdout] | [INFO] [stdout] 554 | if col >= 0 && col <= 7 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:566:12 [INFO] [stdout] | [INFO] [stdout] 566 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:571:12 [INFO] [stdout] | [INFO] [stdout] 571 | if col <= 7 && col >= 0 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:584:12 [INFO] [stdout] | [INFO] [stdout] 584 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:590:12 [INFO] [stdout] | [INFO] [stdout] 590 | if col >= 0 && col <= 7 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:605:12 [INFO] [stdout] | [INFO] [stdout] 605 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:610:12 [INFO] [stdout] | [INFO] [stdout] 610 | if col >= 0 && col <= 7 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:683:5 [INFO] [stdout] | [INFO] [stdout] 683 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 683 - return valid_moves; [INFO] [stdout] 683 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:743:5 [INFO] [stdout] | [INFO] [stdout] 743 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 743 - return valid_moves; [INFO] [stdout] 743 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/board/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod board; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return parse_fen_string(fen.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return parse_fen_string(fen.unwrap()); [INFO] [stdout] 123 + parse_fen_string(fen.unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:772:5 [INFO] [stdout] | [INFO] [stdout] 772 | return possible_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 772 - return possible_moves; [INFO] [stdout] 772 + possible_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/board/pieces.rs:759:10 [INFO] [stdout] | [INFO] [stdout] 759 | .map(|(_piece, index)| { [INFO] [stdout] | __________^ [INFO] [stdout] 760 | | let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 761 | | [INFO] [stdout] 762 | | let pseudo_moves = get_pseudo_legal_moves(game.board, col, row, color); [INFO] [stdout] ... | [INFO] [stdout] 769 | | }) [INFO] [stdout] 770 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 759 ~ .flat_map(|(_piece, index)| { [INFO] [stdout] 760 + let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 761 + [INFO] [stdout] 762 + let pseudo_moves = get_pseudo_legal_moves(game.board, col, row, color); [INFO] [stdout] 763 + let legal_moves = filter_illegal_moves(&(game.board), pseudo_moves, color, col, row); [INFO] [stdout] 764 + if legal_moves.len() > 0 { [INFO] [stdout] 765 + println!("{:?}", legal_moves); [INFO] [stdout] 766 + println!("{:?} {:?}", col, row); [INFO] [stdout] 767 + } [INFO] [stdout] 768 + return legal_moves; [INFO] [stdout] 769 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:768:13 [INFO] [stdout] | [INFO] [stdout] 768 | return legal_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 768 - return legal_moves; [INFO] [stdout] 768 + legal_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return pawns; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return pawns; [INFO] [stdout] 134 + pawns [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return false; [INFO] [stdout] 146 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board/pieces.rs:764:16 [INFO] [stdout] | [INFO] [stdout] 764 | if legal_moves.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!legal_moves.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | return check; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return check; [INFO] [stdout] 193 + check [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:804:5 [INFO] [stdout] | [INFO] [stdout] 804 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 804 - return valid_moves; [INFO] [stdout] 804 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/board/board.rs:171:10 [INFO] [stdout] | [INFO] [stdout] 171 | .map(|(_piece, index)| { [INFO] [stdout] | __________^ [INFO] [stdout] 172 | | let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 173 | | [INFO] [stdout] 174 | | let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] ... | [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 171 ~ .flat_map(|(_piece, index)| { [INFO] [stdout] 172 + let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 173 + [INFO] [stdout] 174 + let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] 175 + [INFO] [stdout] 176 + return pseudo_moves; [INFO] [stdout] 177 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | return pseudo_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return pseudo_moves; [INFO] [stdout] 176 + pseudo_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:232:5 [INFO] [stdout] | [INFO] [stdout] 232 | return check; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - return check; [INFO] [stdout] 232 + check [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:839:5 [INFO] [stdout] | [INFO] [stdout] 839 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 839 - return valid_moves; [INFO] [stdout] 839 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/board/board.rs:216:10 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|(_piece, index)| { [INFO] [stdout] | __________^ [INFO] [stdout] 217 | | let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 218 | | [INFO] [stdout] 219 | | let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] 220 | | return pseudo_moves; [INFO] [stdout] 221 | | }) [INFO] [stdout] 222 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 216 ~ .flat_map(|(_piece, index)| { [INFO] [stdout] 217 + let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 218 + [INFO] [stdout] 219 + let pseudo_moves = get_pseudo_legal_moves(board, col, row, opposing_color); [INFO] [stdout] 220 + return pseudo_moves; [INFO] [stdout] 221 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/board.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | return pseudo_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return pseudo_moves; [INFO] [stdout] 220 + pseudo_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:847:5 [INFO] [stdout] | [INFO] [stdout] 847 | return [diagonal_moves, horizontal_vertical_moves].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 847 - return [diagonal_moves, horizontal_vertical_moves].concat(); [INFO] [stdout] 847 + [diagonal_moves, horizontal_vertical_moves].concat() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return None; [INFO] [stdout] 65 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/matrix.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return Some((row, col)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return Some((row, col)); [INFO] [stdout] 11 + Some((row, col)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sets.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return product; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return product; [INFO] [stdout] 10 + product [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/board/board.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | assert_eq!(in_check(board, Color::WHITE), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 354 - assert_eq!(in_check(board, Color::WHITE), false); [INFO] [stdout] 354 + assert!(!in_check(board, Color::WHITE)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/board/board.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 356 | assert_eq!(in_check(board, Color::BLACK), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 356 - assert_eq!(in_check(board, Color::BLACK), false); [INFO] [stdout] 356 + assert!(!in_check(board, Color::BLACK)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/board/board.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | assert_eq!(in_check(board, Color::BLACK), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 407 - assert_eq!(in_check(board, Color::BLACK), true); [INFO] [stdout] 407 + assert!(in_check(board, Color::BLACK)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/board/board.rs:408:9 [INFO] [stdout] | [INFO] [stdout] 408 | assert_eq!(in_check(board, Color::WHITE), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 408 - assert_eq!(in_check(board, Color::WHITE), false); [INFO] [stdout] 408 + assert!(!in_check(board, Color::WHITE)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/parser.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return board; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return board; [INFO] [stdout] 83 + board [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/board/parser.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 54 | board_row[(file + i) as usize] = Piece { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `((file + i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/board/parser.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | offset_by_empty_spots = offset_by_empty_spots + (n_empty_spots as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset_by_empty_spots += (n_empty_spots as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&piece).is_some()` [INFO] [stdout] --> src/board/parser.rs:61:39 [INFO] [stdout] | [INFO] [stdout] 61 | } else if black_piece_map.get(&piece).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&piece)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&piece).is_some()` [INFO] [stdout] --> src/board/parser.rs:68:39 [INFO] [stdout] | [INFO] [stdout] 68 | } else if white_piece_map.get(&piece).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&piece)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/board/pieces.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | println!("x: {}, y: {}", self.0, self.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `writeln!(f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return false; [INFO] [stdout] 61 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | return legal_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return legal_moves; [INFO] [stdout] 120 + legal_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Board` which implements the `Copy` trait [INFO] [stdout] --> src/board/pieces.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | let mut board_copy = board.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | if !left_positions_in_check [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 144 | | && left_rook_pos.has_moved == false [INFO] [stdout] 145 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] ... | [INFO] [stdout] 148 | | && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] 149 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 142 - if !left_positions_in_check [INFO] [stdout] 143 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 144 - && left_rook_pos.has_moved == false [INFO] [stdout] 145 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 146 - && board.pieces[7][1].piece_type == PieceType::EMPTY [INFO] [stdout] 147 - && board.pieces[7][2].piece_type == PieceType::EMPTY [INFO] [stdout] 148 - && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] 149 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 142 + if !(left_positions_in_check || left_rook_pos.piece_type != PieceType::ROOK || left_rook_pos.has_moved != false || king_pos.piece_type != PieceType::KING || board.pieces[7][1].piece_type != PieceType::EMPTY || board.pieces[7][2].piece_type != PieceType::EMPTY || board.pieces[7][3].piece_type != PieceType::EMPTY) [INFO] [stdout] | [INFO] [stdout] 142 - if !left_positions_in_check [INFO] [stdout] 143 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 144 - && left_rook_pos.has_moved == false [INFO] [stdout] 145 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 146 - && board.pieces[7][1].piece_type == PieceType::EMPTY [INFO] [stdout] 147 - && board.pieces[7][2].piece_type == PieceType::EMPTY [INFO] [stdout] 148 - && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] 149 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 142 + if !left_positions_in_check && left_rook_pos.piece_type == PieceType::ROOK && left_rook_pos.has_moved == false && king_pos.piece_type == PieceType::KING && board.pieces[7][1].piece_type == PieceType::EMPTY && board.pieces[7][2].piece_type == PieceType::EMPTY && board.pieces[7][3].piece_type == PieceType::EMPTY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | if !left_positions_in_check [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 | | && left_rook_pos.has_moved == false [INFO] [stdout] 182 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] ... | [INFO] [stdout] 185 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] 186 | | && king_pos.has_moved == false [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 186 - && king_pos.has_moved == false [INFO] [stdout] 179 + if !(left_positions_in_check || left_rook_pos.piece_type != PieceType::ROOK || left_rook_pos.has_moved != false || king_pos.piece_type != PieceType::KING || board.pieces[0][6].piece_type != PieceType::EMPTY || board.pieces[0][5].piece_type != PieceType::EMPTY || king_pos.has_moved != false) [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 186 - && king_pos.has_moved == false [INFO] [stdout] 179 + if !left_positions_in_check && left_rook_pos.piece_type == PieceType::ROOK && left_rook_pos.has_moved == false && king_pos.piece_type == PieceType::KING && board.pieces[0][6].piece_type == PieceType::EMPTY && board.pieces[0][5].piece_type == PieceType::EMPTY && king_pos.has_moved == false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | if !left_positions_in_check [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 | | && left_rook_pos.has_moved == false [INFO] [stdout] 182 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 | | && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 | | && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 | | && king_pos.piece_type == PieceType::KING [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 179 + if !(left_positions_in_check || left_rook_pos.piece_type != PieceType::ROOK || left_rook_pos.has_moved != false || king_pos.piece_type != PieceType::KING || board.pieces[0][6].piece_type != PieceType::EMPTY || board.pieces[0][5].piece_type != PieceType::EMPTY) [INFO] [stdout] | [INFO] [stdout] 179 - if !left_positions_in_check [INFO] [stdout] 180 - && left_rook_pos.piece_type == PieceType::ROOK [INFO] [stdout] 181 - && left_rook_pos.has_moved == false [INFO] [stdout] 182 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 183 - && board.pieces[0][6].piece_type == PieceType::EMPTY [INFO] [stdout] 184 - && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] 185 - && king_pos.piece_type == PieceType::KING [INFO] [stdout] 179 + if !left_positions_in_check && left_rook_pos.piece_type == PieceType::ROOK && left_rook_pos.has_moved == false && king_pos.piece_type == PieceType::KING && board.pieces[0][6].piece_type == PieceType::EMPTY && board.pieces[0][5].piece_type == PieceType::EMPTY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return (false, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return (false, false); [INFO] [stdout] 204 + (false, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:144:16 [INFO] [stdout] | [INFO] [stdout] 144 | && left_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!left_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | && right_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!right_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 161 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | && left_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!left_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | && right_rook_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!right_rook_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/board/pieces.rs:198:16 [INFO] [stdout] | [INFO] [stdout] 198 | && king_pos.has_moved == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!king_pos.has_moved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 210 | if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 210 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 210 + if !(x <= 7 && y <= 7 && x >= 0) { [INFO] [stdout] | [INFO] [stdout] 210 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 210 + if x > 7 || y > 7 || x < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Ok(()); [INFO] [stdout] 222 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:267:5 [INFO] [stdout] | [INFO] [stdout] 267 | return moves; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return moves; [INFO] [stdout] 267 + moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:256:13 [INFO] [stdout] | [INFO] [stdout] 256 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:262:13 [INFO] [stdout] | [INFO] [stdout] 262 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | return filter_illegal_moves(&board, moves, piece.color, x, y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return filter_illegal_moves(&board, moves, piece.color, x, y); [INFO] [stdout] 312 + filter_illegal_moves(&board, moves, piece.color, x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:282:13 [INFO] [stdout] | [INFO] [stdout] 282 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 283 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 300 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | x.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/board/pieces.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | y.try_into().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:364:5 [INFO] [stdout] | [INFO] [stdout] 364 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 364 - return None; [INFO] [stdout] 364 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/board/pieces.rs:351:12 [INFO] [stdout] | [INFO] [stdout] 351 | } else if color == Color::BLACK { [INFO] [stdout] | ____________^ [INFO] [stdout] 352 | | if game.white_moves[0].1 == PieceType::PAWN [INFO] [stdout] 353 | | && ((x > 0 [INFO] [stdout] 354 | | && game.board.pieces[4][x as usize - 1].piece_type == PieceType::PAWN [INFO] [stdout] ... | [INFO] [stdout] 363 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 351 ~ } else if color == Color::BLACK [INFO] [stdout] 352 ~ && game.white_moves[0].1 == PieceType::PAWN [INFO] [stdout] 353 | && ((x > 0 [INFO] [stdout] ... [INFO] [stdout] 361 | return Some((x, y)); [INFO] [stdout] 362 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/board/pieces.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | } else if color == Color::BLACK { [INFO] [stdout] | ____________^ [INFO] [stdout] 381 | | if game.black_en_passant.is_some() { [INFO] [stdout] 382 | | simulate_piece_move(&mut game.board, Move(x, y + 1), x, y + 1).ok(); [INFO] [stdout] ... | [INFO] [stdout] 392 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 380 ~ } else if color == Color::BLACK [INFO] [stdout] 381 ~ && game.black_en_passant.is_some() { [INFO] [stdout] 382 | simulate_piece_move(&mut game.board, Move(x, y + 1), x, y + 1).ok(); [INFO] [stdout] ... [INFO] [stdout] 390 | game.black_en_passant = None; [INFO] [stdout] 391 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:422:5 [INFO] [stdout] | [INFO] [stdout] 422 | return Err("Could not castle"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 422 - return Err("Could not castle"); [INFO] [stdout] 422 + Err("Could not castle") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board/pieces.rs:426:8 [INFO] [stdout] | [INFO] [stdout] 426 | if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 426 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 426 + if !(x <= 7 && y <= 7 && x >= 0) { [INFO] [stdout] | [INFO] [stdout] 426 - if x > 7 || y > 7 || x < 0 || x < 0 { [INFO] [stdout] 426 + if x > 7 || y > 7 || x < 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 458 - return Ok(()); [INFO] [stdout] 458 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | return Err("No pawn to promote"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return Err("No pawn to promote"); [INFO] [stdout] 538 + Err("No pawn to promote") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:619:5 [INFO] [stdout] | [INFO] [stdout] 619 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 619 - return valid_moves; [INFO] [stdout] 619 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:549:12 [INFO] [stdout] | [INFO] [stdout] 549 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:554:12 [INFO] [stdout] | [INFO] [stdout] 554 | if col >= 0 && col <= 7 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:566:12 [INFO] [stdout] | [INFO] [stdout] 566 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:571:12 [INFO] [stdout] | [INFO] [stdout] 571 | if col <= 7 && col >= 0 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:584:12 [INFO] [stdout] | [INFO] [stdout] 584 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:590:12 [INFO] [stdout] | [INFO] [stdout] 590 | if col >= 0 && col <= 7 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:605:12 [INFO] [stdout] | [INFO] [stdout] 605 | if col > 7 || col < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `!(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/board/pieces.rs:610:12 [INFO] [stdout] | [INFO] [stdout] 610 | if col >= 0 && col <= 7 && piece.color == Color::EMPTY { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=7).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:683:5 [INFO] [stdout] | [INFO] [stdout] 683 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 683 - return valid_moves; [INFO] [stdout] 683 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:743:5 [INFO] [stdout] | [INFO] [stdout] 743 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 743 - return valid_moves; [INFO] [stdout] 743 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:772:5 [INFO] [stdout] | [INFO] [stdout] 772 | return possible_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 772 - return possible_moves; [INFO] [stdout] 772 + possible_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/board/pieces.rs:759:10 [INFO] [stdout] | [INFO] [stdout] 759 | .map(|(_piece, index)| { [INFO] [stdout] | __________^ [INFO] [stdout] 760 | | let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 761 | | [INFO] [stdout] 762 | | let pseudo_moves = get_pseudo_legal_moves(game.board, col, row, color); [INFO] [stdout] ... | [INFO] [stdout] 769 | | }) [INFO] [stdout] 770 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 759 ~ .flat_map(|(_piece, index)| { [INFO] [stdout] 760 + let (row, col) = index_to_col_row(*index).unwrap(); [INFO] [stdout] 761 + [INFO] [stdout] 762 + let pseudo_moves = get_pseudo_legal_moves(game.board, col, row, color); [INFO] [stdout] 763 + let legal_moves = filter_illegal_moves(&(game.board), pseudo_moves, color, col, row); [INFO] [stdout] 764 + if legal_moves.len() > 0 { [INFO] [stdout] 765 + println!("{:?}", legal_moves); [INFO] [stdout] 766 + println!("{:?} {:?}", col, row); [INFO] [stdout] 767 + } [INFO] [stdout] 768 + return legal_moves; [INFO] [stdout] 769 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:768:13 [INFO] [stdout] | [INFO] [stdout] 768 | return legal_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 768 - return legal_moves; [INFO] [stdout] 768 + legal_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board/pieces.rs:764:16 [INFO] [stdout] | [INFO] [stdout] 764 | if legal_moves.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!legal_moves.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:804:5 [INFO] [stdout] | [INFO] [stdout] 804 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 804 - return valid_moves; [INFO] [stdout] 804 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:839:5 [INFO] [stdout] | [INFO] [stdout] 839 | return valid_moves; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 839 - return valid_moves; [INFO] [stdout] 839 + valid_moves [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board/pieces.rs:847:5 [INFO] [stdout] | [INFO] [stdout] 847 | return [diagonal_moves, horizontal_vertical_moves].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 847 - return [diagonal_moves, horizontal_vertical_moves].concat(); [INFO] [stdout] 847 + [diagonal_moves, horizontal_vertical_moves].concat() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return None; [INFO] [stdout] 65 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | assert_eq!(game.board.pieces[3][3].has_moved, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 180 - assert_eq!(game.board.pieces[3][3].has_moved, true); [INFO] [stdout] 180 + assert!(game.board.pieces[3][3].has_moved); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | assert_eq!(game.check_mate_white, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 220 - assert_eq!(game.check_mate_white, true); [INFO] [stdout] 220 + assert!(game.check_mate_white); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | assert_eq!(game.check_mate_black, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 221 - assert_eq!(game.check_mate_black, false); [INFO] [stdout] 221 + assert!(!game.check_mate_black); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | assert_eq!(game.check_mate_white, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 236 - assert_eq!(game.check_mate_white, false); [INFO] [stdout] 236 + assert!(!game.check_mate_white); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/game.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | assert_eq!(game.check_mate_black, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 237 - assert_eq!(game.check_mate_black, true); [INFO] [stdout] 237 + assert!(game.check_mate_black); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/matrix.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return Some((row, col)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return Some((row, col)); [INFO] [stdout] 11 + Some((row, col)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/sets.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return product; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return product; [INFO] [stdout] 10 + product [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `Command { std: "docker" "inspect" "73b815c108822fa9220d9f8cbf8ac2dd675512b447139251a9c24446ef6c3866", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73b815c108822fa9220d9f8cbf8ac2dd675512b447139251a9c24446ef6c3866", kill_on_drop: false }` [INFO] [stdout] 73b815c108822fa9220d9f8cbf8ac2dd675512b447139251a9c24446ef6c3866