[INFO] cloning repository https://github.com/IInexerino/advent-of-code_2025 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IInexerino/advent-of-code_2025" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIInexerino%2Fadvent-of-code_2025", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIInexerino%2Fadvent-of-code_2025'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ecfb80ecc202fcab2624fc7a941e45ef6e905828 [INFO] linting IInexerino/advent-of-code_2025 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIInexerino%2Fadvent-of-code_2025" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IInexerino/advent-of-code_2025 [INFO] finished tweaking git repo https://github.com/IInexerino/advent-of-code_2025 [INFO] tweaked toml for git repo https://github.com/IInexerino/advent-of-code_2025 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IInexerino/advent-of-code_2025 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IInexerino/advent-of-code_2025 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ea69a995c331ae127dad2ff7c3034d97235ea22476dbaeac452dfea1d316630 [INFO] running `Command { std: "docker" "start" "-a" "9ea69a995c331ae127dad2ff7c3034d97235ea22476dbaeac452dfea1d316630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ea69a995c331ae127dad2ff7c3034d97235ea22476dbaeac452dfea1d316630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ea69a995c331ae127dad2ff7c3034d97235ea22476dbaeac452dfea1d316630", kill_on_drop: false }` [INFO] [stdout] 9ea69a995c331ae127dad2ff7c3034d97235ea22476dbaeac452dfea1d316630 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 556c90d6d744ed69c398e66fdcd552595fead022f1a9453c515fb7be46f63ed6 [INFO] running `Command { std: "docker" "start" "-a" "556c90d6d744ed69c398e66fdcd552595fead022f1a9453c515fb7be46f63ed6", kill_on_drop: false }` [INFO] [stderr] Checking advent_of_code_2025 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return Dial(amount) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Dial(amount) [INFO] [stdout] 25 + Dial(amount) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | if self.0 == 0 { return true } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - if self.0 == 0 { return true } [INFO] [stdout] 59 + if self.0 == 0 { true } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 60 | else { return false } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - else { return false } [INFO] [stdout] 60 + else { false } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | / if self.0 == 0 { return true } [INFO] [stdout] 60 | | else { return false } [INFO] [stdout] | |_________________________________^ help: you can reduce it to: `return self.0 == 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return dial_turns; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return dial_turns; [INFO] [stdout] 91 + dial_turns [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return id_ranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return id_ranges [INFO] [stdout] 122 + id_ranges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | return Grid(rows) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return Grid(rows) [INFO] [stdout] 197 + Grid(rows) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | / if self.0[position.y as usize][position.x as usize] { [INFO] [stdout] 202 | | self.0[position.y as usize][position.x as usize] = false [INFO] [stdout] 203 | | } [INFO] [stdout] 204 | | else { [INFO] [stdout] 205 | | self.0[position.y as usize][position.x as usize] = true [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `self.0[position.y as usize][position.x as usize] = !self.0[position.y as usize][position.x as usize];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | / if self.0[position.y as usize][position.x as usize] { true } [INFO] [stdout] 211 | | else { false } [INFO] [stdout] | |__________________________^ help: you can reduce it to: `self.0[position.y as usize][position.x as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | if !(position.y < 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(position.y >= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:216:16 [INFO] [stdout] | [INFO] [stdout] 216 | && !(position.x < 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(position.x >= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | / if !(position.y < 0) [INFO] [stdout] 216 | | && !(position.x < 0) [INFO] [stdout] 217 | | && position.y < self.0.len() as i64 [INFO] [stdout] 218 | | && position.x < self.0[0].len() as i64 { true } [INFO] [stdout] 219 | | else { false } [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 215 ~ !(position.y < 0) [INFO] [stdout] 216 + && !(position.x < 0) [INFO] [stdout] 217 + && position.y < self.0.len() as i64 && position.x < self.0[0].len() as i64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:242:13 [INFO] [stdout] | [INFO] [stdout] 242 | return if occupied_neighbors < 4 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return if occupied_neighbors < 4 { true } else { false }; [INFO] [stdout] 242 + if occupied_neighbors < 4 { true } else { false } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:242:20 [INFO] [stdout] | [INFO] [stdout] 242 | return if occupied_neighbors < 4 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `occupied_neighbors < 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return Dial(amount) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Dial(amount) [INFO] [stdout] 25 + Dial(amount) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | if self.0 == 0 { return true } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - if self.0 == 0 { return true } [INFO] [stdout] 59 + if self.0 == 0 { true } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 60 | else { return false } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - else { return false } [INFO] [stdout] 60 + else { false } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | / if self.0 == 0 { return true } [INFO] [stdout] 60 | | else { return false } [INFO] [stdout] | |_________________________________^ help: you can reduce it to: `return self.0 == 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return dial_turns; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return dial_turns; [INFO] [stdout] 91 + dial_turns [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return id_ranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return id_ranges [INFO] [stdout] 122 + id_ranges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | return Grid(rows) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return Grid(rows) [INFO] [stdout] 197 + Grid(rows) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | / if self.0[position.y as usize][position.x as usize] { [INFO] [stdout] 202 | | self.0[position.y as usize][position.x as usize] = false [INFO] [stdout] 203 | | } [INFO] [stdout] 204 | | else { [INFO] [stdout] 205 | | self.0[position.y as usize][position.x as usize] = true [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____________^ help: you can reduce it to: `self.0[position.y as usize][position.x as usize] = !self.0[position.y as usize][position.x as usize];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | / if self.0[position.y as usize][position.x as usize] { true } [INFO] [stdout] 211 | | else { false } [INFO] [stdout] | |__________________________^ help: you can reduce it to: `self.0[position.y as usize][position.x as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:215:16 [INFO] [stdout] | [INFO] [stdout] 215 | if !(position.y < 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(position.y >= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:216:16 [INFO] [stdout] | [INFO] [stdout] 216 | && !(position.x < 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(position.x >= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | / if !(position.y < 0) [INFO] [stdout] 216 | | && !(position.x < 0) [INFO] [stdout] 217 | | && position.y < self.0.len() as i64 [INFO] [stdout] 218 | | && position.x < self.0[0].len() as i64 { true } [INFO] [stdout] 219 | | else { false } [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 215 ~ !(position.y < 0) [INFO] [stdout] 216 + && !(position.x < 0) [INFO] [stdout] 217 + && position.y < self.0.len() as i64 && position.x < self.0[0].len() as i64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:242:13 [INFO] [stdout] | [INFO] [stdout] 242 | return if occupied_neighbors < 4 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return if occupied_neighbors < 4 { true } else { false }; [INFO] [stdout] 242 + if occupied_neighbors < 4 { true } else { false } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/lib.rs:242:20 [INFO] [stdout] | [INFO] [stdout] 242 | return if occupied_neighbors < 4 { true } else { false }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `occupied_neighbors < 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex3_2.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return string_of_digits.parse::().expect("Error: digits string cannot be parsed into a u32"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return string_of_digits.parse::().expect("Error: digits string cannot be parsed into a u32"); [INFO] [stdout] 41 + string_of_digits.parse::().expect("Error: digits string cannot be parsed into a u32") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/bin/ex3_2.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | remaining_digits -= 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx_counter` is used as a loop counter [INFO] [stdout] --> src/bin/ex3_2.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | for digit in &battery_bank.0[idx_counter..] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx_counter, digit) in (previous_idx..).zip(battery_bank.0[idx_counter..].iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex3_2.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return string_of_digits.parse::().expect("Error: digits string cannot be parsed into a u32"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return string_of_digits.parse::().expect("Error: digits string cannot be parsed into a u32"); [INFO] [stdout] 41 + string_of_digits.parse::().expect("Error: digits string cannot be parsed into a u32") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/bin/ex3_2.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | remaining_digits -= 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx_counter` is used as a loop counter [INFO] [stdout] --> src/bin/ex3_2.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | for digit in &battery_bank.0[idx_counter..] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx_counter, digit) in (previous_idx..).zip(battery_bank.0[idx_counter..].iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_1.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return (fresh_ranges, ingredient_ids) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return (fresh_ranges, ingredient_ids) [INFO] [stdout] 47 + (fresh_ranges, ingredient_ids) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/ex5_1.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if line == "" { break } [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex3_1.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return final_number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return final_number [INFO] [stdout] 47 + final_number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/ex5_1.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / loop { [INFO] [stdout] 37 | | if let Some(line_result) = reader_lines.next() { [INFO] [stdout] 38 | | ingredient_ids.push( [INFO] [stdout] 39 | | line_result [INFO] [stdout] ... | [INFO] [stdout] 44 | | } else { break } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(line_result) = reader_lines.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx_counter` is used as a loop counter [INFO] [stdout] --> src/bin/ex3_1.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | for digit in battery_bank.0.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx_counter, digit) in battery_bank.0.clone().into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_1.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return is_fresh; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return is_fresh; [INFO] [stdout] 63 + is_fresh [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/ex5_1.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / loop { [INFO] [stdout] 74 | | if let Some(id) = ingredient_ids.next() { [INFO] [stdout] 75 | | if is_it_fresh(*id, &fresh_ranges) { total_fresh_ingredients += 1} [INFO] [stdout] 76 | | } else { break } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(id) = ingredient_ids.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | return RangeOverlap::AEqualsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return RangeOverlap::AEqualsB [INFO] [stdout] 20 + RangeOverlap::AEqualsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return RangeOverlap::AInsideB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return RangeOverlap::AInsideB [INFO] [stdout] 24 + RangeOverlap::AInsideB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | return RangeOverlap::AContainsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return RangeOverlap::AContainsB [INFO] [stdout] 28 + RangeOverlap::AContainsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return RangeOverlap::AStartsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return RangeOverlap::AStartsInB [INFO] [stdout] 32 + RangeOverlap::AStartsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return RangeOverlap::AEndsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return RangeOverlap::AEndsInB [INFO] [stdout] 36 + RangeOverlap::AEndsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_1.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return (fresh_ranges, ingredient_ids) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return (fresh_ranges, ingredient_ids) [INFO] [stdout] 47 + (fresh_ranges, ingredient_ids) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/ex5_1.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if line == "" { break } [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/ex5_1.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / loop { [INFO] [stdout] 37 | | if let Some(line_result) = reader_lines.next() { [INFO] [stdout] 38 | | ingredient_ids.push( [INFO] [stdout] 39 | | line_result [INFO] [stdout] ... | [INFO] [stdout] 44 | | } else { break } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(line_result) = reader_lines.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_1.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return is_fresh; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return is_fresh; [INFO] [stdout] 63 + is_fresh [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `len` is never used [INFO] [stdout] --> src/bin/example.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 8 | impl FreshRange { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 13 | fn len(&self) -> u128 { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return fresh_ranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return fresh_ranges [INFO] [stdout] 86 + fresh_ranges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/ex5_2.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if line == "" { break } [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/ex5_1.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / loop { [INFO] [stdout] 74 | | if let Some(id) = ingredient_ids.next() { [INFO] [stdout] 75 | | if is_it_fresh(*id, &fresh_ranges) { total_fresh_ingredients += 1} [INFO] [stdout] 76 | | } else { break } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(id) = ingredient_ids.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | return non_overlapping_ranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return non_overlapping_ranges [INFO] [stdout] 110 + non_overlapping_ranges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex1_1.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return counter [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return counter [INFO] [stdout] 16 + counter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex2_1.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return invalid_codes [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return invalid_codes [INFO] [stdout] 25 + invalid_codes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/ex2_1.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if id_digit_chars.len() % 2 != 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!id_digit_chars.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex4_2.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return coords_to_remove.len() as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return coords_to_remove.len() as u64; [INFO] [stdout] 22 + coords_to_remove.len() as u64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return RangeOverlap::AEqualsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return RangeOverlap::AEqualsB [INFO] [stdout] 24 + RangeOverlap::AEqualsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | return RangeOverlap::AInsideB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return RangeOverlap::AInsideB [INFO] [stdout] 28 + RangeOverlap::AInsideB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return RangeOverlap::AContainsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return RangeOverlap::AContainsB [INFO] [stdout] 32 + RangeOverlap::AContainsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return RangeOverlap::AStartsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return RangeOverlap::AStartsInB [INFO] [stdout] 36 + RangeOverlap::AStartsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return RangeOverlap::AEndsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return RangeOverlap::AEndsInB [INFO] [stdout] 40 + RangeOverlap::AEndsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `len` is never used [INFO] [stdout] --> src/bin/example.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 8 | impl FreshRange { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 13 | fn len(&self) -> u128 { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return RangeOverlap::AEqualsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return RangeOverlap::AEqualsB [INFO] [stdout] 24 + RangeOverlap::AEqualsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | return RangeOverlap::AInsideB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return RangeOverlap::AInsideB [INFO] [stdout] 28 + RangeOverlap::AInsideB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return RangeOverlap::AContainsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return RangeOverlap::AContainsB [INFO] [stdout] 32 + RangeOverlap::AContainsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return RangeOverlap::AStartsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return RangeOverlap::AStartsInB [INFO] [stdout] 36 + RangeOverlap::AStartsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/example.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return RangeOverlap::AEndsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return RangeOverlap::AEndsInB [INFO] [stdout] 40 + RangeOverlap::AEndsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_1.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return math_problems [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return math_problems [INFO] [stdout] 63 + math_problems [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_2.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return math_problem_grids [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return math_problem_grids [INFO] [stdout] 83 + math_problem_grids [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_2.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return math_problems [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return math_problems [INFO] [stdout] 134 + math_problems [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_2.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | return math_problems [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return math_problems [INFO] [stdout] 159 + math_problems [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_1.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return math_problems [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return math_problems [INFO] [stdout] 63 + math_problems [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_2.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return math_problem_grids [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return math_problem_grids [INFO] [stdout] 83 + math_problem_grids [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_2.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return math_problems [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return math_problems [INFO] [stdout] 134 + math_problems [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex6_2.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | return math_problems [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return math_problems [INFO] [stdout] 159 + math_problems [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex3_1.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return final_number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return final_number [INFO] [stdout] 47 + final_number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx_counter` is used as a loop counter [INFO] [stdout] --> src/bin/ex3_1.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | for digit in battery_bank.0.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx_counter, digit) in battery_bank.0.clone().into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex2_1.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return invalid_codes [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return invalid_codes [INFO] [stdout] 25 + invalid_codes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/ex2_1.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if id_digit_chars.len() % 2 != 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!id_digit_chars.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex2_2.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return invalid_codes [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return invalid_codes [INFO] [stdout] 44 + invalid_codes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/ex2_2.rs:13:16 [INFO] [stdout] | [INFO] [stdout] 13 | if id_digit_chars.len() % combo_size != 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!id_digit_chars.len().is_multiple_of(combo_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex2_2.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return invalid_codes [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return invalid_codes [INFO] [stdout] 44 + invalid_codes [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex1_1.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return counter [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return counter [INFO] [stdout] 16 + counter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/ex2_2.rs:13:16 [INFO] [stdout] | [INFO] [stdout] 13 | if id_digit_chars.len() % combo_size != 0 { continue } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!id_digit_chars.len().is_multiple_of(combo_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | return RangeOverlap::AEqualsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return RangeOverlap::AEqualsB [INFO] [stdout] 20 + RangeOverlap::AEqualsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return RangeOverlap::AInsideB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return RangeOverlap::AInsideB [INFO] [stdout] 24 + RangeOverlap::AInsideB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | return RangeOverlap::AContainsB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return RangeOverlap::AContainsB [INFO] [stdout] 28 + RangeOverlap::AContainsB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return RangeOverlap::AStartsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return RangeOverlap::AStartsInB [INFO] [stdout] 32 + RangeOverlap::AStartsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return RangeOverlap::AEndsInB [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return RangeOverlap::AEndsInB [INFO] [stdout] 36 + RangeOverlap::AEndsInB [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex4_2.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return coords_to_remove.len() as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return coords_to_remove.len() as u64; [INFO] [stdout] 22 + coords_to_remove.len() as u64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return fresh_ranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return fresh_ranges [INFO] [stdout] 86 + fresh_ranges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/ex5_2.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if line == "" { break } [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/ex5_2.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | return non_overlapping_ranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return non_overlapping_ranges [INFO] [stdout] 110 + non_overlapping_ranges [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "556c90d6d744ed69c398e66fdcd552595fead022f1a9453c515fb7be46f63ed6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "556c90d6d744ed69c398e66fdcd552595fead022f1a9453c515fb7be46f63ed6", kill_on_drop: false }` [INFO] [stdout] 556c90d6d744ed69c398e66fdcd552595fead022f1a9453c515fb7be46f63ed6