[INFO] cloning repository https://github.com/IDL13/GL [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/IDL13/GL" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIDL13%2FGL", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIDL13%2FGL'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ca8a4422e9a0ba78e847c7ee11f139c2b8da2a59 [INFO] linting IDL13/GL against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FIDL13%2FGL" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/IDL13/GL [INFO] finished tweaking git repo https://github.com/IDL13/GL [INFO] tweaked toml for git repo https://github.com/IDL13/GL written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/IDL13/GL on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/IDL13/GL already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cc v1.0.88 [INFO] [stderr] Downloaded sdl2 v0.36.0 [INFO] [stderr] Downloaded sdl2-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ecec68fb34d00bdd5f0734b876e112729483a66a247c0db2b0833253fafb5be1 [INFO] running `Command { std: "docker" "start" "-a" "ecec68fb34d00bdd5f0734b876e112729483a66a247c0db2b0833253fafb5be1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ecec68fb34d00bdd5f0734b876e112729483a66a247c0db2b0833253fafb5be1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecec68fb34d00bdd5f0734b876e112729483a66a247c0db2b0833253fafb5be1", kill_on_drop: false }` [INFO] [stdout] ecec68fb34d00bdd5f0734b876e112729483a66a247c0db2b0833253fafb5be1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4edfee21c780593359565a733172267ad61183d6f1b678d509723f054243e909 [INFO] running `Command { std: "docker" "start" "-a" "4edfee21c780593359565a733172267ad61183d6f1b678d509723f054243e909", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.88 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking opengl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `GLchar` and `GLfloat` [INFO] [stdout] --> src/main.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use gl::types::{GLchar, GLfloat}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `GLchar` and `GLfloat` [INFO] [stdout] --> src/main.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use gl::types::{GLchar, GLfloat}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `sdl`, `gl_context`, and `gl` are never read [INFO] [stdout] --> src/winsdl.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Winsdl { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 6 | pub sdl: Sdl, // Экземпляр SDL [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pub window: Window, // Окно SDL [INFO] [stdout] 8 | pub gl_context: GLContext, // Контекст OpenGL [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 9 | pub gl: (), // Загрузчик OpenGL [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/winsdl.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / let gl = gl::load_with(|s| { [INFO] [stdout] 39 | | video_subsystem.gl_get_proc_address(s) as *const std::os::raw::c_void [INFO] [stdout] 40 | | }); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 38 ~ gl::load_with(|s| { [INFO] [stdout] 39 | video_subsystem.gl_get_proc_address(s) as *const std::os::raw::c_void [INFO] [stdout] ... [INFO] [stdout] 55 | gl_context, [INFO] [stdout] 56 ~ gl: (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/objects.rs:178:30 [INFO] [stdout] | [INFO] [stdout] 178 | fn data(&self, vertices: &Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 178 - fn data(&self, vertices: &Vec) { [INFO] [stdout] 178 + fn data(&self, vertices: &[f32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/objects.rs:234:29 [INFO] [stdout] | [INFO] [stdout] 234 | fn data(&self, indices: &Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 234 - fn data(&self, indices: &Vec) { [INFO] [stdout] 234 + fn data(&self, indices: &[u32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | / if let WindowEvent::Resized(width, height) = win_event { [INFO] [stdout] 64 | | unsafe { [INFO] [stdout] 65 | | gl::Viewport(0, 0, width, height); [INFO] [stdout] 66 | | gl::Uniform2f(u_resolution.id, width as f32, height as f32); [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | Event::Window { win_event, .. } => { [INFO] [stdout] | ^^^^^^^^^ replace this binding [INFO] [stdout] 63 | if let WindowEvent::Resized(width, height) = win_event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `win_event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `sdl`, `gl_context`, and `gl` are never read [INFO] [stdout] --> src/winsdl.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Winsdl { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 6 | pub sdl: Sdl, // Экземпляр SDL [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pub window: Window, // Окно SDL [INFO] [stdout] 8 | pub gl_context: GLContext, // Контекст OpenGL [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 9 | pub gl: (), // Загрузчик OpenGL [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/winsdl.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / let gl = gl::load_with(|s| { [INFO] [stdout] 39 | | video_subsystem.gl_get_proc_address(s) as *const std::os::raw::c_void [INFO] [stdout] 40 | | }); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 38 ~ gl::load_with(|s| { [INFO] [stdout] 39 | video_subsystem.gl_get_proc_address(s) as *const std::os::raw::c_void [INFO] [stdout] ... [INFO] [stdout] 55 | gl_context, [INFO] [stdout] 56 ~ gl: (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/objects.rs:178:30 [INFO] [stdout] | [INFO] [stdout] 178 | fn data(&self, vertices: &Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 178 - fn data(&self, vertices: &Vec) { [INFO] [stdout] 178 + fn data(&self, vertices: &[f32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/objects.rs:234:29 [INFO] [stdout] | [INFO] [stdout] 234 | fn data(&self, indices: &Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 234 - fn data(&self, indices: &Vec) { [INFO] [stdout] 234 + fn data(&self, indices: &[u32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | / if let WindowEvent::Resized(width, height) = win_event { [INFO] [stdout] 64 | | unsafe { [INFO] [stdout] 65 | | gl::Viewport(0, 0, width, height); [INFO] [stdout] 66 | | gl::Uniform2f(u_resolution.id, width as f32, height as f32); [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | Event::Window { win_event, .. } => { [INFO] [stdout] | ^^^^^^^^^ replace this binding [INFO] [stdout] 63 | if let WindowEvent::Resized(width, height) = win_event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `win_event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 17s [INFO] running `Command { std: "docker" "inspect" "4edfee21c780593359565a733172267ad61183d6f1b678d509723f054243e909", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4edfee21c780593359565a733172267ad61183d6f1b678d509723f054243e909", kill_on_drop: false }` [INFO] [stdout] 4edfee21c780593359565a733172267ad61183d6f1b678d509723f054243e909