[INFO] cloning repository https://github.com/I2Tunimib/semTParser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/I2Tunimib/semTParser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FI2Tunimib%2FsemTParser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FI2Tunimib%2FsemTParser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] efadd1e204f140e03c54bd1b8fda49682dd916d7 [INFO] linting I2Tunimib/semTParser against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FI2Tunimib%2FsemTParser" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/I2Tunimib/semTParser [INFO] finished tweaking git repo https://github.com/I2Tunimib/semTParser [INFO] tweaked toml for git repo https://github.com/I2Tunimib/semTParser written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/I2Tunimib/semTParser on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/I2Tunimib/semTParser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rev_lines v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77a507281f0d6c46497ab347560120db03481677d2fd3b636b36e758991573e0 [INFO] running `Command { std: "docker" "start" "-a" "77a507281f0d6c46497ab347560120db03481677d2fd3b636b36e758991573e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77a507281f0d6c46497ab347560120db03481677d2fd3b636b36e758991573e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77a507281f0d6c46497ab347560120db03481677d2fd3b636b36e758991573e0", kill_on_drop: false }` [INFO] [stdout] 77a507281f0d6c46497ab347560120db03481677d2fd3b636b36e758991573e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27ccad2250239799eea0378d75fa37b431a0b22db79031645ec225554338036e [INFO] running `Command { std: "docker" "start" "-a" "27ccad2250239799eea0378d75fa37b431a0b22db79031645ec225554338036e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking rev_lines v0.3.0 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking semTParser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/test_notebook.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use chrono; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/test_notebook.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use chrono; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/notebook_helpers.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use chrono; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/notebook_helpers.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use chrono; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 334 | / let formatted_code = BASE_PYTHON_FILE_CONTENT [INFO] [stdout] 335 | | .replace( [INFO] [stdout] 336 | | "__USERNAME__", [INFO] [stdout] 337 | | &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] ... | [INFO] [stdout] 346 | | .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 347 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 348 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 334 ~ [INFO] [stdout] 335 ~ BASE_PYTHON_FILE_CONTENT [INFO] [stdout] 336 + .replace( [INFO] [stdout] 337 + "__USERNAME__", [INFO] [stdout] 338 + &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] 339 + ) [INFO] [stdout] 340 + .replace( [INFO] [stdout] 341 + "__PASSWORD__", [INFO] [stdout] 342 + &std::env::var("PASSWORD").unwrap_or_default(), [INFO] [stdout] 343 + ) [INFO] [stdout] 344 + .replace( [INFO] [stdout] 345 + "__BASE_URL__", [INFO] [stdout] 346 + &std::env::var("BASE_URL") [INFO] [stdout] 347 + .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 348 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 352 | / let formatted_code = BASE_NOTEBOOK_FILE_CONTENT [INFO] [stdout] 353 | | .replace( [INFO] [stdout] 354 | | "__USERNAME__", [INFO] [stdout] 355 | | &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] ... | [INFO] [stdout] 364 | | .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 365 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 366 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 352 ~ [INFO] [stdout] 353 ~ BASE_NOTEBOOK_FILE_CONTENT [INFO] [stdout] 354 + .replace( [INFO] [stdout] 355 + "__USERNAME__", [INFO] [stdout] 356 + &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] 357 + ) [INFO] [stdout] 358 + .replace( [INFO] [stdout] 359 + "__PASSWORD__", [INFO] [stdout] 360 + &std::env::var("PASSWORD").unwrap_or_default(), [INFO] [stdout] 361 + ) [INFO] [stdout] 362 + .replace( [INFO] [stdout] 363 + "__BASE_URL__", [INFO] [stdout] 364 + &std::env::var("BASE_URL") [INFO] [stdout] 365 + .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 366 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:379:5 [INFO] [stdout] | [INFO] [stdout] 374 | / let formatted_code = BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 375 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 376 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 377 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 378 | | .replace("__COLUMNS_TO_DELETE__", ""); [INFO] [stdout] | |______________________________________________- unnecessary `let` binding [INFO] [stdout] 379 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 374 ~ [INFO] [stdout] 375 ~ BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 376 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 377 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 378 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 379 + .replace("__COLUMNS_TO_DELETE__", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 398 | / let formatted_code = BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 399 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 400 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 401 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 402 | | .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str); [INFO] [stdout] | |__________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 403 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 398 ~ [INFO] [stdout] 399 ~ BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 400 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 401 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 402 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 403 + .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 411 | / let formatted_code = BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 412 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 413 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 414 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 415 | | .replace("__COLUMNS_TO_DELETE__", ""); [INFO] [stdout] | |______________________________________________- unnecessary `let` binding [INFO] [stdout] 416 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 411 ~ [INFO] [stdout] 412 ~ BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 413 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 414 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 415 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 416 + .replace("__COLUMNS_TO_DELETE__", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 435 | / let formatted_code = BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 436 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 437 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 438 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 439 | | .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str); [INFO] [stdout] | |__________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 440 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 435 ~ [INFO] [stdout] 436 ~ BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 437 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 438 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 439 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 440 + .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:472:5 [INFO] [stdout] | [INFO] [stdout] 467 | / let formatted_code = BASE_EXTENSION_OPERATION [INFO] [stdout] 468 | | .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 469 | | .replace("__EXTENSION_PROPERTIES__", &properties_str) [INFO] [stdout] 470 | | .replace("__EXTENSION_PARAMS__", &additional_params_str) [INFO] [stdout] 471 | | .replace("__EXTENDER_ID__", extender_id); [INFO] [stdout] | |_________________________________________________- unnecessary `let` binding [INFO] [stdout] 472 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 467 ~ [INFO] [stdout] 468 ~ BASE_EXTENSION_OPERATION [INFO] [stdout] 469 + .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 470 + .replace("__EXTENSION_PROPERTIES__", &properties_str) [INFO] [stdout] 471 + .replace("__EXTENSION_PARAMS__", &additional_params_str) [INFO] [stdout] 472 + .replace("__EXTENDER_ID__", extender_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:488:5 [INFO] [stdout] | [INFO] [stdout] 484 | / let formatted_code = BASE_RECONCILE_OPERATION [INFO] [stdout] 485 | | .replace("__RECONCILIATOR_ID__", reconciler_id) // Replace with actual reconciliator ID [INFO] [stdout] 486 | | .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 487 | | .replace("__OPTIONAL_COLUMNS__", &additional_columns_str); [INFO] [stdout] | |__________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 488 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 484 ~ [INFO] [stdout] 485 ~ BASE_RECONCILE_OPERATION [INFO] [stdout] 486 + .replace("__RECONCILIATOR_ID__", reconciler_id) // Replace with actual reconciliator ID [INFO] [stdout] 487 + .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 488 + .replace("__OPTIONAL_COLUMNS__", &additional_columns_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:527:5 [INFO] [stdout] | [INFO] [stdout] 524 | / let formatted_code = BASE_PROPAGATION_OPERATION [INFO] [stdout] 525 | | .replace("__COL_TO_PROPAGATE__", column_name) [INFO] [stdout] 526 | | .replace("__TYPE_TO_PROPAGATE__", &type_str); [INFO] [stdout] | |_____________________________________________________- unnecessary `let` binding [INFO] [stdout] 527 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 524 ~ [INFO] [stdout] 525 ~ BASE_PROPAGATION_OPERATION [INFO] [stdout] 526 + .replace("__COL_TO_PROPAGATE__", column_name) [INFO] [stdout] 527 + .replace("__TYPE_TO_PROPAGATE__", &type_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:540:5 [INFO] [stdout] | [INFO] [stdout] 536 | / let formatted_code = BASE_MODIFICATION_OPERATION [INFO] [stdout] 537 | | .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 538 | | .replace("__MODIFIER_NAME__", modifier_name) [INFO] [stdout] 539 | | .replace("__MODIFICATION_PROPS__", &props_str); [INFO] [stdout] | |_______________________________________________________- unnecessary `let` binding [INFO] [stdout] 540 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 536 ~ [INFO] [stdout] 537 ~ BASE_MODIFICATION_OPERATION [INFO] [stdout] 538 + .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 539 + .replace("__MODIFIER_NAME__", modifier_name) [INFO] [stdout] 540 + .replace("__MODIFICATION_PROPS__", &props_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 334 | / let formatted_code = BASE_PYTHON_FILE_CONTENT [INFO] [stdout] 335 | | .replace( [INFO] [stdout] 336 | | "__USERNAME__", [INFO] [stdout] 337 | | &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] ... | [INFO] [stdout] 346 | | .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 347 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 348 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 334 ~ [INFO] [stdout] 335 ~ BASE_PYTHON_FILE_CONTENT [INFO] [stdout] 336 + .replace( [INFO] [stdout] 337 + "__USERNAME__", [INFO] [stdout] 338 + &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] 339 + ) [INFO] [stdout] 340 + .replace( [INFO] [stdout] 341 + "__PASSWORD__", [INFO] [stdout] 342 + &std::env::var("PASSWORD").unwrap_or_default(), [INFO] [stdout] 343 + ) [INFO] [stdout] 344 + .replace( [INFO] [stdout] 345 + "__BASE_URL__", [INFO] [stdout] 346 + &std::env::var("BASE_URL") [INFO] [stdout] 347 + .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 348 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 352 | / let formatted_code = BASE_NOTEBOOK_FILE_CONTENT [INFO] [stdout] 353 | | .replace( [INFO] [stdout] 354 | | "__USERNAME__", [INFO] [stdout] 355 | | &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] ... | [INFO] [stdout] 364 | | .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 365 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 366 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 352 ~ [INFO] [stdout] 353 ~ BASE_NOTEBOOK_FILE_CONTENT [INFO] [stdout] 354 + .replace( [INFO] [stdout] 355 + "__USERNAME__", [INFO] [stdout] 356 + &std::env::var("USERNAME").unwrap_or_default(), [INFO] [stdout] 357 + ) [INFO] [stdout] 358 + .replace( [INFO] [stdout] 359 + "__PASSWORD__", [INFO] [stdout] 360 + &std::env::var("PASSWORD").unwrap_or_default(), [INFO] [stdout] 361 + ) [INFO] [stdout] 362 + .replace( [INFO] [stdout] 363 + "__BASE_URL__", [INFO] [stdout] 364 + &std::env::var("BASE_URL") [INFO] [stdout] 365 + .unwrap_or("http://vm.chronos.disco.unimib.it:3003".to_string()), [INFO] [stdout] 366 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:379:5 [INFO] [stdout] | [INFO] [stdout] 374 | / let formatted_code = BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 375 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 376 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 377 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 378 | | .replace("__COLUMNS_TO_DELETE__", ""); [INFO] [stdout] | |______________________________________________- unnecessary `let` binding [INFO] [stdout] 379 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 374 ~ [INFO] [stdout] 375 ~ BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 376 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 377 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 378 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 379 + .replace("__COLUMNS_TO_DELETE__", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 398 | / let formatted_code = BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 399 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 400 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 401 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 402 | | .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str); [INFO] [stdout] | |__________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 403 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 398 ~ [INFO] [stdout] 399 ~ BASE_PYTHON_DATASET_LOAD_DATAFRAME [INFO] [stdout] 400 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 401 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 402 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 403 + .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 411 | / let formatted_code = BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 412 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 413 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 414 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 415 | | .replace("__COLUMNS_TO_DELETE__", ""); [INFO] [stdout] | |______________________________________________- unnecessary `let` binding [INFO] [stdout] 416 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 411 ~ [INFO] [stdout] 412 ~ BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 413 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 414 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 415 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 416 + .replace("__COLUMNS_TO_DELETE__", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 435 | / let formatted_code = BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 436 | | .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 437 | | .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 438 | | .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 439 | | .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str); [INFO] [stdout] | |__________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 440 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 435 ~ [INFO] [stdout] 436 ~ BASE_NOTEBOOK_DATASET_LOAD_DATAFRAME [INFO] [stdout] 437 + .replace("__TABLE_PATH__", table_path) [INFO] [stdout] 438 + .replace("__DATASET_ID__", dataset_id) [INFO] [stdout] 439 + .replace("__TABLE_NAME__", table_name) [INFO] [stdout] 440 + .replace("__COLUMNS_TO_DELETE__", &columns_to_delete_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:472:5 [INFO] [stdout] | [INFO] [stdout] 467 | / let formatted_code = BASE_EXTENSION_OPERATION [INFO] [stdout] 468 | | .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 469 | | .replace("__EXTENSION_PROPERTIES__", &properties_str) [INFO] [stdout] 470 | | .replace("__EXTENSION_PARAMS__", &additional_params_str) [INFO] [stdout] 471 | | .replace("__EXTENDER_ID__", extender_id); [INFO] [stdout] | |_________________________________________________- unnecessary `let` binding [INFO] [stdout] 472 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 467 ~ [INFO] [stdout] 468 ~ BASE_EXTENSION_OPERATION [INFO] [stdout] 469 + .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 470 + .replace("__EXTENSION_PROPERTIES__", &properties_str) [INFO] [stdout] 471 + .replace("__EXTENSION_PARAMS__", &additional_params_str) [INFO] [stdout] 472 + .replace("__EXTENDER_ID__", extender_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:488:5 [INFO] [stdout] | [INFO] [stdout] 484 | / let formatted_code = BASE_RECONCILE_OPERATION [INFO] [stdout] 485 | | .replace("__RECONCILIATOR_ID__", reconciler_id) // Replace with actual reconciliator ID [INFO] [stdout] 486 | | .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 487 | | .replace("__OPTIONAL_COLUMNS__", &additional_columns_str); [INFO] [stdout] | |__________________________________________________________________- unnecessary `let` binding [INFO] [stdout] 488 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 484 ~ [INFO] [stdout] 485 ~ BASE_RECONCILE_OPERATION [INFO] [stdout] 486 + .replace("__RECONCILIATOR_ID__", reconciler_id) // Replace with actual reconciliator ID [INFO] [stdout] 487 + .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 488 + .replace("__OPTIONAL_COLUMNS__", &additional_columns_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/notebook_helpers.rs:105:54 [INFO] [stdout] | [INFO] [stdout] 105 | for (_, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 105 - for (_, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] 105 + for operation in displayed_operations.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:527:5 [INFO] [stdout] | [INFO] [stdout] 524 | / let formatted_code = BASE_PROPAGATION_OPERATION [INFO] [stdout] 525 | | .replace("__COL_TO_PROPAGATE__", column_name) [INFO] [stdout] 526 | | .replace("__TYPE_TO_PROPAGATE__", &type_str); [INFO] [stdout] | |_____________________________________________________- unnecessary `let` binding [INFO] [stdout] 527 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 524 ~ [INFO] [stdout] 525 ~ BASE_PROPAGATION_OPERATION [INFO] [stdout] 526 + .replace("__COL_TO_PROPAGATE__", column_name) [INFO] [stdout] 527 + .replace("__TYPE_TO_PROPAGATE__", &type_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/code_helper/mod.rs:540:5 [INFO] [stdout] | [INFO] [stdout] 536 | / let formatted_code = BASE_MODIFICATION_OPERATION [INFO] [stdout] 537 | | .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 538 | | .replace("__MODIFIER_NAME__", modifier_name) [INFO] [stdout] 539 | | .replace("__MODIFICATION_PROPS__", &props_str); [INFO] [stdout] | |_______________________________________________________- unnecessary `let` binding [INFO] [stdout] 540 | formatted_code [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 536 ~ [INFO] [stdout] 537 ~ BASE_MODIFICATION_OPERATION [INFO] [stdout] 538 + .replace("__COLUMN_NAME__", column_name) [INFO] [stdout] 539 + .replace("__MODIFIER_NAME__", modifier_name) [INFO] [stdout] 540 + .replace("__MODIFICATION_PROPS__", &props_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/notebook_helpers.rs:105:54 [INFO] [stdout] | [INFO] [stdout] 105 | for (_, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 105 - for (_, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] 105 + for operation in displayed_operations.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:313:25 [INFO] [stdout] | [INFO] [stdout] 313 | &col_name, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:432:25 [INFO] [stdout] | [INFO] [stdout] 432 | &col_name, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:466:64 [INFO] [stdout] | [INFO] [stdout] 466 | source: get_base_propagation_operation(&col_name, Some(&value)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:510:25 [INFO] [stdout] | [INFO] [stdout] 510 | &col_name, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:313:25 [INFO] [stdout] | [INFO] [stdout] 313 | &col_name, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:432:25 [INFO] [stdout] | [INFO] [stdout] 432 | &col_name, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operations.rs:26:50 [INFO] [stdout] | [INFO] [stdout] 26 | if line.contains("GET_TABLE") && !end_line.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `end_line.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:466:64 [INFO] [stdout] | [INFO] [stdout] 466 | source: get_base_propagation_operation(&col_name, Some(&value)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/notebook_helpers.rs:510:25 [INFO] [stdout] | [INFO] [stdout] 510 | &col_name, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `col_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/operations.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | } else if line.contains("SAVE_TABLE") { [INFO] [stdout] | ________________________^ [INFO] [stdout] 30 | | if end_line.is_none() { [INFO] [stdout] 31 | | println!("Found SAVE_TABLE line: {}", line); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ } else if line.contains("SAVE_TABLE") [INFO] [stdout] 30 ~ && end_line.is_none() { [INFO] [stdout] 31 | println!("Found SAVE_TABLE line: {}", line); [INFO] [stdout] ... [INFO] [stdout] 34 | result.push(line); [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/operations.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | let end = match end_line { [INFO] [stdout] | _______________^ [INFO] [stdout] 49 | | Some(line) => line, [INFO] [stdout] 50 | | None => String::new(), // If no end line is found, we will read until the end of the file [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_____^ help: replace it with: `end_line.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/operations.rs:26:50 [INFO] [stdout] | [INFO] [stdout] 26 | if line.contains("GET_TABLE") && !end_line.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `end_line.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/operations.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | } else if line.contains("SAVE_TABLE") { [INFO] [stdout] | ________________________^ [INFO] [stdout] 30 | | if end_line.is_none() { [INFO] [stdout] 31 | | println!("Found SAVE_TABLE line: {}", line); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ } else if line.contains("SAVE_TABLE") [INFO] [stdout] 30 ~ && end_line.is_none() { [INFO] [stdout] 31 | println!("Found SAVE_TABLE line: {}", line); [INFO] [stdout] ... [INFO] [stdout] 34 | result.push(line); [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/operations.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | let end = match end_line { [INFO] [stdout] | _______________^ [INFO] [stdout] 49 | | Some(line) => line, [INFO] [stdout] 50 | | None => String::new(), // If no end line is found, we will read until the end of the file [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_____^ help: replace it with: `end_line.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/python_helpers.rs:129:27 [INFO] [stdout] | [INFO] [stdout] 129 | OpenOptions::new().write(true).append(true).open(file_path) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/python_helpers.rs:194:59 [INFO] [stdout] | [INFO] [stdout] 194 | for (_index, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 194 - for (_index, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] 194 + for operation in displayed_operations.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/python_helpers.rs:129:27 [INFO] [stdout] | [INFO] [stdout] 129 | OpenOptions::new().write(true).append(true).open(file_path) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/python_helpers.rs:194:59 [INFO] [stdout] | [INFO] [stdout] 194 | for (_index, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 194 - for (_index, operation) in displayed_operations.iter().enumerate() { [INFO] [stdout] 194 + for operation in displayed_operations.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.16s [INFO] running `Command { std: "docker" "inspect" "27ccad2250239799eea0378d75fa37b431a0b22db79031645ec225554338036e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27ccad2250239799eea0378d75fa37b431a0b22db79031645ec225554338036e", kill_on_drop: false }` [INFO] [stdout] 27ccad2250239799eea0378d75fa37b431a0b22db79031645ec225554338036e