[INFO] cloning repository https://github.com/Human-Hummus/mds
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Human-Hummus/mds" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHuman-Hummus%2Fmds", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHuman-Hummus%2Fmds'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] a997d1d6210bf50b8fab7e9a9f219c8be8b1a464
[INFO] linting Human-Hummus/mds against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHuman-Hummus%2Fmds" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Human-Hummus/mds
[INFO] finished tweaking git repo https://github.com/Human-Hummus/mds
[INFO] tweaked toml for git repo https://github.com/Human-Hummus/mds written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Human-Hummus/mds on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Human-Hummus/mds already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded which v6.0.1
[INFO] [stderr]   Downloaded question v0.2.2
[INFO] [stderr]   Downloaded jwalk v0.6.2
[INFO] [stderr]   Downloaded delete v1.0.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3e8b76a1b47288dc0cb9c8b7625ad935b2e26d7726a421957c90e441a0aadacf
[INFO] running `Command { std: "docker" "start" "-a" "3e8b76a1b47288dc0cb9c8b7625ad935b2e26d7726a421957c90e441a0aadacf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3e8b76a1b47288dc0cb9c8b7625ad935b2e26d7726a421957c90e441a0aadacf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3e8b76a1b47288dc0cb9c8b7625ad935b2e26d7726a421957c90e441a0aadacf", kill_on_drop: false }`
[INFO] [stdout] 3e8b76a1b47288dc0cb9c8b7625ad935b2e26d7726a421957c90e441a0aadacf
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 4908a530aa599954be16d3ff21703ea46f6f5760ce7e9536871a5e6f092ffabf
[INFO] running `Command { std: "docker" "start" "-a" "4908a530aa599954be16d3ff21703ea46f6f5760ce7e9536871a5e6f092ffabf", kill_on_drop: false }`
[INFO] [stderr]    Compiling lock_api v0.4.12
[INFO] [stderr]    Compiling slab v0.4.9
[INFO] [stderr]    Compiling cc v1.2.17
[INFO] [stderr]     Checking memchr v2.7.1
[INFO] [stderr]     Checking once_cell v1.21.1
[INFO] [stderr]     Checking bitflags v2.5.0
[INFO] [stderr]    Compiling syn v2.0.55
[INFO] [stderr]     Checking parking_lot_core v0.9.10
[INFO] [stderr]     Checking num_cpus v1.16.0
[INFO] [stderr]     Checking socket2 v0.5.8
[INFO] [stderr]     Checking mio v0.8.11
[INFO] [stderr]     Checking indexmap v2.8.0
[INFO] [stderr]    Compiling serde v1.0.210
[INFO] [stderr]     Checking either v1.10.0
[INFO] [stderr]     Checking crossbeam-channel v0.5.12
[INFO] [stderr]     Checking getrandom v0.2.15
[INFO] [stderr]     Checking crossbeam-queue v0.3.11
[INFO] [stderr]    Compiling rustix v0.38.32
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking http-body-util v0.1.3
[INFO] [stderr]     Checking sync_wrapper v1.0.2
[INFO] [stderr]     Checking tracing-core v0.1.33
[INFO] [stderr]     Checking linux-raw-sys v0.4.13
[INFO] [stderr]     Checking rayon v1.10.0
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking numtoa v0.1.0
[INFO] [stderr]     Checking crossbeam v0.8.4
[INFO] [stderr]     Checking home v0.5.9
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking question v0.2.2
[INFO] [stderr]     Checking parking_lot v0.12.3
[INFO] [stderr]     Checking termion v2.0.1
[INFO] [stderr]     Checking tracing v0.1.41
[INFO] [stderr]    Compiling openssl-sys v0.9.106
[INFO] [stderr]    Compiling openssl v0.10.71
[INFO] [stderr]    Compiling native-tls v0.2.14
[INFO] [stderr]     Checking jwalk v0.6.2
[INFO] [stderr]     Checking which v6.0.1
[INFO] [stderr]     Checking serde_json v1.0.140
[INFO] [stderr]     Checking serde_urlencoded v0.7.1
[INFO] [stderr]    Compiling synstructure v0.13.1
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.7.5
[INFO] [stderr]    Compiling zerovec-derive v0.10.3
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling tokio-macros v2.2.0
[INFO] [stderr]    Compiling futures-macro v0.3.30
[INFO] [stderr]    Compiling icu_provider_macros v1.5.0
[INFO] [stderr]    Compiling openssl-macros v0.1.1
[INFO] [stderr]     Checking tokio v1.36.0
[INFO] [stderr]     Checking futures-util v0.3.30
[INFO] [stderr]     Checking zerofrom v0.1.6
[INFO] [stderr]     Checking yoke v0.7.5
[INFO] [stderr]     Checking zerovec v0.10.4
[INFO] [stderr]     Checking tinystr v0.7.6
[INFO] [stderr]     Checking icu_collections v1.5.0
[INFO] [stderr]     Checking icu_locid v1.5.0
[INFO] [stderr]     Checking futures-executor v0.3.30
[INFO] [stderr]     Checking futures v0.3.30
[INFO] [stderr]     Checking icu_provider v1.5.0
[INFO] [stderr]     Checking icu_locid_transform v1.5.0
[INFO] [stderr]     Checking tokio-util v0.7.14
[INFO] [stderr]     Checking tokio-native-tls v0.3.1
[INFO] [stderr]     Checking tower v0.5.2
[INFO] [stderr]     Checking delete v1.0.1
[INFO] [stderr]     Checking icu_properties v1.5.1
[INFO] [stderr]     Checking h2 v0.4.8
[INFO] [stderr]     Checking icu_normalizer v1.5.0
[INFO] [stderr]     Checking idna_adapter v1.2.0
[INFO] [stderr]     Checking idna v1.0.3
[INFO] [stderr]     Checking url v2.5.4
[INFO] [stderr]     Checking hyper v1.6.0
[INFO] [stderr]     Checking hyper-util v0.1.10
[INFO] [stderr]     Checking hyper-tls v0.6.0
[INFO] [stderr]     Checking reqwest v0.12.15
[INFO] [stderr]     Checking mds v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:23:17
[INFO] [stdout]    |
[INFO] [stdout] 23 |                 return Some(nc);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 ~                 Some(nc)
[INFO] [stdout] 24 |             }
[INFO] [stdout] ...
[INFO] [stdout] 28 |             }
[INFO] [stdout] 29 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:27:17
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 return None;
[INFO] [stdout]    |                 ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 ~                 None
[INFO] [stdout] 28 |             }
[INFO] [stdout] 29 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:31:9
[INFO] [stdout]    |
[INFO] [stdout] 31 |         return download_cover_art(infile, title);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 31 -         return download_cover_art(infile, title);
[INFO] [stdout] 31 +         download_cover_art(infile, title)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:33:9
[INFO] [stdout]    |
[INFO] [stdout] 33 |         return og_cover.clone();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -         return og_cover.clone();
[INFO] [stdout] 33 +         og_cover.clone()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/download/cover.rs:73:20
[INFO] [stdout]    |
[INFO] [stdout] 73 | fn youtube(infile: &String, title: &String) -> Option<String> {
[INFO] [stdout]    |                    ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 73 - fn youtube(infile: &String, title: &String) -> Option<String> {
[INFO] [stdout] 73 + fn youtube(infile: &str, title: &String) -> Option<String> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/download/cover.rs:84:5
[INFO] [stdout]    |
[INFO] [stdout] 84 | /     match get_cover(&format!(
[INFO] [stdout] 85 | |         "https://i.ytimg.com/vi/{the_vid_link}/hqdefault.jpg"
[INFO] [stdout] 86 | |     )) {
[INFO] [stdout] 87 | |         Ok(tr) => return Some(tr),
[INFO] [stdout] 88 | |         _ => {}
[INFO] [stdout] 89 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 84 ~     if let Ok(tr) = get_cover(&format!(
[INFO] [stdout] 85 +         "https://i.ytimg.com/vi/{the_vid_link}/hqdefault.jpg"
[INFO] [stdout] 86 +     )) { return Some(tr) }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/download/cover.rs:90:5
[INFO] [stdout]    |
[INFO] [stdout] 90 | /     match get_cover(&format!("https://i.ytimg.com/vi/{the_vid_link}/hq720.jpg")) {
[INFO] [stdout] 91 | |         Ok(tr) => return Some(tr),
[INFO] [stdout] 92 | |         _ => {}
[INFO] [stdout] 93 | |     }
[INFO] [stdout]    | |_____^ help: try: `if let Ok(tr) = get_cover(&format!("https://i.ytimg.com/vi/{the_vid_link}/hq720.jpg")) { return Some(tr) }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/download/cover.rs:117:9
[INFO] [stdout]     |
[INFO] [stdout] 117 | /         contents
[INFO] [stdout] 118 | |             .split("src=\"https://i1.sndcdn.com")
[INFO] [stdout] 119 | |             .nth(1)?
[INFO] [stdout] 120 | |             .split("\"")
[INFO] [stdout] 121 | |             .nth(0)?
[INFO] [stdout]     | |___________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] help: try calling `.next()` instead of `.nth(0)`
[INFO] [stdout]     |
[INFO] [stdout] 117 ~         contents
[INFO] [stdout] 118 +             .split("src=\"https://i1.sndcdn.com")
[INFO] [stdout] 119 +             .nth(1)?
[INFO] [stdout] 120 ~             .split("\"").next()?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/download.rs:107:33
[INFO] [stdout]     |
[INFO] [stdout] 107 |         if song.is_cover_url && !song.cover.is_none() {
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: try: `song.cover.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `song.cover` after checking its variant with `is_none`
[INFO] [stdout]    --> src/download.rs:108:34
[INFO] [stdout]     |
[INFO] [stdout] 107 |         if song.is_cover_url && !song.cover.is_none() {
[INFO] [stdout]     |                                  -------------------- the check is happening here
[INFO] [stdout] 108 |             delete::delete_file(&song.cover.unwrap()).unwrap();
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/download.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 39 |         let infile: String;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `infile` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 39 ~         
[INFO] [stdout] 40 |
[INFO] [stdout] ...
[INFO] [stdout] 68 |
[INFO] [stdout] 69 ~         let infile: String = if song.is_file_url {
[INFO] [stdout] 70 ~             match tmp_ytdlp(&song.infile) {
[INFO] [stdout] 71 |                 Some(value) => value,
[INFO] [stdout] ...
[INFO] [stdout] 80 |         } else {
[INFO] [stdout] 81 ~             song.infile.clone()
[INFO] [stdout] 82 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/download.rs:131:8
[INFO] [stdout]     |
[INFO] [stdout] 131 |     if file_errors != "" {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!file_errors.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/download.rs:139:13
[INFO] [stdout]     |
[INFO] [stdout] 139 |     infile: &String,
[INFO] [stdout]     |             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 139 -     infile: &String,
[INFO] [stdout] 139 +     infile: &str,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/download.rs:162:8
[INFO] [stdout]     |
[INFO] [stdout] 162 |     if artist != "" {
[INFO] [stdout]     |        ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!artist.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/download.rs:201:35
[INFO] [stdout]     |
[INFO] [stdout] 201 | fn is_done(title: &String, files: &Vec<String>) -> bool {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 201 - fn is_done(title: &String, files: &Vec<String>) -> bool {
[INFO] [stdout] 201 + fn is_done(title: &String, files: &[String]) -> bool {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/parser.rs:13:20
[INFO] [stdout]    |
[INFO] [stdout] 13 | fn lines_to(chars: &Vec<char>, pos: usize) -> usize {
[INFO] [stdout]    |                    ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 13 - fn lines_to(chars: &Vec<char>, pos: usize) -> usize {
[INFO] [stdout] 13 + fn lines_to(chars: &[char], pos: usize) -> usize {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/parser.rs:79:20
[INFO] [stdout]    |
[INFO] [stdout] 79 |                 if song.infile.len() < 1 {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `song.infile.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/parser.rs:95:20
[INFO] [stdout]    |
[INFO] [stdout] 95 |                 if song.name.len() < 1 {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `song.name.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/parser.rs:106:20
[INFO] [stdout]     |
[INFO] [stdout] 106 |                 if cover.len() > 0 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cover.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/parser.rs:107:24
[INFO] [stdout]     |
[INFO] [stdout] 107 |                     if cover.chars().nth(0).unwrap() == '!' {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `cover.chars().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/parser.rs:145:20
[INFO] [stdout]     |
[INFO] [stdout] 145 |                 if ftga.chars().nth(0).unwrap() == '/' {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ftga.chars().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
[INFO] [stdout]    --> src/parser.rs:147:26
[INFO] [stdout]     |
[INFO] [stdout] 147 |                         .into_iter()
[INFO] [stdout]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/parser.rs:159:31
[INFO] [stdout]     |
[INFO] [stdout] 159 | pub fn get_artist_name(input: &mut Vec<SongDesc>) {
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 159 - pub fn get_artist_name(input: &mut Vec<SongDesc>) {
[INFO] [stdout] 159 + pub fn get_artist_name(input: &mut [SongDesc]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]   --> src/main.rs:82:20
[INFO] [stdout]    |
[INFO] [stdout] 82 |                 if std::path::Path::new(&args[x]).exists() == false {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!std::path::Path::new(&args[x]).exists()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]    --> src/main.rs:123:8
[INFO] [stdout]     |
[INFO] [stdout] 123 |     if conf.input_file.len() < 1 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `conf.input_file.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]    --> src/main.rs:126:8
[INFO] [stdout]     |
[INFO] [stdout] 126 |     if conf.output_dir.len() < 1 && !searching {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `conf.output_dir.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]    --> src/main.rs:157:21
[INFO] [stdout]     |
[INFO] [stdout] 157 | /                     (&i.as_ref()
[INFO] [stdout] 158 | |                         .unwrap_or_else(|_| {
[INFO] [stdout] 159 | |                             panic!("Error Reading dir \"{}\"", conf.output_dir.clone())
[INFO] [stdout] 160 | |                         })
[INFO] [stdout] ...   |
[INFO] [stdout] 164 | |                         .to_string_lossy()
[INFO] [stdout] 165 | |                         .into_owned())
[INFO] [stdout]     | |______________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 157 ~                     i.as_ref()
[INFO] [stdout] 158 +                         .unwrap_or_else(|_| {
[INFO] [stdout] 159 +                             panic!("Error Reading dir \"{}\"", conf.output_dir.clone())
[INFO] [stdout] 160 +                         })
[INFO] [stdout] 161 +                         .path()
[INFO] [stdout] 162 +                         .file_stem()
[INFO] [stdout] 163 +                         .expect("failed on directory")
[INFO] [stdout] 164 +                         .to_string_lossy()
[INFO] [stdout] 165 +                         .into_owned()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:23:17
[INFO] [stdout]    |
[INFO] [stdout] 23 |                 return Some(nc);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 ~                 Some(nc)
[INFO] [stdout] 24 |             }
[INFO] [stdout] ...
[INFO] [stdout] 28 |             }
[INFO] [stdout] 29 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:27:17
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 return None;
[INFO] [stdout]    |                 ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 ~                 None
[INFO] [stdout] 28 |             }
[INFO] [stdout] 29 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:31:9
[INFO] [stdout]    |
[INFO] [stdout] 31 |         return download_cover_art(infile, title);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 31 -         return download_cover_art(infile, title);
[INFO] [stdout] 31 +         download_cover_art(infile, title)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/download/cover.rs:33:9
[INFO] [stdout]    |
[INFO] [stdout] 33 |         return og_cover.clone();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -         return og_cover.clone();
[INFO] [stdout] 33 +         og_cover.clone()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/download/cover.rs:73:20
[INFO] [stdout]    |
[INFO] [stdout] 73 | fn youtube(infile: &String, title: &String) -> Option<String> {
[INFO] [stdout]    |                    ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 73 - fn youtube(infile: &String, title: &String) -> Option<String> {
[INFO] [stdout] 73 + fn youtube(infile: &str, title: &String) -> Option<String> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/download/cover.rs:84:5
[INFO] [stdout]    |
[INFO] [stdout] 84 | /     match get_cover(&format!(
[INFO] [stdout] 85 | |         "https://i.ytimg.com/vi/{the_vid_link}/hqdefault.jpg"
[INFO] [stdout] 86 | |     )) {
[INFO] [stdout] 87 | |         Ok(tr) => return Some(tr),
[INFO] [stdout] 88 | |         _ => {}
[INFO] [stdout] 89 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 84 ~     if let Ok(tr) = get_cover(&format!(
[INFO] [stdout] 85 +         "https://i.ytimg.com/vi/{the_vid_link}/hqdefault.jpg"
[INFO] [stdout] 86 +     )) { return Some(tr) }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/download/cover.rs:90:5
[INFO] [stdout]    |
[INFO] [stdout] 90 | /     match get_cover(&format!("https://i.ytimg.com/vi/{the_vid_link}/hq720.jpg")) {
[INFO] [stdout] 91 | |         Ok(tr) => return Some(tr),
[INFO] [stdout] 92 | |         _ => {}
[INFO] [stdout] 93 | |     }
[INFO] [stdout]    | |_____^ help: try: `if let Ok(tr) = get_cover(&format!("https://i.ytimg.com/vi/{the_vid_link}/hq720.jpg")) { return Some(tr) }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/download/cover.rs:117:9
[INFO] [stdout]     |
[INFO] [stdout] 117 | /         contents
[INFO] [stdout] 118 | |             .split("src=\"https://i1.sndcdn.com")
[INFO] [stdout] 119 | |             .nth(1)?
[INFO] [stdout] 120 | |             .split("\"")
[INFO] [stdout] 121 | |             .nth(0)?
[INFO] [stdout]     | |___________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]     = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] help: try calling `.next()` instead of `.nth(0)`
[INFO] [stdout]     |
[INFO] [stdout] 117 ~         contents
[INFO] [stdout] 118 +             .split("src=\"https://i1.sndcdn.com")
[INFO] [stdout] 119 +             .nth(1)?
[INFO] [stdout] 120 ~             .split("\"").next()?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/download.rs:107:33
[INFO] [stdout]     |
[INFO] [stdout] 107 |         if song.is_cover_url && !song.cover.is_none() {
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: try: `song.cover.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `song.cover` after checking its variant with `is_none`
[INFO] [stdout]    --> src/download.rs:108:34
[INFO] [stdout]     |
[INFO] [stdout] 107 |         if song.is_cover_url && !song.cover.is_none() {
[INFO] [stdout]     |                                  -------------------- the check is happening here
[INFO] [stdout] 108 |             delete::delete_file(&song.cover.unwrap()).unwrap();
[INFO] [stdout]     |                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/download.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 39 |         let infile: String;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `infile` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 39 ~         
[INFO] [stdout] 40 |
[INFO] [stdout] ...
[INFO] [stdout] 68 |
[INFO] [stdout] 69 ~         let infile: String = if song.is_file_url {
[INFO] [stdout] 70 ~             match tmp_ytdlp(&song.infile) {
[INFO] [stdout] 71 |                 Some(value) => value,
[INFO] [stdout] ...
[INFO] [stdout] 80 |         } else {
[INFO] [stdout] 81 ~             song.infile.clone()
[INFO] [stdout] 82 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/download.rs:131:8
[INFO] [stdout]     |
[INFO] [stdout] 131 |     if file_errors != "" {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!file_errors.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/download.rs:139:13
[INFO] [stdout]     |
[INFO] [stdout] 139 |     infile: &String,
[INFO] [stdout]     |             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 139 -     infile: &String,
[INFO] [stdout] 139 +     infile: &str,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/download.rs:162:8
[INFO] [stdout]     |
[INFO] [stdout] 162 |     if artist != "" {
[INFO] [stdout]     |        ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!artist.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/download.rs:201:35
[INFO] [stdout]     |
[INFO] [stdout] 201 | fn is_done(title: &String, files: &Vec<String>) -> bool {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 201 - fn is_done(title: &String, files: &Vec<String>) -> bool {
[INFO] [stdout] 201 + fn is_done(title: &String, files: &[String]) -> bool {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/parser.rs:13:20
[INFO] [stdout]    |
[INFO] [stdout] 13 | fn lines_to(chars: &Vec<char>, pos: usize) -> usize {
[INFO] [stdout]    |                    ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 13 - fn lines_to(chars: &Vec<char>, pos: usize) -> usize {
[INFO] [stdout] 13 + fn lines_to(chars: &[char], pos: usize) -> usize {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/parser.rs:79:20
[INFO] [stdout]    |
[INFO] [stdout] 79 |                 if song.infile.len() < 1 {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `song.infile.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/parser.rs:95:20
[INFO] [stdout]    |
[INFO] [stdout] 95 |                 if song.name.len() < 1 {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `song.name.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/parser.rs:106:20
[INFO] [stdout]     |
[INFO] [stdout] 106 |                 if cover.len() > 0 {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cover.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/parser.rs:107:24
[INFO] [stdout]     |
[INFO] [stdout] 107 |                     if cover.chars().nth(0).unwrap() == '!' {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `cover.chars().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]    --> src/parser.rs:145:20
[INFO] [stdout]     |
[INFO] [stdout] 145 |                 if ftga.chars().nth(0).unwrap() == '/' {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ftga.chars().next()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
[INFO] [stdout]    --> src/parser.rs:147:26
[INFO] [stdout]     |
[INFO] [stdout] 147 |                         .into_iter()
[INFO] [stdout]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/parser.rs:159:31
[INFO] [stdout]     |
[INFO] [stdout] 159 | pub fn get_artist_name(input: &mut Vec<SongDesc>) {
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 159 - pub fn get_artist_name(input: &mut Vec<SongDesc>) {
[INFO] [stdout] 159 + pub fn get_artist_name(input: &mut [SongDesc]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]   --> src/main.rs:82:20
[INFO] [stdout]    |
[INFO] [stdout] 82 |                 if std::path::Path::new(&args[x]).exists() == false {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!std::path::Path::new(&args[x]).exists()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]    --> src/main.rs:123:8
[INFO] [stdout]     |
[INFO] [stdout] 123 |     if conf.input_file.len() < 1 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `conf.input_file.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]    --> src/main.rs:126:8
[INFO] [stdout]     |
[INFO] [stdout] 126 |     if conf.output_dir.len() < 1 && !searching {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `conf.output_dir.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]    --> src/main.rs:157:21
[INFO] [stdout]     |
[INFO] [stdout] 157 | /                     (&i.as_ref()
[INFO] [stdout] 158 | |                         .unwrap_or_else(|_| {
[INFO] [stdout] 159 | |                             panic!("Error Reading dir \"{}\"", conf.output_dir.clone())
[INFO] [stdout] 160 | |                         })
[INFO] [stdout] ...   |
[INFO] [stdout] 164 | |                         .to_string_lossy()
[INFO] [stdout] 165 | |                         .into_owned())
[INFO] [stdout]     | |______________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 157 ~                     i.as_ref()
[INFO] [stdout] 158 +                         .unwrap_or_else(|_| {
[INFO] [stdout] 159 +                             panic!("Error Reading dir \"{}\"", conf.output_dir.clone())
[INFO] [stdout] 160 +                         })
[INFO] [stdout] 161 +                         .path()
[INFO] [stdout] 162 +                         .file_stem()
[INFO] [stdout] 163 +                         .expect("failed on directory")
[INFO] [stdout] 164 +                         .to_string_lossy()
[INFO] [stdout] 165 +                         .into_owned()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.38s
[INFO] running `Command { std: "docker" "inspect" "4908a530aa599954be16d3ff21703ea46f6f5760ce7e9536871a5e6f092ffabf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "4908a530aa599954be16d3ff21703ea46f6f5760ce7e9536871a5e6f092ffabf", kill_on_drop: false }`
[INFO] [stdout] 4908a530aa599954be16d3ff21703ea46f6f5760ce7e9536871a5e6f092ffabf