[INFO] cloning repository https://github.com/HughBliss/leetcode_solutuons [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HughBliss/leetcode_solutuons" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHughBliss%2Fleetcode_solutuons", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHughBliss%2Fleetcode_solutuons'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9ccb7e37a372f7ba2e28fa46a39a89e24c7af225 [INFO] linting HughBliss/leetcode_solutuons against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHughBliss%2Fleetcode_solutuons" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HughBliss/leetcode_solutuons [INFO] finished tweaking git repo https://github.com/HughBliss/leetcode_solutuons [INFO] tweaked toml for git repo https://github.com/HughBliss/leetcode_solutuons written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HughBliss/leetcode_solutuons on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HughBliss/leetcode_solutuons already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9281d10d19f18db65220ac81c81c9e7e046286a8e60a6b54c3163a0f025fb33 [INFO] running `Command { std: "docker" "start" "-a" "c9281d10d19f18db65220ac81c81c9e7e046286a8e60a6b54c3163a0f025fb33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9281d10d19f18db65220ac81c81c9e7e046286a8e60a6b54c3163a0f025fb33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9281d10d19f18db65220ac81c81c9e7e046286a8e60a6b54c3163a0f025fb33", kill_on_drop: false }` [INFO] [stdout] c9281d10d19f18db65220ac81c81c9e7e046286a8e60a6b54c3163a0f025fb33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] faef6c7bccdbebf6eed66fb52024962436add7a0e075c66c38abc63883429614 [INFO] running `Command { std: "docker" "start" "-a" "faef6c7bccdbebf6eed66fb52024962436add7a0e075c66c38abc63883429614", kill_on_drop: false }` [INFO] [stderr] Checking leet_code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/valid_parentheses/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / /// 3. Every close bracket has a corresponding open bracket of the same type. [INFO] [stdout] 14 | | [INFO] [stdout] | |_^ [INFO] [stdout] 15 | pub struct Solution; [INFO] [stdout] | ------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/valid_parentheses/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / /// 3. Every close bracket has a corresponding open bracket of the same type. [INFO] [stdout] 14 | | [INFO] [stdout] | |_^ [INFO] [stdout] 15 | pub struct Solution; [INFO] [stdout] | ------------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/add_two_numbers/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return dummy_head.unwrap().next; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return dummy_head.unwrap().next; [INFO] [stdout] 64 + dummy_head.unwrap().next [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/add_two_numbers/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if addition != 0 { [INFO] [stdout] 59 | | if let Some(node) = list_3_iterator { [INFO] [stdout] 60 | | node.next = Some(Box::new(ListNode::new(addition))) [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if addition != 0 [INFO] [stdout] 59 ~ && let Some(node) = list_3_iterator { [INFO] [stdout] 60 | node.next = Some(Box::new(ListNode::new(addition))) [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `flowerbed` [INFO] [stdout] --> src/can_place_flowers/mod.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | for i in 0..flowerbed.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 35 - for i in 0..flowerbed.len() { [INFO] [stdout] 35 + for in &flowerbed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/count_square_submatrices_with_all_ones/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return squares_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return squares_count; [INFO] [stdout] 28 + squares_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/count_submatrices_with_all_ones/mod.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 14 - for i in 0..mat.len() { [INFO] [stdout] 14 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Solution` is never constructed [INFO] [stdout] --> src/ongest_subarray_of1s_after_deleting_one_element/mod.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct Solution; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `longest_subarray` is never used [INFO] [stdout] --> src/ongest_subarray_of1s_after_deleting_one_element/mod.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 3 | impl Solution { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 4 | pub fn longest_subarray(nums: Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/divide_an_array_into_subarrays_with_minimum_cost_i/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return result; [INFO] [stdout] 22 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/add_two_numbers/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return dummy_head.unwrap().next; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return dummy_head.unwrap().next; [INFO] [stdout] 64 + dummy_head.unwrap().next [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/find_smallest_letter_greater_than_target/mod.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return letters[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return letters[0]; [INFO] [stdout] 25 + letters[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/add_two_numbers/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / if addition != 0 { [INFO] [stdout] 59 | | if let Some(node) = list_3_iterator { [INFO] [stdout] 60 | | node.next = Some(Box::new(ListNode::new(addition))) [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 58 ~ if addition != 0 [INFO] [stdout] 59 ~ && let Some(node) = list_3_iterator { [INFO] [stdout] 60 | node.next = Some(Box::new(ListNode::new(addition))) [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | for i in 0..grid.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 16 - for i in 0..grid.len() { [INFO] [stdout] 16 + for (i, ) in grid.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | for j in 0..grid[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 18 - for j in 0..grid[i].len() { [INFO] [stdout] 18 + for (j, ) in grid.iter().enumerate().take(grid[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `flowerbed` [INFO] [stdout] --> src/can_place_flowers/mod.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | for i in 0..flowerbed.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 35 - for i in 0..flowerbed.len() { [INFO] [stdout] 35 + for in &flowerbed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if height_start == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `height_start.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:39:56 [INFO] [stdout] | [INFO] [stdout] 39 | return (width_end as i32 - width_start) * (height_end as i32 - hs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `height_end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/count_square_submatrices_with_all_ones/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return squares_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return squares_count; [INFO] [stdout] 28 + squares_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/count_submatrices_with_all_ones/mod.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 14 - for i in 0..mat.len() { [INFO] [stdout] 14 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_ii/mod.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | for r in r_start..r_end { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 19 - for r in r_start..r_end { [INFO] [stdout] 19 + for (r, ) in grid.iter().enumerate().take(r_end).skip(r_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_ii/mod.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | for c in c_start..c_end { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for c in c_start..c_end { [INFO] [stdout] 20 + for (c, ) in grid.iter().enumerate().take(c_end).skip(c_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/divide_an_array_into_subarrays_with_minimum_cost_i/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return result; [INFO] [stdout] 22 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/find_smallest_letter_greater_than_target/mod.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return letters[0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return letters[0]; [INFO] [stdout] 25 + letters[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | for i in 0..grid.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 16 - for i in 0..grid.len() { [INFO] [stdout] 16 + for (i, ) in grid.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | for j in 0..grid[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 18 - for j in 0..grid[i].len() { [INFO] [stdout] 18 + for (j, ) in grid.iter().enumerate().take(grid[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if height_start == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `height_start.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/greatest_common_divisor_of_strings/mod.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | let mut iter1 = bts1.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_i/mod.rs:39:56 [INFO] [stdout] | [INFO] [stdout] 39 | return (width_end as i32 - width_start) * (height_end as i32 - hs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `height_end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/greatest_common_divisor_of_strings/mod.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | let mut iter2 = bts2.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_ii/mod.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | for r in r_start..r_end { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 19 - for r in r_start..r_end { [INFO] [stdout] 19 + for (r, ) in grid.iter().enumerate().take(r_end).skip(r_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `grid` [INFO] [stdout] --> src/find_the_minimum_area_to_cover_all_ones_ii/mod.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | for c in c_start..c_end { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for c in c_start..c_end { [INFO] [stdout] 20 + for (c, ) in grid.iter().enumerate().take(c_end).skip(c_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nums` [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 1..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 14 - for i in 1..nums.len() { [INFO] [stdout] 14 + for in nums.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | if candidate2 == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `candidate2.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(Solution::increasing_triplet(vec![1]), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 62 - assert_eq!(Solution::increasing_triplet(vec![1]), false); [INFO] [stdout] 62 + assert!(!Solution::increasing_triplet(vec![1])); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | assert_eq!(Solution::increasing_triplet(vec![1, 1, -2, 6]), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 67 - assert_eq!(Solution::increasing_triplet(vec![1, 1, -2, 6]), false); [INFO] [stdout] 67 + assert!(!Solution::increasing_triplet(vec![1, 1, -2, 6])); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / assert_eq!( [INFO] [stdout] 73 | | Solution::increasing_triplet(vec![20, 100, 10, 12, 5, 13]), [INFO] [stdout] 74 | | true [INFO] [stdout] 75 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 ~ assert!( [INFO] [stdout] 73 ~ Solution::increasing_triplet(vec![20, 100, 10, 12, 5, 13]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/greatest_common_divisor_of_strings/mod.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | let mut iter1 = bts1.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/greatest_common_divisor_of_strings/mod.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | let mut iter2 = bts2.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nums` [INFO] [stdout] --> src/longest_balanced_subarray_ii/mod.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 11 - for i in 0..nums.len() { [INFO] [stdout] 11 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nums` [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 1..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 14 - for i in 1..nums.len() { [INFO] [stdout] 14 + for in nums.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/increasing_triplet_subsequence/mod.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | if candidate2 == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `candidate2.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `nums` [INFO] [stdout] --> src/longest_balanced_subarray_ii/mod.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | for j in i..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 22 - for j in i..nums.len() { [INFO] [stdout] 22 + for (j, ) in nums.iter().enumerate().skip(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nums` [INFO] [stdout] --> src/longest_balanced_subarray_ii/mod.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 11 - for i in 0..nums.len() { [INFO] [stdout] 11 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `nums` [INFO] [stdout] --> src/longest_balanced_subarray_ii/mod.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | for j in i..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 22 - for j in i..nums.len() { [INFO] [stdout] 22 + for (j, ) in nums.iter().enumerate().skip(i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return longest as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return longest as i32; [INFO] [stdout] 24 + longest as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `byts` [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | for i in start..end { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 10 - for i in start..end { [INFO] [stdout] 10 + for (i, ) in byts.iter().enumerate().take(end).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | start = i + 1; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return longest as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return longest as i32; [INFO] [stdout] 42 + longest as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return longest as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return longest as i32; [INFO] [stdout] 24 + longest as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `byts` [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | for i in start..end { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 10 - for i in start..end { [INFO] [stdout] 10 + for (i, ) in byts.iter().enumerate().take(end).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | start = i + 1; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `dimensions` [INFO] [stdout] --> src/maximum_area_of_longest_diagonal_rectangle/mod.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..dimensions.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..dimensions.len() { [INFO] [stdout] 9 + for in &dimensions { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/longest_substring_without_repeating_characters/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return longest as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return longest as i32; [INFO] [stdout] 42 + longest as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `dimensions` [INFO] [stdout] --> src/maximum_area_of_longest_diagonal_rectangle/mod.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..dimensions.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..dimensions.len() { [INFO] [stdout] 9 + for in &dimensions { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_two_sorted_lists/mod.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return Self::vec_to_list(v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Self::vec_to_list(v); [INFO] [stdout] 78 + Self::vec_to_list(v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/merge_two_sorted_lists/mod.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | None => match list2 { [INFO] [stdout] | _________________________^ [INFO] [stdout] 69 | | Some(l2) => { [INFO] [stdout] 70 | | v.push(l2.val); [INFO] [stdout] 71 | | list2 = l2.next; [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | None => {} [INFO] [stdout] 74 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ None => if let Some(l2) = list2 { [INFO] [stdout] 69 + v.push(l2.val); [INFO] [stdout] 70 + list2 = l2.next; [INFO] [stdout] 71 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nums` [INFO] [stdout] --> src/product_of_array_except_self/mod.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..nums.len() { [INFO] [stdout] 9 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/remove_duplicates_from_sorted_array/mod.rs:6:36 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn remove_duplicates(nums: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn remove_duplicates(nums: &mut Vec) -> i32 { [INFO] [stdout] 6 + pub fn remove_duplicates(nums: &mut [i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_two_sorted_lists/mod.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return Self::vec_to_list(v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Self::vec_to_list(v); [INFO] [stdout] 78 + Self::vec_to_list(v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/remove_duplicates_from_sorted_array/mod.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if nums.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nums.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/merge_two_sorted_lists/mod.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | None => match list2 { [INFO] [stdout] | _________________________^ [INFO] [stdout] 69 | | Some(l2) => { [INFO] [stdout] 70 | | v.push(l2.val); [INFO] [stdout] 71 | | list2 = l2.next; [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | None => {} [INFO] [stdout] 74 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 ~ None => if let Some(l2) = list2 { [INFO] [stdout] 69 + v.push(l2.val); [INFO] [stdout] 70 + list2 = l2.next; [INFO] [stdout] 71 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/remove_element/mod.rs:6:33 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn remove_element(nums: &mut Vec, val: i32) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn remove_element(nums: &mut Vec, val: i32) -> i32 { [INFO] [stdout] 6 + pub fn remove_element(nums: &mut [i32], val: i32) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'e'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:35 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'i'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'o'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:57 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'u'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nums` [INFO] [stdout] --> src/product_of_array_except_self/mod.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..nums.len() { [INFO] [stdout] 9 + for in &nums { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'A'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'E'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'I'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:46 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'O'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:57 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'U'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/remove_duplicates_from_sorted_array/mod.rs:6:36 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn remove_duplicates(nums: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn remove_duplicates(nums: &mut Vec) -> i32 { [INFO] [stdout] 6 + pub fn remove_duplicates(nums: &mut [i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/remove_duplicates_from_sorted_array/mod.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if nums.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nums.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/string_compression/mod.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn compress(chars: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn compress(chars: &mut Vec) -> i32 { [INFO] [stdout] 5 + pub fn compress(chars: &mut [char]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/remove_element/mod.rs:6:33 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn remove_element(nums: &mut Vec, val: i32) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - pub fn remove_element(nums: &mut Vec, val: i32) -> i32 { [INFO] [stdout] 6 + pub fn remove_element(nums: &mut [i32], val: i32) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/string_compression/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return i as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return i as i32; [INFO] [stdout] 73 + i as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/string_compression/mod.rs:37:42 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn compress_по_дибильному(chars: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub fn compress_по_дибильному(chars: &mut Vec) -> i32 { [INFO] [stdout] 37 + pub fn compress_по_дибильному(chars: &mut [char]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transformed_array/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return result; [INFO] [stdout] 18 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/trionic_array_ii/mod.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if !(l < p) { [INFO] [stdout] | ^^^^^^^^ help: try: `(l >= p)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/trionic_array_ii/mod.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | if !(p < q) { [INFO] [stdout] | ^^^^^^^^ help: try: `(p >= q)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/trionic_array_ii/mod.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | if !(q < r) { [INFO] [stdout] | ^^^^^^^^ help: try: `(q >= r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/trionic_array_ii/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return 0; [INFO] [stdout] 58 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `nums` [INFO] [stdout] --> src/trionic_array_ii/mod.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | for k in l..=j { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 39 - for k in l..=j { [INFO] [stdout] 39 + for in nums.iter().take(j + 1).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/trionic_array_ii/mod.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | current_sum = current_sum + nums[k] as i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_sum += nums[k] as i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/twenty_four_game/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return Self::judge_point24_f64(input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return Self::judge_point24_f64(input); [INFO] [stdout] 9 + Self::judge_point24_f64(input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `cards` [INFO] [stdout] --> src/twenty_four_game/mod.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | for k in 0..cards.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 24 - for k in 0..cards.len() { [INFO] [stdout] 24 + for (k, ) in cards.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'e'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:35 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'i'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'o'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:8:57 [INFO] [stdout] | [INFO] [stdout] 8 | 'a' as u8, 'e' as u8, 'i' as u8, 'o' as u8, 'u' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'u'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'A'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'E'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'I'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:46 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'O'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/twenty_four_game/mod.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | / if b.abs() > 1e-6 { [INFO] [stdout] 46 | | if Self::judge_point24_f64([vec![a / b], next_cards_base.clone()].concat()) { [INFO] [stdout] 47 | | return true; [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if b.abs() > 1e-6 [INFO] [stdout] 46 ~ && Self::judge_point24_f64([vec![a / b], next_cards_base.clone()].concat()) { [INFO] [stdout] 47 | return true; [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/reverse_vowels_of_a_string/mod.rs:9:57 [INFO] [stdout] | [INFO] [stdout] 9 | 'A' as u8, 'E' as u8, 'I' as u8, 'O' as u8, 'U' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'U'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/twenty_four_game/mod.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | / if a.abs() > 1e-6 { [INFO] [stdout] 51 | | if Self::judge_point24_f64([vec![b / a], next_cards_base.clone()].concat()) { [INFO] [stdout] 52 | | return true; [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ if a.abs() > 1e-6 [INFO] [stdout] 51 ~ && Self::judge_point24_f64([vec![b / a], next_cards_base.clone()].concat()) { [INFO] [stdout] 52 | return true; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/string_compression/mod.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn compress(chars: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 - pub fn compress(chars: &mut Vec) -> i32 { [INFO] [stdout] 5 + pub fn compress(chars: &mut [char]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/string_compression/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return i as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return i as i32; [INFO] [stdout] 73 + i as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/string_compression/mod.rs:37:42 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn compress_по_дибильному(chars: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - pub fn compress_по_дибильному(chars: &mut Vec) -> i32 { [INFO] [stdout] 37 + pub fn compress_по_дибильному(chars: &mut [char]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transformed_array/mod.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return result; [INFO] [stdout] 18 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/trionic_array_ii/mod.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if !(l < p) { [INFO] [stdout] | ^^^^^^^^ help: try: `(l >= p)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/trionic_array_ii/mod.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | if !(p < q) { [INFO] [stdout] | ^^^^^^^^ help: try: `(p >= q)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/trionic_array_ii/mod.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | if !(q < r) { [INFO] [stdout] | ^^^^^^^^ help: try: `(q >= r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/trionic_array_ii/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return 0; [INFO] [stdout] 58 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `nums` [INFO] [stdout] --> src/trionic_array_ii/mod.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | for k in l..=j { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 39 - for k in l..=j { [INFO] [stdout] 39 + for in nums.iter().take(j + 1).skip(l) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/trionic_array_ii/mod.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | current_sum = current_sum + nums[k] as i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_sum += nums[k] as i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/twenty_four_game/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return Self::judge_point24_f64(input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return Self::judge_point24_f64(input); [INFO] [stdout] 9 + Self::judge_point24_f64(input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `cards` [INFO] [stdout] --> src/twenty_four_game/mod.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | for k in 0..cards.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 24 - for k in 0..cards.len() { [INFO] [stdout] 24 + for (k, ) in cards.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | || !(cards[1] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 72 | | || !Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2], cards[3]])) [INFO] [stdout] | |________________________________________________________________________________________________^ help: try: `cards[1] != 0 && Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2], cards[3]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | || !(cards[2] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 74 | | || !Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2], cards[3]])) [INFO] [stdout] | |________________________________________________________________________________________________^ help: try: `cards[2] != 0 && Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2], cards[3]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 75 | || !(cards[3] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 76 | | || !Self::judge_point24_dumb(vec![cards[0], cards[1], cards[2] / cards[3]])); [INFO] [stdout] | |________________________________________________________________________________________________^ help: try: `cards[3] != 0 && Self::judge_point24_dumb(vec![cards[0], cards[1], cards[2] / cards[3]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | || !(cards[1] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 86 | | || !Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2]])) [INFO] [stdout] | |______________________________________________________________________________________^ help: try: `cards[1] != 0 && Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | || !(cards[2] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | || !Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2]])); [INFO] [stdout] | |______________________________________________________________________________________^ help: try: `cards[2] != 0 && Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/twenty_four_game/mod.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | / if b.abs() > 1e-6 { [INFO] [stdout] 46 | | if Self::judge_point24_f64([vec![a / b], next_cards_base.clone()].concat()) { [INFO] [stdout] 47 | | return true; [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if b.abs() > 1e-6 [INFO] [stdout] 46 ~ && Self::judge_point24_f64([vec![a / b], next_cards_base.clone()].concat()) { [INFO] [stdout] 47 | return true; [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/twenty_four_game/mod.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | / if a.abs() > 1e-6 { [INFO] [stdout] 51 | | if Self::judge_point24_f64([vec![b / a], next_cards_base.clone()].concat()) { [INFO] [stdout] 52 | | return true; [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ if a.abs() > 1e-6 [INFO] [stdout] 51 ~ && Self::judge_point24_f64([vec![b / a], next_cards_base.clone()].concat()) { [INFO] [stdout] 52 | return true; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/valid_parentheses/mod.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if open_parens_stack.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!open_parens_stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | || !(cards[1] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 72 | | || !Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2], cards[3]])) [INFO] [stdout] | |________________________________________________________________________________________________^ help: try: `cards[1] != 0 && Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2], cards[3]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | || !(cards[2] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 74 | | || !Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2], cards[3]])) [INFO] [stdout] | |________________________________________________________________________________________________^ help: try: `cards[2] != 0 && Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2], cards[3]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 75 | || !(cards[3] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 76 | | || !Self::judge_point24_dumb(vec![cards[0], cards[1], cards[2] / cards[3]])); [INFO] [stdout] | |________________________________________________________________________________________________^ help: try: `cards[3] != 0 && Self::judge_point24_dumb(vec![cards[0], cards[1], cards[2] / cards[3]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | || !(cards[1] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 86 | | || !Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2]])) [INFO] [stdout] | |______________________________________________________________________________________^ help: try: `cards[1] != 0 && Self::judge_point24_dumb(vec![cards[0] / cards[1], cards[2]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/twenty_four_game/mod.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | || !(cards[2] == 0 [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | || !Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2]])); [INFO] [stdout] | |______________________________________________________________________________________^ help: try: `cards[2] != 0 && Self::judge_point24_dumb(vec![cards[0], cards[1] / cards[2]])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/twenty_four_game/mod.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | assert_eq!(Solution::judge_point24(vec![4, 1, 8, 7]), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 109 - assert_eq!(Solution::judge_point24(vec![4, 1, 8, 7]), true) [INFO] [stdout] 109 + assert!(Solution::judge_point24(vec![4, 1, 8, 7])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/twenty_four_game/mod.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | assert_eq!(Solution::judge_point24(vec![1, 2, 1, 2]), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 114 - assert_eq!(Solution::judge_point24(vec![1, 2, 1, 2]), false) [INFO] [stdout] 114 + assert!(!Solution::judge_point24(vec![1, 2, 1, 2])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/valid_parentheses/mod.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if open_parens_stack.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!open_parens_stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/valid_parentheses/mod.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(Solution::is_valid("()".to_string()), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 - assert_eq!(Solution::is_valid("()".to_string()), true); [INFO] [stdout] 63 + assert!(Solution::is_valid("()".to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/valid_parentheses/mod.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | assert_eq!(Solution::is_valid("()[]{}".to_string()), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 68 - assert_eq!(Solution::is_valid("()[]{}".to_string()), true); [INFO] [stdout] 68 + assert!(Solution::is_valid("()[]{}".to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/valid_parentheses/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(Solution::is_valid("(]".to_string()), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 73 - assert_eq!(Solution::is_valid("(]".to_string()), false); [INFO] [stdout] 73 + assert!(!Solution::is_valid("(]".to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/valid_parentheses/mod.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(Solution::is_valid("([)]".to_string()), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 78 - assert_eq!(Solution::is_valid("([)]".to_string()), false); [INFO] [stdout] 78 + assert!(!Solution::is_valid("([)]".to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/valid_parentheses/mod.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | assert_eq!(Solution::is_valid("{[]}".to_string()), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 83 - assert_eq!(Solution::is_valid("{[]}".to_string()), true); [INFO] [stdout] 83 + assert!(Solution::is_valid("{[]}".to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/valid_parentheses/mod.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | assert_eq!(Solution::is_valid("{".to_string()), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 88 - assert_eq!(Solution::is_valid("{".to_string()), false); [INFO] [stdout] 88 + assert!(!Solution::is_valid("{".to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `Command { std: "docker" "inspect" "faef6c7bccdbebf6eed66fb52024962436add7a0e075c66c38abc63883429614", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "faef6c7bccdbebf6eed66fb52024962436add7a0e075c66c38abc63883429614", kill_on_drop: false }` [INFO] [stdout] faef6c7bccdbebf6eed66fb52024962436add7a0e075c66c38abc63883429614