[INFO] cloning repository https://github.com/Hopson97/Asciimon [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hopson97/Asciimon" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHopson97%2FAsciimon", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHopson97%2FAsciimon'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8cf12801839f163eb21e755228e874cec4167d47 [INFO] linting Hopson97/Asciimon against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHopson97%2FAsciimon" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Hopson97/Asciimon [INFO] finished tweaking git repo https://github.com/Hopson97/Asciimon [INFO] tweaked toml for git repo https://github.com/Hopson97/Asciimon written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Hopson97/Asciimon on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Hopson97/Asciimon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef2c6a9d8f085188a841297740d12bb1f1e9faf023725a1bfaad48ed82caddcf [INFO] running `Command { std: "docker" "start" "-a" "ef2c6a9d8f085188a841297740d12bb1f1e9faf023725a1bfaad48ed82caddcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef2c6a9d8f085188a841297740d12bb1f1e9faf023725a1bfaad48ed82caddcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef2c6a9d8f085188a841297740d12bb1f1e9faf023725a1bfaad48ed82caddcf", kill_on_drop: false }` [INFO] [stdout] ef2c6a9d8f085188a841297740d12bb1f1e9faf023725a1bfaad48ed82caddcf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4a8b99cce24cc86af368b36017d6dfe54cffe1c8398a0b185f73d4befcfa0c2 [INFO] running `Command { std: "docker" "start" "-a" "d4a8b99cce24cc86af368b36017d6dfe54cffe1c8398a0b185f73d4befcfa0c2", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking asciimon v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::sprite::Sprite` [INFO] [stdout] --> src/graphics/mod.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use self::sprite::Sprite; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/game/world/chunk.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/world/chunk.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | tile_data: tile_data, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ChunkLoadData` [INFO] [stdout] --> src/game/world/mod.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | use self::chunk_loader::{ChunkLoadData, load_chunk, extract_pos_from_path}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/game/mod.rs:17:22 [INFO] [stdout] | [INFO] [stdout] 17 | use std::io::{stdin, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `console` [INFO] [stdout] --> src/game/game_state/state_explore.rs:171:49 [INFO] [stdout] | [INFO] [stdout] 171 | fn draw(&mut self, renderer: &mut Renderer, console: &mut Console) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_console` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/game/mod.rs:85:51 [INFO] [stdout] | [INFO] [stdout] 85 | Some(UpdateResult::TransitionPush(state)) => {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/graphics/renderer.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Renderer { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 20 | size: Vector2D, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `size` and `draw_sprite` are never used [INFO] [stdout] --> src/graphics/renderer.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl Renderer { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn size(&self) -> Vector2D { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | pub fn draw_sprite(&self, section: &str, sprite: &Sprite) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Sprite` is never constructed [INFO] [stdout] --> src/graphics/sprite.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Sprite { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `with_capacity`, `square`, and `render_data` are never used [INFO] [stdout] --> src/graphics/sprite.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Sprite { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 9 | pub fn new() -> Sprite { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn with_capacity(capacity: usize) -> Sprite { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn square(width: i32, height: i32, fill: char) -> Sprite { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn render_data(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `UI_BACKGROUND` is never used [INFO] [stdout] --> src/game/mod.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | define_colour!(UI_BACKGROUND, 50, 50, 50); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `define_colour` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ZERO` is never used [INFO] [stdout] --> src/util/vector.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub const ZERO: Vector2D = Vector2D { x: 0, y: 0 }; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `cast` is never used [INFO] [stdout] --> src/util/vector.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Vector2D { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn cast>(self) -> Vector2D { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/graphics/renderer.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - None => { [INFO] [stdout] 71 - return; [INFO] [stdout] 70 + None => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc quote line without `>` marker [INFO] [stdout] --> src/game/game_state/state_explore.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | /// Moves player 3 left, then 2 down, then 2 right. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this not intended to be a quote at all, escape it with `\>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: add markers to start of line [INFO] [stdout] | [INFO] [stdout] 56 | /// > Moves player 3 left, then 2 down, then 2 right. [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc quote line without `>` marker [INFO] [stdout] --> src/game/game_state/state_explore.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | /// Collision will stop player moving in a direction, but will continue to cycle the buffer [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this not intended to be a quote at all, escape it with `\>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: add markers to start of line [INFO] [stdout] | [INFO] [stdout] 57 | /// > Collision will stop player moving in a direction, but will continue to cycle the buffer [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/game/game_state/state_explore.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / match n.parse::() { [INFO] [stdout] 136 | | Err(_) => 0, [INFO] [stdout] 137 | | Ok(step) => step, [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____________^ help: ascribe the type i32 and replace your expression with: `n.parse::().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game/game_state/state_explore.rs:172:27 [INFO] [stdout] | [INFO] [stdout] 172 | self.world.render(&renderer, self.player.position()); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `renderer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::sprite::Sprite` [INFO] [stdout] --> src/graphics/mod.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use self::sprite::Sprite; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game/console.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | &line, [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/game/world/chunk.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/world/chunk.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | tile_data: tile_data, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ChunkLoadData` [INFO] [stdout] --> src/game/world/mod.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | use self::chunk_loader::{ChunkLoadData, load_chunk, extract_pos_from_path}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game/console.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | line.draw(index + y, &renderer); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `renderer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/game/world/chunk.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | y as usize, [INFO] [stdout] | ^^^^^^^^^^ help: try: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/world/chunk_loader.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | if !(data.portal_ids.len() == data.portal_positions.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(data.portal_ids.len() != data.portal_positions.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/game/world/chunk_loader.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / match ch { [INFO] [stdout] 134 | | '1' => { [INFO] [stdout] 135 | | let y = data.tile_data.len() as i32; [INFO] [stdout] 136 | | data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stdout] 137 | | }, [INFO] [stdout] 138 | | _ => {} [INFO] [stdout] 139 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 133 ~ if ch == &'1' { [INFO] [stdout] 134 + let y = data.tile_data.len() as i32; [INFO] [stdout] 135 + data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stdout] 136 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/mod.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | return Some(UpdateResult::Exit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return Some(UpdateResult::Exit); [INFO] [stdout] 128 + Some(UpdateResult::Exit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/mod.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | return Some(UpdateResult::Exit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return Some(UpdateResult::Exit); [INFO] [stdout] 131 + Some(UpdateResult::Exit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/graphics/renderer.rs:145:28 [INFO] [stdout] | [INFO] [stdout] 145 | None => panic!(format!( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 146 | | "Tried to render to section which doesn't exist: {}", [INFO] [stdout] 147 | | section [INFO] [stdout] 148 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 145 ~ None => panic!( [INFO] [stdout] 146 | "Tried to render to section which doesn't exist: {}", [INFO] [stdout] 147 | section [INFO] [stdout] 148 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/game/mod.rs:17:22 [INFO] [stdout] | [INFO] [stdout] 17 | use std::io::{stdin, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `console` [INFO] [stdout] --> src/game/game_state/state_explore.rs:171:49 [INFO] [stdout] | [INFO] [stdout] 171 | fn draw(&mut self, renderer: &mut Renderer, console: &mut Console) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_console` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/game/mod.rs:85:51 [INFO] [stdout] | [INFO] [stdout] 85 | Some(UpdateResult::TransitionPush(state)) => {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/graphics/renderer.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Renderer { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 20 | size: Vector2D, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `size` and `draw_sprite` are never used [INFO] [stdout] --> src/graphics/renderer.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl Renderer { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn size(&self) -> Vector2D { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | pub fn draw_sprite(&self, section: &str, sprite: &Sprite) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Sprite` is never constructed [INFO] [stdout] --> src/graphics/sprite.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Sprite { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `with_capacity`, `square`, and `render_data` are never used [INFO] [stdout] --> src/graphics/sprite.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Sprite { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 9 | pub fn new() -> Sprite { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn with_capacity(capacity: usize) -> Sprite { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn square(width: i32, height: i32, fill: char) -> Sprite { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn render_data(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `UI_BACKGROUND` is never used [INFO] [stdout] --> src/game/mod.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 24 | define_colour!(UI_BACKGROUND, 50, 50, 50); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `define_colour` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ZERO` is never used [INFO] [stdout] --> src/util/vector.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub const ZERO: Vector2D = Vector2D { x: 0, y: 0 }; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `cast` is never used [INFO] [stdout] --> src/util/vector.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Vector2D { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn cast>(self) -> Vector2D { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/graphics/renderer.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - None => { [INFO] [stdout] 71 - return; [INFO] [stdout] 70 + None => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc quote line without `>` marker [INFO] [stdout] --> src/game/game_state/state_explore.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | /// Moves player 3 left, then 2 down, then 2 right. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this not intended to be a quote at all, escape it with `\>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: add markers to start of line [INFO] [stdout] | [INFO] [stdout] 56 | /// > Moves player 3 left, then 2 down, then 2 right. [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc quote line without `>` marker [INFO] [stdout] --> src/game/game_state/state_explore.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | /// Collision will stop player moving in a direction, but will continue to cycle the buffer [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this not intended to be a quote at all, escape it with `\>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: add markers to start of line [INFO] [stdout] | [INFO] [stdout] 57 | /// > Collision will stop player moving in a direction, but will continue to cycle the buffer [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/game/game_state/state_explore.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / match n.parse::() { [INFO] [stdout] 136 | | Err(_) => 0, [INFO] [stdout] 137 | | Ok(step) => step, [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____________^ help: ascribe the type i32 and replace your expression with: `n.parse::().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game/game_state/state_explore.rs:172:27 [INFO] [stdout] | [INFO] [stdout] 172 | self.world.render(&renderer, self.player.position()); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `renderer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game/console.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | &line, [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game/console.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | line.draw(index + y, &renderer); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `renderer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/game/world/chunk.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | y as usize, [INFO] [stdout] | ^^^^^^^^^^ help: try: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/world/chunk_loader.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | if !(data.portal_ids.len() == data.portal_positions.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(data.portal_ids.len() != data.portal_positions.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/game/world/chunk_loader.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / match ch { [INFO] [stdout] 134 | | '1' => { [INFO] [stdout] 135 | | let y = data.tile_data.len() as i32; [INFO] [stdout] 136 | | data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stdout] 137 | | }, [INFO] [stdout] 138 | | _ => {} [INFO] [stdout] 139 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 133 ~ if ch == &'1' { [INFO] [stdout] 134 + let y = data.tile_data.len() as i32; [INFO] [stdout] 135 + data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stdout] 136 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/mod.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | return Some(UpdateResult::Exit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return Some(UpdateResult::Exit); [INFO] [stdout] 128 + Some(UpdateResult::Exit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/mod.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | return Some(UpdateResult::Exit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return Some(UpdateResult::Exit); [INFO] [stdout] 131 + Some(UpdateResult::Exit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/graphics/renderer.rs:145:28 [INFO] [stdout] | [INFO] [stdout] 145 | None => panic!(format!( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 146 | | "Tried to render to section which doesn't exist: {}", [INFO] [stdout] 147 | | section [INFO] [stdout] 148 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 145 ~ None => panic!( [INFO] [stdout] 146 | "Tried to render to section which doesn't exist: {}", [INFO] [stdout] 147 | section [INFO] [stdout] 148 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "d4a8b99cce24cc86af368b36017d6dfe54cffe1c8398a0b185f73d4befcfa0c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4a8b99cce24cc86af368b36017d6dfe54cffe1c8398a0b185f73d4befcfa0c2", kill_on_drop: false }` [INFO] [stdout] d4a8b99cce24cc86af368b36017d6dfe54cffe1c8398a0b185f73d4befcfa0c2