[INFO] cloning repository https://github.com/Hoblovski/rs-raft-interactive [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hoblovski/rs-raft-interactive" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHoblovski%2Frs-raft-interactive", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHoblovski%2Frs-raft-interactive'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2067103bbebd6185613b74a6efd71ab5c3d9db70 [INFO] linting Hoblovski/rs-raft-interactive against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHoblovski%2Frs-raft-interactive" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Hoblovski/rs-raft-interactive [INFO] finished tweaking git repo https://github.com/Hoblovski/rs-raft-interactive [INFO] tweaked toml for git repo https://github.com/Hoblovski/rs-raft-interactive written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Hoblovski/rs-raft-interactive on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Hoblovski/rs-raft-interactive already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn v2.0.75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 831c0576803ff81e6db29c3a3c61350541da451257021beff8a662b6915f7c2d [INFO] running `Command { std: "docker" "start" "-a" "831c0576803ff81e6db29c3a3c61350541da451257021beff8a662b6915f7c2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "831c0576803ff81e6db29c3a3c61350541da451257021beff8a662b6915f7c2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "831c0576803ff81e6db29c3a3c61350541da451257021beff8a662b6915f7c2d", kill_on_drop: false }` [INFO] [stdout] 831c0576803ff81e6db29c3a3c61350541da451257021beff8a662b6915f7c2d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc138f55d68d6c6a44f4d28ea42307d008c635cd0093840da88fb338ee99307b [INFO] running `Command { std: "docker" "start" "-a" "dc138f55d68d6c6a44f4d28ea42307d008c635cd0093840da88fb338ee99307b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rstla v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / let Some(idx) = msgs.iter().position(f) else { [INFO] [stdout] 93 | | return None; [INFO] [stdout] 94 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let idx = msgs.iter().position(f)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / return (0..network_size) [INFO] [stdout] 198 | | .map(|id| Self::new_follower(id as i32, network.clone(), network_size)) [INFO] [stdout] 199 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 ~ (0..network_size) [INFO] [stdout] 198 + .map(|id| Self::new_follower(id as i32, network.clone(), network_size)) [INFO] [stdout] 199 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | return self.state == NodeState::Leader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return self.state == NodeState::Leader; [INFO] [stdout] 289 + self.state == NodeState::Leader [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | return self.state == NodeState::Candidate && self.id != dest; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 307 - return self.state == NodeState::Candidate && self.id != dest; [INFO] [stdout] 307 + self.state == NodeState::Candidate && self.id != dest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:320:17 [INFO] [stdout] | [INFO] [stdout] 320 | to: dest as i32, [INFO] [stdout] | ^^^^^^^^^^^ help: try: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return self.state == NodeState::Leader && self.id != dest; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return self.state == NodeState::Leader && self.id != dest; [INFO] [stdout] 329 + self.state == NodeState::Leader && self.id != dest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:344:17 [INFO] [stdout] | [INFO] [stdout] 344 | to: dest as i32, [INFO] [stdout] | ^^^^^^^^^^^ help: try: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | return matches!(data, MessageData::RequestVoteRequest { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 - return matches!(data, MessageData::RequestVoteRequest { .. }); [INFO] [stdout] 357 + matches!(data, MessageData::RequestVoteRequest { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:383:26 [INFO] [stdout] | [INFO] [stdout] 383 | let votefor_ok = !self.voted_for.is_some_and(|x| x != from); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.voted_for.is_none_or(|x| x == from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return matches!(data, MessageData::RequestVoteResponse { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return matches!(data, MessageData::RequestVoteResponse { .. }); [INFO] [stdout] 399 + matches!(data, MessageData::RequestVoteResponse { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | / if granted { [INFO] [stdout] 418 | | if !self.votes_received.contains(&from) { [INFO] [stdout] 419 | | self.votes_received.push(from); [INFO] [stdout] 420 | | } [INFO] [stdout] 421 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 417 ~ if granted [INFO] [stdout] 418 ~ && !self.votes_received.contains(&from) { [INFO] [stdout] 419 | self.votes_received.push(from); [INFO] [stdout] 420 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | return matches!(data, MessageData::AppendEntriesRequest { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - return matches!(data, MessageData::AppendEntriesRequest { .. }); [INFO] [stdout] 435 + matches!(data, MessageData::AppendEntriesRequest { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return matches!(data, MessageData::AppendEntriesResponse { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return matches!(data, MessageData::AppendEntriesResponse { .. }); [INFO] [stdout] 485 + matches!(data, MessageData::AppendEntriesResponse { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/main.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / let Some(idx) = msgs.iter().position(f) else { [INFO] [stdout] 93 | | return None; [INFO] [stdout] 94 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let idx = msgs.iter().position(f)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / return (0..network_size) [INFO] [stdout] 198 | | .map(|id| Self::new_follower(id as i32, network.clone(), network_size)) [INFO] [stdout] 199 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 ~ (0..network_size) [INFO] [stdout] 198 + .map(|id| Self::new_follower(id as i32, network.clone(), network_size)) [INFO] [stdout] 199 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | return self.state == NodeState::Leader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return self.state == NodeState::Leader; [INFO] [stdout] 289 + self.state == NodeState::Leader [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | return self.state == NodeState::Candidate && self.id != dest; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 307 - return self.state == NodeState::Candidate && self.id != dest; [INFO] [stdout] 307 + self.state == NodeState::Candidate && self.id != dest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:320:17 [INFO] [stdout] | [INFO] [stdout] 320 | to: dest as i32, [INFO] [stdout] | ^^^^^^^^^^^ help: try: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return self.state == NodeState::Leader && self.id != dest; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return self.state == NodeState::Leader && self.id != dest; [INFO] [stdout] 329 + self.state == NodeState::Leader && self.id != dest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:344:17 [INFO] [stdout] | [INFO] [stdout] 344 | to: dest as i32, [INFO] [stdout] | ^^^^^^^^^^^ help: try: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | return matches!(data, MessageData::RequestVoteRequest { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 - return matches!(data, MessageData::RequestVoteRequest { .. }); [INFO] [stdout] 357 + matches!(data, MessageData::RequestVoteRequest { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:383:26 [INFO] [stdout] | [INFO] [stdout] 383 | let votefor_ok = !self.voted_for.is_some_and(|x| x != from); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.voted_for.is_none_or(|x| x == from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return matches!(data, MessageData::RequestVoteResponse { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return matches!(data, MessageData::RequestVoteResponse { .. }); [INFO] [stdout] 399 + matches!(data, MessageData::RequestVoteResponse { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | / if granted { [INFO] [stdout] 418 | | if !self.votes_received.contains(&from) { [INFO] [stdout] 419 | | self.votes_received.push(from); [INFO] [stdout] 420 | | } [INFO] [stdout] 421 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 417 ~ if granted [INFO] [stdout] 418 ~ && !self.votes_received.contains(&from) { [INFO] [stdout] 419 | self.votes_received.push(from); [INFO] [stdout] 420 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | return matches!(data, MessageData::AppendEntriesRequest { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - return matches!(data, MessageData::AppendEntriesRequest { .. }); [INFO] [stdout] 435 + matches!(data, MessageData::AppendEntriesRequest { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return matches!(data, MessageData::AppendEntriesResponse { .. }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return matches!(data, MessageData::AppendEntriesResponse { .. }); [INFO] [stdout] 485 + matches!(data, MessageData::AppendEntriesResponse { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.00s [INFO] running `Command { std: "docker" "inspect" "dc138f55d68d6c6a44f4d28ea42307d008c635cd0093840da88fb338ee99307b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc138f55d68d6c6a44f4d28ea42307d008c635cd0093840da88fb338ee99307b", kill_on_drop: false }` [INFO] [stdout] dc138f55d68d6c6a44f4d28ea42307d008c635cd0093840da88fb338ee99307b