[INFO] cloning repository https://github.com/Hezaerd/win-touch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hezaerd/win-touch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHezaerd%2Fwin-touch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHezaerd%2Fwin-touch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 76adcae22a7169322db5bd308f2fd2573ce59852 [INFO] linting Hezaerd/win-touch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHezaerd%2Fwin-touch" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Hezaerd/win-touch [INFO] finished tweaking git repo https://github.com/Hezaerd/win-touch [INFO] tweaked toml for git repo https://github.com/Hezaerd/win-touch written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Hezaerd/win-touch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Hezaerd/win-touch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95f0360fc788a2815d75969f13be03bafc07770c65a277a5eb7a743e4528ddf2 [INFO] running `Command { std: "docker" "start" "-a" "95f0360fc788a2815d75969f13be03bafc07770c65a277a5eb7a743e4528ddf2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95f0360fc788a2815d75969f13be03bafc07770c65a277a5eb7a743e4528ddf2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95f0360fc788a2815d75969f13be03bafc07770c65a277a5eb7a743e4528ddf2", kill_on_drop: false }` [INFO] [stdout] 95f0360fc788a2815d75969f13be03bafc07770c65a277a5eb7a743e4528ddf2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32da571d75e9eef2690ee3ec7fb1a67be0a95d93b72c6c00ac88e12ce01b4c24 [INFO] running `Command { std: "docker" "start" "-a" "32da571d75e9eef2690ee3ec7fb1a67be0a95d93b72c6c00ac88e12ce01b4c24", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking wintouch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:128:24 [INFO] [stdout] | [INFO] [stdout] 128 | let new_atime = if access_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 128 - let new_atime = if access_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 128 + let new_atime = if !(!access_time_flag && modification_time_flag) { [INFO] [stdout] | [INFO] [stdout] 128 - let new_atime = if access_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 128 + let new_atime = if access_time_flag || !modification_time_flag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:134:24 [INFO] [stdout] | [INFO] [stdout] 134 | let new_mtime = if modification_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 - let new_mtime = if modification_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 134 + let new_mtime = if !(!modification_time_flag && access_time_flag) { [INFO] [stdout] | [INFO] [stdout] 134 - let new_mtime = if modification_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 134 + let new_mtime = if modification_time_flag || !access_time_flag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:121:14 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|m| FileTime::from_last_access_time(m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `FileTime::from_last_access_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 125 | .map(|m| FileTime::from_last_modification_time(m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `FileTime::from_last_modification_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:174:76 [INFO] [stdout] | [INFO] [stdout] 174 | let formatted_ts_str = if main_part.len() == 10 && seconds_str == "00" { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 175 | | format!("{}.00", main_part) [INFO] [stdout] 176 | | } else if main_part.len() == 12 && seconds_str == "00" { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:176:60 [INFO] [stdout] | [INFO] [stdout] 176 | } else if main_part.len() == 12 && seconds_str == "00" { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 177 | | format!("{}.00", main_part) [INFO] [stdout] 178 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:128:24 [INFO] [stdout] | [INFO] [stdout] 128 | let new_atime = if access_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 128 - let new_atime = if access_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 128 + let new_atime = if !(!access_time_flag && modification_time_flag) { [INFO] [stdout] | [INFO] [stdout] 128 - let new_atime = if access_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 128 + let new_atime = if access_time_flag || !modification_time_flag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:134:24 [INFO] [stdout] | [INFO] [stdout] 134 | let new_mtime = if modification_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 134 - let new_mtime = if modification_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 134 + let new_mtime = if !(!modification_time_flag && access_time_flag) { [INFO] [stdout] | [INFO] [stdout] 134 - let new_mtime = if modification_time_flag || (!access_time_flag && !modification_time_flag) { [INFO] [stdout] 134 + let new_mtime = if modification_time_flag || !access_time_flag { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:121:14 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|m| FileTime::from_last_access_time(m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `FileTime::from_last_access_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 125 | .map(|m| FileTime::from_last_modification_time(m)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `FileTime::from_last_modification_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:174:76 [INFO] [stdout] | [INFO] [stdout] 174 | let formatted_ts_str = if main_part.len() == 10 && seconds_str == "00" { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 175 | | format!("{}.00", main_part) [INFO] [stdout] 176 | | } else if main_part.len() == 12 && seconds_str == "00" { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:176:60 [INFO] [stdout] | [INFO] [stdout] 176 | } else if main_part.len() == 12 && seconds_str == "00" { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 177 | | format!("{}.00", main_part) [INFO] [stdout] 178 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.67s [INFO] running `Command { std: "docker" "inspect" "32da571d75e9eef2690ee3ec7fb1a67be0a95d93b72c6c00ac88e12ce01b4c24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32da571d75e9eef2690ee3ec7fb1a67be0a95d93b72c6c00ac88e12ce01b4c24", kill_on_drop: false }` [INFO] [stdout] 32da571d75e9eef2690ee3ec7fb1a67be0a95d93b72c6c00ac88e12ce01b4c24