[INFO] cloning repository https://github.com/HenselForCongress/financial-discloser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HenselForCongress/financial-discloser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenselForCongress%2Ffinancial-discloser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenselForCongress%2Ffinancial-discloser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e74dfaba04123cfb54540f8125476b063d48a26d [INFO] linting HenselForCongress/financial-discloser against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenselForCongress%2Ffinancial-discloser" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HenselForCongress/financial-discloser [INFO] finished tweaking git repo https://github.com/HenselForCongress/financial-discloser [INFO] tweaked toml for git repo https://github.com/HenselForCongress/financial-discloser written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HenselForCongress/financial-discloser on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HenselForCongress/financial-discloser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sentry-contexts v0.33.0 [INFO] [stderr] Downloaded zip v0.5.13 [INFO] [stderr] Downloaded sentry-debug-images v0.33.0 [INFO] [stderr] Downloaded wasm-streams v0.4.0 [INFO] [stderr] Downloaded sentry-types v0.33.0 [INFO] [stderr] Downloaded ureq v2.9.7 [INFO] [stderr] Downloaded backtrace v0.3.72 [INFO] [stderr] Downloaded sentry v0.33.0 [INFO] [stderr] Downloaded findshlibs v0.10.2 [INFO] [stderr] Downloaded hyper v1.3.1 [INFO] [stderr] Downloaded hyper v0.14.29 [INFO] [stderr] Downloaded reqwest v0.12.4 [INFO] [stderr] Downloaded sentry-panic v0.33.0 [INFO] [stderr] Downloaded hyper-util v0.1.5 [INFO] [stderr] Downloaded object v0.35.0 [INFO] [stderr] Downloaded sentry-core v0.33.0 [INFO] [stderr] Downloaded sentry-backtrace v0.33.0 [INFO] [stderr] Downloaded sentry-tracing v0.33.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5d098018c7af91ef296096346c1c4f21753a943135523e6192659a7a9089b00 [INFO] running `Command { std: "docker" "start" "-a" "d5d098018c7af91ef296096346c1c4f21753a943135523e6192659a7a9089b00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5d098018c7af91ef296096346c1c4f21753a943135523e6192659a7a9089b00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5d098018c7af91ef296096346c1c4f21753a943135523e6192659a7a9089b00", kill_on_drop: false }` [INFO] [stdout] d5d098018c7af91ef296096346c1c4f21753a943135523e6192659a7a9089b00 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63af59b3ccb4c3b5f43264dbfb6bea2d768c28bbbbcd78e48d615760cd093062 [INFO] running `Command { std: "docker" "start" "-a" "63af59b3ccb4c3b5f43264dbfb6bea2d768c28bbbbcd78e48d615760cd093062", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking object v0.35.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking hostname v0.4.0 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling sentry-contexts v0.33.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling backtrace v0.3.72 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling findshlibs v0.10.2 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking async-compression v0.4.11 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking sentry-types v0.33.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking sentry-core v0.33.0 [INFO] [stderr] Checking sentry-backtrace v0.33.0 [INFO] [stderr] Checking sentry-debug-images v0.33.0 [INFO] [stderr] Checking sentry-panic v0.33.0 [INFO] [stderr] Checking sentry v0.33.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking financial-discloser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `reqwest::Client` [INFO] [stdout] --> src/build_index.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use reqwest::Client; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/build_index.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | use anyhow::{Result, Context}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `reqwest::Client` [INFO] [stdout] --> src/build_index.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use reqwest::Client; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/build_index.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | use anyhow::{Result, Context}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/pdf_download.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{info, error, warn, debug}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/pdf_download.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use anyhow::{Result, Context}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/pdf_download.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/pdf_download.rs:6:30 [INFO] [stdout] | [INFO] [stdout] 6 | use log::{info, error, warn, debug}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/pdf_download.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use anyhow::{Result, Context}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/pdf_download.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `send_test_event` is never used [INFO] [stdout] --> src/main.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn send_test_event() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pdf_download.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if !fs::metadata(&file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdf_download.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | return Err("404".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return Err("404".to_string()); [INFO] [stdout] 210 + Err("404".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdf_download.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | return Err(format!("HTTP error: {}", status)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Err(format!("HTTP error: {}", status)); [INFO] [stdout] 212 + Err(format!("HTTP error: {}", status)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `send_test_event` is never used [INFO] [stdout] --> src/main.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn send_test_event() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pdf_download.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if !fs::metadata(&file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdf_download.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | return Err("404".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return Err("404".to_string()); [INFO] [stdout] 210 + Err("404".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pdf_download.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | return Err(format!("HTTP error: {}", status)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Err(format!("HTTP error: {}", status)); [INFO] [stdout] 212 + Err(format!("HTTP error: {}", status)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.59s [INFO] running `Command { std: "docker" "inspect" "63af59b3ccb4c3b5f43264dbfb6bea2d768c28bbbbcd78e48d615760cd093062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63af59b3ccb4c3b5f43264dbfb6bea2d768c28bbbbcd78e48d615760cd093062", kill_on_drop: false }` [INFO] [stdout] 63af59b3ccb4c3b5f43264dbfb6bea2d768c28bbbbcd78e48d615760cd093062