[INFO] cloning repository https://github.com/Henkhogan/magicjson-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Henkhogan/magicjson-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenkhogan%2Fmagicjson-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenkhogan%2Fmagicjson-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a00d8d03dac4a6741735c15bd9e80f227c7255cf [INFO] linting Henkhogan/magicjson-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHenkhogan%2Fmagicjson-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Henkhogan/magicjson-rust [INFO] finished tweaking git repo https://github.com/Henkhogan/magicjson-rust [INFO] tweaked toml for git repo https://github.com/Henkhogan/magicjson-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Henkhogan/magicjson-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Henkhogan/magicjson-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded is-terminal v0.4.10 [INFO] [stderr] Downloaded quote v1.0.34 [INFO] [stderr] Downloaded proc-macro2 v1.0.73 [INFO] [stderr] Downloaded syn v2.0.45 [INFO] [stderr] Downloaded chrono-tz v0.8.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c86603681a72fe91e4b2313b857d06fa21f29fd67793830e71d98e0c4abe290 [INFO] running `Command { std: "docker" "start" "-a" "3c86603681a72fe91e4b2313b857d06fa21f29fd67793830e71d98e0c4abe290", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c86603681a72fe91e4b2313b857d06fa21f29fd67793830e71d98e0c4abe290", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c86603681a72fe91e4b2313b857d06fa21f29fd67793830e71d98e0c4abe290", kill_on_drop: false }` [INFO] [stdout] 3c86603681a72fe91e4b2313b857d06fa21f29fd67793830e71d98e0c4abe290 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5005c17f492fbfbda741cd92b91bfbbeeff1bc8860ae01ee9d241b8151a7938e [INFO] running `Command { std: "docker" "start" "-a" "5005c17f492fbfbda741cd92b91bfbbeeff1bc8860ae01ee9d241b8151a7938e", kill_on_drop: false }` [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.8.5 [INFO] [stderr] Checking magicjson v0.0.1-alpha.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/deserialize.rs:260:79 [INFO] [stdout] | [INFO] [stdout] 260 | return T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/serialize.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::PrimInt` [INFO] [stdout] --> src/serialize.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use num_traits::PrimInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | bufreader: bufreader, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bufreader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | / /// Run tests with `cargo test -- --nocapture` [INFO] [stdout] 48 | | [INFO] [stdout] | |_^ [INFO] [stdout] 49 | #[cfg(test)]#[cfg(test)] [INFO] [stdout] 50 | mod tests { [INFO] [stdout] | --------- the comment documents this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `any::Any` and `fmt::Display` [INFO] [stdout] --> src/lib.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | use std::{any::Any, collections::{BTreeMap, HashMap}, fmt::Display}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/deserialize.rs:260:79 [INFO] [stdout] | [INFO] [stdout] 260 | return T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/serialize.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::PrimInt` [INFO] [stdout] --> src/serialize.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use num_traits::PrimInt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | bufreader: bufreader, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bufreader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_json_string` is never used [INFO] [stdout] --> src/serialize.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 51 | pub trait ToJsonString { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 52 | fn to_json(&self) -> JsonSerializable; [INFO] [stdout] 53 | fn to_json_string(self) -> String; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrapper.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return key [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return key [INFO] [stdout] 113 + key [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/wrapper.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | quote_char = c.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrapper.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | return Some(c); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Some(c); [INFO] [stdout] 126 + Some(c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrapper.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return None; [INFO] [stdout] 134 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return T::from(JsonItem::Dict(values)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return T::from(JsonItem::Dict(values)); [INFO] [stdout] 75 + T::from(JsonItem::Dict(values)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | return T::from(JsonItem::List(values)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return T::from(JsonItem::List(values)); [INFO] [stdout] 113 + T::from(JsonItem::List(values)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | return handle_dict(json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return handle_dict(json_wrapper); [INFO] [stdout] 120 + handle_dict(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | return handle_list(json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return handle_list(json_wrapper); [INFO] [stdout] 124 + handle_list(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return value_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return value_str; [INFO] [stdout] 165 + value_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | return JsonItem::Int(value_str.parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return JsonItem::Int(value_str.parse().unwrap()); [INFO] [stdout] 216 + JsonItem::Int(value_str.parse().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `quote_and_escape_string` is never used [INFO] [stdout] --> src/serialize.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn quote_and_escape_string(s: String) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `JsonSerializable` is never used [INFO] [stdout] --> src/serialize.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 27 | pub enum JsonSerializable { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToJsonString` is never used [INFO] [stdout] --> src/serialize.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 51 | pub trait ToJsonString { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToJsonFromInt` is never used [INFO] [stdout] --> src/serialize.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 57 | pub trait ToJsonFromInt { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return T::from(JsonItem::Datetime(DateTime::parse_from_rfc3339(&value).unwrap().naive_utc())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return T::from(JsonItem::Datetime(DateTime::parse_from_rfc3339(&value).unwrap().naive_utc())); [INFO] [stdout] 254 + T::from(JsonItem::Datetime(DateTime::parse_from_rfc3339(&value).unwrap().naive_utc())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | return T::from(JsonItem::Timestamp(value.parse().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - return T::from(JsonItem::Timestamp(value.parse().unwrap())); [INFO] [stdout] 257 + T::from(JsonItem::Timestamp(value.parse().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | return T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})); [INFO] [stdout] 260 + T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrapper.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return key [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return key [INFO] [stdout] 113 + key [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/deserialize.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 273 | if !(json_wrapper.current == *c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(json_wrapper.current != *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/wrapper.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | quote_char = c.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/deserialize.rs:292:16 [INFO] [stdout] | [INFO] [stdout] 292 | if !(json_wrapper.current == *c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(json_wrapper.current != *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/deserialize.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if !(json_wrapper.current == *c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(json_wrapper.current != *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrapper.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | return Some(c); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Some(c); [INFO] [stdout] 126 + Some(c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wrapper.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return None; [INFO] [stdout] 134 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | return T::from(JsonItem::Str(handle_string(json_wrapper, c))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 316 - return T::from(JsonItem::Str(handle_string(json_wrapper, c))); [INFO] [stdout] 316 + T::from(JsonItem::Str(handle_string(json_wrapper, c))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | return T::from(handle_number(json_wrapper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 320 - return T::from(handle_number(json_wrapper)); [INFO] [stdout] 320 + T::from(handle_number(json_wrapper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 325 | return T::from(JsonItem::Null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return T::from(JsonItem::Null()); [INFO] [stdout] 325 + T::from(JsonItem::Null()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:330:13 [INFO] [stdout] | [INFO] [stdout] 330 | return T::from(JsonItem::Bool(false)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - return T::from(JsonItem::Bool(false)); [INFO] [stdout] 330 + T::from(JsonItem::Bool(false)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:335:13 [INFO] [stdout] | [INFO] [stdout] 335 | return T::from(JsonItem::Bool(true)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - return T::from(JsonItem::Bool(true)); [INFO] [stdout] 335 + T::from(JsonItem::Bool(true)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | return handle_custom_type(json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return handle_custom_type(json_wrapper); [INFO] [stdout] 339 + handle_custom_type(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | return handle_dict_or_list(json_wrapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 342 - return handle_dict_or_list(json_wrapper) [INFO] [stdout] 342 + handle_dict_or_list(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return escaped_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return escaped_string [INFO] [stdout] 24 + escaped_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return T::from(JsonItem::Dict(values)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return T::from(JsonItem::Dict(values)); [INFO] [stdout] 75 + T::from(JsonItem::Dict(values)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | return T::from(JsonItem::List(values)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return T::from(JsonItem::List(values)); [INFO] [stdout] 113 + T::from(JsonItem::List(values)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | return handle_dict(json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return handle_dict(json_wrapper); [INFO] [stdout] 120 + handle_dict(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | return handle_list(json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return handle_list(json_wrapper); [INFO] [stdout] 124 + handle_list(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/serialize.rs:418:1 [INFO] [stdout] | [INFO] [stdout] 418 | / impl ToString for JsonSerializable { [INFO] [stdout] 419 | | fn to_string(&self) -> String { [INFO] [stdout] 420 | | match self { [INFO] [stdout] 421 | | JsonSerializable::Null => "null".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 488 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return value_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return value_str; [INFO] [stdout] 165 + value_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:449:17 [INFO] [stdout] | [INFO] [stdout] 449 | return serialized_array [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return serialized_array [INFO] [stdout] 449 + serialized_array [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | return serialized_hashmap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 462 - return serialized_hashmap [INFO] [stdout] 462 + serialized_hashmap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:475:17 [INFO] [stdout] | [INFO] [stdout] 475 | return serialized_hashmap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 475 - return serialized_hashmap [INFO] [stdout] 475 + serialized_hashmap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | return JsonItem::Int(value_str.parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return JsonItem::Int(value_str.parse().unwrap()); [INFO] [stdout] 216 + JsonItem::Int(value_str.parse().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return T::from(JsonItem::Datetime(DateTime::parse_from_rfc3339(&value).unwrap().naive_utc())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return T::from(JsonItem::Datetime(DateTime::parse_from_rfc3339(&value).unwrap().naive_utc())); [INFO] [stdout] 254 + T::from(JsonItem::Datetime(DateTime::parse_from_rfc3339(&value).unwrap().naive_utc())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:257:13 [INFO] [stdout] | [INFO] [stdout] 257 | return T::from(JsonItem::Timestamp(value.parse().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - return T::from(JsonItem::Timestamp(value.parse().unwrap())); [INFO] [stdout] 257 + T::from(JsonItem::Timestamp(value.parse().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | return T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})); [INFO] [stdout] 260 + T::from(JsonItem::Custom(JsonCustomType{name: type_id_str, value: value})) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return handle_dict_or_list(&mut json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return handle_dict_or_list(&mut json_wrapper); [INFO] [stdout] 38 + handle_dict_or_list(&mut json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/deserialize.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 273 | if !(json_wrapper.current == *c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(json_wrapper.current != *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/deserialize.rs:292:16 [INFO] [stdout] | [INFO] [stdout] 292 | if !(json_wrapper.current == *c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(json_wrapper.current != *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/deserialize.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | if !(json_wrapper.current == *c) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(json_wrapper.current != *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | return T::from(JsonItem::Str(handle_string(json_wrapper, c))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 316 - return T::from(JsonItem::Str(handle_string(json_wrapper, c))); [INFO] [stdout] 316 + T::from(JsonItem::Str(handle_string(json_wrapper, c))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | return T::from(handle_number(json_wrapper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 320 - return T::from(handle_number(json_wrapper)); [INFO] [stdout] 320 + T::from(handle_number(json_wrapper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:325:13 [INFO] [stdout] | [INFO] [stdout] 325 | return T::from(JsonItem::Null()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return T::from(JsonItem::Null()); [INFO] [stdout] 325 + T::from(JsonItem::Null()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:330:13 [INFO] [stdout] | [INFO] [stdout] 330 | return T::from(JsonItem::Bool(false)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - return T::from(JsonItem::Bool(false)); [INFO] [stdout] 330 + T::from(JsonItem::Bool(false)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:335:13 [INFO] [stdout] | [INFO] [stdout] 335 | return T::from(JsonItem::Bool(true)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - return T::from(JsonItem::Bool(true)); [INFO] [stdout] 335 + T::from(JsonItem::Bool(true)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | return handle_custom_type(json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return handle_custom_type(json_wrapper); [INFO] [stdout] 339 + handle_custom_type(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/deserialize.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | return handle_dict_or_list(json_wrapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 342 - return handle_dict_or_list(json_wrapper) [INFO] [stdout] 342 + handle_dict_or_list(json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return escaped_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return escaped_string [INFO] [stdout] 24 + escaped_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/serialize.rs:418:1 [INFO] [stdout] | [INFO] [stdout] 418 | / impl ToString for JsonSerializable { [INFO] [stdout] 419 | | fn to_string(&self) -> String { [INFO] [stdout] 420 | | match self { [INFO] [stdout] 421 | | JsonSerializable::Null => "null".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 488 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:449:17 [INFO] [stdout] | [INFO] [stdout] 449 | return serialized_array [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return serialized_array [INFO] [stdout] 449 + serialized_array [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | return serialized_hashmap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 462 - return serialized_hashmap [INFO] [stdout] 462 + serialized_hashmap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/serialize.rs:475:17 [INFO] [stdout] | [INFO] [stdout] 475 | return serialized_hashmap [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 475 - return serialized_hashmap [INFO] [stdout] 475 + serialized_hashmap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return handle_dict_or_list(&mut json_wrapper); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return handle_dict_or_list(&mut json_wrapper); [INFO] [stdout] 38 + handle_dict_or_list(&mut json_wrapper) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.73s [INFO] running `Command { std: "docker" "inspect" "5005c17f492fbfbda741cd92b91bfbbeeff1bc8860ae01ee9d241b8151a7938e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5005c17f492fbfbda741cd92b91bfbbeeff1bc8860ae01ee9d241b8151a7938e", kill_on_drop: false }` [INFO] [stdout] 5005c17f492fbfbda741cd92b91bfbbeeff1bc8860ae01ee9d241b8151a7938e