[INFO] cloning repository https://github.com/Helyos96/Lightning [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Helyos96/Lightning" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHelyos96%2FLightning", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHelyos96%2FLightning'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3bdc498ccf0b3721e3d894f92378cfab68c89f78 [INFO] linting Helyos96/Lightning against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHelyos96%2FLightning" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Helyos96/Lightning [INFO] finished tweaking git repo https://github.com/Helyos96/Lightning [INFO] tweaked toml for git repo https://github.com/Helyos96/Lightning written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Helyos96/Lightning on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Helyos96/Lightning already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded deprecate-until v0.1.1 [INFO] [stderr] Downloaded encoding_rs_io v0.1.7 [INFO] [stderr] Downloaded argh_shared v0.1.13 [INFO] [stderr] Downloaded argh v0.1.13 [INFO] [stderr] Downloaded dds-rs v0.7.0 [INFO] [stderr] Downloaded bencher v0.1.5 [INFO] [stderr] Downloaded mime_guess2 v2.3.1 [INFO] [stderr] Downloaded argh_derive v0.1.13 [INFO] [stderr] Downloaded egui_extras v0.31.1 [INFO] [stderr] Downloaded quadtree-f32 v0.4.1 [INFO] [stderr] Downloaded bincode v0.8.0 [INFO] [stderr] Downloaded pathfinding v4.14.0 [INFO] [stderr] Downloaded glam v0.30.7 [INFO] [stderr] Downloaded rust-fuzzy-search v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22f90cce5df61111972e849fecb5316c0aa150362628a719991f5c846e43dbe1 [INFO] running `Command { std: "docker" "start" "-a" "22f90cce5df61111972e849fecb5316c0aa150362628a719991f5c846e43dbe1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22f90cce5df61111972e849fecb5316c0aa150362628a719991f5c846e43dbe1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22f90cce5df61111972e849fecb5316c0aa150362628a719991f5c846e43dbe1", kill_on_drop: false }` [INFO] [stdout] 22f90cce5df61111972e849fecb5316c0aa150362628a719991f5c846e43dbe1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96ad1e3bf97c9529f3191429b7b5fa397411cd5da4b108578c4ca5b315c43e1e [INFO] running `Command { std: "docker" "start" "-a" "96ad1e3bf97c9529f3191429b7b5fa397411cd5da4b108578c4ca5b315c43e1e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Compiling serde_core v1.0.226 [INFO] [stderr] Compiling serde v1.0.226 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling cc v1.2.38 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling xml-rs v0.8.27 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking pxfm v0.1.24 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking epaint_default_fonts v0.31.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling mime_guess2 v2.3.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling argh_shared v0.1.13 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking bencher v0.1.5 [INFO] [stderr] Checking rust-fuzzy-search v0.1.1 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking quadtree-f32 v0.4.1 [INFO] [stderr] Checking glam v0.30.7 [INFO] [stderr] Checking thousands v0.2.0 [INFO] [stderr] Checking moxcms v0.7.5 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.0.2 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.226 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling deprecate-until v0.1.1 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Compiling argh_derive v0.1.13 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking emath v0.31.1 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.16 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking pathfinding v4.14.0 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking ecolor v0.31.1 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Checking epaint v0.31.1 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling serde_with_macros v3.11.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking egui v0.31.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking argh v0.1.13 [INFO] [stderr] Checking dds-rs v0.7.0 [INFO] [stderr] Checking serde_with v3.11.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking egui_extras v0.31.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking lightning-model v0.1.0 (/opt/rustwide/workdir/lightning-model) [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> lightning-model/src/stackvec.rs:8:23 [INFO] [stdout] | [INFO] [stdout] 8 | let mut vec = crate::stackvec::StackVec::new(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> lightning-model/src/stackvec.rs:8:23 [INFO] [stdout] | [INFO] [stdout] 8 | let mut vec = crate::stackvec::StackVec::new(); [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> lightning-model/src/data/mod.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | const fn new(stat_id: StatId, added_min_id: StatId, added_max_id: StatId, base_min_id: StatId, base_max_id: StatId, min_id: StatId, max_id: StatId, damage_type: DamageType) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> lightning-model/src/modifier.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | static ref BEGINNINGS: Vec<(Regex, Box Option> + Send + Sync>)> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> lightning-model/src/data/mod.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | const fn new(stat_id: StatId, added_min_id: StatId, added_max_id: StatId, base_min_id: StatId, base_max_id: StatId, min_id: StatId, max_id: StatId, damage_type: DamageType) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> lightning-model/src/modifier.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | static ref BEGINNINGS: Vec<(Regex, Box Option> + Send + Sync>)> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking lightning-data v0.1.0 (/opt/rustwide/workdir/lightning-data) [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> lightning-data/src/main.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 35 | let nb_rows = (dds_files.len() + max_items_per_line - 1) / max_items_per_line; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `dds_files.len().div_ceil(max_items_per_line)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> lightning-data/src/main.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 35 | let nb_rows = (dds_files.len() + max_items_per_line - 1) / max_items_per_line; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `dds_files.len().div_ceil(max_items_per_line)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking egui-winit v0.31.1 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking egui_glow v0.31.1 [INFO] [stderr] Checking lightning-app v0.1.0 (/opt/rustwide/workdir/lightning-app) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> lightning-app/src/gui/mod.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | config: config, // needs to be after fields that depend on config [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> lightning-app/src/gui/mod.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | config: config, // needs to be after fields that depend on config [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> lightning-app/src/gui/mod.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | vec.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 - vec.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 230 + vec.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> lightning-app/src/tree_gl/draw_data.rs:138:1 [INFO] [stdout] | [INFO] [stdout] 138 | fn connector_gl(x1: f32, y1: f32, x2: f32, y2: f32, w: f32, rect: &Rect, sprite: &Sprite, dd: &mut DrawData) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> lightning-app/src/gui/mod.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | vec.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 - vec.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 230 + vec.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> lightning-app/src/main.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | / ... if state.ui_state == UiState::Main(MainState::Tree) && gui::is_over_tree(&state.mouse_pos) { [INFO] [stdout] 319 | | ... state.zoom_tmp = (state.zoom_tmp + v).clamp(1.0, 10.0); [INFO] [stdout] 320 | | ... state.zoom = state.zoom_tmp.round(); [INFO] [stdout] 321 | | ... window.request_redraw(); [INFO] [stdout] 322 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 317 ~ } [INFO] [stdout] 318 ~ if state.ui_state == UiState::Main(MainState::Tree) && gui::is_over_tree(&state.mouse_pos) => { [INFO] [stdout] 319 | state.zoom_tmp = (state.zoom_tmp + v).clamp(1.0, 10.0); [INFO] [stdout] 320 | state.zoom = state.zoom_tmp.round(); [INFO] [stdout] 321 | window.request_redraw(); [INFO] [stdout] 322 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> lightning-app/src/main.rs:337:29 [INFO] [stdout] | [INFO] [stdout] 337 | / ... if button == MouseButton::Left { [INFO] [stdout] 338 | | ... if button_state == ElementState::Pressed { [INFO] [stdout] 339 | | ... if state.ui_state == UiState::Main(MainState::Tree) && gui::is_over_tree(&state.mouse_pos) { [INFO] [stdout] 340 | | ... state.mouse_tree_drag = Some(state.mouse_pos); [INFO] [stdout] ... | [INFO] [stdout] 363 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 336 ~ } [INFO] [stdout] 337 ~ if button == MouseButton::Left => { [INFO] [stdout] 338 | if button_state == ElementState::Pressed { [INFO] [stdout] ... [INFO] [stdout] 362 | } [INFO] [stdout] 363 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> lightning-app/src/main.rs:366:29 [INFO] [stdout] | [INFO] [stdout] 366 | / ... if event.state.is_pressed() { [INFO] [stdout] 367 | | ... if state.modifiers.state().control_key() { [INFO] [stdout] 368 | | ... if event.logical_key == Key::Character("z".into()) { [INFO] [stdout] 369 | | ... state.undo(); [INFO] [stdout] ... | [INFO] [stdout] 378 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 365 ~ WindowEvent::KeyboardInput { event, .. } [INFO] [stdout] 366 ~ if event.state.is_pressed() => { [INFO] [stdout] 367 | if state.modifiers.state().control_key() { [INFO] [stdout] ... [INFO] [stdout] 377 | } [INFO] [stdout] 378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> lightning-app/src/tree_gl/draw_data.rs:138:1 [INFO] [stdout] | [INFO] [stdout] 138 | fn connector_gl(x1: f32, y1: f32, x2: f32, y2: f32, w: f32, rect: &Rect, sprite: &Sprite, dd: &mut DrawData) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> lightning-app/src/main.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | / ... if state.ui_state == UiState::Main(MainState::Tree) && gui::is_over_tree(&state.mouse_pos) { [INFO] [stdout] 319 | | ... state.zoom_tmp = (state.zoom_tmp + v).clamp(1.0, 10.0); [INFO] [stdout] 320 | | ... state.zoom = state.zoom_tmp.round(); [INFO] [stdout] 321 | | ... window.request_redraw(); [INFO] [stdout] 322 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 317 ~ } [INFO] [stdout] 318 ~ if state.ui_state == UiState::Main(MainState::Tree) && gui::is_over_tree(&state.mouse_pos) => { [INFO] [stdout] 319 | state.zoom_tmp = (state.zoom_tmp + v).clamp(1.0, 10.0); [INFO] [stdout] 320 | state.zoom = state.zoom_tmp.round(); [INFO] [stdout] 321 | window.request_redraw(); [INFO] [stdout] 322 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> lightning-app/src/main.rs:337:29 [INFO] [stdout] | [INFO] [stdout] 337 | / ... if button == MouseButton::Left { [INFO] [stdout] 338 | | ... if button_state == ElementState::Pressed { [INFO] [stdout] 339 | | ... if state.ui_state == UiState::Main(MainState::Tree) && gui::is_over_tree(&state.mouse_pos) { [INFO] [stdout] 340 | | ... state.mouse_tree_drag = Some(state.mouse_pos); [INFO] [stdout] ... | [INFO] [stdout] 363 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 336 ~ } [INFO] [stdout] 337 ~ if button == MouseButton::Left => { [INFO] [stdout] 338 | if button_state == ElementState::Pressed { [INFO] [stdout] ... [INFO] [stdout] 362 | } [INFO] [stdout] 363 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> lightning-app/src/main.rs:366:29 [INFO] [stdout] | [INFO] [stdout] 366 | / ... if event.state.is_pressed() { [INFO] [stdout] 367 | | ... if state.modifiers.state().control_key() { [INFO] [stdout] 368 | | ... if event.logical_key == Key::Character("z".into()) { [INFO] [stdout] 369 | | ... state.undo(); [INFO] [stdout] ... | [INFO] [stdout] 378 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 365 ~ WindowEvent::KeyboardInput { event, .. } [INFO] [stdout] 366 ~ if event.state.is_pressed() => { [INFO] [stdout] 367 | if state.modifiers.state().control_key() { [INFO] [stdout] ... [INFO] [stdout] 377 | } [INFO] [stdout] 378 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 37.57s [INFO] running `Command { std: "docker" "inspect" "96ad1e3bf97c9529f3191429b7b5fa397411cd5da4b108578c4ca5b315c43e1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96ad1e3bf97c9529f3191429b7b5fa397411cd5da4b108578c4ca5b315c43e1e", kill_on_drop: false }` [INFO] [stdout] 96ad1e3bf97c9529f3191429b7b5fa397411cd5da4b108578c4ca5b315c43e1e