[INFO] cloning repository https://github.com/HehehehaBawg/Stonks [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HehehehaBawg/Stonks" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHehehehaBawg%2FStonks", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHehehehaBawg%2FStonks'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aa9168cbab3c6324d8250e058f3d161901f7ba58 [INFO] linting HehehehaBawg/Stonks against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHehehehaBawg%2FStonks" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HehehehaBawg/Stonks [INFO] finished tweaking git repo https://github.com/HehehehaBawg/Stonks [INFO] tweaked toml for git repo https://github.com/HehehehaBawg/Stonks written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HehehehaBawg/Stonks on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HehehehaBawg/Stonks already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-0-tc1/source/Cargo.toml: unused manifest key: patch.crates-io.egui_wgpu_backend.revision [INFO] [stderr] Updating git repository `https://github.com/jsgroth/egui_wgpu_backend` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bincode_derive v2.0.0-rc.3 [INFO] [stderr] Downloaded virtue v0.0.13 [INFO] [stderr] Downloaded ext-trait-proc_macros v1.0.1 [INFO] [stderr] Downloaded extension-traits v1.0.1 [INFO] [stderr] Downloaded xdg-home v1.1.0 [INFO] [stderr] Downloaded lending-iterator-proc_macros v0.1.7 [INFO] [stderr] Downloaded test-log v0.2.15 [INFO] [stderr] Downloaded indexmap v2.2.5 [INFO] [stderr] Downloaded enumflags2_derive v0.7.9 [INFO] [stderr] Downloaded async-signal v0.2.5 [INFO] [stderr] Downloaded egui_extras v0.25.0 [INFO] [stderr] Downloaded async-once-cell v0.5.3 [INFO] [stderr] Downloaded clipboard-win v5.2.0 [INFO] [stderr] Downloaded webbrowser v0.8.12 [INFO] [stderr] Downloaded eframe v0.25.0 [INFO] [stderr] Downloaded gdk-sys v0.18.0 [INFO] [stderr] Downloaded toml_edit v0.22.6 [INFO] [stderr] Downloaded wgpu v0.18.0 [INFO] [stderr] Downloaded gtk-sys v0.18.0 [INFO] [stderr] Downloaded sdl2 v0.36.0 [INFO] [stderr] Downloaded wgpu-hal v0.18.1 [INFO] [stderr] Downloaded wgpu-core v0.18.1 [INFO] [stderr] Downloaded ruzstd v0.6.0 [INFO] [stderr] Downloaded egui v0.25.0 [INFO] [stderr] Downloaded egui-winit v0.25.0 [INFO] [stderr] Downloaded system-deps v6.2.0 [INFO] [stderr] Downloaded rfd v0.13.0 [INFO] [stderr] Downloaded lending-iterator v0.1.7 [INFO] [stderr] Downloaded lzma-rs-perf-exp v0.2.1 [INFO] [stderr] Downloaded macro_rules_attribute v0.1.3 [INFO] [stderr] Downloaded gpu-allocator v0.23.0 [INFO] [stderr] Downloaded wgpu-types v0.18.0 [INFO] [stderr] Downloaded naga v0.14.2 [INFO] [stderr] Downloaded enumflags2 v0.7.9 [INFO] [stderr] Downloaded egui_glow v0.25.0 [INFO] [stderr] Downloaded accesskit v0.12.2 [INFO] [stderr] Downloaded winit v0.29.13 [INFO] [stderr] Downloaded ecolor v0.25.0 [INFO] [stderr] Downloaded emath v0.25.0 [INFO] [stderr] Downloaded atk-sys v0.18.0 [INFO] [stderr] Downloaded polonius-the-crab v0.2.1 [INFO] [stderr] Downloaded nougat-proc_macros v0.2.4 [INFO] [stderr] Downloaded nougat v0.2.4 [INFO] [stderr] Downloaded env_logger v0.11.2 [INFO] [stderr] Downloaded test-log-macros v0.2.15 [INFO] [stderr] Downloaded enumn v0.1.13 [INFO] [stderr] Downloaded epaint v0.25.0 [INFO] [stderr] Downloaded xrandr v0.2.0 [INFO] [stderr] Downloaded bitreader v0.3.8 [INFO] [stderr] Downloaded ext-trait v1.0.1 [INFO] [stderr] Downloaded never-say-never v6.6.666 [INFO] [stderr] Downloaded macro_rules_attribute-proc_macro v0.1.3 [INFO] [stderr] Downloaded sdl2-sys v0.36.0 [INFO] [stderr] Downloaded chd v0.3.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf33af34f35bb249d695d36a95573fdd83e08192c26361c14efd8510aa170767 [INFO] running `Command { std: "docker" "start" "-a" "cf33af34f35bb249d695d36a95573fdd83e08192c26361c14efd8510aa170767", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf33af34f35bb249d695d36a95573fdd83e08192c26361c14efd8510aa170767", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf33af34f35bb249d695d36a95573fdd83e08192c26361c14efd8510aa170767", kill_on_drop: false }` [INFO] [stdout] cf33af34f35bb249d695d36a95573fdd83e08192c26361c14efd8510aa170767 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77523a7df63c75ac631f74816f26a39e01a64f1da44b3713ef765fd2fc3387ce [INFO] running `Command { std: "docker" "start" "-a" "77523a7df63c75ac631f74816f26a39e01a64f1da44b3713ef765fd2fc3387ce", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/Cargo.toml: unused manifest key: patch.crates-io.egui_wgpu_backend.revision [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling virtue v0.0.13 [INFO] [stderr] Compiling indexmap v2.2.5 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Compiling target-lexicon v0.12.14 [INFO] [stderr] Compiling winnow v0.6.5 [INFO] [stderr] Compiling smallvec v1.13.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling cc v1.0.89 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling bincode_derive v2.0.0-rc.3 [INFO] [stderr] Checking crc v3.0.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking bincode v2.0.0-rc.3 [INFO] [stderr] Compiling cfg-expr v0.15.7 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking event-listener v5.2.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Compiling wayland-backend v0.3.3 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.1.3 [INFO] [stderr] Compiling wayland-scanner v0.31.1 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking spirv v0.2.0+1.5.4 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking wgpu-types v0.18.0 [INFO] [stderr] Checking never-say-never v6.6.666 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking macro_rules_attribute v0.1.3 [INFO] [stderr] Checking polonius-the-crab v0.2.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking lzma-rs-perf-exp v0.2.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking xdg-home v1.1.0 [INFO] [stderr] Checking bitreader v0.3.8 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking text_io v0.1.12 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Compiling winit v0.29.13 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling glutin v0.31.3 [INFO] [stderr] Checking async-once-cell v0.5.3 [INFO] [stderr] Compiling mime_guess2 v2.0.5 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling serde_spanned v0.6.5 [INFO] [stderr] Compiling toml_edit v0.22.6 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking webbrowser v0.8.12 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Compiling rfd v0.13.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking jgenesis-web v0.7.1 (/opt/rustwide/workdir/frontend/jgenesis-web) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling jgenesis-proc-macros v0.7.1 (/opt/rustwide/workdir/jgenesis-proc-macros) [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling enumn v0.1.13 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling enumflags2_derive v0.7.9 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking x11rb v0.13.0 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking wayland-client v0.31.2 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking xrandr v0.2.0 [INFO] [stderr] Compiling toml v0.8.10 [INFO] [stderr] Compiling test-log-macros v0.2.15 [INFO] [stderr] Checking jgenesis-common v0.7.1 (/opt/rustwide/workdir/jgenesis-common) [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling system-deps v6.2.0 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> jgenesis-common/src/frontend.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Color { [INFO] [stdout] | ^^^^^ field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check` is never used [INFO] [stdout] --> jgenesis-common/src/frontend.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / #[repr(C)] [INFO] [stdout] 8 | | #[derive(Debug, Clone, Copy, PartialEq, Eq, bytemuck::Pod, bytemuck::Zeroable, Encode, Decode)] [INFO] [stdout] 9 | | pub struct Color { [INFO] [stdout] 10 | | pub r: u8, [INFO] [stdout] ... | [INFO] [stdout] 13 | | pub a: u8, [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> jgenesis-common/src/timeutils.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if year % 4 == 0 { 29 } else { 28 } [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking test-log v0.2.15 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Compiling glib-sys v0.18.1 [INFO] [stderr] Compiling gobject-sys v0.18.0 [INFO] [stderr] Compiling gio-sys v0.18.1 [INFO] [stderr] Compiling atk-sys v0.18.0 [INFO] [stderr] Compiling gdk-sys v0.18.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.18.0 [INFO] [stderr] Compiling cairo-sys-rs v0.18.2 [INFO] [stderr] Compiling pango-sys v0.18.0 [INFO] [stderr] Compiling gtk-sys v0.18.0 [INFO] [stderr] Compiling ext-trait-proc_macros v1.0.1 [INFO] [stderr] Compiling nougat-proc_macros v0.2.4 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling lending-iterator-proc_macros v0.1.7 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Checking ext-trait v1.0.1 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking extension-traits v1.0.1 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking arboard v3.3.2 [INFO] [stderr] Checking nougat v0.2.4 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking lending-iterator v0.1.7 [INFO] [stderr] Checking ruzstd v0.6.0 [INFO] [stderr] Checking chd v0.3.1 [INFO] [stderr] Checking cdrom v0.7.1 (/opt/rustwide/workdir/cdrom) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking accesskit v0.12.2 [INFO] [stderr] Checking enumflags2 v0.7.9 [INFO] [stderr] Checking emath v0.25.0 [INFO] [stderr] Checking ecolor v0.25.0 [INFO] [stderr] Checking serde_json v1.0.114 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> jgenesis-common/src/frontend.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Color { [INFO] [stdout] | ^^^^^ field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check` is never used [INFO] [stdout] --> jgenesis-common/src/frontend.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / #[repr(C)] [INFO] [stdout] 8 | | #[derive(Debug, Clone, Copy, PartialEq, Eq, bytemuck::Pod, bytemuck::Zeroable, Encode, Decode)] [INFO] [stdout] 9 | | pub struct Color { [INFO] [stdout] 10 | | pub r: u8, [INFO] [stdout] ... | [INFO] [stdout] 13 | | pub a: u8, [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> jgenesis-common/src/frontend.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Color { [INFO] [stdout] | ^^^^^ field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check` is never used [INFO] [stdout] --> jgenesis-common/src/frontend.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / #[repr(C)] [INFO] [stdout] 8 | | #[derive(Debug, Clone, Copy, PartialEq, Eq, bytemuck::Pod, bytemuck::Zeroable, Encode, Decode)] [INFO] [stdout] 9 | | pub struct Color { [INFO] [stdout] 10 | | pub r: u8, [INFO] [stdout] ... | [INFO] [stdout] 13 | | pub a: u8, [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> jgenesis-common/src/timeutils.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if year % 4 == 0 { 29 } else { 28 } [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> jgenesis-common/src/timeutils.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if year % 4 == 0 { 29 } else { 28 } [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `year.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking z80-emu v0.7.1 (/opt/rustwide/workdir/cpu/z80-emu) [INFO] [stderr] Checking m68000-emu v0.7.1 (/opt/rustwide/workdir/cpu/m68000-emu) [INFO] [stderr] Checking wdc65816-emu v0.7.1 (/opt/rustwide/workdir/cpu/wdc65816-emu) [INFO] [stderr] Checking mos6502-emu v0.7.1 (/opt/rustwide/workdir/cpu/mos6502-emu) [INFO] [stderr] Checking spc700-emu v0.7.1 (/opt/rustwide/workdir/cpu/spc700-emu) [INFO] [stderr] Checking gb-core v0.7.1 (/opt/rustwide/workdir/backend/gb-core) [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking epaint v0.25.0 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/arithmetic.rs:143:6 [INFO] [stdout] | [INFO] [stdout] 143 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 143 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 143 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/bits.rs:133:6 [INFO] [stdout] | [INFO] [stdout] 133 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 133 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 133 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/bits.rs:171:28 [INFO] [stdout] | [INFO] [stdout] 171 | self.registers.a = (a << 1) | (a >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `a.rotate_left(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/bits.rs:193:28 [INFO] [stdout] | [INFO] [stdout] 193 | self.registers.a = (a >> 1) | (a << 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `a.rotate_right(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/control.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 9 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 9 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/io.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 7 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 7 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/jump.rs:70:6 [INFO] [stdout] | [INFO] [stdout] 70 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 70 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 70 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/load.rs:6:6 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 6 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 6 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/z80-emu/src/core/instructions.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | value.count_ones() % 2 == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `value.count_ones().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/arithmetic.rs:171:6 [INFO] [stdout] | [INFO] [stdout] 171 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 171 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 171 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/bits.rs:294:6 [INFO] [stdout] | [INFO] [stdout] 294 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 294 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 294 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking smsgg-core v0.7.1 (/opt/rustwide/workdir/backend/smsgg-core) [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/controlflow.rs:11:6 [INFO] [stdout] | [INFO] [stdout] 11 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 11 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 11 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/controlflow.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> cpu/spc700-emu/src/instructions/bits.rs:310:31 [INFO] [stdout] | [INFO] [stdout] 310 | cpu.registers.a = (cpu.registers.a >> 4) | (cpu.registers.a << 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `cpu.registers.a.rotate_left(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/load.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 57 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 57 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 57 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/load.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 230 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking spc700-test-runner v0.7.1 (/opt/rustwide/workdir/cpu/spc700-test-runner) [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/arithmetic.rs:143:6 [INFO] [stdout] | [INFO] [stdout] 143 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 143 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 143 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions.rs:320:6 [INFO] [stdout] | [INFO] [stdout] 320 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 320 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 320 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking naga v0.14.2 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/bits.rs:133:6 [INFO] [stdout] | [INFO] [stdout] 133 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 133 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 133 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/bits.rs:171:28 [INFO] [stdout] | [INFO] [stdout] 171 | self.registers.a = (a << 1) | (a >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `a.rotate_left(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/bits.rs:193:28 [INFO] [stdout] | [INFO] [stdout] 193 | self.registers.a = (a >> 1) | (a << 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `a.rotate_right(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/control.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 9 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 9 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/io.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 7 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 7 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/jump.rs:70:6 [INFO] [stdout] | [INFO] [stdout] 70 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 70 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 70 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/z80-emu/src/core/instructions/load.rs:6:6 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 6 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 6 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:429:12 [INFO] [stdout] | [INFO] [stdout] 429 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:438:12 [INFO] [stdout] | [INFO] [stdout] 438 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:449:12 [INFO] [stdout] | [INFO] [stdout] 449 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:458:12 [INFO] [stdout] | [INFO] [stdout] 458 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/z80-emu/src/core/instructions.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | value.count_ones() % 2 == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `value.count_ones().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> cpu/z80-emu/src/traits.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | memory: [0; 0x10000], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![0; 0x10000].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] = note: `-W clippy::large-stack-arrays` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_stack_arrays)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking z80-test-runner v0.7.1 (/opt/rustwide/workdir/cpu/z80-test-runner) [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking m68000-test-runner v0.7.1 (/opt/rustwide/workdir/cpu/m68000-test-runner) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> cpu/z80-test-runner/src/main.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 83 | Self { memory: [0; 0x10000], io_ports: [0; 0x100] } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![0; 0x10000].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] = note: `-W clippy::large-stack-arrays` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_stack_arrays)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> cpu/z80-test-runner/src/main.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 83 | Self { memory: [0; 0x10000], io_ports: [0; 0x100] } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![0; 0x10000].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] = note: `-W clippy::large-stack-arrays` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_stack_arrays)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/gb-core/src/bus.rs:61:6 [INFO] [stdout] | [INFO] [stdout] 61 | impl<'a> Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 61 - impl<'a> Bus<'a> { [INFO] [stdout] 61 + impl Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/gb-core/src/bus.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 129 - impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] 129 + impl BusInterface for Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/gb-core/src/cartridge/mappers.rs:163:10 [INFO] [stdout] | [INFO] [stdout] 163 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking nes-core v0.7.1 (/opt/rustwide/workdir/backend/nes-core) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/gb-core/src/dma.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / impl Default for VramDmaState { [INFO] [stdout] 18 | | fn default() -> Self { [INFO] [stdout] 19 | | Self::Idle [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 10 + #[derive(Default)] [INFO] [stdout] 11 | enum VramDmaState { [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking mos6502-test-runner v0.7.1 (/opt/rustwide/workdir/cpu/mos6502-test-runner) [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/gb-core/src/bus.rs:61:6 [INFO] [stdout] | [INFO] [stdout] 61 | impl<'a> Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 61 - impl<'a> Bus<'a> { [INFO] [stdout] 61 + impl Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/gb-core/src/bus.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 129 - impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] 129 + impl BusInterface for Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking egui v0.25.0 [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/gb-core/src/cartridge/mappers.rs:163:10 [INFO] [stdout] | [INFO] [stdout] 163 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/gb-core/src/dma.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / impl Default for VramDmaState { [INFO] [stdout] 18 | | fn default() -> Self { [INFO] [stdout] 19 | | Self::Idle [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 10 + #[derive(Default)] [INFO] [stdout] 11 | enum VramDmaState { [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cpu/mos6502-test-runner/src/main.rs:116:56 [INFO] [stdout] | [INFO] [stdout] 116 | let file_path = Path::new(&args.dir_path).join(&format!("{opcode:02x}.json")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{opcode:02x}.json")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/smsgg-core/src/api.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 285 | if self.frame_count % 60 == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(60)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | (self.registers.a << 1) | (self.registers.a >> 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_left(1)` [INFO] [stdout] ... [INFO] [stdout] 79 | impl_rla_op!(rlca, thru_carry: false); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] = note: this warning originates in the macro `impl_rla_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | (self.registers.a >> 1) | (self.registers.a << 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_right(1)` [INFO] [stdout] ... [INFO] [stdout] 82 | impl_rra_op!(rrca, thru_carry: false); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: this warning originates in the macro `impl_rra_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | (self.registers.a << 1) | (self.registers.a >> 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_left(1)` [INFO] [stdout] ... [INFO] [stdout] 85 | impl_rla_op!(rla, thru_carry: true); [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: this warning originates in the macro `impl_rla_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/smsgg-core/src/bus.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 34 | impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 34 - impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] 34 + impl BusInterface for Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | (self.registers.a >> 1) | (self.registers.a << 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_right(1)` [INFO] [stdout] ... [INFO] [stdout] 88 | impl_rra_op!(rra, thru_carry: true); [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: this warning originates in the macro `impl_rra_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 93 | let rotated = (value << 1) | (value >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `value.rotate_left(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 102 | let rotated = (value >> 1) | (value << 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `value.rotate_right(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:156:42 [INFO] [stdout] | [INFO] [stdout] 156 | self.write_register(bus, opcode, (value >> 4) | (value << 4)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `value.rotate_left(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | (self.registers.a << 1) | (self.registers.a >> 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_left(1)` [INFO] [stdout] ... [INFO] [stdout] 79 | impl_rla_op!(rlca, thru_carry: false); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] = note: this warning originates in the macro `impl_rla_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | (self.registers.a >> 1) | (self.registers.a << 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_right(1)` [INFO] [stdout] ... [INFO] [stdout] 82 | impl_rra_op!(rrca, thru_carry: false); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: this warning originates in the macro `impl_rra_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | (self.registers.a << 1) | (self.registers.a >> 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_left(1)` [INFO] [stdout] ... [INFO] [stdout] 85 | impl_rla_op!(rla, thru_carry: true); [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: this warning originates in the macro `impl_rla_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | (self.registers.a >> 1) | (self.registers.a << 7) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.registers.a.rotate_right(1)` [INFO] [stdout] ... [INFO] [stdout] 88 | impl_rra_op!(rra, thru_carry: true); [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: this warning originates in the macro `impl_rra_op` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 93 | let rotated = (value << 1) | (value >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `value.rotate_left(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 102 | let rotated = (value >> 1) | (value << 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `value.rotate_right(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/gb-core/src/sm83/bits.rs:156:42 [INFO] [stdout] | [INFO] [stdout] 156 | self.write_register(bus, opcode, (value >> 4) | (value << 4)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `value.rotate_left(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> cpu/spc700-emu/src/instructions/bits.rs:310:31 [INFO] [stdout] | [INFO] [stdout] 310 | cpu.registers.a = (cpu.registers.a >> 4) | (cpu.registers.a << 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `cpu.registers.a.rotate_left(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/smsgg-core/src/api.rs:285:20 [INFO] [stdout] | [INFO] [stdout] 285 | if self.frame_count % 60 == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(60)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/smsgg-core/src/bus.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 34 | impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 34 - impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] 34 + impl BusInterface for Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cpu/mos6502-test-runner/src/main.rs:116:56 [INFO] [stdout] | [INFO] [stdout] 116 | let file_path = Path::new(&args.dir_path).join(&format!("{opcode:02x}.json")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{opcode:02x}.json")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/smsgg-core/src/vdp.rs:535:6 [INFO] [stdout] | [INFO] [stdout] 535 | impl<'a, T: Copy> Iterator for BufferIter<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 535 - impl<'a, T: Copy> Iterator for BufferIter<'a, T> { [INFO] [stdout] 535 + impl Iterator for BufferIter<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/smsgg-core/src/ym2413.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 165 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> backend/smsgg-core/src/ym2413.rs:418:14 [INFO] [stdout] | [INFO] [stdout] 418 | (-1.0 * sine.log2() * 256.0).round() as u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `-sine.log2()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `-W clippy::neg-multiply` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::neg_multiply)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/smsgg-core/src/vdp.rs:535:6 [INFO] [stdout] | [INFO] [stdout] 535 | impl<'a, T: Copy> Iterator for BufferIter<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 535 - impl<'a, T: Copy> Iterator for BufferIter<'a, T> { [INFO] [stdout] 535 + impl Iterator for BufferIter<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking genesis-core v0.7.1 (/opt/rustwide/workdir/backend/genesis-core) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/smsgg-core/src/ym2413.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 165 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> backend/smsgg-core/src/ym2413.rs:418:14 [INFO] [stdout] | [INFO] [stdout] 418 | (-1.0 * sine.log2() * 256.0).round() as u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `-sine.log2()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `-W clippy::neg-multiply` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::neg_multiply)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/arithmetic.rs:171:6 [INFO] [stdout] | [INFO] [stdout] 171 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 171 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 171 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/bits.rs:294:6 [INFO] [stdout] | [INFO] [stdout] 294 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 294 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 294 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/controlflow.rs:11:6 [INFO] [stdout] | [INFO] [stdout] 11 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 11 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 11 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/controlflow.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/load.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 57 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 57 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 57 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions/load.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 230 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking snes-coprocessors v0.7.1 (/opt/rustwide/workdir/backend/snes-coprocessors) [INFO] [stderr] Checking wdc65816-test-runner v0.7.1 (/opt/rustwide/workdir/cpu/wdc65816-test-runner) [INFO] [stderr] Checking sctk-adwaita v0.8.1 [INFO] [stderr] Checking smithay-clipboard v0.7.1 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'registers, 'bus [INFO] [stdout] --> cpu/m68000-emu/src/core/instructions.rs:320:6 [INFO] [stdout] | [INFO] [stdout] 320 | impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ ^^^^^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 320 - impl<'registers, 'bus, B: BusInterface> InstructionExecutor<'registers, 'bus, B> { [INFO] [stdout] 320 + impl InstructionExecutor<'_, '_, B> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:429:12 [INFO] [stdout] | [INFO] [stdout] 429 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:438:12 [INFO] [stdout] | [INFO] [stdout] 438 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:449:12 [INFO] [stdout] | [INFO] [stdout] 449 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> cpu/m68000-emu/src/core.rs:458:12 [INFO] [stdout] | [INFO] [stdout] 458 | if address % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!address.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> backend/nes-core/src/apu.rs:329:41 [INFO] [stdout] | [INFO] [stdout] 329 | let mut lookup_table = Box::new([[[0.0; 16]; 16]; 128]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![[[0.0; 16]; 16]; 128].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] = note: `-W clippy::large-stack-arrays` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_stack_arrays)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/bandai.rs:254:17 [INFO] [stdout] | [INFO] [stdout] 254 | / if self.data.ram_enabled { [INFO] [stdout] 255 | | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 256 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 253 ~ (Variant::Lz93D50(MemoryVariant::RAM), 0x6000..=0x7FFF) [INFO] [stdout] 254 ~ if self.data.ram_enabled => { [INFO] [stdout] 255 | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/genesis-core/src/memory.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | / if self.ram_mapped { [INFO] [stdout] 261 | | self.external_memory.write_byte(address, value); [INFO] [stdout] 262 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 259 ~ 0x000000..=0x3FFFFF [INFO] [stdout] 260 ~ if self.ram_mapped => { [INFO] [stdout] 261 | self.external_memory.write_byte(address, value); [INFO] [stdout] 262 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/genesis-core/src/memory.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | / if self.ram_mapped { [INFO] [stdout] 281 | | self.external_memory.write_word(address, value); [INFO] [stdout] 282 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 279 ~ 0x000000..=0x3FFFFF [INFO] [stdout] 280 ~ if self.ram_mapped => { [INFO] [stdout] 281 | self.external_memory.write_word(address, value); [INFO] [stdout] 282 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/genesis-core/src/memory.rs:671:6 [INFO] [stdout] | [INFO] [stdout] 671 | impl<'a, Medium: PhysicalMedium> m68000_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 671 - impl<'a, Medium: PhysicalMedium> m68000_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] 671 + impl m68000_emu::BusInterface for MainBus<'_, Medium> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/genesis-core/src/memory.rs:757:6 [INFO] [stdout] | [INFO] [stdout] 757 | impl<'a, Medium: PhysicalMedium> z80_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 757 - impl<'a, Medium: PhysicalMedium> z80_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] 757 + impl z80_emu::BusInterface for MainBus<'_, Medium> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc6.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | / if amplified > 1.0 { [INFO] [stdout] 334 | | 1.0 [INFO] [stdout] 335 | | } else if amplified < -1.0 { [INFO] [stdout] 336 | | -1.0 [INFO] [stdout] 337 | | } else { [INFO] [stdout] 338 | | amplified [INFO] [stdout] 339 | | } [INFO] [stdout] | |_________^ help: replace with clamp: `amplified.clamp(-1.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `-W clippy::manual-clamp` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_clamp)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:186:14 [INFO] [stdout] | [INFO] [stdout] 186 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/genesis-core/src/svp.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | (self.address << 4) | (self.address >> 12) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.address.rotate_left(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:439:14 [INFO] [stdout] | [INFO] [stdout] 439 | (-1.0 * sine.log2() * 256.0).round() as u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `-sine.log2()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `-W clippy::neg-multiply` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::neg_multiply)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/genesis-core/src/svp.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 384 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/genesis-core/src/memory.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | / if self.ram_mapped { [INFO] [stdout] 261 | | self.external_memory.write_byte(address, value); [INFO] [stdout] 262 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 259 ~ 0x000000..=0x3FFFFF [INFO] [stdout] 260 ~ if self.ram_mapped => { [INFO] [stdout] 261 | self.external_memory.write_byte(address, value); [INFO] [stdout] 262 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:879:21 [INFO] [stdout] | [INFO] [stdout] 879 | / if self.data.audio.enabled { [INFO] [stdout] 880 | | self.data.audio.write_data(value); [INFO] [stdout] 881 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 878 ~ (Variant::Vrc7a | Variant::Unknown, 0x9030) [INFO] [stdout] 879 ~ if self.data.audio.enabled => { [INFO] [stdout] 880 | self.data.audio.write_data(value); [INFO] [stdout] 881 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/genesis-core/src/memory.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | / if self.ram_mapped { [INFO] [stdout] 281 | | self.external_memory.write_word(address, value); [INFO] [stdout] 282 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 279 ~ 0x000000..=0x3FFFFF [INFO] [stdout] 280 ~ if self.ram_mapped => { [INFO] [stdout] 281 | self.external_memory.write_word(address, value); [INFO] [stdout] 282 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:943:30 [INFO] [stdout] | [INFO] [stdout] 943 | let clamped_sample = if amplified_sample < -1.0 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 944 | | -1.0 [INFO] [stdout] 945 | | } else if amplified_sample > 1.0 { [INFO] [stdout] 946 | | 1.0 [INFO] [stdout] 947 | | } else { [INFO] [stdout] 948 | | amplified_sample [INFO] [stdout] 949 | | }; [INFO] [stdout] | |_________^ help: replace with clamp: `amplified_sample.clamp(-1.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> backend/nes-core/src/apu.rs:329:41 [INFO] [stdout] | [INFO] [stdout] 329 | let mut lookup_table = Box::new([[[0.0; 16]; 16]; 128]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![[[0.0; 16]; 16]; 128].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] = note: `-W clippy::large-stack-arrays` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_stack_arrays)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/genesis-core/src/memory.rs:671:6 [INFO] [stdout] | [INFO] [stdout] 671 | impl<'a, Medium: PhysicalMedium> m68000_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 671 - impl<'a, Medium: PhysicalMedium> m68000_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] 671 + impl m68000_emu::BusInterface for MainBus<'_, Medium> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/genesis-core/src/memory.rs:757:6 [INFO] [stdout] | [INFO] [stdout] 757 | impl<'a, Medium: PhysicalMedium> z80_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 757 - impl<'a, Medium: PhysicalMedium> z80_emu::BusInterface for MainBus<'a, Medium> { [INFO] [stdout] 757 + impl z80_emu::BusInterface for MainBus<'_, Medium> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> backend/nes-core/src/bus.rs:976:1 [INFO] [stdout] | [INFO] [stdout] 976 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 989 | pub(crate) fn cpu_open_bus(address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `-W clippy::items-after-test-module` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::items_after_test_module)]` [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> backend/genesis-core/src/svp.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | (self.address << 4) | (self.address >> 12) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `self.address.rotate_left(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `-W clippy::manual-rotate` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_rotate)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/bandai.rs:254:17 [INFO] [stdout] | [INFO] [stdout] 254 | / if self.data.ram_enabled { [INFO] [stdout] 255 | | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 256 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 253 ~ (Variant::Lz93D50(MemoryVariant::RAM), 0x6000..=0x7FFF) [INFO] [stdout] 254 ~ if self.data.ram_enabled => { [INFO] [stdout] 255 | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 256 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/genesis-core/src/vdp/render.rs:978:6 [INFO] [stdout] | [INFO] [stdout] 978 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/genesis-core/src/svp.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 384 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc6.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | / if amplified > 1.0 { [INFO] [stdout] 334 | | 1.0 [INFO] [stdout] 335 | | } else if amplified < -1.0 { [INFO] [stdout] 336 | | -1.0 [INFO] [stdout] 337 | | } else { [INFO] [stdout] 338 | | amplified [INFO] [stdout] 339 | | } [INFO] [stdout] | |_________^ help: replace with clamp: `amplified.clamp(-1.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `-W clippy::manual-clamp` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_clamp)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:186:14 [INFO] [stdout] | [INFO] [stdout] 186 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:439:14 [INFO] [stdout] | [INFO] [stdout] 439 | (-1.0 * sine.log2() * 256.0).round() as u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `-sine.log2()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `-W clippy::neg-multiply` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::neg_multiply)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:879:21 [INFO] [stdout] | [INFO] [stdout] 879 | / if self.data.audio.enabled { [INFO] [stdout] 880 | | self.data.audio.write_data(value); [INFO] [stdout] 881 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 878 ~ (Variant::Vrc7a | Variant::Unknown, 0x9030) [INFO] [stdout] 879 ~ if self.data.audio.enabled => { [INFO] [stdout] 880 | self.data.audio.write_data(value); [INFO] [stdout] 881 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/konami/vrc7.rs:943:30 [INFO] [stdout] | [INFO] [stdout] 943 | let clamped_sample = if amplified_sample < -1.0 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 944 | | -1.0 [INFO] [stdout] 945 | | } else if amplified_sample > 1.0 { [INFO] [stdout] 946 | | 1.0 [INFO] [stdout] 947 | | } else { [INFO] [stdout] 948 | | amplified_sample [INFO] [stdout] 949 | | }; [INFO] [stdout] | |_________^ help: replace with clamp: `amplified_sample.clamp(-1.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/namco175.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | / if self.data.ram_enabled && !self.cartridge.prg_ram.is_empty() { [INFO] [stdout] 82 | | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 83 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ 0x6000..=0x7FFF [INFO] [stdout] 81 ~ if self.data.ram_enabled && !self.cartridge.prg_ram.is_empty() => { [INFO] [stdout] 82 | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/genesis-core/src/ym2612/envelope.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 196 | if self.cycle_count % (1 << update_frequency_shift) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle_count.is_multiple_of(1 << update_frequency_shift)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge/mappers/namco175.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | / if self.data.ram_enabled && !self.cartridge.prg_ram.is_empty() { [INFO] [stdout] 82 | | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 83 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ 0x6000..=0x7FFF [INFO] [stdout] 81 ~ if self.data.ram_enabled && !self.cartridge.prg_ram.is_empty() => { [INFO] [stdout] 82 | self.cartridge.set_prg_ram((address & 0x1FFF).into(), value); [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/genesis-core/src/vdp/render.rs:978:6 [INFO] [stdout] | [INFO] [stdout] 978 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 306 | / if mapper.get_and_clear_eeprom_dirty_bit() { [INFO] [stdout] 307 | | return true; [INFO] [stdout] 308 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 305 ~ Mapper::BandaiFcg(mapper) [INFO] [stdout] 306 ~ if mapper.get_and_clear_eeprom_dirty_bit() => { [INFO] [stdout] 307 | return true; [INFO] [stdout] 308 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge.rs:311:17 [INFO] [stdout] | [INFO] [stdout] 311 | / if mapper.has_battery_backed_internal_ram() [INFO] [stdout] 312 | | && mapper.get_and_clear_internal_ram_dirty_bit() [INFO] [stdout] 313 | | { [INFO] [stdout] 314 | | return true; [INFO] [stdout] 315 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 310 ~ Mapper::Namco163(mapper) [INFO] [stdout] 311 | if mapper.has_battery_backed_internal_ram() [INFO] [stdout] 312 | && mapper.get_and_clear_internal_ram_dirty_bit() [INFO] [stdout] 313 ~ => { [INFO] [stdout] 314 | return true; [INFO] [stdout] 315 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | / if mapper.has_battery_backed_internal_ram() { [INFO] [stdout] 338 | | return mapper.get_internal_ram(); [INFO] [stdout] 339 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 336 ~ Mapper::Namco163(mapper) [INFO] [stdout] 337 ~ if mapper.has_battery_backed_internal_ram() => { [INFO] [stdout] 338 | return mapper.get_internal_ram(); [INFO] [stdout] 339 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/nes-core/src/bus.rs:318:1 [INFO] [stdout] | [INFO] [stdout] 318 | / impl Default for IoRegister { [INFO] [stdout] 319 | | fn default() -> Self { [INFO] [stdout] 320 | | Self::SQ1_VOL [INFO] [stdout] 321 | | } [INFO] [stdout] 322 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 292 + #[derive(Default)] [INFO] [stdout] 293 | pub enum IoRegister { [INFO] [stdout] 294 ~ #[default] [INFO] [stdout] 295 ~ SQ1_VOL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `dest_addr` is used as a loop counter [INFO] [stdout] --> backend/snes-coprocessors/src/cx4.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | for _ in 0..dma_len { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (dest_addr, _) in ((self.dma_destination_address - 0x6000).into()..).zip((0..dma_len))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `-W clippy::explicit-counter-loop` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::explicit_counter_loop)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 306 | / if mapper.get_and_clear_eeprom_dirty_bit() { [INFO] [stdout] 307 | | return true; [INFO] [stdout] 308 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 305 ~ Mapper::BandaiFcg(mapper) [INFO] [stdout] 306 ~ if mapper.get_and_clear_eeprom_dirty_bit() => { [INFO] [stdout] 307 | return true; [INFO] [stdout] 308 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge.rs:311:17 [INFO] [stdout] | [INFO] [stdout] 311 | / if mapper.has_battery_backed_internal_ram() [INFO] [stdout] 312 | | && mapper.get_and_clear_internal_ram_dirty_bit() [INFO] [stdout] 313 | | { [INFO] [stdout] 314 | | return true; [INFO] [stdout] 315 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 310 ~ Mapper::Namco163(mapper) [INFO] [stdout] 311 | if mapper.has_battery_backed_internal_ram() [INFO] [stdout] 312 | && mapper.get_and_clear_internal_ram_dirty_bit() [INFO] [stdout] 313 ~ => { [INFO] [stdout] 314 | return true; [INFO] [stdout] 315 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/nes-core/src/bus/cartridge.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | / if mapper.has_battery_backed_internal_ram() { [INFO] [stdout] 338 | | return mapper.get_internal_ram(); [INFO] [stdout] 339 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 336 ~ Mapper::Namco163(mapper) [INFO] [stdout] 337 ~ if mapper.has_battery_backed_internal_ram() => { [INFO] [stdout] 338 | return mapper.get_internal_ram(); [INFO] [stdout] 339 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/nes-core/src/bus.rs:693:6 [INFO] [stdout] | [INFO] [stdout] 693 | impl<'a> BusInterface for CpuBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 693 - impl<'a> BusInterface for CpuBus<'a> { [INFO] [stdout] 693 + impl BusInterface for CpuBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/nes-core/src/bus.rs:740:6 [INFO] [stdout] | [INFO] [stdout] 740 | impl<'a> CpuBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 740 - impl<'a> CpuBus<'a> { [INFO] [stdout] 740 + impl CpuBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/nes-core/src/bus.rs:899:6 [INFO] [stdout] | [INFO] [stdout] 899 | impl<'a> PpuBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 899 - impl<'a> PpuBus<'a> { [INFO] [stdout] 899 + impl PpuBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/nes-core/src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / impl Default for State { [INFO] [stdout] 23 | | fn default() -> Self { [INFO] [stdout] 24 | | Self::CpuExecuting [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Default)] [INFO] [stdout] 17 | enum State { [INFO] [stdout] 18 ~ #[default] [INFO] [stdout] 19 ~ CpuExecuting, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wgpu-hal v0.18.1 [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/nes-core/src/bus.rs:318:1 [INFO] [stdout] | [INFO] [stdout] 318 | / impl Default for IoRegister { [INFO] [stdout] 319 | | fn default() -> Self { [INFO] [stdout] 320 | | Self::SQ1_VOL [INFO] [stdout] 321 | | } [INFO] [stdout] 322 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 292 + #[derive(Default)] [INFO] [stdout] 293 | pub enum IoRegister { [INFO] [stdout] 294 ~ #[default] [INFO] [stdout] 295 ~ SQ1_VOL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-coprocessors/src/sa1/bus.rs:112:6 [INFO] [stdout] | [INFO] [stdout] 112 | impl<'a> BusInterface for Sa1Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 112 - impl<'a> BusInterface for Sa1Bus<'a> { [INFO] [stdout] 112 + impl BusInterface for Sa1Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `dest_addr` is used as a loop counter [INFO] [stdout] --> backend/snes-coprocessors/src/cx4.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | for _ in 0..dma_len { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `for (dest_addr, _) in ((self.dma_destination_address - 0x6000).into()..).zip((0..dma_len))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `-W clippy::explicit-counter-loop` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::explicit_counter_loop)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-coprocessors/src/sa1/registers.rs:156:1 [INFO] [stdout] | [INFO] [stdout] 156 | / impl Default for DmaState { [INFO] [stdout] 157 | | fn default() -> Self { [INFO] [stdout] 158 | | Self::Idle [INFO] [stdout] 159 | | } [INFO] [stdout] 160 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 147 + #[derive(Default)] [INFO] [stdout] 148 | pub enum DmaState { [INFO] [stdout] 149 ~ #[default] [INFO] [stdout] 150 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/nes-core/src/bus.rs:693:6 [INFO] [stdout] | [INFO] [stdout] 693 | impl<'a> BusInterface for CpuBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 693 - impl<'a> BusInterface for CpuBus<'a> { [INFO] [stdout] 693 + impl BusInterface for CpuBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/nes-core/src/bus.rs:740:6 [INFO] [stdout] | [INFO] [stdout] 740 | impl<'a> CpuBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 740 - impl<'a> CpuBus<'a> { [INFO] [stdout] 740 + impl CpuBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/nes-core/src/bus.rs:899:6 [INFO] [stdout] | [INFO] [stdout] 899 | impl<'a> PpuBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 899 - impl<'a> PpuBus<'a> { [INFO] [stdout] 899 + impl PpuBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/nes-core/src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / impl Default for State { [INFO] [stdout] 23 | | fn default() -> Self { [INFO] [stdout] 24 | | Self::CpuExecuting [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 16 + #[derive(Default)] [INFO] [stdout] 17 | enum State { [INFO] [stdout] 18 ~ #[default] [INFO] [stdout] 19 ~ CpuExecuting, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/genesis-core/src/ym2612/envelope.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 196 | if self.cycle_count % (1 << update_frequency_shift) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.cycle_count.is_multiple_of(1 << update_frequency_shift)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> backend/nes-core/src/ppu.rs:334:27 [INFO] [stdout] | [INFO] [stdout] 334 | frame_buffer: [[(0, ColorEmphasis::default()); SCREEN_WIDTH as usize]; [INFO] [stdout] | ___________________________^ [INFO] [stdout] 335 | | MAX_SCREEN_HEIGHT as usize], [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![[(0, ColorEmphasis::default()); SCREEN_WIDTH as usize]; [INFO] [stdout] MAX_SCREEN_HEIGHT as usize].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-coprocessors/src/sa1/bus.rs:112:6 [INFO] [stdout] | [INFO] [stdout] 112 | impl<'a> BusInterface for Sa1Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 112 - impl<'a> BusInterface for Sa1Bus<'a> { [INFO] [stdout] 112 + impl BusInterface for Sa1Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allocating a local array larger than 16384 bytes [INFO] [stdout] --> backend/nes-core/src/ppu.rs:334:27 [INFO] [stdout] | [INFO] [stdout] 334 | frame_buffer: [[(0, ColorEmphasis::default()); SCREEN_WIDTH as usize]; [INFO] [stdout] | ___________________________^ [INFO] [stdout] 335 | | MAX_SCREEN_HEIGHT as usize], [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider allocating on the heap with `vec![[(0, ColorEmphasis::default()); SCREEN_WIDTH as usize]; [INFO] [stdout] MAX_SCREEN_HEIGHT as usize].into_boxed_slice()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-coprocessors/src/sa1/registers.rs:156:1 [INFO] [stdout] | [INFO] [stdout] 156 | / impl Default for DmaState { [INFO] [stdout] 157 | | fn default() -> Self { [INFO] [stdout] 158 | | Self::Idle [INFO] [stdout] 159 | | } [INFO] [stdout] 160 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 147 + #[derive(Default)] [INFO] [stdout] 148 | pub enum DmaState { [INFO] [stdout] 149 ~ #[default] [INFO] [stdout] 150 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking segacd-core v0.7.1 (/opt/rustwide/workdir/backend/segacd-core) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[ignore]` without reason [INFO] [stdout] --> backend/segacd-core/src/memory/wordram.rs:539:5 [INFO] [stdout] | [INFO] [stdout] 539 | #[ignore] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: add a reason with `= ".."` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignore_without_reason [INFO] [stdout] = note: `-W clippy::ignore-without-reason` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::ignore_without_reason)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/snes-coprocessors/src/spc7110.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | / if self.registers.sram_enabled { [INFO] [stdout] 135 | | let sram_addr = address & 0x1FFF; [INFO] [stdout] 136 | | self.sram[sram_addr as usize] = value; [INFO] [stdout] 137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ (0x00..=0x3F | 0x80..=0xBF, 0x6000..=0x7FFF) [INFO] [stdout] 133 | // SRAM (always 8KB) [INFO] [stdout] 134 ~ if self.registers.sram_enabled => { [INFO] [stdout] 135 | let sram_addr = address & 0x1FFF; [INFO] [stdout] 136 | self.sram[sram_addr as usize] = value; [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-coprocessors/src/srtc.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl Default for ReadState { [INFO] [stdout] 17 | | fn default() -> Self { [INFO] [stdout] 18 | | Self::Ack [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 10 + #[derive(Default)] [INFO] [stdout] 11 | enum ReadState { [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Ack, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-coprocessors/src/srtc.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / impl Default for WriteState { [INFO] [stdout] 31 | | fn default() -> Self { [INFO] [stdout] 32 | | Self::Start [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 23 + #[derive(Default)] [INFO] [stdout] 24 | enum WriteState { [INFO] [stdout] 25 ~ #[default] [INFO] [stdout] 26 ~ Start, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/snes-coprocessors/src/spc7110.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | / if self.registers.sram_enabled { [INFO] [stdout] 135 | | let sram_addr = address & 0x1FFF; [INFO] [stdout] 136 | | self.sram[sram_addr as usize] = value; [INFO] [stdout] 137 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ (0x00..=0x3F | 0x80..=0xBF, 0x6000..=0x7FFF) [INFO] [stdout] 133 | // SRAM (always 8KB) [INFO] [stdout] 134 ~ if self.registers.sram_enabled => { [INFO] [stdout] 135 | let sram_addr = address & 0x1FFF; [INFO] [stdout] 136 | self.sram[sram_addr as usize] = value; [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-coprocessors/src/srtc.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl Default for ReadState { [INFO] [stdout] 17 | | fn default() -> Self { [INFO] [stdout] 18 | | Self::Ack [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 10 + #[derive(Default)] [INFO] [stdout] 11 | enum ReadState { [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Ack, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-coprocessors/src/srtc.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / impl Default for WriteState { [INFO] [stdout] 31 | | fn default() -> Self { [INFO] [stdout] 32 | | Self::Start [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 23 + #[derive(Default)] [INFO] [stdout] 24 | enum WriteState { [INFO] [stdout] 25 ~ #[default] [INFO] [stdout] 26 ~ Start, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking egui_glow v0.25.0 [INFO] [stderr] Checking egui_extras v0.25.0 [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/snes-coprocessors/src/superfx.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / if !self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes { [INFO] [stdout] 108 | | self.ram[(address & 0x1FFF) as usize] = value; [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ (0x00..=0x3F | 0x80..=0xBF, 0x6000..=0x7FFF) [INFO] [stdout] 106 | // First 8KB of RAM [INFO] [stdout] 107 ~ if (!self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes) => { [INFO] [stdout] 108 | self.ram[(address & 0x1FFF) as usize] = value; [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/snes-coprocessors/src/superfx.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | / if !self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes { [INFO] [stdout] 114 | | self.ram[(address as usize) & (self.ram.len() - 1)] = value; [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 111 ~ (0x70..=0x71 | 0xF0..=0xF1, _) [INFO] [stdout] 112 | // RAM [INFO] [stdout] 113 ~ if (!self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes) => { [INFO] [stdout] 114 | self.ram[(address as usize) & (self.ram.len() - 1)] = value; [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/snes-coprocessors/src/upd77c25.rs:332:10 [INFO] [stdout] | [INFO] [stdout] 332 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/snes-coprocessors/src/superfx.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / if !self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes { [INFO] [stdout] 108 | | self.ram[(address & 0x1FFF) as usize] = value; [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ (0x00..=0x3F | 0x80..=0xBF, 0x6000..=0x7FFF) [INFO] [stdout] 106 | // First 8KB of RAM [INFO] [stdout] 107 ~ if (!self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes) => { [INFO] [stdout] 108 | self.ram[(address & 0x1FFF) as usize] = value; [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> backend/snes-coprocessors/src/superfx.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | / if !self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes { [INFO] [stdout] 114 | | self.ram[(address as usize) & (self.ram.len() - 1)] = value; [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 111 ~ (0x70..=0x71 | 0xF0..=0xF1, _) [INFO] [stdout] 112 | // RAM [INFO] [stdout] 113 ~ if (!self.gsu.is_running() || self.gsu.ram_access() == BusAccess::Snes) => { [INFO] [stdout] 114 | self.ram[(address as usize) & (self.ram.len() - 1)] = value; [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking snes-core v0.7.1 (/opt/rustwide/workdir/backend/snes-core) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> backend/snes-coprocessors/src/upd77c25.rs:332:10 [INFO] [stdout] | [INFO] [stdout] 332 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/segacd-core/src/cddrive/cdd.rs:91:1 [INFO] [stdout] | [INFO] [stdout] 91 | / impl Default for ReportType { [INFO] [stdout] 92 | | fn default() -> Self { [INFO] [stdout] 93 | | Self::AbsoluteTime [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 49 + #[derive(Default)] [INFO] [stdout] 50 | enum ReportType { [INFO] [stdout] 51 ~ #[default] [INFO] [stdout] 52 ~ AbsoluteTime, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/segacd-core/src/cddrive/cdd.rs:163:1 [INFO] [stdout] | [INFO] [stdout] 163 | / impl Default for State { [INFO] [stdout] 164 | | fn default() -> Self { [INFO] [stdout] 165 | | Self::MotorStopped [INFO] [stdout] 166 | | } [INFO] [stdout] 167 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 104 + #[derive(Default)] [INFO] [stdout] 105 | enum State { [INFO] [stdout] 106 ~ #[default] [INFO] [stdout] 107 ~ MotorStopped, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/segacd-core/src/cddrive/cdd.rs:91:1 [INFO] [stdout] | [INFO] [stdout] 91 | / impl Default for ReportType { [INFO] [stdout] 92 | | fn default() -> Self { [INFO] [stdout] 93 | | Self::AbsoluteTime [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 49 + #[derive(Default)] [INFO] [stdout] 50 | enum ReportType { [INFO] [stdout] 51 ~ #[default] [INFO] [stdout] 52 ~ AbsoluteTime, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/segacd-core/src/cddrive/cdd.rs:163:1 [INFO] [stdout] | [INFO] [stdout] 163 | / impl Default for State { [INFO] [stdout] 164 | | fn default() -> Self { [INFO] [stdout] 165 | | Self::MotorStopped [INFO] [stdout] 166 | | } [INFO] [stdout] 167 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 104 + #[derive(Default)] [INFO] [stdout] 105 | enum State { [INFO] [stdout] 106 ~ #[default] [INFO] [stdout] 107 ~ MotorStopped, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/segacd-core/src/memory.rs:783:6 [INFO] [stdout] | [INFO] [stdout] 783 | impl<'a> SubBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 783 - impl<'a> SubBus<'a> { [INFO] [stdout] 783 + impl SubBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/segacd-core/src/memory.rs:1231:6 [INFO] [stdout] | [INFO] [stdout] 1231 | impl<'a> BusInterface for SubBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1231 - impl<'a> BusInterface for SubBus<'a> { [INFO] [stdout] 1231 + impl BusInterface for SubBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/segacd-core/src/memory.rs:783:6 [INFO] [stdout] | [INFO] [stdout] 783 | impl<'a> SubBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 783 - impl<'a> SubBus<'a> { [INFO] [stdout] 783 + impl SubBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/segacd-core/src/memory.rs:1231:6 [INFO] [stdout] | [INFO] [stdout] 1231 | impl<'a> BusInterface for SubBus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 1231 - impl<'a> BusInterface for SubBus<'a> { [INFO] [stdout] 1231 + impl BusInterface for SubBus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/snes-core/src/api.rs:312:24 [INFO] [stdout] | [INFO] [stdout] 312 | if self.frame_count % 30 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/snes-core/src/apu/dsp.rs:523:16 [INFO] [stdout] | [INFO] [stdout] 523 | && (global_counter + ENVELOPE_OFFSET_TABLE[rate as usize]) [INFO] [stdout] | ________________^ [INFO] [stdout] 524 | | % ENVELOPE_RATE_TABLE[rate as usize] [INFO] [stdout] 525 | | == 0 [INFO] [stdout] | |____________________^ help: replace with: `(global_counter + ENVELOPE_OFFSET_TABLE[rate as usize]).is_multiple_of(ENVELOPE_RATE_TABLE[rate as usize])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/snes-core/src/apu/dsp.rs:624:16 [INFO] [stdout] | [INFO] [stdout] 624 | && (global_counter + ENVELOPE_OFFSET_TABLE[rate]) % ENVELOPE_RATE_TABLE[rate] == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(global_counter + ENVELOPE_OFFSET_TABLE[rate]).is_multiple_of(ENVELOPE_RATE_TABLE[rate])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-core/src/apu.rs:164:6 [INFO] [stdout] | [INFO] [stdout] 164 | impl<'a> BusInterface for Spc700Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 164 - impl<'a> BusInterface for Spc700Bus<'a> { [INFO] [stdout] 164 + impl BusInterface for Spc700Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-core/src/bus.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | impl<'a> Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 35 - impl<'a> Bus<'a> { [INFO] [stdout] 35 + impl Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-core/src/bus.rs:192:6 [INFO] [stdout] | [INFO] [stdout] 192 | impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 192 - impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] 192 + impl BusInterface for Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `is_power_of_two` [INFO] [stdout] --> backend/snes-core/src/memory/cartridge.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 129 | if rom_len.count_ones() == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `rom_len.is_power_of_two()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two [INFO] [stdout] = note: `-W clippy::manual-is-power-of-two` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::manual_is_power_of_two)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-core/src/memory/dma.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / impl Default for GpDmaState { [INFO] [stdout] 20 | | fn default() -> Self { [INFO] [stdout] 21 | | Self::Idle [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 13 + #[derive(Default)] [INFO] [stdout] 14 | enum GpDmaState { [INFO] [stdout] 15 ~ #[default] [INFO] [stdout] 16 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-core/src/memory/dma.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for HDmaState { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::Idle [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | enum HDmaState { [INFO] [stdout] 28 ~ #[default] [INFO] [stdout] 29 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wgpu-core v0.18.1 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/snes-core/src/api.rs:312:24 [INFO] [stdout] | [INFO] [stdout] 312 | if self.frame_count % 30 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/snes-core/src/apu/dsp.rs:523:16 [INFO] [stdout] | [INFO] [stdout] 523 | && (global_counter + ENVELOPE_OFFSET_TABLE[rate as usize]) [INFO] [stdout] | ________________^ [INFO] [stdout] 524 | | % ENVELOPE_RATE_TABLE[rate as usize] [INFO] [stdout] 525 | | == 0 [INFO] [stdout] | |____________________^ help: replace with: `(global_counter + ENVELOPE_OFFSET_TABLE[rate as usize]).is_multiple_of(ENVELOPE_RATE_TABLE[rate as usize])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> backend/snes-core/src/apu/dsp.rs:624:16 [INFO] [stdout] | [INFO] [stdout] 624 | && (global_counter + ENVELOPE_OFFSET_TABLE[rate]) % ENVELOPE_RATE_TABLE[rate] == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(global_counter + ENVELOPE_OFFSET_TABLE[rate]).is_multiple_of(ENVELOPE_RATE_TABLE[rate])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-core/src/apu.rs:164:6 [INFO] [stdout] | [INFO] [stdout] 164 | impl<'a> BusInterface for Spc700Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 164 - impl<'a> BusInterface for Spc700Bus<'a> { [INFO] [stdout] 164 + impl BusInterface for Spc700Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-core/src/bus.rs:35:6 [INFO] [stdout] | [INFO] [stdout] 35 | impl<'a> Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 35 - impl<'a> Bus<'a> { [INFO] [stdout] 35 + impl Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> backend/snes-core/src/bus.rs:192:6 [INFO] [stdout] | [INFO] [stdout] 192 | impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 192 - impl<'a> BusInterface for Bus<'a> { [INFO] [stdout] 192 + impl BusInterface for Bus<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `is_power_of_two` [INFO] [stdout] --> backend/snes-core/src/memory/cartridge.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 129 | if rom_len.count_ones() == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `rom_len.is_power_of_two()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two [INFO] [stdout] = note: `-W clippy::manual-is-power-of-two` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::manual_is_power_of_two)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-core/src/memory/dma.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / impl Default for GpDmaState { [INFO] [stdout] 20 | | fn default() -> Self { [INFO] [stdout] 21 | | Self::Idle [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `-W clippy::derivable-impls` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 13 + #[derive(Default)] [INFO] [stdout] 14 | enum GpDmaState { [INFO] [stdout] 15 ~ #[default] [INFO] [stdout] 16 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> backend/snes-core/src/memory/dma.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for HDmaState { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::Idle [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | enum HDmaState { [INFO] [stdout] 28 ~ #[default] [INFO] [stdout] 29 ~ Idle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking wgpu v0.18.0 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking egui_wgpu_backend v0.27.0 (https://github.com/jsgroth/egui_wgpu_backend#198d0da0) [INFO] [stderr] Checking jgenesis-renderer v0.7.1 (/opt/rustwide/workdir/frontend/jgenesis-renderer) [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> frontend/jgenesis-renderer/src/renderer.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Vertex { [INFO] [stdout] | ^^^^^^ field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check` is never used [INFO] [stdout] --> frontend/jgenesis-renderer/src/renderer.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / #[repr(C)] [INFO] [stdout] 10 | | #[derive(Debug, Clone, Copy, bytemuck::Pod, bytemuck::Zeroable)] [INFO] [stdout] 11 | | struct Vertex { [INFO] [stdout] 12 | | position: [f32; 2], [INFO] [stdout] 13 | | texture_coords: [f32; 2], [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> frontend/jgenesis-renderer/src/renderer.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Vertex { [INFO] [stdout] | ^^^^^^ field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check` is never used [INFO] [stdout] --> frontend/jgenesis-renderer/src/renderer.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / #[repr(C)] [INFO] [stdout] 10 | | #[derive(Debug, Clone, Copy, bytemuck::Pod, bytemuck::Zeroable)] [INFO] [stdout] 11 | | struct Vertex { [INFO] [stdout] 12 | | position: [f32; 2], [INFO] [stdout] 13 | | texture_coords: [f32; 2], [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-renderer/src/renderer.rs:994:12 [INFO] [stdout] | [INFO] [stdout] 994 | if self.frame_count % self.speed_multiplier != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.frame_count.is_multiple_of(self.speed_multiplier)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-renderer/src/renderer.rs:994:12 [INFO] [stdout] | [INFO] [stdout] 994 | if self.frame_count % self.speed_multiplier != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.frame_count.is_multiple_of(self.speed_multiplier)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking jgenesis-native-driver v0.7.1 (/opt/rustwide/workdir/frontend/jgenesis-native-driver) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking accesskit_winit v0.16.1 [INFO] [stderr] Checking egui-winit v0.25.0 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking eframe v0.25.0 [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/audio.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if self.sample_count % self.speed_multiplier != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.sample_count.is_multiple_of(self.speed_multiplier)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug/eguisdl.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | / match win_event { [INFO] [stdout] 45 | | SdlWindowEvent::Resized(width, height) [INFO] [stdout] 46 | | | SdlWindowEvent::SizeChanged(width, height) => { [INFO] [stdout] 47 | | self.raw_input.screen_rect = Some(egui::Rect::from_min_size( [INFO] [stdout] ... | [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug/eguisdl.rs:43:43 [INFO] [stdout] | [INFO] [stdout] 43 | SdlEvent::Window { window_id, win_event, .. } if window_id == self.window_id => { [INFO] [stdout] | ^^^^^^^^^ replace this binding [INFO] [stdout] 44 | match win_event { [INFO] [stdout] 45 | / SdlWindowEvent::Resized(width, height) [INFO] [stdout] 46 | | | SdlWindowEvent::SizeChanged(width, height) => { [INFO] [stdout] | |________________________________________________________________^ with this pattern, prefixed by `win_event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/audio.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if self.sample_count % self.speed_multiplier != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.sample_count.is_multiple_of(self.speed_multiplier)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug/eguisdl.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | / match win_event { [INFO] [stdout] 45 | | SdlWindowEvent::Resized(width, height) [INFO] [stdout] 46 | | | SdlWindowEvent::SizeChanged(width, height) => { [INFO] [stdout] 47 | | self.raw_input.screen_rect = Some(egui::Rect::from_min_size( [INFO] [stdout] ... | [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug/eguisdl.rs:43:43 [INFO] [stdout] | [INFO] [stdout] 43 | SdlEvent::Window { window_id, win_event, .. } if window_id == self.window_id => { [INFO] [stdout] | ^^^^^^^^^ replace this binding [INFO] [stdout] 44 | match win_event { [INFO] [stdout] 45 | / SdlWindowEvent::Resized(width, height) [INFO] [stdout] 46 | | | SdlWindowEvent::SizeChanged(width, height) => { [INFO] [stdout] | |________________________________________________________________^ with this pattern, prefixed by `win_event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `-W clippy::collapsible-match` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::collapsible_match)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | / match win_event { [INFO] [stdout] 191 | | WindowEvent::Resized(..) | WindowEvent::SizeChanged(..) => { [INFO] [stdout] 192 | | let (width, height) = self.window.size(); [INFO] [stdout] 193 | | self.surface_config.width = width; [INFO] [stdout] ... | [INFO] [stdout] 197 | | _ => {} [INFO] [stdout] 198 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug.rs:189:40 [INFO] [stdout] | [INFO] [stdout] 189 | Event::Window { window_id, win_event, .. } if *window_id == self.window.id() => { [INFO] [stdout] | ^^^^^^^^^ replace this binding [INFO] [stdout] 190 | match win_event { [INFO] [stdout] 191 | WindowEvent::Resized(..) | WindowEvent::SizeChanged(..) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `win_event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 272 | impl<'a, T: Copy + PartialEq> Widget for SelectableButton<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 272 - impl<'a, T: Copy + PartialEq> Widget for SelectableButton<'a, T> { [INFO] [stdout] 272 + impl Widget for SelectableButton<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/rewind.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if self.frame_count % FRAME_DIVIDER == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(FRAME_DIVIDER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | / match win_event { [INFO] [stdout] 191 | | WindowEvent::Resized(..) | WindowEvent::SizeChanged(..) => { [INFO] [stdout] 192 | | let (width, height) = self.window.size(); [INFO] [stdout] 193 | | self.surface_config.width = width; [INFO] [stdout] ... | [INFO] [stdout] 197 | | _ => {} [INFO] [stdout] 198 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug.rs:189:40 [INFO] [stdout] | [INFO] [stdout] 189 | Event::Window { window_id, win_event, .. } if *window_id == self.window.id() => { [INFO] [stdout] | ^^^^^^^^^ replace this binding [INFO] [stdout] 190 | match win_event { [INFO] [stdout] 191 | WindowEvent::Resized(..) | WindowEvent::SizeChanged(..) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `win_event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/debug.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 272 | impl<'a, T: Copy + PartialEq> Widget for SelectableButton<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 272 - impl<'a, T: Copy + PartialEq> Widget for SelectableButton<'a, T> { [INFO] [stdout] 272 + impl Widget for SelectableButton<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-native-driver/src/mainloop/rewind.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if self.frame_count % FRAME_DIVIDER == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(FRAME_DIVIDER)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking jgenesis-gui v0.7.1 (/opt/rustwide/workdir/frontend/jgenesis-gui) [INFO] [stderr] Checking jgenesis-cli v0.7.1 (/opt/rustwide/workdir/frontend/jgenesis-cli) [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] 56 + /// Hardware (`MasterSystem` / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:56:44 [INFO] [stdout] | [INFO] [stdout] 56 | /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] 56 + /// Hardware (MasterSystem / Genesis / `SegaCd` / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (`NtscMasterSystem2` / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:48 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / `NtscMasterSystem1` / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:68 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / `PalMasterSystem2` / PalMasterSystem1 / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:87 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / `PalMasterSystem1` / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:106 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / `GameGear`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:76:28 [INFO] [stdout] | [INFO] [stdout] 76 | /// Force PSG version (MasterSystem2 / Standard) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 - /// Force PSG version (MasterSystem2 / Standard) [INFO] [stdout] 76 + /// Force PSG version (`MasterSystem2` / Standard) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:80:50 [INFO] [stdout] | [INFO] [stdout] 80 | /// Master System aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 80 - /// Master System aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 80 + /// Master System aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:84:33 [INFO] [stdout] | [INFO] [stdout] 84 | /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] 84 + /// Game Gear aspect ratio (`GgLcd` / SquarePixels / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:84:41 [INFO] [stdout] | [INFO] [stdout] 84 | /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] 84 + /// Game Gear aspect ratio (GgLcd / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 124 - /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 124 + /// Aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:149:36 [INFO] [stdout] | [INFO] [stdout] 149 | /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 - /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 149 + /// Aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:185:41 [INFO] [stdout] | [INFO] [stdout] 185 | /// SNES aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - /// SNES aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 185 + /// SNES aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:197:42 [INFO] [stdout] | [INFO] [stdout] 197 | /// Player 2 input device (Gamepad / SuperScope) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 197 - /// Player 2 input device (Gamepad / SuperScope) [INFO] [stdout] 197 + /// Player 2 input device (Gamepad / `SuperScope`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:233:23 [INFO] [stdout] | [INFO] [stdout] 233 | /// Aspect ratio (SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - /// Aspect ratio (SquarePixels / Stretched) [INFO] [stdout] 233 + /// Aspect ratio (`SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:237:27 [INFO] [stdout] | [INFO] [stdout] 237 | /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 - /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] 237 + /// Game Boy palette (`BlackAndWhite` / GreenTint / LimeGreen) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:237:43 [INFO] [stdout] | [INFO] [stdout] 237 | /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 - /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] 237 + /// Game Boy palette (BlackAndWhite / `GreenTint` / LimeGreen) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:237:55 [INFO] [stdout] | [INFO] [stdout] 237 | /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 - /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] 237 + /// Game Boy palette (BlackAndWhite / GreenTint / `LimeGreen`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:241:49 [INFO] [stdout] | [INFO] [stdout] 241 | /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 241 - /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] 241 + /// Game Boy Color color correction (None / `GbcLcd` / GbaLcd) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:241:58 [INFO] [stdout] | [INFO] [stdout] 241 | /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 241 - /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] 241 + /// Game Boy Color color correction (None / GbcLcd / `GbaLcd`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:261:39 [INFO] [stdout] | [INFO] [stdout] 261 | /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] 261 + /// wgpu backend (Auto / Vulkan / `DirectX12` / OpenGl) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:261:51 [INFO] [stdout] | [INFO] [stdout] 261 | /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] 261 + /// wgpu backend (Auto / Vulkan / DirectX12 / `OpenGl`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | /// VSync mode (Enabled / Disabled / Fast) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 265 - /// VSync mode (Enabled / Disabled / Fast) [INFO] [stdout] 265 + /// `VSync` mode (Enabled / Disabled / Fast) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:35 [INFO] [stdout] | [INFO] [stdout] 285 | /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / `HorizontalBlurTwoPixels` / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:61 [INFO] [stdout] | [INFO] [stdout] 285 | /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / `HorizontalBlurThreePixels` / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:89 [INFO] [stdout] | [INFO] [stdout] 285 | /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / `HorizontalBlurSnesAdaptive` / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:118 [INFO] [stdout] | [INFO] [stdout] 285 | ...HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / `AntiDitherWeak` / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:135 [INFO] [stdout] | [INFO] [stdout] 285 | ...ePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / `AntiDitherStrong`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:309:37 [INFO] [stdout] | [INFO] [stdout] 309 | /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 309 - /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] 309 + /// P1 Genesis controller type (`ThreeButton` / SixButton) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:309:51 [INFO] [stdout] | [INFO] [stdout] 309 | /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 309 - /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] 309 + /// P1 Genesis controller type (ThreeButton / `SixButton`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] 56 + /// Hardware (`MasterSystem` / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:56:44 [INFO] [stdout] | [INFO] [stdout] 56 | /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - /// Hardware (MasterSystem / Genesis / SegaCd / Nes / Snes), will default based on file extension if not set [INFO] [stdout] 56 + /// Hardware (MasterSystem / Genesis / `SegaCd` / Nes / Snes), will default based on file extension if not set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (`NtscMasterSystem2` / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:48 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / `NtscMasterSystem1` / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:68 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / `PalMasterSystem2` / PalMasterSystem1 / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:87 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / `PalMasterSystem1` / GameGear) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:72:106 [INFO] [stdout] | [INFO] [stdout] 72 | /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / GameGear) [INFO] [stdout] 72 + /// Force VDP version (NtscMasterSystem2 / NtscMasterSystem1 / PalMasterSystem2 / PalMasterSystem1 / `GameGear`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:76:28 [INFO] [stdout] | [INFO] [stdout] 76 | /// Force PSG version (MasterSystem2 / Standard) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 - /// Force PSG version (MasterSystem2 / Standard) [INFO] [stdout] 76 + /// Force PSG version (`MasterSystem2` / Standard) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:80:50 [INFO] [stdout] | [INFO] [stdout] 80 | /// Master System aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 80 - /// Master System aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 80 + /// Master System aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:84:33 [INFO] [stdout] | [INFO] [stdout] 84 | /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] 84 + /// Game Gear aspect ratio (`GgLcd` / SquarePixels / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:84:41 [INFO] [stdout] | [INFO] [stdout] 84 | /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - /// Game Gear aspect ratio (GgLcd / SquarePixels / Stretched) [INFO] [stdout] 84 + /// Game Gear aspect ratio (GgLcd / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 124 - /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 124 + /// Aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:149:36 [INFO] [stdout] | [INFO] [stdout] 149 | /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 - /// Aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 149 + /// Aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:185:41 [INFO] [stdout] | [INFO] [stdout] 185 | /// SNES aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - /// SNES aspect ratio (Ntsc / Pal / SquarePixels / Stretched) [INFO] [stdout] 185 + /// SNES aspect ratio (Ntsc / Pal / `SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:197:42 [INFO] [stdout] | [INFO] [stdout] 197 | /// Player 2 input device (Gamepad / SuperScope) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 197 - /// Player 2 input device (Gamepad / SuperScope) [INFO] [stdout] 197 + /// Player 2 input device (Gamepad / `SuperScope`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:233:23 [INFO] [stdout] | [INFO] [stdout] 233 | /// Aspect ratio (SquarePixels / Stretched) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - /// Aspect ratio (SquarePixels / Stretched) [INFO] [stdout] 233 + /// Aspect ratio (`SquarePixels` / Stretched) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:237:27 [INFO] [stdout] | [INFO] [stdout] 237 | /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 - /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] 237 + /// Game Boy palette (`BlackAndWhite` / GreenTint / LimeGreen) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:237:43 [INFO] [stdout] | [INFO] [stdout] 237 | /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 - /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] 237 + /// Game Boy palette (BlackAndWhite / `GreenTint` / LimeGreen) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:237:55 [INFO] [stdout] | [INFO] [stdout] 237 | /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 - /// Game Boy palette (BlackAndWhite / GreenTint / LimeGreen) [INFO] [stdout] 237 + /// Game Boy palette (BlackAndWhite / GreenTint / `LimeGreen`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:241:49 [INFO] [stdout] | [INFO] [stdout] 241 | /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 241 - /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] 241 + /// Game Boy Color color correction (None / `GbcLcd` / GbaLcd) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:241:58 [INFO] [stdout] | [INFO] [stdout] 241 | /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 241 - /// Game Boy Color color correction (None / GbcLcd / GbaLcd) [INFO] [stdout] 241 + /// Game Boy Color color correction (None / GbcLcd / `GbaLcd`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:261:39 [INFO] [stdout] | [INFO] [stdout] 261 | /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] 261 + /// wgpu backend (Auto / Vulkan / `DirectX12` / OpenGl) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:261:51 [INFO] [stdout] | [INFO] [stdout] 261 | /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - /// wgpu backend (Auto / Vulkan / DirectX12 / OpenGl) [INFO] [stdout] 261 + /// wgpu backend (Auto / Vulkan / DirectX12 / `OpenGl`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | /// VSync mode (Enabled / Disabled / Fast) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 265 - /// VSync mode (Enabled / Disabled / Fast) [INFO] [stdout] 265 + /// `VSync` mode (Enabled / Disabled / Fast) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:35 [INFO] [stdout] | [INFO] [stdout] 285 | /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / `HorizontalBlurTwoPixels` / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:61 [INFO] [stdout] | [INFO] [stdout] 285 | /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / `HorizontalBlurThreePixels` / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:89 [INFO] [stdout] | [INFO] [stdout] 285 | /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / `HorizontalBlurSnesAdaptive` / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:118 [INFO] [stdout] | [INFO] [stdout] 285 | ...HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / `AntiDitherWeak` / AntiDitherStrong) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:285:135 [INFO] [stdout] | [INFO] [stdout] 285 | ...ePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 285 - /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / AntiDitherStrong) [INFO] [stdout] 285 + /// Preprocess shader (None / HorizontalBlurTwoPixels / HorizontalBlurThreePixels / HorizontalBlurSnesAdaptive / AntiDitherWeak / `AntiDitherStrong`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:309:37 [INFO] [stdout] | [INFO] [stdout] 309 | /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 309 - /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] 309 + /// P1 Genesis controller type (`ThreeButton` / SixButton) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item in documentation is missing backticks [INFO] [stdout] --> frontend/jgenesis-cli/src/main.rs:309:51 [INFO] [stdout] | [INFO] [stdout] 309 | /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 309 - /// P1 Genesis controller type (ThreeButton / SixButton) [INFO] [stdout] 309 + /// P1 Genesis controller type (ThreeButton / `SixButton`) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-gui/src/app.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | && (config.common.prescale_factor.get() % 2 != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!config.common.prescale_factor.get().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> frontend/jgenesis-gui/src/app.rs:275:6 [INFO] [stdout] | [INFO] [stdout] 275 | impl<'a, T: Copy + FromStr> Widget for NumericTextEdit<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 275 - impl<'a, T: Copy + FromStr> Widget for NumericTextEdit<'a, T> { [INFO] [stdout] 275 + impl Widget for NumericTextEdit<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: assigning the result of `Clone::clone()` may be inefficient [INFO] [stdout] --> frontend/jgenesis-gui/src/app.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | self.state.current_file_path = path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.state.current_file_path.clone_from(&path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones [INFO] [stdout] = note: `-W clippy::assigning-clones` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::assigning_clones)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> frontend/jgenesis-gui/src/emuthread.rs:336:1 [INFO] [stdout] | [INFO] [stdout] 336 | / enum GenericEmulator { [INFO] [stdout] 337 | | SmsGg(NativeSmsGgEmulator), [INFO] [stdout] | | -------------------------- the second-largest variant contains at least 29232 bytes [INFO] [stdout] 338 | | Genesis(NativeGenesisEmulator), [INFO] [stdout] 339 | | SegaCd(NativeSegaCdEmulator), [INFO] [stdout] 340 | | Nes(NativeNesEmulator), [INFO] [stdout] | | ---------------------- the largest variant contains at least 133304 bytes [INFO] [stdout] 341 | | Snes(NativeSnesEmulator), [INFO] [stdout] 342 | | GameBoy(NativeGameBoyEmulator), [INFO] [stdout] 343 | | } [INFO] [stdout] | |_^ the entire enum is at least 133312 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `-W clippy::large-enum-variant` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::large_enum_variant)]` [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 340 - Nes(NativeNesEmulator), [INFO] [stdout] 340 + Nes(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> frontend/jgenesis-gui/src/app.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | && (config.common.prescale_factor.get() % 2 != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!config.common.prescale_factor.get().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `-W clippy::manual-is-multiple-of` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::manual_is_multiple_of)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> frontend/jgenesis-gui/src/app.rs:275:6 [INFO] [stdout] | [INFO] [stdout] 275 | impl<'a, T: Copy + FromStr> Widget for NumericTextEdit<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 275 - impl<'a, T: Copy + FromStr> Widget for NumericTextEdit<'a, T> { [INFO] [stdout] 275 + impl Widget for NumericTextEdit<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: assigning the result of `Clone::clone()` may be inefficient [INFO] [stdout] --> frontend/jgenesis-gui/src/app.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | self.state.current_file_path = path.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.state.current_file_path.clone_from(&path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones [INFO] [stdout] = note: `-W clippy::assigning-clones` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::assigning_clones)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> frontend/jgenesis-gui/src/emuthread.rs:336:1 [INFO] [stdout] | [INFO] [stdout] 336 | / enum GenericEmulator { [INFO] [stdout] 337 | | SmsGg(NativeSmsGgEmulator), [INFO] [stdout] | | -------------------------- the second-largest variant contains at least 29232 bytes [INFO] [stdout] 338 | | Genesis(NativeGenesisEmulator), [INFO] [stdout] 339 | | SegaCd(NativeSegaCdEmulator), [INFO] [stdout] 340 | | Nes(NativeNesEmulator), [INFO] [stdout] | | ---------------------- the largest variant contains at least 133304 bytes [INFO] [stdout] 341 | | Snes(NativeSnesEmulator), [INFO] [stdout] 342 | | GameBoy(NativeGameBoyEmulator), [INFO] [stdout] 343 | | } [INFO] [stdout] | |_^ the entire enum is at least 133312 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `-W clippy::large-enum-variant` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::large_enum_variant)]` [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 340 - Nes(NativeNesEmulator), [INFO] [stdout] 340 + Nes(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `clippy::string_to_string` has been removed: `clippy::implicit_clone` covers those cases [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W clippy::string_to_string` [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint group `all` has the same priority (0) as a lint [INFO] [stdout] --> Cargo.toml:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | all = "warn" [INFO] [stdout] | ^^^ ------ has an implicit priority of 0 [INFO] [stdout] ... [INFO] [stdout] 112 | verbose_bit_mask = "allow" [INFO] [stdout] | ---------------- has the same priority as this lint [INFO] [stdout] | [INFO] [stdout] = note: the order of the lints in the table is ignored by Cargo [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority [INFO] [stdout] = note: `-W clippy::lint-groups-priority` implied by `-W clippy::all` [INFO] [stdout] = help: to override `-W clippy::all` add `#[allow(clippy::lint_groups_priority)]` [INFO] [stdout] help: to have lints override the group set `all` to a lower priority [INFO] [stdout] | [INFO] [stdout] 76 - all = "warn" [INFO] [stdout] 76 + all = { level = "warn", priority = -1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 37s [INFO] running `Command { std: "docker" "inspect" "77523a7df63c75ac631f74816f26a39e01a64f1da44b3713ef765fd2fc3387ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77523a7df63c75ac631f74816f26a39e01a64f1da44b3713ef765fd2fc3387ce", kill_on_drop: false }` [INFO] [stdout] 77523a7df63c75ac631f74816f26a39e01a64f1da44b3713ef765fd2fc3387ce