[INFO] cloning repository https://github.com/HeatXD/chip8emu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HeatXD/chip8emu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHeatXD%2Fchip8emu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHeatXD%2Fchip8emu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f4bab079befb1971f0d83bd6ade34a25b5c643c4 [INFO] linting HeatXD/chip8emu against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHeatXD%2Fchip8emu" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HeatXD/chip8emu [INFO] finished tweaking git repo https://github.com/HeatXD/chip8emu [INFO] tweaked toml for git repo https://github.com/HeatXD/chip8emu written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HeatXD/chip8emu on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HeatXD/chip8emu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded macroquad_macro v0.1.7 [INFO] [stderr] Downloaded audir-sles v0.1.0 [INFO] [stderr] Downloaded quad-rand v0.2.1 [INFO] [stderr] Downloaded ogg v0.7.1 [INFO] [stderr] Downloaded quad-alsa-sys v0.3.2 [INFO] [stderr] Downloaded audrey v0.3.0 [INFO] [stderr] Downloaded miniquad v0.4.0 [INFO] [stderr] Downloaded macroquad v0.4.5 [INFO] [stderr] Downloaded quad-snd v0.2.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4dc06c12d09bf50dc11734e5f61a77d638f71c3616c937154cd306172049cde [INFO] running `Command { std: "docker" "start" "-a" "e4dc06c12d09bf50dc11734e5f61a77d638f71c3616c937154cd306172049cde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4dc06c12d09bf50dc11734e5f61a77d638f71c3616c937154cd306172049cde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4dc06c12d09bf50dc11734e5f61a77d638f71c3616c937154cd306172049cde", kill_on_drop: false }` [INFO] [stdout] e4dc06c12d09bf50dc11734e5f61a77d638f71c3616c937154cd306172049cde [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98f5d492becf36d7689aa6c9fd7dc1dec7d9d96c7f6d90210732091bda858ea4 [INFO] running `Command { std: "docker" "start" "-a" "98f5d492becf36d7689aa6c9fd7dc1dec7d9d96c7f6d90210732091bda858ea4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling quad-alsa-sys v0.3.2 [INFO] [stderr] Compiling miniquad v0.4.0 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking dasp_frame v0.11.0 [INFO] [stderr] Compiling quad-snd v0.2.7 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Compiling macroquad_macro v0.1.7 [INFO] [stderr] Checking bumpalo v3.15.4 [INFO] [stderr] Checking quad-rand v0.2.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking glam v0.21.3 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking audrey v0.3.0 [INFO] [stderr] Checking fontdue v0.7.3 [INFO] [stderr] Checking macroquad v0.4.5 [INFO] [stderr] Checking chip8emu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/chip8.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return col; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return col; [INFO] [stdout] 72 + col [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | reg_x = reg_x % 64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reg_x %= 64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | reg_y = reg_y % 32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reg_y %= 32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `sprite` [INFO] [stdout] --> src/chip8.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for j in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 50 - for j in 0..len { [INFO] [stdout] 50 + for (j, ) in sprite.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chip8.rs:282:42 [INFO] [stdout] | [INFO] [stdout] 282 | self.regs[0xF] = !(rx < self.regs[y]) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(rx >= self.regs[y])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/chip8.rs:354:25 [INFO] [stdout] | [INFO] [stdout] 354 | / if self.current_keys[(self.regs[x] & 0xF) as usize] == 1 { [INFO] [stdout] 355 | | self.inc_pc(); [INFO] [stdout] 356 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 353 ~ 0x9E [INFO] [stdout] 354 ~ if self.current_keys[(self.regs[x] & 0xF) as usize] == 1 => { [INFO] [stdout] 355 | self.inc_pc(); [INFO] [stdout] 356 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/chip8.rs:360:25 [INFO] [stdout] | [INFO] [stdout] 360 | / if self.current_keys[(self.regs[x] & 0xF) as usize] != 1 { [INFO] [stdout] 361 | | self.inc_pc(); [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 359 ~ 0xA1 [INFO] [stdout] 360 ~ if self.current_keys[(self.regs[x] & 0xF) as usize] != 1 => { [INFO] [stdout] 361 | self.inc_pc(); [INFO] [stdout] 362 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/chip8.rs:394:25 [INFO] [stdout] | [INFO] [stdout] 394 | / if self.regs[x] < 16 { [INFO] [stdout] 395 | | self.index = (self.regs[x] * 0x5) as u16 & 0xF; [INFO] [stdout] 396 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 392 ~ 0x29 [INFO] [stdout] 393 | // Set I = location of sprite for digit Vx. [INFO] [stdout] 394 ~ if self.regs[x] < 16 => { [INFO] [stdout] 395 | self.index = (self.regs[x] * 0x5) as u16 & 0xF; [INFO] [stdout] 396 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | update_image(&cpu, image, &texture); [INFO] [stdout] | ^^^^ help: change this to: `cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:59:43 [INFO] [stdout] | [INFO] [stdout] 59 | update_image(&cpu, image, &texture); [INFO] [stdout] | ^^^^^^^^ help: change this to: `texture` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `gfx` [INFO] [stdout] --> src/main.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..gfx.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..gfx.len() { [INFO] [stdout] 102 + for (i, ) in gfx.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/main.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | image.bytes[i * 4 + 0] = (col.r * 255.) as u8; [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `(i * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:114:20 [INFO] [stdout] | [INFO] [stdout] 114 | texture.update(&image); [INFO] [stdout] | ^^^^^^ help: change this to: `image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/chip8.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return col; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return col; [INFO] [stdout] 72 + col [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | reg_x = reg_x % 64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reg_x %= 64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/chip8.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | reg_y = reg_y % 32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reg_y %= 32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `sprite` [INFO] [stdout] --> src/chip8.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for j in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 50 - for j in 0..len { [INFO] [stdout] 50 + for (j, ) in sprite.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chip8.rs:282:42 [INFO] [stdout] | [INFO] [stdout] 282 | self.regs[0xF] = !(rx < self.regs[y]) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(rx >= self.regs[y])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/chip8.rs:354:25 [INFO] [stdout] | [INFO] [stdout] 354 | / if self.current_keys[(self.regs[x] & 0xF) as usize] == 1 { [INFO] [stdout] 355 | | self.inc_pc(); [INFO] [stdout] 356 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 353 ~ 0x9E [INFO] [stdout] 354 ~ if self.current_keys[(self.regs[x] & 0xF) as usize] == 1 => { [INFO] [stdout] 355 | self.inc_pc(); [INFO] [stdout] 356 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/chip8.rs:360:25 [INFO] [stdout] | [INFO] [stdout] 360 | / if self.current_keys[(self.regs[x] & 0xF) as usize] != 1 { [INFO] [stdout] 361 | | self.inc_pc(); [INFO] [stdout] 362 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 359 ~ 0xA1 [INFO] [stdout] 360 ~ if self.current_keys[(self.regs[x] & 0xF) as usize] != 1 => { [INFO] [stdout] 361 | self.inc_pc(); [INFO] [stdout] 362 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/chip8.rs:394:25 [INFO] [stdout] | [INFO] [stdout] 394 | / if self.regs[x] < 16 { [INFO] [stdout] 395 | | self.index = (self.regs[x] * 0x5) as u16 & 0xF; [INFO] [stdout] 396 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 392 ~ 0x29 [INFO] [stdout] 393 | // Set I = location of sprite for digit Vx. [INFO] [stdout] 394 ~ if self.regs[x] < 16 => { [INFO] [stdout] 395 | self.index = (self.regs[x] * 0x5) as u16 & 0xF; [INFO] [stdout] 396 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | update_image(&cpu, image, &texture); [INFO] [stdout] | ^^^^ help: change this to: `cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:59:43 [INFO] [stdout] | [INFO] [stdout] 59 | update_image(&cpu, image, &texture); [INFO] [stdout] | ^^^^^^^^ help: change this to: `texture` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `gfx` [INFO] [stdout] --> src/main.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..gfx.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..gfx.len() { [INFO] [stdout] 102 + for (i, ) in gfx.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/main.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | image.bytes[i * 4 + 0] = (col.r * 255.) as u8; [INFO] [stdout] | ^^^^^^^^^ help: consider reducing it to: `(i * 4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:114:20 [INFO] [stdout] | [INFO] [stdout] 114 | texture.update(&image); [INFO] [stdout] | ^^^^^^ help: change this to: `image` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.71s [INFO] running `Command { std: "docker" "inspect" "98f5d492becf36d7689aa6c9fd7dc1dec7d9d96c7f6d90210732091bda858ea4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98f5d492becf36d7689aa6c9fd7dc1dec7d9d96c7f6d90210732091bda858ea4", kill_on_drop: false }` [INFO] [stdout] 98f5d492becf36d7689aa6c9fd7dc1dec7d9d96c7f6d90210732091bda858ea4