[INFO] cloning repository https://github.com/HasChad/overflow [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HasChad/overflow" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHasChad%2Foverflow", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHasChad%2Foverflow'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8221f0fc341c435df331af9fdb4fb2a877b759ff [INFO] linting HasChad/overflow against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHasChad%2Foverflow" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HasChad/overflow [INFO] finished tweaking git repo https://github.com/HasChad/overflow [INFO] tweaked toml for git repo https://github.com/HasChad/overflow written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HasChad/overflow on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HasChad/overflow already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quad-rand v0.2.3 [INFO] [stderr] Downloaded objc-rs v0.2.8 [INFO] [stderr] Downloaded macroquad_macro v0.1.8 [INFO] [stderr] Downloaded miniquad v0.4.8 [INFO] [stderr] Downloaded macroquad v0.4.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b59536ba820c1261974c681bd83b55084c7756663dfe57a1ff6da7e0b71dff20 [INFO] running `Command { std: "docker" "start" "-a" "b59536ba820c1261974c681bd83b55084c7756663dfe57a1ff6da7e0b71dff20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b59536ba820c1261974c681bd83b55084c7756663dfe57a1ff6da7e0b71dff20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b59536ba820c1261974c681bd83b55084c7756663dfe57a1ff6da7e0b71dff20", kill_on_drop: false }` [INFO] [stdout] b59536ba820c1261974c681bd83b55084c7756663dfe57a1ff6da7e0b71dff20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 81a3ba8d1f82d1de14862e32b036c4db88df0540e350dd7be55aa6c4f27123b6 [INFO] running `Command { std: "docker" "start" "-a" "81a3ba8d1f82d1de14862e32b036c4db88df0540e350dd7be55aa6c4f27123b6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling miniquad v0.4.8 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking quad-rand v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Compiling macroquad_macro v0.1.8 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking macroquad v0.4.14 [INFO] [stderr] Checking overflow v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/draw.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | format!("Press R to play again").as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Press R to play again".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/first_phase.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / if is_mouse_button_pressed(MouseButton::Left) { [INFO] [stdout] 19 | | if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Empty { [INFO] [stdout] 21 | | match state.current_player { [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if is_mouse_button_pressed(MouseButton::Left) [INFO] [stdout] 19 ~ && let Some(index) = state.focused_tile { [INFO] [stdout] 20 | if state.grid[index] == Tile::Empty { [INFO] [stdout] ... [INFO] [stdout] 31 | } [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/first_phase.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Empty { [INFO] [stdout] 21 | | match state.current_player { [INFO] [stdout] 22 | | crate::Players::PlayerOne => { [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if let Some(index) = state.focused_tile [INFO] [stdout] 20 ~ && state.grid[index] == Tile::Empty { [INFO] [stdout] 21 | match state.current_player { [INFO] [stdout] ... [INFO] [stdout] 30 | } [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_setup.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if (x == 0 && y == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 11 | | || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 12 | | || (x == GRID_SIZE - 1 && y == GRID_SIZE - 1) [INFO] [stdout] 13 | | || (x == GRID_SIZE - 1 && y == 0) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 12 - || (x == GRID_SIZE - 1 && y == GRID_SIZE - 1) [INFO] [stdout] 13 - || (x == GRID_SIZE - 1 && y == 0) [INFO] [stdout] 10 + if !(y != 0 && y != GRID_SIZE - 1 || x != 0 && x != GRID_SIZE - 1) [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 12 - || (x == GRID_SIZE - 1 && y == GRID_SIZE - 1) [INFO] [stdout] 13 - || (x == GRID_SIZE - 1 && y == 0) [INFO] [stdout] 10 + if (x == GRID_SIZE - 1 || x == 0) && (y == GRID_SIZE - 1 || y == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_setup.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if (x == 0 && y == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 11 | | || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 10 + if !(x != 0 || y != 0 && y != GRID_SIZE - 1) [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 10 + if (y == GRID_SIZE - 1 || y == 0) && x == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/second_phase.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / if is_mouse_button_pressed(MouseButton::Right) && state.round > 2 { [INFO] [stdout] 19 | | if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Wall { [INFO] [stdout] 21 | | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if is_mouse_button_pressed(MouseButton::Right) && state.round > 2 [INFO] [stdout] 19 ~ && let Some(index) = state.focused_tile { [INFO] [stdout] 20 | if state.grid[index] == Tile::Wall { [INFO] [stdout] ... [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/second_phase.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Wall { [INFO] [stdout] 21 | | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] 22 | | let y = (index / GRID_SIZE) as f32; [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if let Some(index) = state.focused_tile [INFO] [stdout] 20 ~ && state.grid[index] == Tile::Wall { [INFO] [stdout] 21 | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/second_phase.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / if is_mouse_button_pressed(MouseButton::Left) { [INFO] [stdout] 50 | | if let Some(index) = state.focused_tile { [INFO] [stdout] 51 | | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] 52 | | let y = (index / GRID_SIZE) as f32; [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 49 ~ if is_mouse_button_pressed(MouseButton::Left) [INFO] [stdout] 50 ~ && let Some(index) = state.focused_tile { [INFO] [stdout] 51 | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] ... [INFO] [stdout] 140 | } [INFO] [stdout] 141 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/second_phase.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 75 | let tile_s = GRID_SIZE as usize - 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `GRID_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/draw.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | format!("Press R to play again").as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Press R to play again".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/first_phase.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / if is_mouse_button_pressed(MouseButton::Left) { [INFO] [stdout] 19 | | if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Empty { [INFO] [stdout] 21 | | match state.current_player { [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if is_mouse_button_pressed(MouseButton::Left) [INFO] [stdout] 19 ~ && let Some(index) = state.focused_tile { [INFO] [stdout] 20 | if state.grid[index] == Tile::Empty { [INFO] [stdout] ... [INFO] [stdout] 31 | } [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/first_phase.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Empty { [INFO] [stdout] 21 | | match state.current_player { [INFO] [stdout] 22 | | crate::Players::PlayerOne => { [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if let Some(index) = state.focused_tile [INFO] [stdout] 20 ~ && state.grid[index] == Tile::Empty { [INFO] [stdout] 21 | match state.current_player { [INFO] [stdout] ... [INFO] [stdout] 30 | } [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_setup.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if (x == 0 && y == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 11 | | || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 12 | | || (x == GRID_SIZE - 1 && y == GRID_SIZE - 1) [INFO] [stdout] 13 | | || (x == GRID_SIZE - 1 && y == 0) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 12 - || (x == GRID_SIZE - 1 && y == GRID_SIZE - 1) [INFO] [stdout] 13 - || (x == GRID_SIZE - 1 && y == 0) [INFO] [stdout] 10 + if !(y != 0 && y != GRID_SIZE - 1 || x != 0 && x != GRID_SIZE - 1) [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 12 - || (x == GRID_SIZE - 1 && y == GRID_SIZE - 1) [INFO] [stdout] 13 - || (x == GRID_SIZE - 1 && y == 0) [INFO] [stdout] 10 + if (x == GRID_SIZE - 1 || x == 0) && (y == GRID_SIZE - 1 || y == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game_setup.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if (x == 0 && y == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 11 | | || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 10 + if !(x != 0 || y != 0 && y != GRID_SIZE - 1) [INFO] [stdout] | [INFO] [stdout] 10 - if (x == 0 && y == 0) [INFO] [stdout] 11 - || (x == 0 && y == GRID_SIZE - 1) [INFO] [stdout] 10 + if (y == GRID_SIZE - 1 || y == 0) && x == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/second_phase.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / if is_mouse_button_pressed(MouseButton::Right) && state.round > 2 { [INFO] [stdout] 19 | | if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Wall { [INFO] [stdout] 21 | | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if is_mouse_button_pressed(MouseButton::Right) && state.round > 2 [INFO] [stdout] 19 ~ && let Some(index) = state.focused_tile { [INFO] [stdout] 20 | if state.grid[index] == Tile::Wall { [INFO] [stdout] ... [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/second_phase.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / if let Some(index) = state.focused_tile { [INFO] [stdout] 20 | | if state.grid[index] == Tile::Wall { [INFO] [stdout] 21 | | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] 22 | | let y = (index / GRID_SIZE) as f32; [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ if let Some(index) = state.focused_tile [INFO] [stdout] 20 ~ && state.grid[index] == Tile::Wall { [INFO] [stdout] 21 | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/second_phase.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / if is_mouse_button_pressed(MouseButton::Left) { [INFO] [stdout] 50 | | if let Some(index) = state.focused_tile { [INFO] [stdout] 51 | | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] 52 | | let y = (index / GRID_SIZE) as f32; [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 49 ~ if is_mouse_button_pressed(MouseButton::Left) [INFO] [stdout] 50 ~ && let Some(index) = state.focused_tile { [INFO] [stdout] 51 | let x = (index % GRID_SIZE) as f32; [INFO] [stdout] ... [INFO] [stdout] 140 | } [INFO] [stdout] 141 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.86s [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/second_phase.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 75 | let tile_s = GRID_SIZE as usize - 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `GRID_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "81a3ba8d1f82d1de14862e32b036c4db88df0540e350dd7be55aa6c4f27123b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81a3ba8d1f82d1de14862e32b036c4db88df0540e350dd7be55aa6c4f27123b6", kill_on_drop: false }` [INFO] [stdout] 81a3ba8d1f82d1de14862e32b036c4db88df0540e350dd7be55aa6c4f27123b6