[INFO] cloning repository https://github.com/HarryPoggers/git-in-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HarryPoggers/git-in-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHarryPoggers%2Fgit-in-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHarryPoggers%2Fgit-in-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 01878bc1fc84ddf9100ad28112a549dbcf2d189b [INFO] linting HarryPoggers/git-in-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHarryPoggers%2Fgit-in-rust" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HarryPoggers/git-in-rust [INFO] finished tweaking git repo https://github.com/HarryPoggers/git-in-rust [INFO] tweaked toml for git repo https://github.com/HarryPoggers/git-in-rust written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HarryPoggers/git-in-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HarryPoggers/git-in-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.59 [INFO] [stderr] Downloaded clap v4.0.32 [INFO] [stderr] Downloaded rustix v0.36.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 843d98397d24cbf0d733caa5da583069e7f741fdc4db17558419bdb8853accf9 [INFO] running `Command { std: "docker" "start" "-a" "843d98397d24cbf0d733caa5da583069e7f741fdc4db17558419bdb8853accf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "843d98397d24cbf0d733caa5da583069e7f741fdc4db17558419bdb8853accf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "843d98397d24cbf0d733caa5da583069e7f741fdc4db17558419bdb8853accf9", kill_on_drop: false }` [INFO] [stdout] 843d98397d24cbf0d733caa5da583069e7f741fdc4db17558419bdb8853accf9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 302e10290e1a703738a875f8b1f6137c76c7e886ae6ee547981ef759cdf95173 [INFO] running `Command { std: "docker" "start" "-a" "302e10290e1a703738a875f8b1f6137c76c7e886ae6ee547981ef759cdf95173", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling parking_lot_core v0.9.6 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling tokio v1.24.1 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling io-lifetimes v1.0.3 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking indexmap v1.9.1 [INFO] [stderr] Checking generic-array v0.14.6 [INFO] [stderr] Compiling rustix v0.36.6 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking digest v0.10.6 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling clap_derive v4.0.21 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking clap v4.0.32 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.15 [INFO] [stderr] Checking hyper v0.14.23 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.13 [INFO] [stderr] Checking git-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `get_object_path_by_hash` is never used [INFO] [stdout] --> src/utils.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn get_object_path_by_hash(hash: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_object_contents` is never used [INFO] [stdout] --> src/utils.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn get_object_contents(path: PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_object_contents_as_bytes` is never used [INFO] [stdout] --> src/utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_object_contents_as_bytes(path: PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `decompress` is never used [INFO] [stdout] --> src/utils.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn decompress(content: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_object_path_by_hash` is never used [INFO] [stdout] --> src/utils.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn get_object_path_by_hash(hash: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_object_contents` is never used [INFO] [stdout] --> src/utils.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn get_object_contents(path: PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_object_contents_as_bytes` is never used [INFO] [stdout] --> src/utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_object_contents_as_bytes(path: PathBuf) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `decompress` is never used [INFO] [stdout] --> src/utils.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn decompress(content: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/hashobject.rs:13:31 [INFO] [stdout] | [INFO] [stdout] 13 | let mut file = File::open(&path).expect("File unable to be opened."); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/commands/listtree.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | let mut sha_buf = Vec::new(); [INFO] [stdout] | ___________________________^ [INFO] [stdout] 51 | | sha_buf.resize(20, 0); [INFO] [stdout] | |_____________________________^ help: consider replacing this with: `vec![0; 20]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/hashobject.rs:13:31 [INFO] [stdout] | [INFO] [stdout] 13 | let mut file = File::open(&path).expect("File unable to be opened."); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/commands/listtree.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | let mut sha_buf = Vec::new(); [INFO] [stdout] | ___________________________^ [INFO] [stdout] 51 | | sha_buf.resize(20, 0); [INFO] [stdout] | |_____________________________^ help: consider replacing this with: `vec![0; 20]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return final_file_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return final_file_path; [INFO] [stdout] 34 + final_file_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | let root_folder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `root_folder` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 ~ let root_folder = match find_git_root() { [INFO] [stdout] 21 ~ Some(value) => value, [INFO] [stdout] 22 | None => panic!("No git repository found in this or any parent directory."), [INFO] [stdout] 23 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return std::str::from_utf8(&decompressed_content) [INFO] [stdout] 44 | | .expect("Unable to convert to UTF-8 String.") [INFO] [stdout] 45 | | .to_string(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ std::str::from_utf8(&decompressed_content) [INFO] [stdout] 44 + .expect("Unable to convert to UTF-8 String.") [INFO] [stdout] 45 ~ .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return content; [INFO] [stdout] 54 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if !create_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `create_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | let root_folder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `root_folder` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 61 ~ [INFO] [stdout] 62 ~ let root_folder = match find_git_root() { [INFO] [stdout] 63 ~ Some(value) => value, [INFO] [stdout] 64 | None => panic!("No git repository found in this or any parent directory."), [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/utils.rs:77:10 [INFO] [stdout] | [INFO] [stdout] 77 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return final_file_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return final_file_path; [INFO] [stdout] 34 + final_file_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return s; [INFO] [stdout] 117 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | let root_folder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `root_folder` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 ~ let root_folder = match find_git_root() { [INFO] [stdout] 21 ~ Some(value) => value, [INFO] [stdout] 22 | None => panic!("No git repository found in this or any parent directory."), [INFO] [stdout] 23 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | return e.finish().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return e.finish().unwrap(); [INFO] [stdout] 125 + e.finish().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return std::str::from_utf8(&decompressed_content) [INFO] [stdout] 44 | | .expect("Unable to convert to UTF-8 String.") [INFO] [stdout] 45 | | .to_string(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ std::str::from_utf8(&decompressed_content) [INFO] [stdout] 44 + .expect("Unable to convert to UTF-8 String.") [INFO] [stdout] 45 ~ .to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return content; [INFO] [stdout] 54 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if !create_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `create_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | let root_folder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `root_folder` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 61 ~ [INFO] [stdout] 62 ~ let root_folder = match find_git_root() { [INFO] [stdout] 63 ~ Some(value) => value, [INFO] [stdout] 64 | None => panic!("No git repository found in this or any parent directory."), [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/utils.rs:77:10 [INFO] [stdout] | [INFO] [stdout] 77 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return s; [INFO] [stdout] 117 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | return e.finish().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return e.finish().unwrap(); [INFO] [stdout] 125 + e.finish().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.95s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "302e10290e1a703738a875f8b1f6137c76c7e886ae6ee547981ef759cdf95173", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "302e10290e1a703738a875f8b1f6137c76c7e886ae6ee547981ef759cdf95173", kill_on_drop: false }` [INFO] [stdout] 302e10290e1a703738a875f8b1f6137c76c7e886ae6ee547981ef759cdf95173