[INFO] cloning repository https://github.com/HarryDC/json_editor
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HarryDC/json_editor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHarryDC%2Fjson_editor", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHarryDC%2Fjson_editor'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0accb2adb85297dcbe3d676feeea6587d08ea54e
[INFO] linting HarryDC/json_editor against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHarryDC%2Fjson_editor" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/HarryDC/json_editor
[INFO] finished tweaking git repo https://github.com/HarryDC/json_editor
[INFO] tweaked toml for git repo https://github.com/HarryDC/json_editor written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/HarryDC/json_editor on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/HarryDC/json_editor already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded ppv-lite86 v0.2.18
[INFO] [stderr]   Downloaded async-process v2.2.3
[INFO] [stderr]   Downloaded mime_guess2 v2.0.5
[INFO] [stderr]   Downloaded wayland-sys v0.31.4
[INFO] [stderr]   Downloaded xcursor v0.3.6
[INFO] [stderr]   Downloaded zerocopy v0.6.6
[INFO] [stderr]   Downloaded async-signal v0.2.9
[INFO] [stderr]   Downloaded egui_glow v0.28.1
[INFO] [stderr]   Downloaded egui-wgpu v0.28.1
[INFO] [stderr]   Downloaded wayland-scanner v0.31.4
[INFO] [stderr]   Downloaded wayland-client v0.31.5
[INFO] [stderr]   Downloaded wayland-backend v0.3.6
[INFO] [stderr]   Downloaded eframe v0.28.1
[INFO] [stderr]   Downloaded egui-modal v0.4.0
[INFO] [stderr]   Downloaded egui-winit v0.28.1
[INFO] [stderr]   Downloaded egui_extras v0.28.1
[INFO] [stderr]   Downloaded wayland-protocols v0.32.3
[INFO] [stderr]   Downloaded zerocopy-derive v0.6.6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 822c318e0c4ce06b12a436223e8910eca2d0b6ae1268d88ca6368b13f9df6bc1
[INFO] running `Command { std: "docker" "start" "-a" "822c318e0c4ce06b12a436223e8910eca2d0b6ae1268d88ca6368b13f9df6bc1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "822c318e0c4ce06b12a436223e8910eca2d0b6ae1268d88ca6368b13f9df6bc1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "822c318e0c4ce06b12a436223e8910eca2d0b6ae1268d88ca6368b13f9df6bc1", kill_on_drop: false }`
[INFO] [stdout] 822c318e0c4ce06b12a436223e8910eca2d0b6ae1268d88ca6368b13f9df6bc1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 91cdfe684b8517fc3ee77d06b9dad7bd4b6909d8197d47ad532f4c3dc0a86858
[INFO] running `Command { std: "docker" "start" "-a" "91cdfe684b8517fc3ee77d06b9dad7bd4b6909d8197d47ad532f4c3dc0a86858", kill_on_drop: false }`
[INFO] [stderr]    Compiling serde v1.0.204
[INFO] [stderr]    Compiling libc v0.2.155
[INFO] [stderr]    Compiling rustix v0.38.34
[INFO] [stderr]    Compiling crossbeam-utils v0.8.20
[INFO] [stderr]     Checking libloading v0.8.5
[INFO] [stderr]    Compiling hashbrown v0.14.5
[INFO] [stderr]    Compiling wayland-sys v0.31.4
[INFO] [stderr]    Compiling cc v1.1.7
[INFO] [stderr]    Compiling quick-xml v0.34.0
[INFO] [stderr]    Compiling wayland-client v0.31.5
[INFO] [stderr]    Compiling syn v2.0.72
[INFO] [stderr]     Checking futures-lite v2.3.0
[INFO] [stderr]     Checking piper v0.2.3
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]    Compiling thiserror v1.0.63
[INFO] [stderr]     Checking ttf-parser v0.24.0
[INFO] [stderr]     Checking sha1 v0.10.6
[INFO] [stderr]    Compiling polling v2.8.0
[INFO] [stderr]    Compiling memoffset v0.7.1
[INFO] [stderr]     Checking waker-fn v1.2.0
[INFO] [stderr]     Checking dlib v0.5.2
[INFO] [stderr]    Compiling regex-syntax v0.8.4
[INFO] [stderr]     Checking futures-lite v1.13.0
[INFO] [stderr]    Compiling async-io v1.13.0
[INFO] [stderr]    Compiling async-fs v1.6.0
[INFO] [stderr]     Checking zerocopy v0.7.35
[INFO] [stderr]     Checking unicode-normalization v0.1.23
[INFO] [stderr]     Checking xcursor v0.3.6
[INFO] [stderr]    Compiling gl_generator v0.14.0
[INFO] [stderr]     Checking concurrent-queue v2.5.0
[INFO] [stderr]    Compiling memoffset v0.9.1
[INFO] [stderr]     Checking arrayref v0.3.8
[INFO] [stderr]     Checking event-listener v5.3.1
[INFO] [stderr]    Compiling wayland-scanner v0.31.4
[INFO] [stderr]    Compiling unicase v2.7.0
[INFO] [stderr]     Checking async-executor v1.13.0
[INFO] [stderr]     Checking miniz_oxide v0.7.4
[INFO] [stderr]    Compiling indexmap v2.2.6
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling glutin v0.31.3
[INFO] [stderr]     Checking fdeflate v0.3.4
[INFO] [stderr]    Compiling glutin-winit v0.4.2
[INFO] [stderr]     Checking event-listener-strategy v0.5.2
[INFO] [stderr]     Checking idna v0.5.0
[INFO] [stderr]    Compiling mime_guess2 v2.0.5
[INFO] [stderr]     Checking async-channel v2.3.1
[INFO] [stderr]     Checking async-lock v3.4.0
[INFO] [stderr]    Compiling glutin_glx_sys v0.5.0
[INFO] [stderr]    Compiling glutin_egl_sys v0.6.0
[INFO] [stderr]     Checking blocking v1.6.1
[INFO] [stderr]     Checking async-broadcast v0.7.1
[INFO] [stderr]     Checking getrandom v0.2.15
[INFO] [stderr]    Compiling wayland-backend v0.3.6
[INFO] [stderr]     Checking xdg-home v1.2.0
[INFO] [stderr]     Checking io-lifetimes v1.0.11
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking socket2 v0.4.10
[INFO] [stderr]     Checking rustix v0.37.27
[INFO] [stderr]     Checking parking_lot_core v0.9.10
[INFO] [stderr]    Compiling toml_edit v0.19.15
[INFO] [stderr]     Checking nix v0.26.4
[INFO] [stderr]     Checking memmap2 v0.9.4
[INFO] [stderr]    Compiling toml_edit v0.21.1
[INFO] [stderr]     Checking x11-dl v2.21.0
[INFO] [stderr]     Checking async-fs v2.1.2
[INFO] [stderr]     Checking flate2 v1.0.30
[INFO] [stderr]     Checking parking_lot v0.12.3
[INFO] [stderr]     Checking dirs-sys v0.4.1
[INFO] [stderr]     Checking png v0.17.13
[INFO] [stderr]     Checking futures-channel v0.3.30
[INFO] [stderr]     Checking web-time v0.2.4
[INFO] [stderr]    Compiling rfd v0.14.1
[INFO] [stderr]     Checking directories v5.0.1
[INFO] [stderr]     Checking pollster v0.3.0
[INFO] [stderr]     Checking owned_ttf_parser v0.24.0
[INFO] [stderr]     Checking ab_glyph v0.2.28
[INFO] [stderr]    Compiling regex-automata v0.4.7
[INFO] [stderr]    Compiling zvariant_utils v2.1.0
[INFO] [stderr]    Compiling proc-macro-crate v1.3.1
[INFO] [stderr]    Compiling proc-macro-crate v3.1.0
[INFO] [stderr]    Compiling serde_derive v1.0.204
[INFO] [stderr]    Compiling tracing-attributes v0.1.27
[INFO] [stderr]    Compiling enumflags2_derive v0.7.10
[INFO] [stderr]    Compiling bytemuck_derive v1.7.0
[INFO] [stderr]    Compiling zerocopy-derive v0.6.6
[INFO] [stderr]    Compiling thiserror-impl v1.0.63
[INFO] [stderr]    Compiling futures-macro v0.3.30
[INFO] [stderr]    Compiling serde_repr v0.1.19
[INFO] [stderr]    Compiling async-trait v0.1.81
[INFO] [stderr]    Compiling enumn v0.1.14
[INFO] [stderr]    Compiling zvariant_utils v1.0.1
[INFO] [stderr]    Compiling async-recursion v1.1.1
[INFO] [stderr]    Compiling enum-map-derive v0.17.0
[INFO] [stderr]     Checking zerocopy v0.6.6
[INFO] [stderr]    Compiling zvariant_derive v4.2.0
[INFO] [stderr]    Compiling zbus_macros v4.4.0
[INFO] [stderr]     Checking futures-util v0.3.30
[INFO] [stderr]     Checking bytemuck v1.16.3
[INFO] [stderr]     Checking tracing v0.1.40
[INFO] [stderr]     Checking tiny-skia-path v0.11.4
[INFO] [stderr]     Checking image v0.25.2
[INFO] [stderr]     Checking ppv-lite86 v0.2.18
[INFO] [stderr]    Compiling zvariant_derive v3.15.2
[INFO] [stderr]    Compiling derivative v2.2.0
[INFO] [stderr]    Compiling regex v1.10.5
[INFO] [stderr]     Checking tiny-skia v0.11.4
[INFO] [stderr]    Compiling zbus_macros v3.15.2
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking bitflags v2.6.0
[INFO] [stderr]     Checking enumflags2 v0.7.10
[INFO] [stderr]     Checking ahash v0.8.11
[INFO] [stderr]     Checking accesskit v0.12.3
[INFO] [stderr]     Checking emath v0.28.1
[INFO] [stderr]     Checking url v2.5.2
[INFO] [stderr]     Checking enum-map v2.7.3
[INFO] [stderr]     Checking ron v0.8.1
[INFO] [stderr]     Checking xkbcommon-dl v0.4.2
[INFO] [stderr]     Checking nix v0.29.0
[INFO] [stderr]     Checking zvariant v3.15.2
[INFO] [stderr]     Checking ecolor v0.28.1
[INFO] [stderr]     Checking epaint v0.28.1
[INFO] [stderr]     Checking zvariant v4.2.0
[INFO] [stderr]     Checking webbrowser v1.0.1
[INFO] [stderr]     Checking accesskit_consumer v0.16.1
[INFO] [stderr]     Checking zbus_names v2.6.1
[INFO] [stderr]     Checking zbus v3.15.2
[INFO] [stderr]     Checking egui v0.28.1
[INFO] [stderr]     Checking zbus_names v3.0.0
[INFO] [stderr]     Checking polling v3.7.2
[INFO] [stderr]     Checking x11rb v0.13.1
[INFO] [stderr]     Checking calloop v0.12.4
[INFO] [stderr]     Checking calloop v0.13.0
[INFO] [stderr]     Checking async-io v2.3.3
[INFO] [stderr]     Checking wayland-csd-frame v0.3.0
[INFO] [stderr]     Checking async-net v2.0.0
[INFO] [stderr]     Checking zbus v4.4.0
[INFO] [stderr]     Checking arboard v3.4.0
[INFO] [stderr]     Checking wayland-cursor v0.31.5
[INFO] [stderr]     Checking wayland-protocols v0.31.2
[INFO] [stderr]     Checking calloop-wayland-source v0.2.0
[INFO] [stderr]     Checking wayland-protocols v0.32.3
[INFO] [stderr]     Checking calloop-wayland-source v0.3.0
[INFO] [stderr]     Checking atspi-common v0.3.0
[INFO] [stderr]     Checking egui_glow v0.28.1
[INFO] [stderr]     Checking egui-modal v0.4.0
[INFO] [stderr]     Checking egui_extras v0.28.1
[INFO] [stderr]     Checking wayland-protocols-wlr v0.2.0
[INFO] [stderr]     Checking wayland-protocols-plasma v0.2.0
[INFO] [stderr]     Checking ashpd v0.8.1
[INFO] [stderr]     Checking wayland-protocols-wlr v0.3.3
[INFO] [stderr]     Checking smithay-client-toolkit v0.18.1
[INFO] [stderr]     Checking atspi-proxies v0.3.0
[INFO] [stderr]     Checking smithay-client-toolkit v0.19.2
[INFO] [stderr]     Checking sctk-adwaita v0.8.3
[INFO] [stderr]     Checking smithay-clipboard v0.7.2
[INFO] [stderr]     Checking winit v0.29.15
[INFO] [stderr]     Checking atspi-connection v0.3.0
[INFO] [stderr]     Checking atspi v0.19.0
[INFO] [stderr]     Checking accesskit_unix v0.6.2
[INFO] [stderr]     Checking accesskit_winit v0.16.1
[INFO] [stderr]     Checking egui-winit v0.28.1
[INFO] [stderr]     Checking eframe v0.28.1
[INFO] [stderr]     Checking json_editor v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `super::*`
[INFO] [stdout]    --> src/json/value.rs:104:9
[INFO] [stdout]     |
[INFO] [stdout] 104 |     use super::*;
[INFO] [stdout]     |         ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `cursor` is never used
[INFO] [stdout]   --> src/json/state.rs:29:12
[INFO] [stdout]    |
[INFO] [stdout]  9 | impl State {
[INFO] [stdout]    | ---------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 29 |     pub fn cursor(&self) -> usize {
[INFO] [stdout]    |            ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `as_array` and `as_object` are never used
[INFO] [stdout]   --> src/json/value.rs:43:8
[INFO] [stdout]    |
[INFO] [stdout] 13 | impl JsonValueType {
[INFO] [stdout]    | ------------------ methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 43 |     fn as_array(&self) -> Option<&Array> {
[INFO] [stdout]    |        ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 50 |     fn as_object(&self) -> Option<&Object> {
[INFO] [stdout]    |        ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/json/object_parser.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | /     return match state.peek() {
[INFO] [stdout] 17 | |         Some(&'t') | Some(&'f') => {
[INFO] [stdout] 18 | |             if state.read_literal("true") {Ok(JsonTypeBool(true))}
[INFO] [stdout] 19 | |             else if state.read_literal("false") {Ok(JsonTypeBool(false))}
[INFO] [stdout] ...  |
[INFO] [stdout] 38 | |         _ => parse_number(state)
[INFO] [stdout] 39 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 ~     match state.peek() {
[INFO] [stdout] 17 +         Some(&'t') | Some(&'f') => {
[INFO] [stdout] 18 +             if state.read_literal("true") {Ok(JsonTypeBool(true))}
[INFO] [stdout] 19 +             else if state.read_literal("false") {Ok(JsonTypeBool(false))}
[INFO] [stdout] 20 +             else { Err(state.error()) }
[INFO] [stdout] 21 +         },
[INFO] [stdout] 22 +         Some(&'n') => {
[INFO] [stdout] 23 +             if state.read_literal("null") {Ok(JsonTypeNull)}
[INFO] [stdout] 24 +             else { Err(state.error())}
[INFO] [stdout] 25 +         }
[INFO] [stdout] 26 +         Some(&'[') => {
[INFO] [stdout] 27 +             state.take();
[INFO] [stdout] 28 +             parse_array(state)
[INFO] [stdout] 29 +         },
[INFO] [stdout] 30 +         Some(&'"') => {
[INFO] [stdout] 31 +             state.take();
[INFO] [stdout] 32 +             parse_string(state)
[INFO] [stdout] 33 +         },
[INFO] [stdout] 34 +         Some(&'{') => {
[INFO] [stdout] 35 +             state.take();
[INFO] [stdout] 36 +             parse_object(state)
[INFO] [stdout] 37 +         }
[INFO] [stdout] 38 +         _ => parse_number(state)
[INFO] [stdout] 39 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/json/object_parser.rs:52:9
[INFO] [stdout]    |
[INFO] [stdout] 52 |         let key_string: String;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `key_string` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 52 ~         
[INFO] [stdout] 53 ~         let key_string: String = match key {
[INFO] [stdout] 54 ~             Ok(JsonTypeString(val)) => val,
[INFO] [stdout] 55 |             _ => return Err(state.error())
[INFO] [stdout] 56 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/json/object_parser.rs:92:5
[INFO] [stdout]    |
[INFO] [stdout] 92 |     return Ok(JsonTypeArray(Array(vec)));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 92 -     return Ok(JsonTypeArray(Array(vec)));
[INFO] [stdout] 92 +     Ok(JsonTypeArray(Array(vec)))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `num` after checking its variant with `is_err`
[INFO] [stdout]    --> src/json/object_parser.rs:119:27
[INFO] [stdout]     |
[INFO] [stdout] 116 |     if num.is_err() {
[INFO] [stdout]     |     --------------- help: try: `if let Ok(<item>) = num`
[INFO] [stdout] ...
[INFO] [stdout] 119 |         Ok(JsonTypeNumber(num.unwrap()))
[INFO] [stdout]     |                           ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/json/object_parser.rs:152:5
[INFO] [stdout]     |
[INFO] [stdout] 152 |     return Ok(JsonTypeString(result));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 152 -     return Ok(JsonTypeString(result));
[INFO] [stdout] 152 +     Ok(JsonTypeString(result))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/json/value.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 37 | /         match self {
[INFO] [stdout] 38 | |             JsonValueType::JsonTypeNull => true,
[INFO] [stdout] 39 | |             _ => false
[INFO] [stdout] 40 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 37 -         match self {
[INFO] [stdout] 38 -             JsonValueType::JsonTypeNull => true,
[INFO] [stdout] 39 -             _ => false
[INFO] [stdout] 40 -         }
[INFO] [stdout] 37 +         matches!(self, JsonValueType::JsonTypeNull)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `JsonValueType` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/json/value.rs:57:5
[INFO] [stdout]    |
[INFO] [stdout] 57 |     pub fn len(&self) -> Option<usize> {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `json::value::JsonValueType`
[INFO] [stdout]   --> src/json/value.rs:65:5
[INFO] [stdout]    |
[INFO] [stdout] 65 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 66 | |         match &self {
[INFO] [stdout] 67 | |             JsonValueType::JsonTypeNull => "null".to_string(),
[INFO] [stdout] 68 | |             JsonValueType::JsonTypeBool(val) => {
[INFO] [stdout] ...  |
[INFO] [stdout] 98 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `json::value::JsonValueType` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `cursor` is never used
[INFO] [stdout]   --> src/json/state.rs:29:12
[INFO] [stdout]    |
[INFO] [stdout]  9 | impl State {
[INFO] [stdout]    | ---------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 29 |     pub fn cursor(&self) -> usize {
[INFO] [stdout]    |            ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `as_array` and `as_object` are never used
[INFO] [stdout]   --> src/json/value.rs:43:8
[INFO] [stdout]    |
[INFO] [stdout] 13 | impl JsonValueType {
[INFO] [stdout]    | ------------------ methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 43 |     fn as_array(&self) -> Option<&Array> {
[INFO] [stdout]    |        ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 50 |     fn as_object(&self) -> Option<&Object> {
[INFO] [stdout]    |        ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/json/object_parser.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | /     return match state.peek() {
[INFO] [stdout] 17 | |         Some(&'t') | Some(&'f') => {
[INFO] [stdout] 18 | |             if state.read_literal("true") {Ok(JsonTypeBool(true))}
[INFO] [stdout] 19 | |             else if state.read_literal("false") {Ok(JsonTypeBool(false))}
[INFO] [stdout] ...  |
[INFO] [stdout] 38 | |         _ => parse_number(state)
[INFO] [stdout] 39 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 ~     match state.peek() {
[INFO] [stdout] 17 +         Some(&'t') | Some(&'f') => {
[INFO] [stdout] 18 +             if state.read_literal("true") {Ok(JsonTypeBool(true))}
[INFO] [stdout] 19 +             else if state.read_literal("false") {Ok(JsonTypeBool(false))}
[INFO] [stdout] 20 +             else { Err(state.error()) }
[INFO] [stdout] 21 +         },
[INFO] [stdout] 22 +         Some(&'n') => {
[INFO] [stdout] 23 +             if state.read_literal("null") {Ok(JsonTypeNull)}
[INFO] [stdout] 24 +             else { Err(state.error())}
[INFO] [stdout] 25 +         }
[INFO] [stdout] 26 +         Some(&'[') => {
[INFO] [stdout] 27 +             state.take();
[INFO] [stdout] 28 +             parse_array(state)
[INFO] [stdout] 29 +         },
[INFO] [stdout] 30 +         Some(&'"') => {
[INFO] [stdout] 31 +             state.take();
[INFO] [stdout] 32 +             parse_string(state)
[INFO] [stdout] 33 +         },
[INFO] [stdout] 34 +         Some(&'{') => {
[INFO] [stdout] 35 +             state.take();
[INFO] [stdout] 36 +             parse_object(state)
[INFO] [stdout] 37 +         }
[INFO] [stdout] 38 +         _ => parse_number(state)
[INFO] [stdout] 39 +     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/json/object_parser.rs:52:9
[INFO] [stdout]    |
[INFO] [stdout] 52 |         let key_string: String;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `key_string` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 52 ~         
[INFO] [stdout] 53 ~         let key_string: String = match key {
[INFO] [stdout] 54 ~             Ok(JsonTypeString(val)) => val,
[INFO] [stdout] 55 |             _ => return Err(state.error())
[INFO] [stdout] 56 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/json/object_parser.rs:92:5
[INFO] [stdout]    |
[INFO] [stdout] 92 |     return Ok(JsonTypeArray(Array(vec)));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 92 -     return Ok(JsonTypeArray(Array(vec)));
[INFO] [stdout] 92 +     Ok(JsonTypeArray(Array(vec)))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `num` after checking its variant with `is_err`
[INFO] [stdout]    --> src/json/object_parser.rs:119:27
[INFO] [stdout]     |
[INFO] [stdout] 116 |     if num.is_err() {
[INFO] [stdout]     |     --------------- help: try: `if let Ok(<item>) = num`
[INFO] [stdout] ...
[INFO] [stdout] 119 |         Ok(JsonTypeNumber(num.unwrap()))
[INFO] [stdout]     |                           ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/json/object_parser.rs:152:5
[INFO] [stdout]     |
[INFO] [stdout] 152 |     return Ok(JsonTypeString(result));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 152 -     return Ok(JsonTypeString(result));
[INFO] [stdout] 152 +     Ok(JsonTypeString(result))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:85:9
[INFO] [stdout]    |
[INFO] [stdout] 85 |         assert_eq!(true, state_1.read_char('t'));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 85 -         assert_eq!(true, state_1.read_char('t'));
[INFO] [stdout] 85 +         assert!(state_1.read_char('t'));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:86:9
[INFO] [stdout]    |
[INFO] [stdout] 86 |         assert_eq!(false, state_1.read_char('t'));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 86 -         assert_eq!(false, state_1.read_char('t'));
[INFO] [stdout] 86 +         assert!(!state_1.read_char('t'));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:87:9
[INFO] [stdout]    |
[INFO] [stdout] 87 |         assert_eq!(true, state_1.read_char('e'));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 87 -         assert_eq!(true, state_1.read_char('e'));
[INFO] [stdout] 87 +         assert!(state_1.read_char('e'));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:88:9
[INFO] [stdout]    |
[INFO] [stdout] 88 |         assert_eq!(false, state_1.read_char('e'));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 88 -         assert_eq!(false, state_1.read_char('e'));
[INFO] [stdout] 88 +         assert!(!state_1.read_char('e'));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:89:9
[INFO] [stdout]    |
[INFO] [stdout] 89 |         assert_eq!(true, state_1.at_end());
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 89 -         assert_eq!(true, state_1.at_end());
[INFO] [stdout] 89 +         assert!(state_1.at_end());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:95:9
[INFO] [stdout]    |
[INFO] [stdout] 95 |         assert_eq!(true, state_1.read_literal("true"));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 95 -         assert_eq!(true, state_1.read_literal("true"));
[INFO] [stdout] 95 +         assert!(state_1.read_literal("true"));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/json/state.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         assert_eq!(false, state_2.read_literal("trx"));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         assert_eq!(false, state_2.read_literal("trx"));
[INFO] [stdout] 99 +         assert!(!state_2.read_literal("trx"));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:102:9
[INFO] [stdout]     |
[INFO] [stdout] 102 |         assert_eq!(true, state_3.read_literal("false"));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 102 -         assert_eq!(true, state_3.read_literal("false"));
[INFO] [stdout] 102 +         assert!(state_3.read_literal("false"));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:103:9
[INFO] [stdout]     |
[INFO] [stdout] 103 |         assert_eq!(true, state_3.read_literal("true"));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 103 -         assert_eq!(true, state_3.read_literal("true"));
[INFO] [stdout] 103 +         assert!(state_3.read_literal("true"));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:109:9
[INFO] [stdout]     |
[INFO] [stdout] 109 |         assert_eq!(false, state_1.skip_whitespace());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 109 -         assert_eq!(false, state_1.skip_whitespace());
[INFO] [stdout] 109 +         assert!(!state_1.skip_whitespace());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:111:9
[INFO] [stdout]     |
[INFO] [stdout] 111 |         assert_eq!(false, state_1.at_end());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 111 -         assert_eq!(false, state_1.at_end());
[INFO] [stdout] 111 +         assert!(!state_1.at_end());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:115:9
[INFO] [stdout]     |
[INFO] [stdout] 115 |         assert_eq!(false, state_2.skip_whitespace());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 115 -         assert_eq!(false, state_2.skip_whitespace());
[INFO] [stdout] 115 +         assert!(!state_2.skip_whitespace());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:117:9
[INFO] [stdout]     |
[INFO] [stdout] 117 |         assert_eq!(false, state_2.at_end());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 117 -         assert_eq!(false, state_2.at_end());
[INFO] [stdout] 117 +         assert!(!state_2.at_end());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:122:9
[INFO] [stdout]     |
[INFO] [stdout] 122 |         assert_eq!(true, state_3.skip_whitespace());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 122 -         assert_eq!(true, state_3.skip_whitespace());
[INFO] [stdout] 122 +         assert!(state_3.skip_whitespace());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/json/state.rs:123:9
[INFO] [stdout]     |
[INFO] [stdout] 123 |         assert_eq!(true, state_3.at_end());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 123 -         assert_eq!(true, state_3.at_end());
[INFO] [stdout] 123 +         assert!(state_3.at_end());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/json/value.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 37 | /         match self {
[INFO] [stdout] 38 | |             JsonValueType::JsonTypeNull => true,
[INFO] [stdout] 39 | |             _ => false
[INFO] [stdout] 40 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 37 -         match self {
[INFO] [stdout] 38 -             JsonValueType::JsonTypeNull => true,
[INFO] [stdout] 39 -             _ => false
[INFO] [stdout] 40 -         }
[INFO] [stdout] 37 +         matches!(self, JsonValueType::JsonTypeNull)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enum `JsonValueType` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/json/value.rs:57:5
[INFO] [stdout]    |
[INFO] [stdout] 57 |     pub fn len(&self) -> Option<usize> {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `json::value::JsonValueType`
[INFO] [stdout]   --> src/json/value.rs:65:5
[INFO] [stdout]    |
[INFO] [stdout] 65 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 66 | |         match &self {
[INFO] [stdout] 67 | |             JsonValueType::JsonTypeNull => "null".to_string(),
[INFO] [stdout] 68 | |             JsonValueType::JsonTypeBool(val) => {
[INFO] [stdout] ...  |
[INFO] [stdout] 98 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `json::value::JsonValueType` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `json_editor::json::value::JsonValueType`
[INFO] [stdout]  --> tests/object_parser_tests.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 | use json_editor::json::value::JsonValueType;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::hash::Hasher`
[INFO] [stdout]  --> src/editor.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::hash::Hasher;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::hash::Hasher`
[INFO] [stdout]  --> src/editor.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::hash::Hasher;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `ui`
[INFO] [stdout]    --> src/editor.rs:170:20
[INFO] [stdout]     |
[INFO] [stdout] 170 | fn draw_edit_panel(ui: &mut Ui, value: &JsonValueType)  {
[INFO] [stdout]     |                    ^^ help: if this is intentional, prefix it with an underscore: `_ui`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `value`
[INFO] [stdout]    --> src/editor.rs:170:33
[INFO] [stdout]     |
[INFO] [stdout] 170 | fn draw_edit_panel(ui: &mut Ui, value: &JsonValueType)  {
[INFO] [stdout]     |                                 ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `ui`
[INFO] [stdout]    --> src/editor.rs:170:20
[INFO] [stdout]     |
[INFO] [stdout] 170 | fn draw_edit_panel(ui: &mut Ui, value: &JsonValueType)  {
[INFO] [stdout]     |                    ^^ help: if this is intentional, prefix it with an underscore: `_ui`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `value`
[INFO] [stdout]    --> src/editor.rs:170:33
[INFO] [stdout]     |
[INFO] [stdout] 170 | fn draw_edit_panel(ui: &mut Ui, value: &JsonValueType)  {
[INFO] [stdout]     |                                 ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/editor.rs:18:1
[INFO] [stdout]    |
[INFO] [stdout] 18 | / impl Default for JsonEditor {
[INFO] [stdout] 19 | |     fn default() -> Self {
[INFO] [stdout] 20 | |         Self {
[INFO] [stdout] 21 | |             current_file: None, // Restore path from stored path
[INFO] [stdout] ...  |
[INFO] [stdout] 25 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute
[INFO] [stdout]    |
[INFO] [stdout] 12 + #[derive(Default)]
[INFO] [stdout] 13 | pub(crate) struct JsonEditor {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/editor.rs:40:20
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 if ! app.current_data.is_some() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `app.current_data.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/editor.rs:18:1
[INFO] [stdout]    |
[INFO] [stdout] 18 | / impl Default for JsonEditor {
[INFO] [stdout] 19 | |     fn default() -> Self {
[INFO] [stdout] 20 | |         Self {
[INFO] [stdout] 21 | |             current_file: None, // Restore path from stored path
[INFO] [stdout] ...  |
[INFO] [stdout] 25 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute
[INFO] [stdout]    |
[INFO] [stdout] 12 + #[derive(Default)]
[INFO] [stdout] 13 | pub(crate) struct JsonEditor {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/editor.rs:40:20
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 if ! app.current_data.is_some() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `app.current_data.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]    --> src/editor.rs:104:5
[INFO] [stdout]     |
[INFO] [stdout] 104 | /     match to_object(result.as_ref()) {
[INFO] [stdout] 105 | |         Err(_) => None,
[INFO] [stdout] 106 | |         Ok(result) => Some(result)
[INFO] [stdout] 107 | |     }
[INFO] [stdout]     | |_____^ help: replace with: `to_object(result.as_ref()).ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]     = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/editor.rs:126:13
[INFO] [stdout]     |
[INFO] [stdout] 126 |             let text : String;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `text` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 126 ~             
[INFO] [stdout] 127 ~             let text : String = if *val {
[INFO] [stdout] 128 ~                 "true".to_owned()
[INFO] [stdout] 129 |             } else {
[INFO] [stdout] 130 ~                 "false".to_owned()
[INFO] [stdout] 131 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]    --> src/editor.rs:104:5
[INFO] [stdout]     |
[INFO] [stdout] 104 | /     match to_object(result.as_ref()) {
[INFO] [stdout] 105 | |         Err(_) => None,
[INFO] [stdout] 106 | |         Ok(result) => Some(result)
[INFO] [stdout] 107 | |     }
[INFO] [stdout]     | |_____^ help: replace with: `to_object(result.as_ref()).ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]     = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/editor.rs:144:49
[INFO] [stdout]     |
[INFO] [stdout] 144 | ...                   draw_json_value(ui, &item.1);
[INFO] [stdout]     |                                           ^^^^^^^ help: change this to: `item.1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/editor.rs:126:13
[INFO] [stdout]     |
[INFO] [stdout] 126 |             let text : String;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `text` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 126 ~             
[INFO] [stdout] 127 ~             let text : String = if *val {
[INFO] [stdout] 128 ~                 "true".to_owned()
[INFO] [stdout] 129 |             } else {
[INFO] [stdout] 130 ~                 "false".to_owned()
[INFO] [stdout] 131 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/editor.rs:144:49
[INFO] [stdout]     |
[INFO] [stdout] 144 | ...                   draw_json_value(ui, &item.1);
[INFO] [stdout]     |                                           ^^^^^^^ help: change this to: `item.1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 18s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: ashpd v0.8.1
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4`
[INFO] running `Command { std: "docker" "inspect" "91cdfe684b8517fc3ee77d06b9dad7bd4b6909d8197d47ad532f4c3dc0a86858", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "91cdfe684b8517fc3ee77d06b9dad7bd4b6909d8197d47ad532f4c3dc0a86858", kill_on_drop: false }`
[INFO] [stdout] 91cdfe684b8517fc3ee77d06b9dad7bd4b6909d8197d47ad532f4c3dc0a86858