[INFO] cloning repository https://github.com/Hang07/-fd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hang07/-fd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHang07%2F-fd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHang07%2F-fd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c165ff05461269d6a144467679358c4256bba64b [INFO] linting Hang07/-fd against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHang07%2F-fd" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Hang07/-fd [INFO] finished tweaking git repo https://github.com/Hang07/-fd [INFO] tweaked toml for git repo https://github.com/Hang07/-fd written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Hang07/-fd on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Hang07/-fd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding shell-escape v0.1.5 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded magenta-sys v0.1.1 [INFO] [stderr] Downloaded tempdir v0.3.5 [INFO] [stderr] Downloaded same-file v0.1.3 [INFO] [stderr] Downloaded lazy_static v0.2.9 [INFO] [stderr] Downloaded thread_local v0.3.4 [INFO] [stderr] Downloaded redox_syscall v0.1.31 [INFO] [stderr] Downloaded textwrap v0.8.0 [INFO] [stderr] Downloaded globset v0.2.0 [INFO] [stderr] Downloaded aho-corasick v0.6.3 [INFO] [stderr] Downloaded walkdir v1.0.7 [INFO] [stderr] Downloaded ctrlc v3.0.3 [INFO] [stderr] Downloaded crossbeam v0.2.10 [INFO] [stderr] Downloaded regex v0.2.2 [INFO] [stderr] Downloaded nix v0.8.1 [INFO] [stderr] Downloaded libc v0.2.31 [INFO] [stderr] Downloaded ansi_term v0.9.0 [INFO] [stderr] Downloaded clap v2.26.2 [INFO] [stderr] Downloaded ignore v0.2.2 [INFO] [stderr] Downloaded regex-syntax v0.4.1 [INFO] [stderr] Downloaded magenta v0.1.1 [INFO] [stderr] Downloaded rand v0.3.16 [INFO] [stderr] Downloaded fnv v1.0.5 [INFO] [stderr] Downloaded atty v0.2.3 [INFO] [stderr] Downloaded strsim v0.6.0 [INFO] [stderr] Downloaded term_size v0.3.0 [INFO] [stderr] Downloaded diff v0.1.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 174dc8d071bceae89f2af9690a1e2b202e5f23872b66de98098db04a487568d4 [INFO] running `Command { std: "docker" "start" "-a" "174dc8d071bceae89f2af9690a1e2b202e5f23872b66de98098db04a487568d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "174dc8d071bceae89f2af9690a1e2b202e5f23872b66de98098db04a487568d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "174dc8d071bceae89f2af9690a1e2b202e5f23872b66de98098db04a487568d4", kill_on_drop: false }` [INFO] [stdout] 174dc8d071bceae89f2af9690a1e2b202e5f23872b66de98098db04a487568d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b80244f9e091dc763ec5cb761e891f83138b6cd2735bd2c8b3004f42c724403b [INFO] running `Command { std: "docker" "start" "-a" "b80244f9e091dc763ec5cb761e891f83138b6cd2735bd2c8b3004f42c724403b", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Compiling unicode-width v0.1.4 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking lazy_static v0.2.9 [INFO] [stderr] Compiling ansi_term v0.9.0 [INFO] [stderr] Checking regex-syntax v0.4.1 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Compiling vec_map v0.8.0 [INFO] [stderr] Compiling strsim v0.6.0 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking fnv v1.0.5 [INFO] [stderr] Checking log v0.3.8 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking same-file v0.1.3 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Compiling version_check v0.1.3 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking crossbeam v0.2.10 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking walkdir v1.0.7 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking diff v0.1.10 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking ctrlc v3.0.3 [INFO] [stderr] Checking globset v0.2.0 [INFO] [stderr] Checking ignore v0.2.2 [INFO] [stderr] Compiling fd-find v6.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/app.rs:130:1 [INFO] [stdout] | [INFO] [stdout] 130 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/exec/command.rs:46:7 [INFO] [stdout] | [INFO] [stdout] 46 | #[cfg(all(unix))] [INFO] [stdout] | ^^^^^^^^^ help: try: `unix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/app.rs:130:1 [INFO] [stdout] | [INFO] [stdout] 130 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/exec/command.rs:46:7 [INFO] [stdout] | [INFO] [stdout] 46 | #[cfg(all(unix))] [INFO] [stdout] | ^^^^^^^^^ help: try: `unix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lscolors/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// A parser for the `LS_COLORS` environment variable. [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | use std::collections::HashMap; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 9 - /// A parser for the `LS_COLORS` environment variable. [INFO] [stdout] 9 + //! A parser for the `LS_COLORS` environment variable. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> tests/testenv/mod.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | temp_dir: temp_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> tests/testenv/mod.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | fd_exe: fd_exe, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `fd_exe` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/exec/mod.rs:94:27 [INFO] [stdout] | [INFO] [stdout] 94 | CommandTemplate { args: args } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/exec/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / lazy_static! { [INFO] [stdout] 43 | | static ref PLACEHOLDER_PATTERN: Regex = Regex::new(r"\{(/?\.?|//)\}").unwrap(); [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/exec/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / lazy_static! { [INFO] [stdout] 43 | | static ref PLACEHOLDER_PATTERN: Regex = Regex::new(r"\{(/?\.?|//)\}").unwrap(); [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lscolors/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// A parser for the `LS_COLORS` environment variable. [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | use std::collections::HashMap; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 9 - /// A parser for the `LS_COLORS` environment variable. [INFO] [stdout] 9 + //! A parser for the `LS_COLORS` environment variable. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left`: superseded by `trim_start` [INFO] [stdout] --> tests/testenv/mod.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | let line = if trim_left { line.trim_left() } else { line }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 130 - let line = if trim_left { line.trim_left() } else { line }; [INFO] [stdout] 130 + let line = if trim_left { line.trim_start() } else { line }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::os::unix::process::CommandExt::before_exec`: should be unsafe, use `pre_exec` instead [INFO] [stdout] --> src/exec/command.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | let child = cmd.before_exec(move || unsafe { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/exec/mod.rs:94:27 [INFO] [stdout] | [INFO] [stdout] 94 | CommandTemplate { args: args } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/exec/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / lazy_static! { [INFO] [stdout] 43 | | static ref PLACEHOLDER_PATTERN: Regex = Regex::new(r"\{(/?\.?|//)\}").unwrap(); [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/exec/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / lazy_static! { [INFO] [stdout] 43 | | static ref PLACEHOLDER_PATTERN: Regex = Regex::new(r"\{(/?\.?|//)\}").unwrap(); [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/main.rs:145:15 [INFO] [stdout] | [INFO] [stdout] 145 | e.trim_left_matches('.').to_lowercase() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 145 - e.trim_left_matches('.').to_lowercase() [INFO] [stdout] 145 + e.trim_start_matches('.').to_lowercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:159:31 [INFO] [stdout] | [INFO] [stdout] 159 | Err(err) => error(err.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a reference on `std::path::MAIN_SEPARATOR` conversion to `String` [INFO] [stdout] --> tests/testenv/mod.rs:131:31 [INFO] [stdout] | [INFO] [stdout] 131 | line.replace('/', &std::path::MAIN_SEPARATOR.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `std::path::MAIN_SEPARATOR_STR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_main_separator_str [INFO] [stdout] = note: `#[warn(clippy::manual_main_separator_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/testenv/mod.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 185 | panic!(format_exit_error(args, &output)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 185 | panic!("{}", format_exit_error(args, &output)); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/testenv/mod.rs:194:20 [INFO] [stdout] | [INFO] [stdout] 194 | panic!(format_output_error(args, &expected, &actual)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 194 | panic!("{}", format_output_error(args, &expected, &actual)); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path_display` is never read [INFO] [stdout] --> src/internal.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct FdOptions { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | pub path_display: PathDisplay, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lscolors/mod.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | u8::from_str_radix(num, 10).unwrap_or(n_white) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `num.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lscolors/mod.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 163 | if !parts.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parts.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lscolors/mod.rs:176:34 [INFO] [stdout] | [INFO] [stdout] 176 | ... _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 176 - _ => return, [INFO] [stdout] 176 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lscolors/mod.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 186 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - // Unknown/corrupt pattern [INFO] [stdout] 186 - return; [INFO] [stdout] 185 + // Unknown/corrupt pattern [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/lscolors/mod.rs:172:31 [INFO] [stdout] | [INFO] [stdout] 172 | match code.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::os::unix::process::CommandExt::before_exec`: should be unsafe, use `pre_exec` instead [INFO] [stdout] --> src/exec/command.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | let child = cmd.before_exec(move || unsafe { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/output.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn print_entry(entry: &PathBuf, config: &FdOptions, wants_to_quit: &Arc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn print_entry(entry: &PathBuf, config: &FdOptions, wants_to_quit: &Arc) { [INFO] [stdout] 23 + pub fn print_entry(entry: &Path, config: &FdOptions, wants_to_quit: &Arc) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/output.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | print_entry_colorized(path, config, ls_colors, &wants_to_quit) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `wants_to_quit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/output.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | write!(handle, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 75 - write!(handle, "\n")?; [INFO] [stdout] 75 + writeln!(handle)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/output.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | writeln!(handle, "") [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/walk.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | if let Some(_) = config.ls_colors { [INFO] [stdout] | -------^^^^^^^------------------- help: try: `if config.ls_colors.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/walk.rs:141:53 [INFO] [stdout] | [INFO] [stdout] 141 | ... output::print_entry(&v, &rx_config, &wants_to_quit); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:189:24 [INFO] [stdout] | [INFO] [stdout] 189 | if entry.file_type().map_or(true, |ft| !ft.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 189 - if entry.file_type().map_or(true, |ft| !ft.is_file()) { [INFO] [stdout] 189 + if entry.file_type().is_none_or(|ft| !ft.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 194 | if entry.file_type().map_or(true, |ft| !ft.is_dir()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 194 - if entry.file_type().map_or(true, |ft| !ft.is_dir()) { [INFO] [stdout] 194 + if entry.file_type().is_none_or(|ft| !ft.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:199:24 [INFO] [stdout] | [INFO] [stdout] 199 | if entry.file_type().map_or(true, |ft| !ft.is_symlink()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 199 - if entry.file_type().map_or(true, |ft| !ft.is_symlink()) { [INFO] [stdout] 199 + if entry.file_type().is_none_or(|ft| !ft.is_symlink()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:210:20 [INFO] [stdout] | [INFO] [stdout] 210 | if entry_ext.map_or(true, |ext| ext != *filter_ext) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 210 - if entry_ext.map_or(true, |ext| ext != *filter_ext) { [INFO] [stdout] 210 + if entry_ext.is_none_or(|ext| ext != *filter_ext) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/walk.rs:225:37 [INFO] [stdout] | [INFO] [stdout] 225 | if pattern.is_match(&*search_str) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `&search_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | usize::from_str_radix(n, 10).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:127:31 [INFO] [stdout] | [INFO] [stdout] 127 | .and_then(|n| usize::from_str_radix(n, 10).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:133:27 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|n| u64::from_str_radix(n, 10).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:151:29 [INFO] [stdout] | [INFO] [stdout] 151 | .unwrap_or_else(|| vec![]), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_left_matches`: superseded by `trim_start_matches` [INFO] [stdout] --> src/main.rs:145:15 [INFO] [stdout] | [INFO] [stdout] 145 | e.trim_left_matches('.').to_lowercase() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 145 - e.trim_left_matches('.').to_lowercase() [INFO] [stdout] 145 + e.trim_start_matches('.').to_lowercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:159:31 [INFO] [stdout] | [INFO] [stdout] 159 | Err(err) => error(err.description()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path_display` is never read [INFO] [stdout] --> src/internal.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct FdOptions { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | pub path_display: PathDisplay, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/lscolors/mod.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | u8::from_str_radix(num, 10).unwrap_or(n_white) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `num.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lscolors/mod.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 163 | if !parts.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parts.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lscolors/mod.rs:176:34 [INFO] [stdout] | [INFO] [stdout] 176 | ... _ => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 176 - _ => return, [INFO] [stdout] 176 + _ => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lscolors/mod.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 186 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - // Unknown/corrupt pattern [INFO] [stdout] 186 - return; [INFO] [stdout] 185 + // Unknown/corrupt pattern [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/lscolors/mod.rs:172:31 [INFO] [stdout] | [INFO] [stdout] 172 | match code.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `&String::new()` for a function expecting a `&str` argument [INFO] [stdout] --> src/lscolors/mod.rs:253:59 [INFO] [stdout] | [INFO] [stdout] 253 | assert_eq!(LsColors::default(), LsColors::from_string(&String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_owned_empty_strings [INFO] [stdout] = note: `#[warn(clippy::unnecessary_owned_empty_strings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taking a reference on `std::path::MAIN_SEPARATOR` conversion to `String` [INFO] [stdout] --> src/exec/input.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | input.replace('/', &MAIN_SEPARATOR.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `std::path::MAIN_SEPARATOR_STR` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_main_separator_str [INFO] [stdout] = note: `#[warn(clippy::manual_main_separator_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/exec/mod.rs:165:41 [INFO] [stdout] | [INFO] [stdout] 165 | assert_eq!(CommandTemplate::new(&[&"echo", &"${SHELL}:"]), expected); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[&"echo", &"${SHELL}:"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/exec/mod.rs:168:34 [INFO] [stdout] | [INFO] [stdout] 168 | CommandTemplate::new(&["echo", "{.}"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `["echo", "{.}"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/output.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn print_entry(entry: &PathBuf, config: &FdOptions, wants_to_quit: &Arc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - pub fn print_entry(entry: &PathBuf, config: &FdOptions, wants_to_quit: &Arc) { [INFO] [stdout] 23 + pub fn print_entry(entry: &Path, config: &FdOptions, wants_to_quit: &Arc) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/output.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | print_entry_colorized(path, config, ls_colors, &wants_to_quit) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `wants_to_quit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/output.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | write!(handle, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 75 - write!(handle, "\n")?; [INFO] [stdout] 75 + writeln!(handle)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/output.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | writeln!(handle, "") [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/walk.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | if let Some(_) = config.ls_colors { [INFO] [stdout] | -------^^^^^^^------------------- help: try: `if config.ls_colors.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/walk.rs:141:53 [INFO] [stdout] | [INFO] [stdout] 141 | ... output::print_entry(&v, &rx_config, &wants_to_quit); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:189:24 [INFO] [stdout] | [INFO] [stdout] 189 | if entry.file_type().map_or(true, |ft| !ft.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 189 - if entry.file_type().map_or(true, |ft| !ft.is_file()) { [INFO] [stdout] 189 + if entry.file_type().is_none_or(|ft| !ft.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 194 | if entry.file_type().map_or(true, |ft| !ft.is_dir()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 194 - if entry.file_type().map_or(true, |ft| !ft.is_dir()) { [INFO] [stdout] 194 + if entry.file_type().is_none_or(|ft| !ft.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:199:24 [INFO] [stdout] | [INFO] [stdout] 199 | if entry.file_type().map_or(true, |ft| !ft.is_symlink()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 199 - if entry.file_type().map_or(true, |ft| !ft.is_symlink()) { [INFO] [stdout] 199 + if entry.file_type().is_none_or(|ft| !ft.is_symlink()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/walk.rs:210:20 [INFO] [stdout] | [INFO] [stdout] 210 | if entry_ext.map_or(true, |ext| ext != *filter_ext) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 210 - if entry_ext.map_or(true, |ext| ext != *filter_ext) { [INFO] [stdout] 210 + if entry_ext.is_none_or(|ext| ext != *filter_ext) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/walk.rs:225:37 [INFO] [stdout] | [INFO] [stdout] 225 | if pattern.is_match(&*search_str) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `&search_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | usize::from_str_radix(n, 10).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:127:31 [INFO] [stdout] | [INFO] [stdout] 127 | .and_then(|n| usize::from_str_radix(n, 10).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:133:27 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|n| u64::from_str_radix(n, 10).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:151:29 [INFO] [stdout] | [INFO] [stdout] 151 | .unwrap_or_else(|| vec![]), [INFO] [stdout] | ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.81s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "b80244f9e091dc763ec5cb761e891f83138b6cd2735bd2c8b3004f42c724403b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b80244f9e091dc763ec5cb761e891f83138b6cd2735bd2c8b3004f42c724403b", kill_on_drop: false }` [INFO] [stdout] b80244f9e091dc763ec5cb761e891f83138b6cd2735bd2c8b3004f42c724403b