[INFO] cloning repository https://github.com/Hamilt79/phrase-guesser
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hamilt79/phrase-guesser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHamilt79%2Fphrase-guesser", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHamilt79%2Fphrase-guesser'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] ca7aff92a8440d764589d39d1ea57f24e371b111
[INFO] linting Hamilt79/phrase-guesser against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHamilt79%2Fphrase-guesser" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Hamilt79/phrase-guesser
[INFO] finished tweaking git repo https://github.com/Hamilt79/phrase-guesser
[INFO] tweaked toml for git repo https://github.com/Hamilt79/phrase-guesser written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Hamilt79/phrase-guesser on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Hamilt79/phrase-guesser already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded toml_datetime v0.6.8
[INFO] [stderr]   Downloaded version_check v0.9.5
[INFO] [stderr]   Downloaded serde_spanned v0.6.7
[INFO] [stderr]   Downloaded static_vcruntime v2.0.0
[INFO] [stderr]   Downloaded serde v1.0.208
[INFO] [stderr]   Downloaded serde_derive v1.0.208
[INFO] [stderr]   Downloaded toml_edit v0.19.15
[INFO] [stderr]   Downloaded indexmap v2.4.0
[INFO] [stderr]   Downloaded memchr v2.7.4
[INFO] [stderr]   Downloaded hashbrown v0.14.5
[INFO] [stderr]   Downloaded winnow v0.5.40
[INFO] [stderr]   Downloaded winresource v0.1.17
[INFO] [stderr]   Downloaded toml v0.7.8
[INFO] [stderr]   Downloaded syn v2.0.74
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 2b8361881f90e1d137c17f943a8c77b187840b290499db9fe511a9cd218b9bef
[INFO] running `Command { std: "docker" "start" "-a" "2b8361881f90e1d137c17f943a8c77b187840b290499db9fe511a9cd218b9bef", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "2b8361881f90e1d137c17f943a8c77b187840b290499db9fe511a9cd218b9bef", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2b8361881f90e1d137c17f943a8c77b187840b290499db9fe511a9cd218b9bef", kill_on_drop: false }`
[INFO] [stdout] 2b8361881f90e1d137c17f943a8c77b187840b290499db9fe511a9cd218b9bef
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 7b257a3ab6afb3f3298353c85daad1ac5430f10a3b060f6d9241c9e9053501ae
[INFO] running `Command { std: "docker" "start" "-a" "7b257a3ab6afb3f3298353c85daad1ac5430f10a3b060f6d9241c9e9053501ae", kill_on_drop: false }`
[INFO] [stderr]    Compiling serde v1.0.208
[INFO] [stderr]    Compiling equivalent v1.0.1
[INFO] [stderr]    Compiling hashbrown v0.14.5
[INFO] [stderr]    Compiling winnow v0.5.40
[INFO] [stderr]    Compiling version_check v0.9.5
[INFO] [stderr]    Compiling static_vcruntime v2.0.0
[INFO] [stderr]    Compiling indexmap v2.4.0
[INFO] [stderr]    Compiling serde_spanned v0.6.7
[INFO] [stderr]    Compiling toml_datetime v0.6.8
[INFO] [stderr]    Compiling toml_edit v0.19.15
[INFO] [stderr]    Compiling toml v0.7.8
[INFO] [stderr]    Compiling winresource v0.1.17
[INFO] [stderr]    Compiling phrase-guesser v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         let phrase_count: i32;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `phrase_count` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 21 ~         
[INFO] [stdout] 22 ~         let phrase_count: i32 = match get_word_count() {
[INFO] [stdout] 23 |             Ok(count) => {
[INFO] [stdout] 24 ~                 count
[INFO] [stdout] 25 |             },
[INFO] [stdout] ...
[INFO] [stdout] 31 |             }
[INFO] [stdout] 32 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:34:9
[INFO] [stdout]    |
[INFO] [stdout] 34 |         let max_num_words: i32;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `max_num_words` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 34 ~         
[INFO] [stdout] 35 ~         let max_num_words: i32 = match get_max_num_words() {
[INFO] [stdout] 36 |             Ok(count) => {
[INFO] [stdout] 37 ~                 count
[INFO] [stdout] 38 |             },
[INFO] [stdout] ...
[INFO] [stdout] 41 |             },
[INFO] [stdout] 42 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:49:61
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let (all_pos_words, most_words) = get_all_pos_words(&words, max_num_words, &all_user_words);
[INFO] [stdout]    |                                                             ^^^^^^ help: change this to: `words`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:90:73
[INFO] [stdout]    |
[INFO] [stdout] 90 | fn get_all_pos_words(words: &Vec<&str>, max_num_words: i32, user_words: &Vec<String>) -> (Vec<Vec<String>>, usize) {
[INFO] [stdout]    |                                                                         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 90 - fn get_all_pos_words(words: &Vec<&str>, max_num_words: i32, user_words: &Vec<String>) -> (Vec<Vec<String>>, usize) {
[INFO] [stdout] 90 + fn get_all_pos_words(words: &Vec<&str>, max_num_words: i32, user_words: &[String]) -> (Vec<Vec<String>>, usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `user_words`
[INFO] [stdout]   --> src/main.rs:93:14
[INFO] [stdout]    |
[INFO] [stdout] 93 |     for i in 0..user_words.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 93 -     for i in 0..user_words.len() {
[INFO] [stdout] 93 +     for <item> in &user_words {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:94:44
[INFO] [stdout]    |
[INFO] [stdout] 94 |         let pos_words = get_possible_words(&words, max_num_words, &user_words[i]);
[INFO] [stdout]    |                                            ^^^^^^ help: change this to: `words`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:174:19
[INFO] [stdout]     |
[INFO] [stdout] 174 |             while !word_next.is_none() && !user_next.is_none() {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `word_next.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:174:43
[INFO] [stdout]     |
[INFO] [stdout] 174 |             while !word_next.is_none() && !user_next.is_none() {
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^ help: try: `user_next.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         let phrase_count: i32;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `phrase_count` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 21 ~         
[INFO] [stdout] 22 ~         let phrase_count: i32 = match get_word_count() {
[INFO] [stdout] 23 |             Ok(count) => {
[INFO] [stdout] 24 ~                 count
[INFO] [stdout] 25 |             },
[INFO] [stdout] ...
[INFO] [stdout] 31 |             }
[INFO] [stdout] 32 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:34:9
[INFO] [stdout]    |
[INFO] [stdout] 34 |         let max_num_words: i32;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `max_num_words` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 34 ~         
[INFO] [stdout] 35 ~         let max_num_words: i32 = match get_max_num_words() {
[INFO] [stdout] 36 |             Ok(count) => {
[INFO] [stdout] 37 ~                 count
[INFO] [stdout] 38 |             },
[INFO] [stdout] ...
[INFO] [stdout] 41 |             },
[INFO] [stdout] 42 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:49:61
[INFO] [stdout]    |
[INFO] [stdout] 49 |         let (all_pos_words, most_words) = get_all_pos_words(&words, max_num_words, &all_user_words);
[INFO] [stdout]    |                                                             ^^^^^^ help: change this to: `words`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:90:73
[INFO] [stdout]    |
[INFO] [stdout] 90 | fn get_all_pos_words(words: &Vec<&str>, max_num_words: i32, user_words: &Vec<String>) -> (Vec<Vec<String>>, usize) {
[INFO] [stdout]    |                                                                         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 90 - fn get_all_pos_words(words: &Vec<&str>, max_num_words: i32, user_words: &Vec<String>) -> (Vec<Vec<String>>, usize) {
[INFO] [stdout] 90 + fn get_all_pos_words(words: &Vec<&str>, max_num_words: i32, user_words: &[String]) -> (Vec<Vec<String>>, usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `user_words`
[INFO] [stdout]   --> src/main.rs:93:14
[INFO] [stdout]    |
[INFO] [stdout] 93 |     for i in 0..user_words.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 93 -     for i in 0..user_words.len() {
[INFO] [stdout] 93 +     for <item> in &user_words {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:94:44
[INFO] [stdout]    |
[INFO] [stdout] 94 |         let pos_words = get_possible_words(&words, max_num_words, &user_words[i]);
[INFO] [stdout]    |                                            ^^^^^^ help: change this to: `words`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:174:19
[INFO] [stdout]     |
[INFO] [stdout] 174 |             while !word_next.is_none() && !user_next.is_none() {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `word_next.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:174:43
[INFO] [stdout]     |
[INFO] [stdout] 174 |             while !word_next.is_none() && !user_next.is_none() {
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^ help: try: `user_next.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.37s
[INFO] running `Command { std: "docker" "inspect" "7b257a3ab6afb3f3298353c85daad1ac5430f10a3b060f6d9241c9e9053501ae", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7b257a3ab6afb3f3298353c85daad1ac5430f10a3b060f6d9241c9e9053501ae", kill_on_drop: false }`
[INFO] [stdout] 7b257a3ab6afb3f3298353c85daad1ac5430f10a3b060f6d9241c9e9053501ae