[INFO] cloning repository https://github.com/Hadi-Obeid/hack-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hadi-Obeid/hack-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHadi-Obeid%2Fhack-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHadi-Obeid%2Fhack-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] daa7c6c5aaf3550c10c8ee67a4e9281b75dfbe48 [INFO] linting Hadi-Obeid/hack-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHadi-Obeid%2Fhack-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Hadi-Obeid/hack-rs [INFO] finished tweaking git repo https://github.com/Hadi-Obeid/hack-rs [INFO] tweaked toml for git repo https://github.com/Hadi-Obeid/hack-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Hadi-Obeid/hack-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Hadi-Obeid/hack-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6c0c537b25464757cd5aca6e0dc36b114113304f3c6f147ee2c6e47b477c7a4 [INFO] running `Command { std: "docker" "start" "-a" "c6c0c537b25464757cd5aca6e0dc36b114113304f3c6f147ee2c6e47b477c7a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6c0c537b25464757cd5aca6e0dc36b114113304f3c6f147ee2c6e47b477c7a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6c0c537b25464757cd5aca6e0dc36b114113304f3c6f147ee2c6e47b477c7a4", kill_on_drop: false }` [INFO] [stdout] c6c0c537b25464757cd5aca6e0dc36b114113304f3c6f147ee2c6e47b477c7a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1879453f9a900c33cc44c7c33e095bf8f6e1449e76b6bc0dabcb7f7500937872 [INFO] running `Command { std: "docker" "start" "-a" "1879453f9a900c33cc44c7c33e095bf8f6e1449e76b6bc0dabcb7f7500937872", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking hack-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `BufRead` [INFO] [stdout] --> src/assembler/mod.rs:1:15 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io::{BufRead, BufReader, BufWriter, Read, Seek, Write}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufRead` [INFO] [stdout] --> src/assembler/mod.rs:1:15 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io::{BufRead, BufReader, BufWriter, Read, Seek, Write}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/assembler/symbol.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/assembler/symbol.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/assembler/mod.rs:9:22 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn assemble_file(input: BufReader, output: &mut BufWriter) -> std::io::Result<()> [INFO] [stdout] | ^ [INFO] [stdout] 10 | where U: Seek [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Error`, `Result`, and `Seek` [INFO] [stdout] --> src/vm/parser.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{BufRead, Error, Read, Result, Seek}; [INFO] [stdout] | ^^^^^ ^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/vm/parser.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/assembler/mod.rs:9:22 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn assemble_file(input: BufReader, output: &mut BufWriter) -> std::io::Result<()> [INFO] [stdout] | ^ [INFO] [stdout] 10 | where U: Seek [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Error`, `Result`, and `Seek` [INFO] [stdout] --> src/vm/parser.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{BufRead, Error, Read, Result, Seek}; [INFO] [stdout] | ^^^^^ ^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vm::parser` [INFO] [stdout] --> src/vm/parser.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | use crate::vm::parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `result` is never read [INFO] [stdout] --> src/assembler/code.rs:63:27 [INFO] [stdout] | [INFO] [stdout] 63 | let mut result: u16 = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `result` is never read [INFO] [stdout] --> src/assembler/code.rs:63:27 [INFO] [stdout] | [INFO] [stdout] 63 | let mut result: u16 = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | let mut output = BufWriter::new(File::create(out_path).expect("Failed to create output")); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/main.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let input = BufReader::new(File::open(&opt.input).expect("Failed to open file")); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/main.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | let mut output = BufWriter::new(File::create(out_path).expect("Failed to create output")); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `assemble_file` is never used [INFO] [stdout] --> src/assembler/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn assemble_file(input: BufReader, output: &mut BufWriter) -> std::io::Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dest` is never used [INFO] [stdout] --> src/assembler/code.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn dest(instruction: &str) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp` is never used [INFO] [stdout] --> src/assembler/code.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn comp(instruction: &str) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `jump` is never used [INFO] [stdout] --> src/assembler/code.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn jump(instruction: &str) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `SymbolTableT` is never used [INFO] [stdout] --> src/assembler/symbol.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | pub type SymbolTableT = HashMap; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SymbolTable` is never constructed [INFO] [stdout] --> src/assembler/symbol.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct SymbolTable { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Variables` is never used [INFO] [stdout] --> src/assembler/symbol.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 12 | pub type Variables = Vec; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_variable` is never used [INFO] [stdout] --> src/assembler/symbol.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn insert_variable(vars: &mut Variables, varname: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `remove_variable` is never used [INFO] [stdout] --> src/assembler/symbol.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn remove_variable(vars: &mut Variables, varname: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `add_entry`, `get_entry`, `contains`, and `init_vars` are never used [INFO] [stdout] --> src/assembler/symbol.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | impl SymbolTable { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 33 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn add_entry(&mut self, symbol: &str, address: u16) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn get_entry(&self, symbol: &str) -> Option<&u16> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn contains(&self, symbol: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | pub fn init_vars(&mut self, vars: Variables) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Parser` is never constructed [INFO] [stdout] --> src/assembler/parser.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Parser { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `InstructionType` is never used [INFO] [stdout] --> src/assembler/parser.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | pub enum InstructionType { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `load_buffer`, `reset`, `has_more_lines`, `read_line`, and `advance` are never used [INFO] [stdout] --> src/assembler/parser.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Parser { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] 39 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn load_buffer(&mut self, buf: BufReader) where T: Read + Seek { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn reset(&mut self) -> Result where T: Seek { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn has_more_lines(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn read_line(&mut self) where T: Read { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | pub fn advance(&mut self) -> &str where T: Read { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `instruction_type` is never used [INFO] [stdout] --> src/assembler/parser.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn instruction_type(instruction: &str) -> InstructionType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `symbol` is never used [INFO] [stdout] --> src/assembler/parser.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn symbol(instruction: &str) -> Result<&str> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dest` is never used [INFO] [stdout] --> src/assembler/parser.rs:131:8 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn dest(instruction: &str) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp` is never used [INFO] [stdout] --> src/assembler/parser.rs:141:8 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn comp(instruction: &str) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `jump` is never used [INFO] [stdout] --> src/assembler/parser.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn jump(instruction: &str) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CommandType` is never used [INFO] [stdout] --> src/vm/parser.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | pub enum CommandType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Parser` is never constructed [INFO] [stdout] --> src/vm/parser.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Parser { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `read_line`, `advance`, and `command_type` are never used [INFO] [stdout] --> src/vm/parser.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl Parser { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 38 | pub fn new(buf: BufReader) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | fn read_line(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub fn advance(&mut self) -> (bool, &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | fn command_type(&self) -> CommandType { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | let mut output = BufWriter::new(File::create(out_path).expect("Failed to create output")); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/main.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let input = BufReader::new(File::open(&opt.input).expect("Failed to open file")); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/main.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | let mut output = BufWriter::new(File::create(out_path).expect("Failed to create output")); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `assemble_file` is never used [INFO] [stdout] --> src/assembler/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn assemble_file(input: BufReader, output: &mut BufWriter) -> std::io::Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dest` is never used [INFO] [stdout] --> src/assembler/code.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn dest(instruction: &str) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp` is never used [INFO] [stdout] --> src/assembler/code.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn comp(instruction: &str) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `jump` is never used [INFO] [stdout] --> src/assembler/code.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn jump(instruction: &str) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `SymbolTableT` is never used [INFO] [stdout] --> src/assembler/symbol.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | pub type SymbolTableT = HashMap; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SymbolTable` is never constructed [INFO] [stdout] --> src/assembler/symbol.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct SymbolTable { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Variables` is never used [INFO] [stdout] --> src/assembler/symbol.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 12 | pub type Variables = Vec; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_variable` is never used [INFO] [stdout] --> src/assembler/symbol.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn insert_variable(vars: &mut Variables, varname: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `remove_variable` is never used [INFO] [stdout] --> src/assembler/symbol.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn remove_variable(vars: &mut Variables, varname: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `add_entry`, `get_entry`, `contains`, and `init_vars` are never used [INFO] [stdout] --> src/assembler/symbol.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 32 | impl SymbolTable { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 33 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn add_entry(&mut self, symbol: &str, address: u16) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn get_entry(&self, symbol: &str) -> Option<&u16> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn contains(&self, symbol: &str) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | pub fn init_vars(&mut self, vars: Variables) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Parser` is never constructed [INFO] [stdout] --> src/assembler/parser.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Parser { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `InstructionType` is never used [INFO] [stdout] --> src/assembler/parser.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | pub enum InstructionType { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `load_buffer`, `reset`, `has_more_lines`, `read_line`, and `advance` are never used [INFO] [stdout] --> src/assembler/parser.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl Parser { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] 39 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn load_buffer(&mut self, buf: BufReader) where T: Read + Seek { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn reset(&mut self) -> Result where T: Seek { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn has_more_lines(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn read_line(&mut self) where T: Read { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | pub fn advance(&mut self) -> &str where T: Read { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `instruction_type` is never used [INFO] [stdout] --> src/assembler/parser.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn instruction_type(instruction: &str) -> InstructionType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `symbol` is never used [INFO] [stdout] --> src/assembler/parser.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn symbol(instruction: &str) -> Result<&str> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dest` is never used [INFO] [stdout] --> src/assembler/parser.rs:131:8 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn dest(instruction: &str) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp` is never used [INFO] [stdout] --> src/assembler/parser.rs:141:8 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn comp(instruction: &str) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `jump` is never used [INFO] [stdout] --> src/assembler/parser.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn jump(instruction: &str) -> &str { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CommandType` is never used [INFO] [stdout] --> src/vm/parser.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | pub enum CommandType { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `command_type` is never used [INFO] [stdout] --> src/vm/parser.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 37 | impl Parser { [INFO] [stdout] | ----------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | fn command_type(&self) -> CommandType { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/assembler/symbol.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if let None = idx { [INFO] [stdout] | -------^^^^------ help: try: `if idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/assembler/symbol.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if let None = idx { [INFO] [stdout] | -------^^^^------ help: try: `if idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/assembler/symbol.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 75 | self.add_entry(&var, i as u16 + 16); [INFO] [stdout] | ^^^^ help: change this to: `var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/assembler/symbol.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 75 | self.add_entry(&var, i as u16 + 16); [INFO] [stdout] | ^^^^ help: change this to: `var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Instruction` [INFO] [stdout] --> src/assembler/parser.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / pub enum InstructionType { [INFO] [stdout] 32 | | AInstruction, [INFO] [stdout] 33 | | CInstruction, [INFO] [stdout] 34 | | LInstruction, [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Instruction` [INFO] [stdout] --> src/assembler/parser.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / pub enum InstructionType { [INFO] [stdout] 32 | | AInstruction, [INFO] [stdout] 33 | | CInstruction, [INFO] [stdout] 34 | | LInstruction, [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/parser.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return InstructionType::AInstruction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return InstructionType::AInstruction; [INFO] [stdout] 110 + InstructionType::AInstruction [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/parser.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return InstructionType::LInstruction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return InstructionType::LInstruction; [INFO] [stdout] 112 + InstructionType::LInstruction [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/parser.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return InstructionType::CInstruction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return InstructionType::CInstruction; [INFO] [stdout] 114 + InstructionType::CInstruction [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/assembler/parser.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | Ok(&instruction[1..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/assembler/parser.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | if instruction.starts_with("@") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Some() = instruction.strip_prefix("@") { [INFO] [stdout] 120 ~ Ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/parser.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return InstructionType::AInstruction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return InstructionType::AInstruction; [INFO] [stdout] 110 + InstructionType::AInstruction [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/parser.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return InstructionType::LInstruction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return InstructionType::LInstruction; [INFO] [stdout] 112 + InstructionType::LInstruction [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/parser.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return InstructionType::CInstruction; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return InstructionType::CInstruction; [INFO] [stdout] 114 + InstructionType::CInstruction [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/assembler/parser.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | let eq = if let Some(eq) = instruction.find("=") { eq } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction.find("=").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/assembler/parser.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | Ok(&instruction[1..]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/assembler/parser.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 119 | if instruction.starts_with("@") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 119 ~ if let Some() = instruction.strip_prefix("@") { [INFO] [stdout] 120 ~ Ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/mod.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | if !symbol.parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `symbol.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/assembler/parser.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | let eq = if let Some(eq) = instruction.find("=") { eq } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction.find("=").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/mod.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | if !symbol.parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `symbol.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/assembler/mod.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | if instruction == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `instruction.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/assembler/mod.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | if instruction == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `instruction.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/assembler/mod.rs:104:35 [INFO] [stdout] | [INFO] [stdout] 104 | let word = word | (code::jump(&instruction) << 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `code::jump(&instruction)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/assembler/mod.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | writeln!(output, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/assembler/mod.rs:104:35 [INFO] [stdout] | [INFO] [stdout] 104 | let word = word | (code::jump(&instruction) << 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `code::jump(&instruction)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/assembler/mod.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | writeln!(output, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/vm/parser.rs:120:16 [INFO] [stdout] | [INFO] [stdout] 120 | if instruction.0 == false { break; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!instruction.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.82s [INFO] running `Command { std: "docker" "inspect" "1879453f9a900c33cc44c7c33e095bf8f6e1449e76b6bc0dabcb7f7500937872", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1879453f9a900c33cc44c7c33e095bf8f6e1449e76b6bc0dabcb7f7500937872", kill_on_drop: false }` [INFO] [stdout] 1879453f9a900c33cc44c7c33e095bf8f6e1449e76b6bc0dabcb7f7500937872