[INFO] cloning repository https://github.com/HEnquist/twowaysync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HEnquist/twowaysync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHEnquist%2Ftwowaysync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHEnquist%2Ftwowaysync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab15edaae19794960c18d55586736c169b0c4f24 [INFO] linting HEnquist/twowaysync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHEnquist%2Ftwowaysync" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HEnquist/twowaysync [INFO] finished tweaking git repo https://github.com/HEnquist/twowaysync [INFO] tweaked toml for git repo https://github.com/HEnquist/twowaysync written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HEnquist/twowaysync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HEnquist/twowaysync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded termion v1.5.3 [INFO] [stderr] Downloaded walkdir v2.2.9 [INFO] [stderr] Downloaded same-file v1.0.5 [INFO] [stderr] Downloaded ryu v1.0.0 [INFO] [stderr] Downloaded filetime v0.2.7 [INFO] [stderr] Downloaded globset v0.4.4 [INFO] [stderr] Downloaded proc-macro2 v1.0.5 [INFO] [stderr] Downloaded serde_derive v1.0.101 [INFO] [stderr] Downloaded serde v1.0.101 [INFO] [stderr] Downloaded chrono v0.4.9 [INFO] [stderr] Downloaded bstr v0.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5fd30226871f716e12639be90225d956a55b3c422dff215493ac9fd1dff61fee [INFO] running `Command { std: "docker" "start" "-a" "5fd30226871f716e12639be90225d956a55b3c422dff215493ac9fd1dff61fee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5fd30226871f716e12639be90225d956a55b3c422dff215493ac9fd1dff61fee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fd30226871f716e12639be90225d956a55b3c422dff215493ac9fd1dff61fee", kill_on_drop: false }` [INFO] [stdout] 5fd30226871f716e12639be90225d956a55b3c422dff215493ac9fd1dff61fee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4aef6f447b03134f2e60bd3b178925b2ab7abfd849e3202c86c81decc3f8319 [INFO] running `Command { std: "docker" "start" "-a" "a4aef6f447b03134f2e60bd3b178925b2ab7abfd849e3202c86c81decc3f8319", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking filetime v0.2.7 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking globset v0.4.4 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking twowaysync v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/datatypes.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | diff: diff, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/datatypes.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | ftype: ftype, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `ftype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/datatypes.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | mtime: mtime, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/datatypes.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | ) => (dest_a == dest_b), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 174 - ) => (dest_a == dest_b), [INFO] [stdout] 174 + ) => dest_a == dest_b , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | mtime: mtime, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | ftype: ftype, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `ftype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/datatypes.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/datatypes.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | diff: diff, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/datatypes.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | ftype: ftype, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `ftype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/datatypes.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | mtime: mtime, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/datatypes.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | ) => (dest_a == dest_b), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 174 - ) => (dest_a == dest_b), [INFO] [stdout] 174 + ) => dest_a == dest_b , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | mtime: mtime, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | ftype: ftype, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `ftype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/datatypes.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | / match self { [INFO] [stdout] 114 | | &SyncAction::CopyFile { src: _, dest: _ } => 2, [INFO] [stdout] 115 | | &SyncAction::CopyDir { src: _, dest: _ } => 1, [INFO] [stdout] 116 | | &SyncAction::CopyLink { src: _, dest: _ } => 4, [INFO] [stdout] ... | [INFO] [stdout] 119 | | &SyncAction::DeleteDir { dest: _ } => 6, [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 113 ~ match *self { [INFO] [stdout] 114 ~ SyncAction::CopyFile { src: _, dest: _ } => 2, [INFO] [stdout] 115 ~ SyncAction::CopyDir { src: _, dest: _ } => 1, [INFO] [stdout] 116 ~ SyncAction::CopyLink { src: _, dest: _ } => 4, [INFO] [stdout] 117 ~ SyncAction::CopyMeta { src: _, dest: _ } => 7, [INFO] [stdout] 118 ~ SyncAction::DeleteFile { dest: _ } => 5, [INFO] [stdout] 119 ~ SyncAction::DeleteDir { dest: _ } => 6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/datatypes.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | / &SyncAction::CopyMeta { [INFO] [stdout] 215 | | src: ref src_a, [INFO] [stdout] 216 | | dest: _, [INFO] [stdout] 217 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 214 ~ SyncAction::CopyMeta { [INFO] [stdout] 215 ~ src: src_a, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/datatypes.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | / &SyncAction::CopyMeta { [INFO] [stdout] 219 | | src: ref src_b, [INFO] [stdout] 220 | | dest: _, [INFO] [stdout] 221 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 218 ~ SyncAction::CopyMeta { [INFO] [stdout] 219 ~ src: src_b, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/datatypes.rs:240:23 [INFO] [stdout] | [INFO] [stdout] 240 | Some(self.cmp(&other)) [INFO] [stdout] | ^^^^^^ help: change this to: `other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/datatypes.rs:277:20 [INFO] [stdout] | [INFO] [stdout] 277 | if !fs::metadata(&dest).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&dest).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:265:33 [INFO] [stdout] | [INFO] [stdout] 265 | if fs::metadata(&dest).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:266:50 [INFO] [stdout] | [INFO] [stdout] 266 | let mut perms = fs::metadata(&dest)?.permissions(); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/datatypes.rs:269:25 [INFO] [stdout] | [INFO] [stdout] 269 | perms.set_readonly(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] = note: `#[warn(clippy::permissions_set_readonly_false)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:270:45 [INFO] [stdout] | [INFO] [stdout] 270 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:273:45 [INFO] [stdout] | [INFO] [stdout] 273 | let _bytescopied = fs::copy(&src, &dest)?; [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:273:51 [INFO] [stdout] | [INFO] [stdout] 273 | let _bytescopied = fs::copy(&src, &dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:277:34 [INFO] [stdout] | [INFO] [stdout] 277 | if !fs::metadata(&dest).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:278:36 [INFO] [stdout] | [INFO] [stdout] 278 | fs::create_dir(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:283:42 [INFO] [stdout] | [INFO] [stdout] 283 | let perms = fs::metadata(&src)?.permissions(); [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:284:37 [INFO] [stdout] | [INFO] [stdout] 284 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:285:41 [INFO] [stdout] | [INFO] [stdout] 285 | let attr = fs::metadata(&src)?; [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/datatypes.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | / match self { [INFO] [stdout] 114 | | &SyncAction::CopyFile { src: _, dest: _ } => 2, [INFO] [stdout] 115 | | &SyncAction::CopyDir { src: _, dest: _ } => 1, [INFO] [stdout] 116 | | &SyncAction::CopyLink { src: _, dest: _ } => 4, [INFO] [stdout] ... | [INFO] [stdout] 119 | | &SyncAction::DeleteDir { dest: _ } => 6, [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 113 ~ match *self { [INFO] [stdout] 114 ~ SyncAction::CopyFile { src: _, dest: _ } => 2, [INFO] [stdout] 115 ~ SyncAction::CopyDir { src: _, dest: _ } => 1, [INFO] [stdout] 116 ~ SyncAction::CopyLink { src: _, dest: _ } => 4, [INFO] [stdout] 117 ~ SyncAction::CopyMeta { src: _, dest: _ } => 7, [INFO] [stdout] 118 ~ SyncAction::DeleteFile { dest: _ } => 5, [INFO] [stdout] 119 ~ SyncAction::DeleteDir { dest: _ } => 6, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:288:53 [INFO] [stdout] | [INFO] [stdout] 288 | let _res = filetime::set_file_times(&dest, atime, mtime); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:295:37 [INFO] [stdout] | [INFO] [stdout] 295 | fs::remove_file(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:301:46 [INFO] [stdout] | [INFO] [stdout] 301 | let mut perms = fs::metadata(&dest)?.permissions(); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/datatypes.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | perms.set_readonly(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:305:41 [INFO] [stdout] | [INFO] [stdout] 305 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:307:33 [INFO] [stdout] | [INFO] [stdout] 307 | fs::remove_file(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:311:46 [INFO] [stdout] | [INFO] [stdout] 311 | let mut perms = fs::metadata(&dest)?.permissions(); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/datatypes.rs:314:21 [INFO] [stdout] | [INFO] [stdout] 314 | perms.set_readonly(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:315:41 [INFO] [stdout] | [INFO] [stdout] 315 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/datatypes.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | / &SyncAction::CopyMeta { [INFO] [stdout] 215 | | src: ref src_a, [INFO] [stdout] 216 | | dest: _, [INFO] [stdout] 217 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 214 ~ SyncAction::CopyMeta { [INFO] [stdout] 215 ~ src: src_a, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:317:32 [INFO] [stdout] | [INFO] [stdout] 317 | fs::remove_dir(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/datatypes.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | / &SyncAction::CopyMeta { [INFO] [stdout] 219 | | src: ref src_b, [INFO] [stdout] 220 | | dest: _, [INFO] [stdout] 221 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 218 ~ SyncAction::CopyMeta { [INFO] [stdout] 219 ~ src: src_b, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/datatypes.rs:240:23 [INFO] [stdout] | [INFO] [stdout] 240 | Some(self.cmp(&other)) [INFO] [stdout] | ^^^^^^ help: change this to: `other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | fn map_dir(basepath: &PathBuf, exclude_globs: &GlobSet) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ fn map_dir(basepath: &Path, exclude_globs: &GlobSet) -> Result> { [INFO] [stdout] 33 | let basepath_str = basepath.to_str().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 38 | let depth = usize::max_value(); [INFO] [stdout] 39 ~ for direntry in WalkDir::new(basepath.to_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/main.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let depth = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 38 - let depth = usize::max_value(); [INFO] [stdout] 38 + let depth = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:43:73 [INFO] [stdout] | [INFO] [stdout] 43 | .filter_entry(|e| !exclude_globs.is_match(e.path().strip_prefix(&basepath_str).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `basepath_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/datatypes.rs:277:20 [INFO] [stdout] | [INFO] [stdout] 277 | if !fs::metadata(&dest).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&dest).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:50:41 [INFO] [stdout] | [INFO] [stdout] 50 | let relpath = path.strip_prefix(&basepath_str).unwrap().to_path_buf(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `basepath_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:265:33 [INFO] [stdout] | [INFO] [stdout] 265 | if fs::metadata(&dest).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:266:50 [INFO] [stdout] | [INFO] [stdout] 266 | let mut perms = fs::metadata(&dest)?.permissions(); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/datatypes.rs:269:25 [INFO] [stdout] | [INFO] [stdout] 269 | perms.set_readonly(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] = note: `#[warn(clippy::permissions_set_readonly_false)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:270:45 [INFO] [stdout] | [INFO] [stdout] 270 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:273:45 [INFO] [stdout] | [INFO] [stdout] 273 | let _bytescopied = fs::copy(&src, &dest)?; [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:273:51 [INFO] [stdout] | [INFO] [stdout] 273 | let _bytescopied = fs::copy(&src, &dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:277:34 [INFO] [stdout] | [INFO] [stdout] 277 | if !fs::metadata(&dest).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:278:36 [INFO] [stdout] | [INFO] [stdout] 278 | fs::create_dir(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:283:42 [INFO] [stdout] | [INFO] [stdout] 283 | let perms = fs::metadata(&src)?.permissions(); [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:284:37 [INFO] [stdout] | [INFO] [stdout] 284 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:285:41 [INFO] [stdout] | [INFO] [stdout] 285 | let attr = fs::metadata(&src)?; [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | / match diff_copy.get(path) { [INFO] [stdout] 141 | | Some(diffitem_copy) => { [INFO] [stdout] 142 | | match (&diffitem_master.diff, &diffitem_copy.diff) { [INFO] [stdout] 143 | | (ChangeType::Newer, ChangeType::Newer) [INFO] [stdout] ... | [INFO] [stdout] 171 | | None => {} [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(diffitem_copy) = diff_copy.get(path) { [INFO] [stdout] 141 + match (&diffitem_master.diff, &diffitem_copy.diff) { [INFO] [stdout] 142 + (ChangeType::Newer, ChangeType::Newer) [INFO] [stdout] 143 + | (ChangeType::Newer, ChangeType::Older) [INFO] [stdout] 144 + | (ChangeType::Older, ChangeType::Newer) [INFO] [stdout] 145 + | (ChangeType::Older, ChangeType::Older) [INFO] [stdout] 146 + | (ChangeType::NewOnly, ChangeType::NewOnly) => { [INFO] [stdout] 147 + //check which is newer, remove oldest [INFO] [stdout] 148 + if diffitem_master.mtime >= diffitem_copy.mtime { [INFO] [stdout] 149 + diff_copy.remove(path); [INFO] [stdout] 150 + } else { [INFO] [stdout] 151 + diff_master.remove(path); [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] 154 + (ChangeType::RefOnly, ChangeType::RefOnly) => { [INFO] [stdout] 155 + //fine, remove both [INFO] [stdout] 156 + diff_copy.remove(path); [INFO] [stdout] 157 + diff_master.remove(path); [INFO] [stdout] 158 + } [INFO] [stdout] 159 + (ChangeType::Modified, ChangeType::Modified) | (ChangeType::Newer, _) => { [INFO] [stdout] 160 + //keep master [INFO] [stdout] 161 + diff_copy.remove(path); [INFO] [stdout] 162 + } [INFO] [stdout] 163 + (_, ChangeType::Newer) => { [INFO] [stdout] 164 + //keep copy [INFO] [stdout] 165 + diff_master.remove(path); [INFO] [stdout] 166 + } [INFO] [stdout] 167 + _ => {} [INFO] [stdout] 168 + } [INFO] [stdout] 169 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:288:53 [INFO] [stdout] | [INFO] [stdout] 288 | let _res = filetime::set_file_times(&dest, atime, mtime); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:295:37 [INFO] [stdout] | [INFO] [stdout] 295 | fs::remove_file(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:301:46 [INFO] [stdout] | [INFO] [stdout] 301 | let mut perms = fs::metadata(&dest)?.permissions(); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/datatypes.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | perms.set_readonly(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:305:41 [INFO] [stdout] | [INFO] [stdout] 305 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:307:33 [INFO] [stdout] | [INFO] [stdout] 307 | fs::remove_file(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:311:46 [INFO] [stdout] | [INFO] [stdout] 311 | let mut perms = fs::metadata(&dest)?.permissions(); [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `set_readonly` with argument `false` [INFO] [stdout] --> src/datatypes.rs:314:21 [INFO] [stdout] | [INFO] [stdout] 314 | perms.set_readonly(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: on Unix platforms this results in the file being world writable [INFO] [stdout] = help: you can set the desired permissions using `PermissionsExt`. For more information, see [INFO] [stdout] https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:315:41 [INFO] [stdout] | [INFO] [stdout] 315 | fs::set_permissions(&dest, perms)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/datatypes.rs:317:32 [INFO] [stdout] | [INFO] [stdout] 317 | fs::remove_dir(&dest)?; [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | fn map_dir(basepath: &PathBuf, exclude_globs: &GlobSet) -> Result> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ fn map_dir(basepath: &Path, exclude_globs: &GlobSet) -> Result> { [INFO] [stdout] 33 | let basepath_str = basepath.to_str().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 38 | let depth = usize::max_value(); [INFO] [stdout] 39 ~ for direntry in WalkDir::new(basepath.to_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/main.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let depth = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 38 - let depth = usize::max_value(); [INFO] [stdout] 38 + let depth = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:43:73 [INFO] [stdout] | [INFO] [stdout] 43 | .filter_entry(|e| !exclude_globs.is_match(e.path().strip_prefix(&basepath_str).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `basepath_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:50:41 [INFO] [stdout] | [INFO] [stdout] 50 | let relpath = path.strip_prefix(&basepath_str).unwrap().to_path_buf(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `basepath_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:327:39 [INFO] [stdout] | [INFO] [stdout] 327 | index_a = map_dir(path_a, &exclude_globs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `exclude_globs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:328:39 [INFO] [stdout] | [INFO] [stdout] 328 | index_b = map_dir(path_b, &exclude_globs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `exclude_globs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:329:34 [INFO] [stdout] | [INFO] [stdout] 329 | save_index(&index_a, &path_a)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:330:34 [INFO] [stdout] | [INFO] [stdout] 330 | save_index(&index_b, &path_b)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | / match diff_copy.get(path) { [INFO] [stdout] 141 | | Some(diffitem_copy) => { [INFO] [stdout] 142 | | match (&diffitem_master.diff, &diffitem_copy.diff) { [INFO] [stdout] 143 | | (ChangeType::Newer, ChangeType::Newer) [INFO] [stdout] ... | [INFO] [stdout] 171 | | None => {} [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 ~ if let Some(diffitem_copy) = diff_copy.get(path) { [INFO] [stdout] 141 + match (&diffitem_master.diff, &diffitem_copy.diff) { [INFO] [stdout] 142 + (ChangeType::Newer, ChangeType::Newer) [INFO] [stdout] 143 + | (ChangeType::Newer, ChangeType::Older) [INFO] [stdout] 144 + | (ChangeType::Older, ChangeType::Newer) [INFO] [stdout] 145 + | (ChangeType::Older, ChangeType::Older) [INFO] [stdout] 146 + | (ChangeType::NewOnly, ChangeType::NewOnly) => { [INFO] [stdout] 147 + //check which is newer, remove oldest [INFO] [stdout] 148 + if diffitem_master.mtime >= diffitem_copy.mtime { [INFO] [stdout] 149 + diff_copy.remove(path); [INFO] [stdout] 150 + } else { [INFO] [stdout] 151 + diff_master.remove(path); [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] 154 + (ChangeType::RefOnly, ChangeType::RefOnly) => { [INFO] [stdout] 155 + //fine, remove both [INFO] [stdout] 156 + diff_copy.remove(path); [INFO] [stdout] 157 + diff_master.remove(path); [INFO] [stdout] 158 + } [INFO] [stdout] 159 + (ChangeType::Modified, ChangeType::Modified) | (ChangeType::Newer, _) => { [INFO] [stdout] 160 + //keep master [INFO] [stdout] 161 + diff_copy.remove(path); [INFO] [stdout] 162 + } [INFO] [stdout] 163 + (_, ChangeType::Newer) => { [INFO] [stdout] 164 + //keep copy [INFO] [stdout] 165 + diff_master.remove(path); [INFO] [stdout] 166 + } [INFO] [stdout] 167 + _ => {} [INFO] [stdout] 168 + } [INFO] [stdout] 169 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:356:34 [INFO] [stdout] | [INFO] [stdout] 356 | let index_a_file: PathBuf = [&path_a, &PathBuf::from(INDEXFILENAME)].iter().collect(); [INFO] [stdout] | ^^^^^^^ help: change this to: `path_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 357 | let index_b_file: PathBuf = [&path_b, &PathBuf::from(INDEXFILENAME)].iter().collect(); [INFO] [stdout] | ^^^^^^^ help: change this to: `path_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:391:46 [INFO] [stdout] | [INFO] [stdout] 391 | save_index(&index_a, &path_a)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:392:46 [INFO] [stdout] | [INFO] [stdout] 392 | save_index(&index_b, &path_b)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `indexes` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:538:34 [INFO] [stdout] | [INFO] [stdout] 537 | if !check_only && indexes.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 538 | let (index_a, index_b) = indexes.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:327:39 [INFO] [stdout] | [INFO] [stdout] 327 | index_a = map_dir(path_a, &exclude_globs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `exclude_globs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:328:39 [INFO] [stdout] | [INFO] [stdout] 328 | index_b = map_dir(path_b, &exclude_globs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `exclude_globs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:329:34 [INFO] [stdout] | [INFO] [stdout] 329 | save_index(&index_a, &path_a)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:330:34 [INFO] [stdout] | [INFO] [stdout] 330 | save_index(&index_b, &path_b)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:526:35 [INFO] [stdout] | [INFO] [stdout] 526 | builder.add(Glob::new(&excl).unwrap()); [INFO] [stdout] | ^^^^^ help: change this to: `excl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:356:34 [INFO] [stdout] | [INFO] [stdout] 356 | let index_a_file: PathBuf = [&path_a, &PathBuf::from(INDEXFILENAME)].iter().collect(); [INFO] [stdout] | ^^^^^^^ help: change this to: `path_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 357 | let index_b_file: PathBuf = [&path_b, &PathBuf::from(INDEXFILENAME)].iter().collect(); [INFO] [stdout] | ^^^^^^^ help: change this to: `path_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:391:46 [INFO] [stdout] | [INFO] [stdout] 391 | save_index(&index_a, &path_a)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:392:46 [INFO] [stdout] | [INFO] [stdout] 392 | save_index(&index_b, &path_b)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `path_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_FileType` [INFO] [stdout] 55 | pub enum FileType { [INFO] [stdout] | -------- `FileType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_FileType` [INFO] [stdout] 55 | pub enum FileType { [INFO] [stdout] | -------- `FileType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PathData` [INFO] [stdout] 72 | pub struct PathData { [INFO] [stdout] | -------- `PathData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PathData` [INFO] [stdout] 72 | pub struct PathData { [INFO] [stdout] | -------- `PathData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_DirIndex` [INFO] [stdout] 80 | pub struct DirIndex { [INFO] [stdout] | -------- `DirIndex` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_DirIndex` [INFO] [stdout] 80 | pub struct DirIndex { [INFO] [stdout] | -------- `DirIndex` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `indexes` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:538:34 [INFO] [stdout] | [INFO] [stdout] 537 | if !check_only && indexes.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 538 | let (index_a, index_b) = indexes.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:526:35 [INFO] [stdout] | [INFO] [stdout] 526 | builder.add(Glob::new(&excl).unwrap()); [INFO] [stdout] | ^^^^^ help: change this to: `excl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_FileType` [INFO] [stdout] 55 | pub enum FileType { [INFO] [stdout] | -------- `FileType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | #[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_FileType` [INFO] [stdout] 55 | pub enum FileType { [INFO] [stdout] | -------- `FileType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PathData` [INFO] [stdout] 72 | pub struct PathData { [INFO] [stdout] | -------- `PathData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 71 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PathData` [INFO] [stdout] 72 | pub struct PathData { [INFO] [stdout] | -------- `PathData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_DirIndex` [INFO] [stdout] 80 | pub struct DirIndex { [INFO] [stdout] | -------- `DirIndex` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/datatypes.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_DirIndex` [INFO] [stdout] 80 | pub struct DirIndex { [INFO] [stdout] | -------- `DirIndex` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.24s [INFO] running `Command { std: "docker" "inspect" "a4aef6f447b03134f2e60bd3b178925b2ab7abfd849e3202c86c81decc3f8319", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4aef6f447b03134f2e60bd3b178925b2ab7abfd849e3202c86c81decc3f8319", kill_on_drop: false }` [INFO] [stdout] a4aef6f447b03134f2e60bd3b178925b2ab7abfd849e3202c86c81decc3f8319