[INFO] cloning repository https://github.com/H4-MM-3R/VARiation
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/H4-MM-3R/VARiation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FH4-MM-3R%2FVARiation", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FH4-MM-3R%2FVARiation'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b1855f4f597459879402bb1c7d1dc6dcf1eef521
[INFO] linting H4-MM-3R/VARiation against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FH4-MM-3R%2FVARiation" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/H4-MM-3R/VARiation
[INFO] finished tweaking git repo https://github.com/H4-MM-3R/VARiation
[INFO] tweaked toml for git repo https://github.com/H4-MM-3R/VARiation written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/H4-MM-3R/VARiation on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/H4-MM-3R/VARiation already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded clap v4.4.18
[INFO] [stderr]   Downloaded clap_builder v4.4.18
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a8b40d664b282ebf0195c99aa078cbeae2de95ea9ede9839a577b3c456803a67
[INFO] running `Command { std: "docker" "start" "-a" "a8b40d664b282ebf0195c99aa078cbeae2de95ea9ede9839a577b3c456803a67", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a8b40d664b282ebf0195c99aa078cbeae2de95ea9ede9839a577b3c456803a67", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a8b40d664b282ebf0195c99aa078cbeae2de95ea9ede9839a577b3c456803a67", kill_on_drop: false }`
[INFO] [stdout] a8b40d664b282ebf0195c99aa078cbeae2de95ea9ede9839a577b3c456803a67
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 68cbf0739d9e0e548a26fd17bc23b922e5f70465b114d50022f1c40562f53162
[INFO] running `Command { std: "docker" "start" "-a" "68cbf0739d9e0e548a26fd17bc23b922e5f70465b114d50022f1c40562f53162", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.78
[INFO] [stderr]    Compiling serde v1.0.196
[INFO] [stderr]    Compiling heck v0.4.1
[INFO] [stderr]    Compiling anyhow v1.0.79
[INFO] [stderr]    Compiling serde_json v1.0.113
[INFO] [stderr]     Checking ryu v1.0.16
[INFO] [stderr]     Checking anstream v0.6.11
[INFO] [stderr]     Checking clap_builder v4.4.18
[INFO] [stderr]    Compiling quote v1.0.35
[INFO] [stderr]    Compiling syn v2.0.48
[INFO] [stderr]    Compiling serde_derive v1.0.196
[INFO] [stderr]    Compiling clap_derive v4.4.7
[INFO] [stderr]     Checking clap v4.4.18
[INFO] [stderr]     Checking variation v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: empty line after outer attribute
[INFO] [stdout]  --> src/opts.rs:6:1
[INFO] [stdout]   |
[INFO] [stdout] 6 | / #[clap()]
[INFO] [stdout] 7 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 8 |   pub struct Opts {
[INFO] [stdout]   |   --------------- the attribute applies to this struct
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
[INFO] [stdout]   = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:23:9
[INFO] [stdout]    |
[INFO] [stdout] 23 | /         return Ok(Config {
[INFO] [stdout] 24 | |             operation,
[INFO] [stdout] 25 | |             config,
[INFO] [stdout] 26 | |             pwd,
[INFO] [stdout] 27 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 ~         Ok(Config {
[INFO] [stdout] 24 +             operation,
[INFO] [stdout] 25 +             config,
[INFO] [stdout] 26 +             pwd,
[INFO] [stdout] 27 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:71:13
[INFO] [stdout]    |
[INFO] [stdout] 71 |             return Ok(Operation::Print(Some(arg)));
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -             return Ok(Operation::Print(Some(arg)));
[INFO] [stdout] 71 +             Ok(Operation::Print(Some(arg)))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/config.rs:42:12
[INFO] [stdout]    |
[INFO] [stdout] 42 |         if value.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `value.get(0)`
[INFO] [stdout]   --> src/config.rs:46:20
[INFO] [stdout]    |
[INFO] [stdout] 46 |         let term = value.get(0).expect("expect to exist");
[INFO] [stdout]    |                    ^^^^^^^^^^^^ help: try: `value.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:86:5
[INFO] [stdout]    |
[INFO] [stdout] 86 |     return Ok(loc);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -     return Ok(loc);
[INFO] [stdout] 86 +     Ok(loc)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:95:5
[INFO] [stdout]    |
[INFO] [stdout] 95 |     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 95 -     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout] 95 +     Ok(std::env::current_dir().context("errored getting current directory")?)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> src/config.rs:95:12
[INFO] [stdout]    |
[INFO] [stdout] 95 |     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]    = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 95 -     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout] 95 +     return std::env::current_dir().context("errored getting current directory");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     return Data {
[INFO] [stdout] 19 | |         variance: HashMap::new(),
[INFO] [stdout] 20 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 18 ~     Data {
[INFO] [stdout] 19 +         variance: HashMap::new(),
[INFO] [stdout] 20 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:38:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |         return out;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 38 -         return out;
[INFO] [stdout] 38 +         out
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:54:9
[INFO] [stdout]    |
[INFO] [stdout] 54 |         return out;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 54 -         return out;
[INFO] [stdout] 54 +         out
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
[INFO] [stdout]   --> src/variance.rs:66:9
[INFO] [stdout]    |
[INFO] [stdout] 66 | /         self.data.variance.get_mut(&self.pwd).map(|x| {
[INFO] [stdout] 67 | |             x.remove(key);
[INFO] [stdout] 68 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stdout]    = note: `#[warn(clippy::option_map_unit_fn)]` on by default
[INFO] [stdout] help: use `if let` instead
[INFO] [stdout]    |
[INFO] [stdout] 66 -         self.data.variance.get_mut(&self.pwd).map(|x| {
[INFO] [stdout] 67 -             x.remove(key);
[INFO] [stdout] 68 -         });
[INFO] [stdout] 66 +         if let Some(x) = self.data.variance.get_mut(&self.pwd) { x.remove(key); }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/variance.rs:73:16
[INFO] [stdout]    |
[INFO] [stdout] 73 |             if !std::fs::metadata(p).is_ok() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(p).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:80:9
[INFO] [stdout]    |
[INFO] [stdout] 80 |         return Ok(());
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 80 -         return Ok(());
[INFO] [stdout] 80 +         Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 | /         return Variance {
[INFO] [stdout] 95 | |             config,
[INFO] [stdout] 96 | |             pwd,
[INFO] [stdout] 97 | |             data: default_data(),
[INFO] [stdout] 98 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 94 ~         Variance {
[INFO] [stdout] 95 +             config,
[INFO] [stdout] 96 +             pwd,
[INFO] [stdout] 97 +             data: default_data(),
[INFO] [stdout] 98 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/variance.rs:43:5
[INFO] [stdout]    |
[INFO] [stdout] 43 |     return Ok(());
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -     return Ok(());
[INFO] [stdout] 43 +     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
[INFO] [stdout]   --> src/bin/variance.rs:25:13
[INFO] [stdout]    |
[INFO] [stdout] 25 | /             proj.get_value(&key).map(|x| {
[INFO] [stdout] 26 | |                 println!("{}", x);
[INFO] [stdout] 27 | |             });
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stdout]    = note: `#[warn(clippy::option_map_unit_fn)]` on by default
[INFO] [stdout] help: use `if let` instead
[INFO] [stdout]    |
[INFO] [stdout] 25 -             proj.get_value(&key).map(|x| {
[INFO] [stdout] 26 -                 println!("{}", x);
[INFO] [stdout] 27 -             });
[INFO] [stdout] 25 +             if let Some(x) = proj.get_value(&key) { println!("{}", x) }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/variance.rs:43:5
[INFO] [stdout]    |
[INFO] [stdout] 43 |     return Ok(());
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -     return Ok(());
[INFO] [stdout] 43 +     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
[INFO] [stdout]   --> src/bin/variance.rs:25:13
[INFO] [stdout]    |
[INFO] [stdout] 25 | /             proj.get_value(&key).map(|x| {
[INFO] [stdout] 26 | |                 println!("{}", x);
[INFO] [stdout] 27 | |             });
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stdout]    = note: `#[warn(clippy::option_map_unit_fn)]` on by default
[INFO] [stdout] help: use `if let` instead
[INFO] [stdout]    |
[INFO] [stdout] 25 -             proj.get_value(&key).map(|x| {
[INFO] [stdout] 26 -                 println!("{}", x);
[INFO] [stdout] 27 -             });
[INFO] [stdout] 25 +             if let Some(x) = proj.get_value(&key) { println!("{}", x) }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after outer attribute
[INFO] [stdout]  --> src/opts.rs:6:1
[INFO] [stdout]   |
[INFO] [stdout] 6 | / #[clap()]
[INFO] [stdout] 7 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 8 |   pub struct Opts {
[INFO] [stdout]   |   --------------- the attribute applies to this struct
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
[INFO] [stdout]   = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:23:9
[INFO] [stdout]    |
[INFO] [stdout] 23 | /         return Ok(Config {
[INFO] [stdout] 24 | |             operation,
[INFO] [stdout] 25 | |             config,
[INFO] [stdout] 26 | |             pwd,
[INFO] [stdout] 27 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 ~         Ok(Config {
[INFO] [stdout] 24 +             operation,
[INFO] [stdout] 25 +             config,
[INFO] [stdout] 26 +             pwd,
[INFO] [stdout] 27 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:71:13
[INFO] [stdout]    |
[INFO] [stdout] 71 |             return Ok(Operation::Print(Some(arg)));
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -             return Ok(Operation::Print(Some(arg)));
[INFO] [stdout] 71 +             Ok(Operation::Print(Some(arg)))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/config.rs:42:12
[INFO] [stdout]    |
[INFO] [stdout] 42 |         if value.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `value.get(0)`
[INFO] [stdout]   --> src/config.rs:46:20
[INFO] [stdout]    |
[INFO] [stdout] 46 |         let term = value.get(0).expect("expect to exist");
[INFO] [stdout]    |                    ^^^^^^^^^^^^ help: try: `value.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:86:5
[INFO] [stdout]    |
[INFO] [stdout] 86 |     return Ok(loc);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -     return Ok(loc);
[INFO] [stdout] 86 +     Ok(loc)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/config.rs:95:5
[INFO] [stdout]    |
[INFO] [stdout] 95 |     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 95 -     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout] 95 +     Ok(std::env::current_dir().context("errored getting current directory")?)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> src/config.rs:95:12
[INFO] [stdout]    |
[INFO] [stdout] 95 |     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]    = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 95 -     return Ok(std::env::current_dir().context("errored getting current directory")?);
[INFO] [stdout] 95 +     return std::env::current_dir().context("errored getting current directory");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     return Data {
[INFO] [stdout] 19 | |         variance: HashMap::new(),
[INFO] [stdout] 20 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 18 ~     Data {
[INFO] [stdout] 19 +         variance: HashMap::new(),
[INFO] [stdout] 20 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:38:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |         return out;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 38 -         return out;
[INFO] [stdout] 38 +         out
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:54:9
[INFO] [stdout]    |
[INFO] [stdout] 54 |         return out;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 54 -         return out;
[INFO] [stdout] 54 +         out
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
[INFO] [stdout]   --> src/variance.rs:66:9
[INFO] [stdout]    |
[INFO] [stdout] 66 | /         self.data.variance.get_mut(&self.pwd).map(|x| {
[INFO] [stdout] 67 | |             x.remove(key);
[INFO] [stdout] 68 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stdout]    = note: `#[warn(clippy::option_map_unit_fn)]` on by default
[INFO] [stdout] help: use `if let` instead
[INFO] [stdout]    |
[INFO] [stdout] 66 -         self.data.variance.get_mut(&self.pwd).map(|x| {
[INFO] [stdout] 67 -             x.remove(key);
[INFO] [stdout] 68 -         });
[INFO] [stdout] 66 +         if let Some(x) = self.data.variance.get_mut(&self.pwd) { x.remove(key); }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/variance.rs:73:16
[INFO] [stdout]    |
[INFO] [stdout] 73 |             if !std::fs::metadata(p).is_ok() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(p).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:80:9
[INFO] [stdout]    |
[INFO] [stdout] 80 |         return Ok(());
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 80 -         return Ok(());
[INFO] [stdout] 80 +         Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/variance.rs:94:9
[INFO] [stdout]    |
[INFO] [stdout] 94 | /         return Variance {
[INFO] [stdout] 95 | |             config,
[INFO] [stdout] 96 | |             pwd,
[INFO] [stdout] 97 | |             data: default_data(),
[INFO] [stdout] 98 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 94 ~         Variance {
[INFO] [stdout] 95 +             config,
[INFO] [stdout] 96 +             pwd,
[INFO] [stdout] 97 +             data: default_data(),
[INFO] [stdout] 98 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.40s
[INFO] running `Command { std: "docker" "inspect" "68cbf0739d9e0e548a26fd17bc23b922e5f70465b114d50022f1c40562f53162", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "68cbf0739d9e0e548a26fd17bc23b922e5f70465b114d50022f1c40562f53162", kill_on_drop: false }`
[INFO] [stdout] 68cbf0739d9e0e548a26fd17bc23b922e5f70465b114d50022f1c40562f53162