[INFO] cloning repository https://github.com/Guilhem7/owa_enum [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Guilhem7/owa_enum" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGuilhem7%2Fowa_enum", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGuilhem7%2Fowa_enum'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 306e1bbf53d7d84ea757f4753a492d1ae6fad334 [INFO] linting Guilhem7/owa_enum against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGuilhem7%2Fowa_enum" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Guilhem7/owa_enum [INFO] finished tweaking git repo https://github.com/Guilhem7/owa_enum [INFO] tweaked toml for git repo https://github.com/Guilhem7/owa_enum written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Guilhem7/owa_enum on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Guilhem7/owa_enum already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.41 [INFO] [stderr] Downloaded clap_derive v4.5.41 [INFO] [stderr] Downloaded clap_builder v4.5.41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3aa4e90a2f5566262ff4e670bd368a8d85b38cfee150d30313f8b1a8f3fded4f [INFO] running `Command { std: "docker" "start" "-a" "3aa4e90a2f5566262ff4e670bd368a8d85b38cfee150d30313f8b1a8f3fded4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3aa4e90a2f5566262ff4e670bd368a8d85b38cfee150d30313f8b1a8f3fded4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aa4e90a2f5566262ff4e670bd368a8d85b38cfee150d30313f8b1a8f3fded4f", kill_on_drop: false }` [INFO] [stdout] 3aa4e90a2f5566262ff4e670bd368a8d85b38cfee150d30313f8b1a8f3fded4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5e853c80f1400654b3640cb5b86553340c046fc3cb8af2c6e4bbaf9bbccad40 [INFO] running `Command { std: "docker" "start" "-a" "b5e853c80f1400654b3640cb5b86553340c046fc3cb8af2c6e4bbaf9bbccad40", kill_on_drop: false }` [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking h2 v0.4.11 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-util v0.1.15 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking owa_enum v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/owa/utils.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | uri: uri, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/owa/utils.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | http_client: http_client [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/owa/utils.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | uri: uri, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/owa/utils.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | http_client: http_client [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/owa/utils.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | } else if ! res.headers().get("WWW-Authenticate").is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `res.headers().get("WWW-Authenticate").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | / return if location.contains("/owa/auth") { OwaAuthMethod::Form } [INFO] [stdout] 68 | | else if location.contains("login.microsoftonline.com") { OwaAuthMethod::Oauth } [INFO] [stdout] 69 | | else { OwaAuthMethod::Unknown } [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ if location.contains("/owa/auth") { OwaAuthMethod::Form } [INFO] [stdout] 68 + else if location.contains("login.microsoftonline.com") { OwaAuthMethod::Oauth } [INFO] [stdout] 69 + else { OwaAuthMethod::Unknown } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | return OwaAuthMethod::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return OwaAuthMethod::Unknown; [INFO] [stdout] 76 + OwaAuthMethod::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | return OwaAuthMethod::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return OwaAuthMethod::Unknown; [INFO] [stdout] 78 + OwaAuthMethod::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | return OwaAuthMethod::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return OwaAuthMethod::Unknown; [INFO] [stdout] 83 + OwaAuthMethod::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | return (OwaResult::PasswordValid, elapsed_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return (OwaResult::PasswordValid, elapsed_time); [INFO] [stdout] 129 + (OwaResult::PasswordValid, elapsed_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | return (OwaResult::UserNotFound, elapsed_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return (OwaResult::UserNotFound, elapsed_time); [INFO] [stdout] 134 + (OwaResult::UserNotFound, elapsed_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | return (OwaResult::UserExists, elapsed_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return (OwaResult::UserExists, elapsed_time); [INFO] [stdout] 137 + (OwaResult::UserExists, elapsed_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/owa/utils.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | / match self.http_client.get(&url).send(){ [INFO] [stdout] 147 | | Ok(response) => { [INFO] [stdout] 148 | | if response.status() == reqwest::StatusCode::UNAUTHORIZED { [INFO] [stdout] 149 | | return Ok(endpoint); [INFO] [stdout] ... | [INFO] [stdout] 152 | | Err(_) => {} [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 146 ~ if let Ok(response) = self.http_client.get(&url).send() { [INFO] [stdout] 147 + if response.status() == reqwest::StatusCode::UNAUTHORIZED { [INFO] [stdout] 148 + return Ok(endpoint); [INFO] [stdout] 149 + } [INFO] [stdout] 150 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/owa/utils.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 159 | if self.domain != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.domain.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NTLM` contains a capitalized acronym [INFO] [stdout] --> src/owa/ntlm.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct NTLM; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ntlm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/main.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | let mut users: Vec = vec![(&args.user).to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args.user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/main.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 92 | return (); [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/main.rs:95:16 [INFO] [stdout] | [INFO] [stdout] 95 | return (); [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/main.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | return (); [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | let timeout_to_use: f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `timeout_to_use` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 107 ~ [INFO] [stdout] 108 ~ let timeout_to_use: f64 = match args.timeout { [INFO] [stdout] 109 | Some(timeout) => { [INFO] [stdout] 110 ~ timeout [INFO] [stdout] 111 | } [INFO] [stdout] ... [INFO] [stdout] 118 | Color::RESET); [INFO] [stdout] 119 ~ timeout / 2.0 [INFO] [stdout] 120 | } [INFO] [stdout] 121 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:132:46 [INFO] [stdout] | [INFO] [stdout] 132 | match owa_enumerator.user_exists(&username, args.password.as_ref()) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:135:38 [INFO] [stdout] | [INFO] [stdout] 135 | Color::wrap(&username, Color::CYAN), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:38 [INFO] [stdout] | [INFO] [stdout] 148 | Color::wrap(&username, Color::CYAN), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:159:81 [INFO] [stdout] | [INFO] [stdout] 159 | ... Color::wrap(&username, Color::BOLD), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/owa/utils.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | } else if ! res.headers().get("WWW-Authenticate").is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `res.headers().get("WWW-Authenticate").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | / return if location.contains("/owa/auth") { OwaAuthMethod::Form } [INFO] [stdout] 68 | | else if location.contains("login.microsoftonline.com") { OwaAuthMethod::Oauth } [INFO] [stdout] 69 | | else { OwaAuthMethod::Unknown } [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ if location.contains("/owa/auth") { OwaAuthMethod::Form } [INFO] [stdout] 68 + else if location.contains("login.microsoftonline.com") { OwaAuthMethod::Oauth } [INFO] [stdout] 69 + else { OwaAuthMethod::Unknown } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | return OwaAuthMethod::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return OwaAuthMethod::Unknown; [INFO] [stdout] 76 + OwaAuthMethod::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | return OwaAuthMethod::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return OwaAuthMethod::Unknown; [INFO] [stdout] 78 + OwaAuthMethod::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | return OwaAuthMethod::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return OwaAuthMethod::Unknown; [INFO] [stdout] 83 + OwaAuthMethod::Unknown [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | return (OwaResult::PasswordValid, elapsed_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return (OwaResult::PasswordValid, elapsed_time); [INFO] [stdout] 129 + (OwaResult::PasswordValid, elapsed_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | return (OwaResult::UserNotFound, elapsed_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return (OwaResult::UserNotFound, elapsed_time); [INFO] [stdout] 134 + (OwaResult::UserNotFound, elapsed_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/owa/utils.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | return (OwaResult::UserExists, elapsed_time); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return (OwaResult::UserExists, elapsed_time); [INFO] [stdout] 137 + (OwaResult::UserExists, elapsed_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/owa/utils.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | / match self.http_client.get(&url).send(){ [INFO] [stdout] 147 | | Ok(response) => { [INFO] [stdout] 148 | | if response.status() == reqwest::StatusCode::UNAUTHORIZED { [INFO] [stdout] 149 | | return Ok(endpoint); [INFO] [stdout] ... | [INFO] [stdout] 152 | | Err(_) => {} [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 146 ~ if let Ok(response) = self.http_client.get(&url).send() { [INFO] [stdout] 147 + if response.status() == reqwest::StatusCode::UNAUTHORIZED { [INFO] [stdout] 148 + return Ok(endpoint); [INFO] [stdout] 149 + } [INFO] [stdout] 150 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/owa/utils.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 159 | if self.domain != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.domain.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NTLM` contains a capitalized acronym [INFO] [stdout] --> src/owa/ntlm.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct NTLM; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ntlm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/main.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | let mut users: Vec = vec![(&args.user).to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args.user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/main.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 92 | return (); [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/main.rs:95:16 [INFO] [stdout] | [INFO] [stdout] 95 | return (); [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `()` [INFO] [stdout] --> src/main.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | return (); [INFO] [stdout] | ^^ help: remove the `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | let timeout_to_use: f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `timeout_to_use` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 107 ~ [INFO] [stdout] 108 ~ let timeout_to_use: f64 = match args.timeout { [INFO] [stdout] 109 | Some(timeout) => { [INFO] [stdout] 110 ~ timeout [INFO] [stdout] 111 | } [INFO] [stdout] ... [INFO] [stdout] 118 | Color::RESET); [INFO] [stdout] 119 ~ timeout / 2.0 [INFO] [stdout] 120 | } [INFO] [stdout] 121 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:132:46 [INFO] [stdout] | [INFO] [stdout] 132 | match owa_enumerator.user_exists(&username, args.password.as_ref()) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:135:38 [INFO] [stdout] | [INFO] [stdout] 135 | Color::wrap(&username, Color::CYAN), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:38 [INFO] [stdout] | [INFO] [stdout] 148 | Color::wrap(&username, Color::CYAN), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:159:81 [INFO] [stdout] | [INFO] [stdout] 159 | ... Color::wrap(&username, Color::BOLD), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 53.69s [INFO] running `Command { std: "docker" "inspect" "b5e853c80f1400654b3640cb5b86553340c046fc3cb8af2c6e4bbaf9bbccad40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5e853c80f1400654b3640cb5b86553340c046fc3cb8af2c6e4bbaf9bbccad40", kill_on_drop: false }` [INFO] [stdout] b5e853c80f1400654b3640cb5b86553340c046fc3cb8af2c6e4bbaf9bbccad40