[INFO] cloning repository https://github.com/GroobleDierne/chip8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GroobleDierne/chip8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGroobleDierne%2Fchip8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGroobleDierne%2Fchip8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ca9d615f1b16c7b521754b6abce0e6f47ec56d0d [INFO] linting GroobleDierne/chip8/ca9d615f1b16c7b521754b6abce0e6f47ec56d0d against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGroobleDierne%2Fchip8" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/GroobleDierne/chip8 [INFO] finished tweaking git repo https://github.com/GroobleDierne/chip8 [INFO] tweaked toml for git repo https://github.com/GroobleDierne/chip8 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/GroobleDierne/chip8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/GroobleDierne/chip8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pkg-config v0.3.19 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.74 [INFO] [stderr] Downloaded cmake v0.1.45 [INFO] [stderr] Downloaded filetime v0.2.14 [INFO] [stderr] Downloaded unidiff v0.3.3 [INFO] [stderr] Downloaded version-compare v0.0.10 [INFO] [stderr] Downloaded redox_syscall v0.2.9 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.74 [INFO] [stderr] Downloaded tar v0.4.35 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.74 [INFO] [stderr] Downloaded js-sys v0.3.51 [INFO] [stderr] Downloaded flate2 v1.0.20 [INFO] [stderr] Downloaded aho-corasick v0.7.15 [INFO] [stderr] Downloaded wayland-protocols v0.28.6 [INFO] [stderr] Downloaded bumpalo v3.7.0 [INFO] [stderr] Downloaded wasm-bindgen v0.2.74 [INFO] [stderr] Downloaded wayland-client v0.28.6 [INFO] [stderr] Downloaded sdl2 v0.34.5 [INFO] [stderr] Downloaded minifb v0.19.3 [INFO] [stderr] Downloaded cc v1.0.69 [INFO] [stderr] Downloaded regex v1.4.6 [INFO] [stderr] Downloaded xml-rs v0.8.3 [INFO] [stderr] Downloaded x11-dl v2.18.5 [INFO] [stderr] Downloaded wayland-commons v0.28.6 [INFO] [stderr] Downloaded wayland-scanner v0.28.6 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.74 [INFO] [stderr] Downloaded libloading v0.7.0 [INFO] [stderr] Downloaded xkbcommon-sys v0.7.5 [INFO] [stderr] Downloaded xcursor v0.3.3 [INFO] [stderr] Downloaded xkb v0.2.1 [INFO] [stderr] Downloaded clang-sys v1.2.0 [INFO] [stderr] Downloaded sdl2-sys v0.34.5 [INFO] [stderr] Downloaded wayland-cursor v0.28.6 [INFO] [stderr] Downloaded wayland-sys v0.28.6 [INFO] [stderr] Downloaded libc v0.2.98 [INFO] [stderr] Downloaded web-sys v0.3.51 [INFO] [stderr] Downloaded encoding_rs v0.8.28 [INFO] [stderr] Downloaded orbclient v0.3.31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1d382844ed0d0c1d78ea4a07d190820021793c39314883c7a738258c602adfa [INFO] running `Command { std: "docker" "start" "-a" "d1d382844ed0d0c1d78ea4a07d190820021793c39314883c7a738258c602adfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1d382844ed0d0c1d78ea4a07d190820021793c39314883c7a738258c602adfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1d382844ed0d0c1d78ea4a07d190820021793c39314883c7a738258c602adfa", kill_on_drop: false }` [INFO] [stdout] d1d382844ed0d0c1d78ea4a07d190820021793c39314883c7a738258c602adfa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6119d0c62bf0de16527134448d9f70b591ccebd679074892eb24bab326ad2f8 [INFO] running `Command { std: "docker" "start" "-a" "c6119d0c62bf0de16527134448d9f70b591ccebd679074892eb24bab326ad2f8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling clang-sys v1.2.0 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling aho-corasick v0.7.15 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling libloading v0.7.0 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling bindgen v0.56.0 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling termcolor v1.1.2 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling regex v1.4.6 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling nom v6.2.1 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling env_logger v0.8.4 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling minifb v0.19.3 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking xcursor v0.3.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Compiling xkbcommon-sys v0.7.5 [INFO] [stderr] Checking xkb v0.2.1 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:177:46 [INFO] [stdout] | [INFO] [stdout] 177 | .copy_from_slice(&self.v[0..(x as usize + 1)]), [INFO] [stdout] | ^^^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:179:42 [INFO] [stdout] | [INFO] [stdout] 179 | (0xF, _, 6, 5) => self.v[0..(x as usize + 1)] [INFO] [stdout] | ^^^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/chip8.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 181 | (_, _, _, _) => println!("Unhandled opcode {}", format!("{:X}", opcode)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `sprite` [INFO] [stdout] --> src/chip8.rs:199:18 [INFO] [stdout] | [INFO] [stdout] 199 | for j in 0..height as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 199 - for j in 0..height as usize { [INFO] [stdout] 199 + for (j, ) in sprite.iter().enumerate().take(height as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/chip8.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | return cpu [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return cpu [INFO] [stdout] 253 + cpu [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/decompiler.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / match file.write_all(instructions.join("\n").as_bytes()) { [INFO] [stdout] 27 | | Err(why) => panic!("couldn't write to file: {}", why), [INFO] [stdout] 28 | | Ok(_) => (), [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ help: try: `if let Err(why) = file.write_all(instructions.join("\n").as_bytes()) { panic!("couldn't write to file: {}", why) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / return get_opcode_structure(opcode) [INFO] [stdout] 41 | | .replace("nnn", &nnn.to_string()[..]) [INFO] [stdout] 42 | | .replace("kk", &kk.to_string()[..]) [INFO] [stdout] 43 | | .replace("n", &n.to_string()[..]) [INFO] [stdout] 44 | | .replace("x", &x.to_string()[..]) [INFO] [stdout] 45 | | .replace("y", &y.to_string()[..]); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ get_opcode_structure(opcode) [INFO] [stdout] 41 + .replace("nnn", &nnn.to_string()[..]) [INFO] [stdout] 42 + .replace("kk", &kk.to_string()[..]) [INFO] [stdout] 43 + .replace("n", &n.to_string()[..]) [INFO] [stdout] 44 + .replace("x", &x.to_string()[..]) [INFO] [stdout] 45 ~ .replace("y", &y.to_string()[..]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 55 | (0, 0, 0xE, 0) => return "CLS".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - (0, 0, 0xE, 0) => return "CLS".to_string(), [INFO] [stdout] 55 + (0, 0, 0xE, 0) => "CLS".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | (_, _, 0xE, 0xE) => return "RET".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - (_, _, 0xE, 0xE) => return "RET".to_string(), [INFO] [stdout] 56 + (_, _, 0xE, 0xE) => "RET".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | (1, _, _, _) => return "JP nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - (1, _, _, _) => return "JP nnn".to_string(), [INFO] [stdout] 57 + (1, _, _, _) => "JP nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | (2, _, _, _) => return "CALL nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - (2, _, _, _) => return "CALL nnn".to_string(), [INFO] [stdout] 58 + (2, _, _, _) => "CALL nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | (3, _, _, _) => return "SE Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - (3, _, _, _) => return "SE Vx, kk".to_string(), [INFO] [stdout] 59 + (3, _, _, _) => "SE Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | (4, _, _, _) => return "SNE Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - (4, _, _, _) => return "SNE Vx, kk".to_string(), [INFO] [stdout] 60 + (4, _, _, _) => "SNE Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | (5, _, _, 0) => return "SE Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - (5, _, _, 0) => return "SE Vx, Vy".to_string(), [INFO] [stdout] 61 + (5, _, _, 0) => "SE Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:62:25 [INFO] [stdout] | [INFO] [stdout] 62 | (6, _, _, _) => return "LD Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - (6, _, _, _) => return "LD Vx, kk".to_string(), [INFO] [stdout] 62 + (6, _, _, _) => "LD Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | (7, _, _, _) => return "ADD Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - (7, _, _, _) => return "ADD Vx, kk".to_string(), [INFO] [stdout] 63 + (7, _, _, _) => "ADD Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 64 | (8, _, _, 0) => return "LD Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - (8, _, _, 0) => return "LD Vx, Vy".to_string(), [INFO] [stdout] 64 + (8, _, _, 0) => "LD Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | (8, _, _, 1) => return "OR Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - (8, _, _, 1) => return "OR Vx, Vy".to_string(), [INFO] [stdout] 65 + (8, _, _, 1) => "OR Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | (8, _, _, 2) => return "AND Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - (8, _, _, 2) => return "AND Vx, Vy".to_string(), [INFO] [stdout] 66 + (8, _, _, 2) => "AND Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | (8, _, _, 3) => return "XOR Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - (8, _, _, 3) => return "XOR Vx, Vy".to_string(), [INFO] [stdout] 67 + (8, _, _, 3) => "XOR Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | (8, _, _, 4) => return "ADD Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - (8, _, _, 4) => return "ADD Vx, Vy".to_string(), [INFO] [stdout] 68 + (8, _, _, 4) => "ADD Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | (8, _, _, 5) => return "SUB Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - (8, _, _, 5) => return "SUB Vx, Vy".to_string(), [INFO] [stdout] 69 + (8, _, _, 5) => "SUB Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | (8, _, _, 6) => return "SHR Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - (8, _, _, 6) => return "SHR Vx, Vy".to_string(), [INFO] [stdout] 70 + (8, _, _, 6) => "SHR Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | (8, _, _, 7) => return "SUBN Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - (8, _, _, 7) => return "SUBN Vx, Vy".to_string(), [INFO] [stdout] 71 + (8, _, _, 7) => "SUBN Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:72:27 [INFO] [stdout] | [INFO] [stdout] 72 | (8, _, _, 0xE) => return "SHL Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - (8, _, _, 0xE) => return "SHL Vx".to_string(), [INFO] [stdout] 72 + (8, _, _, 0xE) => "SHL Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | (9, _, _, 0) => return "SNE Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - (9, _, _, 0) => return "SNE Vx, Vy".to_string(), [INFO] [stdout] 73 + (9, _, _, 0) => "SNE Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 74 | (0xA, _, _, _) => return "LD I, nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - (0xA, _, _, _) => return "LD I, nnn".to_string(), [INFO] [stdout] 74 + (0xA, _, _, _) => "LD I, nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 75 | (0xB, _, _, _) => return "JP V0, nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - (0xB, _, _, _) => return "JP V0, nnn".to_string(), [INFO] [stdout] 75 + (0xB, _, _, _) => "JP V0, nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:76:27 [INFO] [stdout] | [INFO] [stdout] 76 | (0xC, _, _, _) => return "RND Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - (0xC, _, _, _) => return "RND Vx, kk".to_string(), [INFO] [stdout] 76 + (0xC, _, _, _) => "RND Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:77:27 [INFO] [stdout] | [INFO] [stdout] 77 | (0xD, _, _, _) => return "DRW Vx, Vy, n".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - (0xD, _, _, _) => return "DRW Vx, Vy, n".to_string(), [INFO] [stdout] 77 + (0xD, _, _, _) => "DRW Vx, Vy, n".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:78:29 [INFO] [stdout] | [INFO] [stdout] 78 | (0xE, _, 9, 0xE) => return "SKP Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - (0xE, _, 9, 0xE) => return "SKP Vx".to_string(), [INFO] [stdout] 78 + (0xE, _, 9, 0xE) => "SKP Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | (0xE, _, 0xA, 1) => return "SKNP Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - (0xE, _, 0xA, 1) => return "SKNP Vx".to_string(), [INFO] [stdout] 79 + (0xE, _, 0xA, 1) => "SKNP Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | (0xF, _, 0, 7) => return "LD Vx, DT".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - (0xF, _, 0, 7) => return "LD Vx, DT".to_string(), [INFO] [stdout] 80 + (0xF, _, 0, 7) => "LD Vx, DT".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:81:29 [INFO] [stdout] | [INFO] [stdout] 81 | (0xF, _, 0, 0xA) => return "LD Vx, K".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - (0xF, _, 0, 0xA) => return "LD Vx, K".to_string(), [INFO] [stdout] 81 + (0xF, _, 0, 0xA) => "LD Vx, K".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:82:27 [INFO] [stdout] | [INFO] [stdout] 82 | (0xF, _, 1, 5) => return "LD DT, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - (0xF, _, 1, 5) => return "LD DT, Vx".to_string(), [INFO] [stdout] 82 + (0xF, _, 1, 5) => "LD DT, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:83:27 [INFO] [stdout] | [INFO] [stdout] 83 | (0xF, _, 1, 8) => return "LD ST, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - (0xF, _, 1, 8) => return "LD ST, Vx".to_string(), [INFO] [stdout] 83 + (0xF, _, 1, 8) => "LD ST, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:177:46 [INFO] [stdout] | [INFO] [stdout] 177 | .copy_from_slice(&self.v[0..(x as usize + 1)]), [INFO] [stdout] | ^^^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/chip8.rs:179:42 [INFO] [stdout] | [INFO] [stdout] 179 | (0xF, _, 6, 5) => self.v[0..(x as usize + 1)] [INFO] [stdout] | ^^^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `println!` args [INFO] [stdout] --> src/chip8.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 181 | (_, _, _, _) => println!("Unhandled opcode {}", format!("{:X}", opcode)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `println!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (0xF, _, 1, 0xE) => return "ADD I, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - (0xF, _, 1, 0xE) => return "ADD I, Vx".to_string(), [INFO] [stdout] 84 + (0xF, _, 1, 0xE) => "ADD I, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | (0xF, _, 2, 9) => return "LD F, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - (0xF, _, 2, 9) => return "LD F, Vx".to_string(), [INFO] [stdout] 85 + (0xF, _, 2, 9) => "LD F, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:86:27 [INFO] [stdout] | [INFO] [stdout] 86 | (0xF, _, 3, 3) => return "LD B, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - (0xF, _, 3, 3) => return "LD B, Vx".to_string(), [INFO] [stdout] 86 + (0xF, _, 3, 3) => "LD B, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:87:27 [INFO] [stdout] | [INFO] [stdout] 87 | (0xF, _, 5, 5) => return "LD [I], Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - (0xF, _, 5, 5) => return "LD [I], Vx".to_string(), [INFO] [stdout] 87 + (0xF, _, 5, 5) => "LD [I], Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:88:27 [INFO] [stdout] | [INFO] [stdout] 88 | (0xF, _, 6, 5) => return "LD Vx, [I]".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - (0xF, _, 6, 5) => return "LD Vx, [I]".to_string(), [INFO] [stdout] 88 + (0xF, _, 6, 5) => "LD Vx, [I]".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | (_, _, _, _) => return format!("{:X}", opcode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - (_, _, _, _) => return format!("{:X}", opcode), [INFO] [stdout] 89 + (_, _, _, _) => format!("{:X}", opcode), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `sprite` [INFO] [stdout] --> src/chip8.rs:199:18 [INFO] [stdout] | [INFO] [stdout] 199 | for j in 0..height as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 199 - for j in 0..height as usize { [INFO] [stdout] 199 + for (j, ) in sprite.iter().enumerate().take(height as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / window.get_keys().map(|keys| { [INFO] [stdout] 44 | | cpu.keys = [false;16]; [INFO] [stdout] 45 | | for t in keys { [INFO] [stdout] 46 | | match t { [INFO] [stdout] ... | [INFO] [stdout] 66 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 43 - window.get_keys().map(|keys| { [INFO] [stdout] 44 - cpu.keys = [false;16]; [INFO] [stdout] 45 - for t in keys { [INFO] [stdout] 46 - match t { [INFO] [stdout] 47 - Key::Key1 => cpu.keys[0x1] = true, [INFO] [stdout] 48 - Key::Key2 => cpu.keys[0x2] = true, [INFO] [stdout] 49 - Key::Key3 => cpu.keys[0x3] = true, [INFO] [stdout] 50 - Key::Key4 => cpu.keys[0xc] = true, [INFO] [stdout] 51 - Key::A => cpu.keys[0x4] = true, [INFO] [stdout] 52 - Key::Z => cpu.keys[0x5] = true, [INFO] [stdout] 53 - Key::E => cpu.keys[0x6] = true, [INFO] [stdout] 54 - Key::R => cpu.keys[0xd] = true, [INFO] [stdout] 55 - Key::Q => cpu.keys[0x7] = true, [INFO] [stdout] 56 - Key::S => cpu.keys[0x8] = true, [INFO] [stdout] 57 - Key::D => cpu.keys[0x9] = true, [INFO] [stdout] 58 - Key::F => cpu.keys[0xe] = true, [INFO] [stdout] 59 - Key::W => cpu.keys[0xa] = true, [INFO] [stdout] 60 - Key::X => cpu.keys[0x0] = true, [INFO] [stdout] 61 - Key::C => cpu.keys[0xb] = true, [INFO] [stdout] 62 - Key::V => cpu.keys[0xf] = true, [INFO] [stdout] 63 - _ => (), [INFO] [stdout] 64 - } [INFO] [stdout] 65 - } [INFO] [stdout] 66 - }); [INFO] [stdout] 43 + if let Some(keys) = window.get_keys() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/chip8.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | return cpu [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return cpu [INFO] [stdout] 253 + cpu [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/decompiler.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / match file.write_all(instructions.join("\n").as_bytes()) { [INFO] [stdout] 27 | | Err(why) => panic!("couldn't write to file: {}", why), [INFO] [stdout] 28 | | Ok(_) => (), [INFO] [stdout] 29 | | }; [INFO] [stdout] | |_____^ help: try: `if let Err(why) = file.write_all(instructions.join("\n").as_bytes()) { panic!("couldn't write to file: {}", why) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | / return get_opcode_structure(opcode) [INFO] [stdout] 41 | | .replace("nnn", &nnn.to_string()[..]) [INFO] [stdout] 42 | | .replace("kk", &kk.to_string()[..]) [INFO] [stdout] 43 | | .replace("n", &n.to_string()[..]) [INFO] [stdout] 44 | | .replace("x", &x.to_string()[..]) [INFO] [stdout] 45 | | .replace("y", &y.to_string()[..]); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ get_opcode_structure(opcode) [INFO] [stdout] 41 + .replace("nnn", &nnn.to_string()[..]) [INFO] [stdout] 42 + .replace("kk", &kk.to_string()[..]) [INFO] [stdout] 43 + .replace("n", &n.to_string()[..]) [INFO] [stdout] 44 + .replace("x", &x.to_string()[..]) [INFO] [stdout] 45 ~ .replace("y", &y.to_string()[..]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 55 | (0, 0, 0xE, 0) => return "CLS".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - (0, 0, 0xE, 0) => return "CLS".to_string(), [INFO] [stdout] 55 + (0, 0, 0xE, 0) => "CLS".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | (_, _, 0xE, 0xE) => return "RET".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - (_, _, 0xE, 0xE) => return "RET".to_string(), [INFO] [stdout] 56 + (_, _, 0xE, 0xE) => "RET".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | (1, _, _, _) => return "JP nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - (1, _, _, _) => return "JP nnn".to_string(), [INFO] [stdout] 57 + (1, _, _, _) => "JP nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | (2, _, _, _) => return "CALL nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - (2, _, _, _) => return "CALL nnn".to_string(), [INFO] [stdout] 58 + (2, _, _, _) => "CALL nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | (3, _, _, _) => return "SE Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - (3, _, _, _) => return "SE Vx, kk".to_string(), [INFO] [stdout] 59 + (3, _, _, _) => "SE Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | (4, _, _, _) => return "SNE Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - (4, _, _, _) => return "SNE Vx, kk".to_string(), [INFO] [stdout] 60 + (4, _, _, _) => "SNE Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | (5, _, _, 0) => return "SE Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - (5, _, _, 0) => return "SE Vx, Vy".to_string(), [INFO] [stdout] 61 + (5, _, _, 0) => "SE Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:62:25 [INFO] [stdout] | [INFO] [stdout] 62 | (6, _, _, _) => return "LD Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - (6, _, _, _) => return "LD Vx, kk".to_string(), [INFO] [stdout] 62 + (6, _, _, _) => "LD Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | (7, _, _, _) => return "ADD Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - (7, _, _, _) => return "ADD Vx, kk".to_string(), [INFO] [stdout] 63 + (7, _, _, _) => "ADD Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 64 | (8, _, _, 0) => return "LD Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - (8, _, _, 0) => return "LD Vx, Vy".to_string(), [INFO] [stdout] 64 + (8, _, _, 0) => "LD Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | (8, _, _, 1) => return "OR Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - (8, _, _, 1) => return "OR Vx, Vy".to_string(), [INFO] [stdout] 65 + (8, _, _, 1) => "OR Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | (8, _, _, 2) => return "AND Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - (8, _, _, 2) => return "AND Vx, Vy".to_string(), [INFO] [stdout] 66 + (8, _, _, 2) => "AND Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | (8, _, _, 3) => return "XOR Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - (8, _, _, 3) => return "XOR Vx, Vy".to_string(), [INFO] [stdout] 67 + (8, _, _, 3) => "XOR Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | (8, _, _, 4) => return "ADD Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - (8, _, _, 4) => return "ADD Vx, Vy".to_string(), [INFO] [stdout] 68 + (8, _, _, 4) => "ADD Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | (8, _, _, 5) => return "SUB Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - (8, _, _, 5) => return "SUB Vx, Vy".to_string(), [INFO] [stdout] 69 + (8, _, _, 5) => "SUB Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | (8, _, _, 6) => return "SHR Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - (8, _, _, 6) => return "SHR Vx, Vy".to_string(), [INFO] [stdout] 70 + (8, _, _, 6) => "SHR Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | (8, _, _, 7) => return "SUBN Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - (8, _, _, 7) => return "SUBN Vx, Vy".to_string(), [INFO] [stdout] 71 + (8, _, _, 7) => "SUBN Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:72:27 [INFO] [stdout] | [INFO] [stdout] 72 | (8, _, _, 0xE) => return "SHL Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - (8, _, _, 0xE) => return "SHL Vx".to_string(), [INFO] [stdout] 72 + (8, _, _, 0xE) => "SHL Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | (9, _, _, 0) => return "SNE Vx, Vy".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - (9, _, _, 0) => return "SNE Vx, Vy".to_string(), [INFO] [stdout] 73 + (9, _, _, 0) => "SNE Vx, Vy".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 74 | (0xA, _, _, _) => return "LD I, nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - (0xA, _, _, _) => return "LD I, nnn".to_string(), [INFO] [stdout] 74 + (0xA, _, _, _) => "LD I, nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 75 | (0xB, _, _, _) => return "JP V0, nnn".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - (0xB, _, _, _) => return "JP V0, nnn".to_string(), [INFO] [stdout] 75 + (0xB, _, _, _) => "JP V0, nnn".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:76:27 [INFO] [stdout] | [INFO] [stdout] 76 | (0xC, _, _, _) => return "RND Vx, kk".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - (0xC, _, _, _) => return "RND Vx, kk".to_string(), [INFO] [stdout] 76 + (0xC, _, _, _) => "RND Vx, kk".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:77:27 [INFO] [stdout] | [INFO] [stdout] 77 | (0xD, _, _, _) => return "DRW Vx, Vy, n".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - (0xD, _, _, _) => return "DRW Vx, Vy, n".to_string(), [INFO] [stdout] 77 + (0xD, _, _, _) => "DRW Vx, Vy, n".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:78:29 [INFO] [stdout] | [INFO] [stdout] 78 | (0xE, _, 9, 0xE) => return "SKP Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - (0xE, _, 9, 0xE) => return "SKP Vx".to_string(), [INFO] [stdout] 78 + (0xE, _, 9, 0xE) => "SKP Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | (0xE, _, 0xA, 1) => return "SKNP Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - (0xE, _, 0xA, 1) => return "SKNP Vx".to_string(), [INFO] [stdout] 79 + (0xE, _, 0xA, 1) => "SKNP Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | (0xF, _, 0, 7) => return "LD Vx, DT".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - (0xF, _, 0, 7) => return "LD Vx, DT".to_string(), [INFO] [stdout] 80 + (0xF, _, 0, 7) => "LD Vx, DT".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:81:29 [INFO] [stdout] | [INFO] [stdout] 81 | (0xF, _, 0, 0xA) => return "LD Vx, K".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - (0xF, _, 0, 0xA) => return "LD Vx, K".to_string(), [INFO] [stdout] 81 + (0xF, _, 0, 0xA) => "LD Vx, K".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:82:27 [INFO] [stdout] | [INFO] [stdout] 82 | (0xF, _, 1, 5) => return "LD DT, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - (0xF, _, 1, 5) => return "LD DT, Vx".to_string(), [INFO] [stdout] 82 + (0xF, _, 1, 5) => "LD DT, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:83:27 [INFO] [stdout] | [INFO] [stdout] 83 | (0xF, _, 1, 8) => return "LD ST, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - (0xF, _, 1, 8) => return "LD ST, Vx".to_string(), [INFO] [stdout] 83 + (0xF, _, 1, 8) => "LD ST, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (0xF, _, 1, 0xE) => return "ADD I, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - (0xF, _, 1, 0xE) => return "ADD I, Vx".to_string(), [INFO] [stdout] 84 + (0xF, _, 1, 0xE) => "ADD I, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | (0xF, _, 2, 9) => return "LD F, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - (0xF, _, 2, 9) => return "LD F, Vx".to_string(), [INFO] [stdout] 85 + (0xF, _, 2, 9) => "LD F, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:86:27 [INFO] [stdout] | [INFO] [stdout] 86 | (0xF, _, 3, 3) => return "LD B, Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - (0xF, _, 3, 3) => return "LD B, Vx".to_string(), [INFO] [stdout] 86 + (0xF, _, 3, 3) => "LD B, Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:87:27 [INFO] [stdout] | [INFO] [stdout] 87 | (0xF, _, 5, 5) => return "LD [I], Vx".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - (0xF, _, 5, 5) => return "LD [I], Vx".to_string(), [INFO] [stdout] 87 + (0xF, _, 5, 5) => "LD [I], Vx".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:88:27 [INFO] [stdout] | [INFO] [stdout] 88 | (0xF, _, 6, 5) => return "LD Vx, [I]".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - (0xF, _, 6, 5) => return "LD Vx, [I]".to_string(), [INFO] [stdout] 88 + (0xF, _, 6, 5) => "LD Vx, [I]".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decompiler.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | (_, _, _, _) => return format!("{:X}", opcode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - (_, _, _, _) => return format!("{:X}", opcode), [INFO] [stdout] 89 + (_, _, _, _) => format!("{:X}", opcode), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / window.get_keys().map(|keys| { [INFO] [stdout] 44 | | cpu.keys = [false;16]; [INFO] [stdout] 45 | | for t in keys { [INFO] [stdout] 46 | | match t { [INFO] [stdout] ... | [INFO] [stdout] 66 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 43 - window.get_keys().map(|keys| { [INFO] [stdout] 44 - cpu.keys = [false;16]; [INFO] [stdout] 45 - for t in keys { [INFO] [stdout] 46 - match t { [INFO] [stdout] 47 - Key::Key1 => cpu.keys[0x1] = true, [INFO] [stdout] 48 - Key::Key2 => cpu.keys[0x2] = true, [INFO] [stdout] 49 - Key::Key3 => cpu.keys[0x3] = true, [INFO] [stdout] 50 - Key::Key4 => cpu.keys[0xc] = true, [INFO] [stdout] 51 - Key::A => cpu.keys[0x4] = true, [INFO] [stdout] 52 - Key::Z => cpu.keys[0x5] = true, [INFO] [stdout] 53 - Key::E => cpu.keys[0x6] = true, [INFO] [stdout] 54 - Key::R => cpu.keys[0xd] = true, [INFO] [stdout] 55 - Key::Q => cpu.keys[0x7] = true, [INFO] [stdout] 56 - Key::S => cpu.keys[0x8] = true, [INFO] [stdout] 57 - Key::D => cpu.keys[0x9] = true, [INFO] [stdout] 58 - Key::F => cpu.keys[0xe] = true, [INFO] [stdout] 59 - Key::W => cpu.keys[0xa] = true, [INFO] [stdout] 60 - Key::X => cpu.keys[0x0] = true, [INFO] [stdout] 61 - Key::C => cpu.keys[0xb] = true, [INFO] [stdout] 62 - Key::V => cpu.keys[0xf] = true, [INFO] [stdout] 63 - _ => (), [INFO] [stdout] 64 - } [INFO] [stdout] 65 - } [INFO] [stdout] 66 - }); [INFO] [stdout] 43 + if let Some(keys) = window.get_keys() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 45.66s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2, nom v6.2.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "c6119d0c62bf0de16527134448d9f70b591ccebd679074892eb24bab326ad2f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6119d0c62bf0de16527134448d9f70b591ccebd679074892eb24bab326ad2f8", kill_on_drop: false }` [INFO] [stdout] c6119d0c62bf0de16527134448d9f70b591ccebd679074892eb24bab326ad2f8