[INFO] cloning repository https://github.com/GrTomato/rdeptree
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GrTomato/rdeptree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGrTomato%2Frdeptree", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGrTomato%2Frdeptree'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] cfbe9b04ae3caf1f6ed5506e6fd94efbea3c37b4
[INFO] linting GrTomato/rdeptree against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGrTomato%2Frdeptree" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/GrTomato/rdeptree
[INFO] finished tweaking git repo https://github.com/GrTomato/rdeptree
[INFO] tweaked toml for git repo https://github.com/GrTomato/rdeptree written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/GrTomato/rdeptree on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/GrTomato/rdeptree already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] f4c5f59c10a7cee569cf75f24d3062a41a3eb46b5589463f3e56b3b56f0a32fc
[INFO] running `Command { std: "docker" "start" "-a" "f4c5f59c10a7cee569cf75f24d3062a41a3eb46b5589463f3e56b3b56f0a32fc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "f4c5f59c10a7cee569cf75f24d3062a41a3eb46b5589463f3e56b3b56f0a32fc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f4c5f59c10a7cee569cf75f24d3062a41a3eb46b5589463f3e56b3b56f0a32fc", kill_on_drop: false }`
[INFO] [stdout] f4c5f59c10a7cee569cf75f24d3062a41a3eb46b5589463f3e56b3b56f0a32fc
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 805a6b61253d908622f3b37163097a48a7014fc7586f07ef37887d9641ef1315
[INFO] running `Command { std: "docker" "start" "-a" "805a6b61253d908622f3b37163097a48a7014fc7586f07ef37887d9641ef1315", kill_on_drop: false }`
[INFO] [stderr]    Compiling syn v2.0.100
[INFO] [stderr]    Compiling memchr v2.7.4
[INFO] [stderr]    Compiling thiserror-impl v2.0.12
[INFO] [stderr]    Compiling thiserror v2.0.12
[INFO] [stderr]     Checking pest v2.8.0
[INFO] [stderr]    Compiling pest_meta v2.8.0
[INFO] [stderr]    Compiling pest_generator v2.8.0
[INFO] [stderr]    Compiling pest_derive v2.8.0
[INFO] [stderr]     Checking rdeptree v0.0.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/dag.rs:19:40
[INFO] [stdout]    |
[INFO] [stdout] 19 | const DISTRMETA_NAME_NORMALIZE_REGEX: &'static str = r"[-_.]+";
[INFO] [stdout]    |                                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]    --> src/dag.rs:160:28
[INFO] [stdout]     |
[INFO] [stdout] 160 | const METADATA_FILE_NAME: &'static str = "METADATA";
[INFO] [stdout]     |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]  --> src/utils.rs:8:29
[INFO] [stdout]   |
[INFO] [stdout] 8 | const METADATA_DIR_SUFFIX: &'static str = ".dist-info";
[INFO] [stdout]   |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/dag.rs:19:40
[INFO] [stdout]    |
[INFO] [stdout] 19 | const DISTRMETA_NAME_NORMALIZE_REGEX: &'static str = r"[-_.]+";
[INFO] [stdout]    |                                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]    --> src/dag.rs:160:28
[INFO] [stdout]     |
[INFO] [stdout] 160 | const METADATA_FILE_NAME: &'static str = "METADATA";
[INFO] [stdout]     |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `pest::Parser`
[INFO] [stdout]  --> src/parser.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use pest::Parser;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]  --> src/utils.rs:8:29
[INFO] [stdout]   |
[INFO] [stdout] 8 | const METADATA_DIR_SUFFIX: &'static str = ".dist-info";
[INFO] [stdout]   |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this call to `as_ref` does nothing
[INFO] [stdout]   --> src/dag.rs:96:64
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if let Ok(mut parse_pair) = DepParser::parse(row_rule, line.as_ref()) {
[INFO] [stdout]    |                                                                ^^^^^^^^^^^^^ help: try: `line`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stdout]    = note: `#[warn(clippy::useless_asref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/dag.rs:173:17
[INFO] [stdout]     |
[INFO] [stdout] 173 |                 !(r == "Description-Content-Type")
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(r != "Description-Content-Type")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]   --> src/locator.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 | /     if let Ok(e) = env::var("VIRTUAL_ENV") {
[INFO] [stdout] 72 | |         Some(e)
[INFO] [stdout] 73 | |     } else {
[INFO] [stdout] 74 | |         None
[INFO] [stdout] 75 | |     }
[INFO] [stdout]    | |_____^ help: replace with: `env::var("VIRTUAL_ENV").ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]    = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this call to `as_ref` does nothing
[INFO] [stdout]   --> src/dag.rs:96:64
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if let Ok(mut parse_pair) = DepParser::parse(row_rule, line.as_ref()) {
[INFO] [stdout]    |                                                                ^^^^^^^^^^^^^ help: try: `line`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stdout]    = note: `#[warn(clippy::useless_asref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/render.rs:31:17
[INFO] [stdout]    |
[INFO] [stdout] 31 |         None => return,
[INFO] [stdout]    |                 ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: replace `return` with a unit value
[INFO] [stdout]    |
[INFO] [stdout] 31 ~         None => (),
[INFO] [stdout] 32 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/dag.rs:173:17
[INFO] [stdout]     |
[INFO] [stdout] 173 |                 !(r == "Description-Content-Type")
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(r != "Description-Content-Type")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
[INFO] [stdout]    --> src/dag.rs:199:33
[INFO] [stdout]     |
[INFO] [stdout] 199 |             node_from_file_iter(sample_meta.into_iter()).unwrap();
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
[INFO] [stdout]    --> src/dag.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 |     I: IntoIterator<Item = S>,
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] help: consider removing the `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 199 -             node_from_file_iter(sample_meta.into_iter()).unwrap();
[INFO] [stdout] 199 +             node_from_file_iter(sample_meta).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/dag.rs:203:9
[INFO] [stdout]     |
[INFO] [stdout] 203 |         assert_eq!(distribution_meta.dependencies.is_empty(), false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 203 -         assert_eq!(distribution_meta.dependencies.is_empty(), false);
[INFO] [stdout] 203 +         assert!(!distribution_meta.dependencies.is_empty());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
[INFO] [stdout]    --> src/dag.rs:232:33
[INFO] [stdout]     |
[INFO] [stdout] 232 |             node_from_file_iter(sample_meta.into_iter()).unwrap();
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
[INFO] [stdout]    --> src/dag.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 |     I: IntoIterator<Item = S>,
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing the `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 232 -             node_from_file_iter(sample_meta.into_iter()).unwrap();
[INFO] [stdout] 232 +             node_from_file_iter(sample_meta).unwrap();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/dag.rs:236:9
[INFO] [stdout]     |
[INFO] [stdout] 236 |         assert_eq!(distribution_meta.dependencies.is_empty(), false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 236 -         assert_eq!(distribution_meta.dependencies.is_empty(), false);
[INFO] [stdout] 236 +         assert!(!distribution_meta.dependencies.is_empty());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Values<'_, std::string::String, dag::DistributionMeta>`
[INFO] [stdout]   --> src/main.rs:61:58
[INFO] [stdout]    |
[INFO] [stdout] 61 |       let non_empty_dependenices_names: HashSet<&String> = dag
[INFO] [stdout]    |  __________________________________________________________^
[INFO] [stdout] 62 | |         .values()
[INFO] [stdout] 63 | |         .into_iter()
[INFO] [stdout]    | |____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]    |
[INFO] [stdout] 61 ~     let non_empty_dependenices_names: HashSet<&String> = dag
[INFO] [stdout] 62 +         .values()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)`
[INFO] [stdout]   --> src/main.rs:78:10
[INFO] [stdout]    |
[INFO] [stdout] 78 |           .filter_map(|k| {
[INFO] [stdout]    |  __________^
[INFO] [stdout] 79 | |             if !non_empty_dependenices_names.contains(k) {
[INFO] [stdout] 80 | |                 Some(k)
[INFO] [stdout] 81 | |             } else {
[INFO] [stdout] ...  |
[INFO] [stdout] 84 | |         })
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_filter_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Keys<'_, std::string::String, dag::DistributionMeta>`
[INFO] [stdout]   --> src/main.rs:75:49
[INFO] [stdout]    |
[INFO] [stdout] 75 |       let top_level_distributions: Vec<&String> = dag
[INFO] [stdout]    |  _________________________________________________^
[INFO] [stdout] 76 | |         .keys()
[INFO] [stdout] 77 | |         .into_iter()
[INFO] [stdout]    | |____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]    |
[INFO] [stdout] 75 ~     let top_level_distributions: Vec<&String> = dag
[INFO] [stdout] 76 +         .keys()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
[INFO] [stdout]    --> src/dag.rs:332:42
[INFO] [stdout]     |
[INFO] [stdout] 332 |         let result = node_from_file_iter(sample_meta.into_iter());
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
[INFO] [stdout]    --> src/dag.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 |     I: IntoIterator<Item = S>,
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing the `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 332 -         let result = node_from_file_iter(sample_meta.into_iter());
[INFO] [stdout] 332 +         let result = node_from_file_iter(sample_meta);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
[INFO] [stdout]    --> src/dag.rs:344:42
[INFO] [stdout]     |
[INFO] [stdout] 344 |         let result = node_from_file_iter(sample_meta.into_iter());
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
[INFO] [stdout]    --> src/dag.rs:127:8
[INFO] [stdout]     |
[INFO] [stdout] 127 |     I: IntoIterator<Item = S>,
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing the `.into_iter()`
[INFO] [stdout]     |
[INFO] [stdout] 344 -         let result = node_from_file_iter(sample_meta.into_iter());
[INFO] [stdout] 344 +         let result = node_from_file_iter(sample_meta);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout]   --> src/locator.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 | /     if let Ok(e) = env::var("VIRTUAL_ENV") {
[INFO] [stdout] 72 | |         Some(e)
[INFO] [stdout] 73 | |     } else {
[INFO] [stdout] 74 | |         None
[INFO] [stdout] 75 | |     }
[INFO] [stdout]    | |_____^ help: replace with: `env::var("VIRTUAL_ENV").ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]    = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/render.rs:31:17
[INFO] [stdout]    |
[INFO] [stdout] 31 |         None => return,
[INFO] [stdout]    |                 ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: replace `return` with a unit value
[INFO] [stdout]    |
[INFO] [stdout] 31 ~         None => (),
[INFO] [stdout] 32 ~     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Values<'_, std::string::String, dag::DistributionMeta>`
[INFO] [stdout]   --> src/main.rs:61:58
[INFO] [stdout]    |
[INFO] [stdout] 61 |       let non_empty_dependenices_names: HashSet<&String> = dag
[INFO] [stdout]    |  __________________________________________________________^
[INFO] [stdout] 62 | |         .values()
[INFO] [stdout] 63 | |         .into_iter()
[INFO] [stdout]    | |____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]    |
[INFO] [stdout] 61 ~     let non_empty_dependenices_names: HashSet<&String> = dag
[INFO] [stdout] 62 +         .values()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)`
[INFO] [stdout]   --> src/main.rs:78:10
[INFO] [stdout]    |
[INFO] [stdout] 78 |           .filter_map(|k| {
[INFO] [stdout]    |  __________^
[INFO] [stdout] 79 | |             if !non_empty_dependenices_names.contains(k) {
[INFO] [stdout] 80 | |                 Some(k)
[INFO] [stdout] 81 | |             } else {
[INFO] [stdout] ...  |
[INFO] [stdout] 84 | |         })
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_filter_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Keys<'_, std::string::String, dag::DistributionMeta>`
[INFO] [stdout]   --> src/main.rs:75:49
[INFO] [stdout]    |
[INFO] [stdout] 75 |       let top_level_distributions: Vec<&String> = dag
[INFO] [stdout]    |  _________________________________________________^
[INFO] [stdout] 76 | |         .keys()
[INFO] [stdout] 77 | |         .into_iter()
[INFO] [stdout]    | |____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] help: consider removing `.into_iter()`
[INFO] [stdout]    |
[INFO] [stdout] 75 ~     let top_level_distributions: Vec<&String> = dag
[INFO] [stdout] 76 +         .keys()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.28s
[INFO] running `Command { std: "docker" "inspect" "805a6b61253d908622f3b37163097a48a7014fc7586f07ef37887d9641ef1315", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "805a6b61253d908622f3b37163097a48a7014fc7586f07ef37887d9641ef1315", kill_on_drop: false }`
[INFO] [stdout] 805a6b61253d908622f3b37163097a48a7014fc7586f07ef37887d9641ef1315