[INFO] cloning repository https://github.com/Gorf963/pipes
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gorf963/pipes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGorf963%2Fpipes", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGorf963%2Fpipes'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] e3f6269498591d6d407e25eff96b7f80e293c5b9
[INFO] linting Gorf963/pipes against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGorf963%2Fpipes" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Gorf963/pipes
[INFO] finished tweaking git repo https://github.com/Gorf963/pipes
[INFO] tweaked toml for git repo https://github.com/Gorf963/pipes written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Gorf963/pipes on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Gorf963/pipes already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] f0aaebe255884d30bb923f741a1497a5056e7932be54551dcb92e14e71510f07
[INFO] running `Command { std: "docker" "start" "-a" "f0aaebe255884d30bb923f741a1497a5056e7932be54551dcb92e14e71510f07", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "f0aaebe255884d30bb923f741a1497a5056e7932be54551dcb92e14e71510f07", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f0aaebe255884d30bb923f741a1497a5056e7932be54551dcb92e14e71510f07", kill_on_drop: false }`
[INFO] [stdout] f0aaebe255884d30bb923f741a1497a5056e7932be54551dcb92e14e71510f07
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 12730f5afad489f22630ac6b3f7cb2cb39d2436b0dc89aeaaedc010438bd3cc2
[INFO] running `Command { std: "docker" "start" "-a" "12730f5afad489f22630ac6b3f7cb2cb39d2436b0dc89aeaaedc010438bd3cc2", kill_on_drop: false }`
[INFO] [stderr]     Checking pipes v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipe/mod.rs:50:13
[INFO] [stdout]    |
[INFO] [stdout] 50 |             pipe_number: pipe_number, 
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipe_number`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipe/mod.rs:51:13
[INFO] [stdout]    |
[INFO] [stdout] 51 |             start_x: start_x,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `start_x`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipe/mod.rs:52:13
[INFO] [stdout]    |
[INFO] [stdout] 52 |             start_y: start_y,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `start_y`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around `for` iterator expression
[INFO] [stdout]   --> src/main.rs:36:14
[INFO] [stdout]    |
[INFO] [stdout] 36 |     for j in {0..Y} {
[INFO] [stdout]    |              ^    ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_braces)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these braces
[INFO] [stdout]    |
[INFO] [stdout] 36 -     for j in {0..Y} {
[INFO] [stdout] 36 +     for j in 0..Y  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around `for` iterator expression
[INFO] [stdout]   --> src/main.rs:37:18
[INFO] [stdout]    |
[INFO] [stdout] 37 |         for i in {0..X} {
[INFO] [stdout]    |                  ^    ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]    |
[INFO] [stdout] 37 -         for i in {0..X} {
[INFO] [stdout] 37 +         for i in 0..X  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipe/mod.rs:50:13
[INFO] [stdout]    |
[INFO] [stdout] 50 |             pipe_number: pipe_number, 
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipe_number`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipe/mod.rs:51:13
[INFO] [stdout]    |
[INFO] [stdout] 51 |             start_x: start_x,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `start_x`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipe/mod.rs:52:13
[INFO] [stdout]    |
[INFO] [stdout] 52 |             start_y: start_y,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `start_y`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around `for` iterator expression
[INFO] [stdout]   --> src/main.rs:36:14
[INFO] [stdout]    |
[INFO] [stdout] 36 |     for j in {0..Y} {
[INFO] [stdout]    |              ^    ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_braces)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these braces
[INFO] [stdout]    |
[INFO] [stdout] 36 -     for j in {0..Y} {
[INFO] [stdout] 36 +     for j in 0..Y  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary braces around `for` iterator expression
[INFO] [stdout]   --> src/main.rs:37:18
[INFO] [stdout]    |
[INFO] [stdout] 37 |         for i in {0..X} {
[INFO] [stdout]    |                  ^    ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these braces
[INFO] [stdout]    |
[INFO] [stdout] 37 -         for i in {0..X} {
[INFO] [stdout] 37 +         for i in 0..X  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/pipe/mod.rs:2:11
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::{i32};
[INFO] [stdout]   |           ^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `i32::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         return false;
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 21 -         return false;
[INFO] [stdout] 21 +         false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:27:9
[INFO] [stdout]    |
[INFO] [stdout] 27 |         return (self.x - x).abs() + (self.y - y).abs();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 -         return (self.x - x).abs() + (self.y - y).abs();
[INFO] [stdout] 27 +         (self.x - x).abs() + (self.y - y).abs()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:66:9
[INFO] [stdout]    |
[INFO] [stdout] 66 |         return self;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 66 -         return self;
[INFO] [stdout] 66 +         self
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `pipe::Pipe`
[INFO] [stdout]   --> src/pipe/mod.rs:68:5
[INFO] [stdout]    |
[INFO] [stdout] 68 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 69 | |         let mut _output = String::new();
[INFO] [stdout] 70 | |         _output = format!("Pipe: {}, X0:{} Y0:{},X1:{}, Y1:{}", self.pipe_number, self.start_x, self.start_y, self.end_x, self.end...
[INFO] [stdout] 71 | |         return _output;
[INFO] [stdout] 72 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `pipe::Pipe` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 |         return _output;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -         return _output;
[INFO] [stdout] 71 +         _output
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipe/mod.rs:174:9
[INFO] [stdout]     |
[INFO] [stdout] 174 |         return true;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 174 -         return true;
[INFO] [stdout] 174 +         true
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/pipe/mod.rs:2:11
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::{i32};
[INFO] [stdout]   |           ^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `i32::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i32` is unnecessary
[INFO] [stdout]    --> src/pipe/mod.rs:127:33
[INFO] [stdout]     |
[INFO] [stdout] 127 |             if current_step.x > 0 as i32 {
[INFO] [stdout]     |                                 ^^^^^^^^ help: try: `0_i32`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipe/mod.rs:194:5
[INFO] [stdout]     |
[INFO] [stdout] 194 |     return north.clone();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 194 -     return north.clone();
[INFO] [stdout] 194 +     north.clone()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`)
[INFO] [stdout]    --> src/pipe/mod.rs:187:13
[INFO] [stdout]     |
[INFO] [stdout] 187 |     if l == (10*y) as i32 {return StepPipe::new(-1,-1);}
[INFO] [stdout]     |             ^^^^^^^^^^^^^ help: try: `(10*y)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         return false;
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 21 -         return false;
[INFO] [stdout] 21 +         false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/loader/mod.rs:15:24
[INFO] [stdout]    |
[INFO] [stdout] 15 |                     if !option.is_none() {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^ help: try: `option.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:27:9
[INFO] [stdout]    |
[INFO] [stdout] 27 |         return (self.x - x).abs() + (self.y - y).abs();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 -         return (self.x - x).abs() + (self.y - y).abs();
[INFO] [stdout] 27 +         (self.x - x).abs() + (self.y - y).abs()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `option` after checking its variant with `is_none`
[INFO] [stdout]   --> src/loader/mod.rs:16:29
[INFO] [stdout]    |
[INFO] [stdout] 15 |                     if !option.is_none() {
[INFO] [stdout]    |                         ---------------- the check is happening here
[INFO] [stdout] 16 |                         z = option.unwrap();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `search` after checking its variant with `is_none`
[INFO] [stdout]   --> src/loader/mod.rs:21:35
[INFO] [stdout]    |
[INFO] [stdout] 18 |                         if search.is_none() {
[INFO] [stdout]    |                         ------------------- help: try: `if let Some(<item>) = search`
[INFO] [stdout] ...
[INFO] [stdout] 21 |                             pipes[search.unwrap() as usize].second_point(i as i32, j as i32);
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `j` is used as a loop counter
[INFO] [stdout]   --> src/loader/mod.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     for line in file_contents.lines() {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, line) in file_contents.lines().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stdout]   --> src/loader/mod.rs:19:50
[INFO] [stdout]    |
[INFO] [stdout] 19 | ...                   pipes.push(Pipe::new(z as char,i as i32,j as i32));
[INFO] [stdout]    |                                            ^^^^^^^^^ help: try: `z`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/loader/mod.rs:21:35
[INFO] [stdout]    |
[INFO] [stdout] 21 | ...                   pipes[search.unwrap() as usize].second_point(i as i32, j as i32);
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ search.unwrap() }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:66:9
[INFO] [stdout]    |
[INFO] [stdout] 66 |         return self;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 66 -         return self;
[INFO] [stdout] 66 +         self
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `pipe::Pipe`
[INFO] [stdout]   --> src/pipe/mod.rs:68:5
[INFO] [stdout]    |
[INFO] [stdout] 68 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 69 | |         let mut _output = String::new();
[INFO] [stdout] 70 | |         _output = format!("Pipe: {}, X0:{} Y0:{},X1:{}, Y1:{}", self.pipe_number, self.start_x, self.start_y, self.end_x, self.end...
[INFO] [stdout] 71 | |         return _output;
[INFO] [stdout] 72 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `pipe::Pipe` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipe/mod.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 |         return _output;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -         return _output;
[INFO] [stdout] 71 +         _output
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipe/mod.rs:174:9
[INFO] [stdout]     |
[INFO] [stdout] 174 |         return true;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 174 -         return true;
[INFO] [stdout] 174 +         true
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 41 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i32` is unnecessary
[INFO] [stdout]    --> src/pipe/mod.rs:127:33
[INFO] [stdout]     |
[INFO] [stdout] 127 |             if current_step.x > 0 as i32 {
[INFO] [stdout]     |                                 ^^^^^^^^ help: try: `0_i32`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipe/mod.rs:194:5
[INFO] [stdout]     |
[INFO] [stdout] 194 |     return north.clone();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 194 -     return north.clone();
[INFO] [stdout] 194 +     north.clone()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`)
[INFO] [stdout]    --> src/pipe/mod.rs:187:13
[INFO] [stdout]     |
[INFO] [stdout] 187 |     if l == (10*y) as i32 {return StepPipe::new(-1,-1);}
[INFO] [stdout]     |             ^^^^^^^^^^^^^ help: try: `(10*y)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/loader/mod.rs:15:24
[INFO] [stdout]    |
[INFO] [stdout] 15 |                     if !option.is_none() {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^ help: try: `option.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `option` after checking its variant with `is_none`
[INFO] [stdout]   --> src/loader/mod.rs:16:29
[INFO] [stdout]    |
[INFO] [stdout] 15 |                     if !option.is_none() {
[INFO] [stdout]    |                         ---------------- the check is happening here
[INFO] [stdout] 16 |                         z = option.unwrap();
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `search` after checking its variant with `is_none`
[INFO] [stdout]   --> src/loader/mod.rs:21:35
[INFO] [stdout]    |
[INFO] [stdout] 18 |                         if search.is_none() {
[INFO] [stdout]    |                         ------------------- help: try: `if let Some(<item>) = search`
[INFO] [stdout] ...
[INFO] [stdout] 21 |                             pipes[search.unwrap() as usize].second_point(i as i32, j as i32);
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `j` is used as a loop counter
[INFO] [stdout]   --> src/loader/mod.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     for line in file_contents.lines() {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, line) in file_contents.lines().enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stdout]   --> src/loader/mod.rs:19:50
[INFO] [stdout]    |
[INFO] [stdout] 19 | ...                   pipes.push(Pipe::new(z as char,i as i32,j as i32));
[INFO] [stdout]    |                                            ^^^^^^^^^ help: try: `z`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/loader/mod.rs:21:35
[INFO] [stdout]    |
[INFO] [stdout] 21 | ...                   pipes[search.unwrap() as usize].second_point(i as i32, j as i32);
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ search.unwrap() }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/main.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 41 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s
[INFO] running `Command { std: "docker" "inspect" "12730f5afad489f22630ac6b3f7cb2cb39d2436b0dc89aeaaedc010438bd3cc2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "12730f5afad489f22630ac6b3f7cb2cb39d2436b0dc89aeaaedc010438bd3cc2", kill_on_drop: false }`
[INFO] [stdout] 12730f5afad489f22630ac6b3f7cb2cb39d2436b0dc89aeaaedc010438bd3cc2