[INFO] cloning repository https://github.com/GlomGlom57/Kaelang [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GlomGlom57/Kaelang" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGlomGlom57%2FKaelang", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGlomGlom57%2FKaelang'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 87a215a2d0ee61e96ecf0c78c28c3f4f00c9158e [INFO] linting GlomGlom57/Kaelang against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGlomGlom57%2FKaelang" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/GlomGlom57/Kaelang [INFO] finished tweaking git repo https://github.com/GlomGlom57/Kaelang [INFO] tweaked toml for git repo https://github.com/GlomGlom57/Kaelang written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/GlomGlom57/Kaelang on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/GlomGlom57/Kaelang already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 71be34af90f170f4867c9050a0b0477f218c4504b3a5f559ec557060fbf80e58 [INFO] running `Command { std: "docker" "start" "-a" "71be34af90f170f4867c9050a0b0477f218c4504b3a5f559ec557060fbf80e58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "71be34af90f170f4867c9050a0b0477f218c4504b3a5f559ec557060fbf80e58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71be34af90f170f4867c9050a0b0477f218c4504b3a5f559ec557060fbf80e58", kill_on_drop: false }` [INFO] [stdout] 71be34af90f170f4867c9050a0b0477f218c4504b3a5f559ec557060fbf80e58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3391920748a73ef8161bec18a88635eadaf1bb09c0a11cb41f8efb77ec550f8 [INFO] running `Command { std: "docker" "start" "-a" "a3391920748a73ef8161bec18a88635eadaf1bb09c0a11cb41f8efb77ec550f8", kill_on_drop: false }` [INFO] [stderr] Checking kaelang v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 45 | output.1.push_str(&value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compile.rs:78:38 [INFO] [stdout] | [INFO] [stdout] 78 | output.push_str(&format!("\n_start:")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n_start:".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/compile.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | flags: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 101 - flags: &Vec, [INFO] [stdout] 101 + flags: &[bool], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:110:44 [INFO] [stdout] | [INFO] [stdout] 110 | s_file.push_str(&write_data(false, &symbol_table)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `symbol_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:115:43 [INFO] [stdout] | [INFO] [stdout] 115 | s_file.push_str(&write_data(true, &symbol_table)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `symbol_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | Type::Function => return 0, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - Type::Function => return 0, [INFO] [stdout] 12 + Type::Function => 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | Type::Str(_) => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - Type::Str(_) => return 1, [INFO] [stdout] 13 + Type::Str(_) => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | _ => return 2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - _ => return 2, [INFO] [stdout] 14 + _ => 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/verify.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | fn lexic_analysis(program: &String, tokens: &mut Vec>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn lexic_analysis(program: &String, tokens: &mut Vec>) { [INFO] [stdout] 19 + fn lexic_analysis(program: &str, tokens: &mut Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return true; [INFO] [stdout] 181 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `token_line.get(0)` [INFO] [stdout] --> src/verify.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 71 | match token_line.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `token_line.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/verify.rs:93:49 [INFO] [stdout] | [INFO] [stdout] 93 | ... let mutable: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `mutable` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 93 ~ [INFO] [stdout] 94 ~ let mutable: bool = if first_token == "var" { [INFO] [stdout] 95 ~ true [INFO] [stdout] 96 | } else { [INFO] [stdout] 97 ~ false [INFO] [stdout] 98 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/verify.rs:94:49 [INFO] [stdout] | [INFO] [stdout] 94 | / ... if first_token == "var" { [INFO] [stdout] 95 | | ... mutable = true; [INFO] [stdout] 96 | | ... } else { [INFO] [stdout] 97 | | ... mutable = false; [INFO] [stdout] 98 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `mutable = first_token == "var";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/verify.rs:171:32 [INFO] [stdout] | [INFO] [stdout] 171 | if let None = symbol_table.get(e) { [INFO] [stdout] | -------^^^^---------------------- help: try: `if symbol_table.get(e).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verify.rs:299:36 [INFO] [stdout] | [INFO] [stdout] 299 | ... if !(verify_types(data_type) == verify_types(operator_type)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(verify_types(data_type) != verify_types(operator_type))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 322 - return true; [INFO] [stdout] 322 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/verify.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 187 | flags: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 187 - flags: &mut Vec, [INFO] [stdout] 187 + flags: &mut [bool], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/verify.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | if is_function == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!is_function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verify.rs:300:58 [INFO] [stdout] | [INFO] [stdout] 300 | ... return error_message(&*format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 301 | | ... "Error: Mismatched types (destiny: {:?}, operator: {:?})", [INFO] [stdout] 302 | | ... operator_type, data_type [INFO] [stdout] 303 | | ... )); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 ~ return error_message(&format!( [INFO] [stdout] 301 + "Error: Mismatched types (destiny: {:?}, operator: {:?})", [INFO] [stdout] 302 + operator_type, data_type [INFO] [stdout] 303 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verify.rs:306:54 [INFO] [stdout] | [INFO] [stdout] 306 | ... return error_message(&*format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 307 | | ... "Error: Unknown operator ({})", [INFO] [stdout] 308 | | ... sign [INFO] [stdout] 309 | | ... )); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 306 ~ return error_message(&format!( [INFO] [stdout] 307 + "Error: Unknown operator ({})", [INFO] [stdout] 308 + sign [INFO] [stdout] 309 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:349:5 [INFO] [stdout] | [INFO] [stdout] 349 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 349 - return true; [INFO] [stdout] 349 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verify.rs:334:20 [INFO] [stdout] | [INFO] [stdout] 334 | lexic_analysis(&program, tokens); [INFO] [stdout] | ^^^^^^^^ help: change this to: `program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verify.rs:338:25 [INFO] [stdout] | [INFO] [stdout] 338 | if !syntax_analysis(&tokens, symbol_table) { [INFO] [stdout] | ^^^^^^^ help: change this to: `tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 45 | output.1.push_str(&value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/compile.rs:78:38 [INFO] [stdout] | [INFO] [stdout] 78 | output.push_str(&format!("\n_start:")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n_start:".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/compile.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | flags: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 101 - flags: &Vec, [INFO] [stdout] 101 + flags: &[bool], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:110:44 [INFO] [stdout] | [INFO] [stdout] 110 | s_file.push_str(&write_data(false, &symbol_table)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `symbol_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compile.rs:115:43 [INFO] [stdout] | [INFO] [stdout] 115 | s_file.push_str(&write_data(true, &symbol_table)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `symbol_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | Type::Function => return 0, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - Type::Function => return 0, [INFO] [stdout] 12 + Type::Function => 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | Type::Str(_) => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - Type::Str(_) => return 1, [INFO] [stdout] 13 + Type::Str(_) => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 14 | _ => return 2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - _ => return 2, [INFO] [stdout] 14 + _ => 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/verify.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | fn lexic_analysis(program: &String, tokens: &mut Vec>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn lexic_analysis(program: &String, tokens: &mut Vec>) { [INFO] [stdout] 19 + fn lexic_analysis(program: &str, tokens: &mut Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return true; [INFO] [stdout] 181 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `token_line.get(0)` [INFO] [stdout] --> src/verify.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 71 | match token_line.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `token_line.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/verify.rs:93:49 [INFO] [stdout] | [INFO] [stdout] 93 | ... let mutable: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `mutable` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 93 ~ [INFO] [stdout] 94 ~ let mutable: bool = if first_token == "var" { [INFO] [stdout] 95 ~ true [INFO] [stdout] 96 | } else { [INFO] [stdout] 97 ~ false [INFO] [stdout] 98 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/verify.rs:94:49 [INFO] [stdout] | [INFO] [stdout] 94 | / ... if first_token == "var" { [INFO] [stdout] 95 | | ... mutable = true; [INFO] [stdout] 96 | | ... } else { [INFO] [stdout] 97 | | ... mutable = false; [INFO] [stdout] 98 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `mutable = first_token == "var";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/verify.rs:171:32 [INFO] [stdout] | [INFO] [stdout] 171 | if let None = symbol_table.get(e) { [INFO] [stdout] | -------^^^^---------------------- help: try: `if symbol_table.get(e).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verify.rs:299:36 [INFO] [stdout] | [INFO] [stdout] 299 | ... if !(verify_types(data_type) == verify_types(operator_type)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(verify_types(data_type) != verify_types(operator_type))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 322 - return true; [INFO] [stdout] 322 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/verify.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 187 | flags: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 187 - flags: &mut Vec, [INFO] [stdout] 187 + flags: &mut [bool], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/verify.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | if is_function == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!is_function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verify.rs:300:58 [INFO] [stdout] | [INFO] [stdout] 300 | ... return error_message(&*format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 301 | | ... "Error: Mismatched types (destiny: {:?}, operator: {:?})", [INFO] [stdout] 302 | | ... operator_type, data_type [INFO] [stdout] 303 | | ... )); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 ~ return error_message(&format!( [INFO] [stdout] 301 + "Error: Mismatched types (destiny: {:?}, operator: {:?})", [INFO] [stdout] 302 + operator_type, data_type [INFO] [stdout] 303 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verify.rs:306:54 [INFO] [stdout] | [INFO] [stdout] 306 | ... return error_message(&*format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 307 | | ... "Error: Unknown operator ({})", [INFO] [stdout] 308 | | ... sign [INFO] [stdout] 309 | | ... )); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 306 ~ return error_message(&format!( [INFO] [stdout] 307 + "Error: Unknown operator ({})", [INFO] [stdout] 308 + sign [INFO] [stdout] 309 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verify.rs:349:5 [INFO] [stdout] | [INFO] [stdout] 349 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 349 - return true; [INFO] [stdout] 349 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verify.rs:334:20 [INFO] [stdout] | [INFO] [stdout] 334 | lexic_analysis(&program, tokens); [INFO] [stdout] | ^^^^^^^^ help: change this to: `program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verify.rs:338:25 [INFO] [stdout] | [INFO] [stdout] 338 | if !syntax_analysis(&tokens, symbol_table) { [INFO] [stdout] | ^^^^^^^ help: change this to: `tokens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.30s [INFO] running `Command { std: "docker" "inspect" "a3391920748a73ef8161bec18a88635eadaf1bb09c0a11cb41f8efb77ec550f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3391920748a73ef8161bec18a88635eadaf1bb09c0a11cb41f8efb77ec550f8", kill_on_drop: false }` [INFO] [stdout] a3391920748a73ef8161bec18a88635eadaf1bb09c0a11cb41f8efb77ec550f8