[INFO] cloning repository https://github.com/GertJan84/HBFileSorter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GertJan84/HBFileSorter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGertJan84%2FHBFileSorter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGertJan84%2FHBFileSorter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cac5427896ada55044eed4d5173f832f065be140 [INFO] linting GertJan84/HBFileSorter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGertJan84%2FHBFileSorter" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/GertJan84/HBFileSorter [INFO] finished tweaking git repo https://github.com/GertJan84/HBFileSorter [INFO] tweaked toml for git repo https://github.com/GertJan84/HBFileSorter written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/GertJan84/HBFileSorter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/GertJan84/HBFileSorter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29bcaabe7f12f921511e7acecf8f590cc5465ff6d7f328442585d6e80e2cf5a4 [INFO] running `Command { std: "docker" "start" "-a" "29bcaabe7f12f921511e7acecf8f590cc5465ff6d7f328442585d6e80e2cf5a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29bcaabe7f12f921511e7acecf8f590cc5465ff6d7f328442585d6e80e2cf5a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29bcaabe7f12f921511e7acecf8f590cc5465ff6d7f328442585d6e80e2cf5a4", kill_on_drop: false }` [INFO] [stdout] 29bcaabe7f12f921511e7acecf8f590cc5465ff6d7f328442585d6e80e2cf5a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a0457c9c3fd7618a8ae46ed99bfb79e940ce7f3a58816d7ce001e6bde282122 [INFO] running `Command { std: "docker" "start" "-a" "2a0457c9c3fd7618a8ae46ed99bfb79e940ce7f3a58816d7ce001e6bde282122", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking HBFileSorter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `path::Path` and `process::exit` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | path::Path, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 7 | process::exit [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if !files.get(filename).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `files.get(filename).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(filename).is_some()` [INFO] [stdout] --> src/main.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | if !files.get(filename).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(filename)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:91:36 [INFO] [stdout] | [INFO] [stdout] 91 | rename(&full_filename, &dest_path.join(&full_filename))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `dest_path.join(&full_filename)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `path::Path` and `process::exit` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | path::Path, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 7 | process::exit [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | if !files.get(filename).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `files.get(filename).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(filename).is_some()` [INFO] [stdout] --> src/main.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | if !files.get(filename).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(filename)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:91:36 [INFO] [stdout] | [INFO] [stdout] 91 | rename(&full_filename, &dest_path.join(&full_filename))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `dest_path.join(&full_filename)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `Command { std: "docker" "inspect" "2a0457c9c3fd7618a8ae46ed99bfb79e940ce7f3a58816d7ce001e6bde282122", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a0457c9c3fd7618a8ae46ed99bfb79e940ce7f3a58816d7ce001e6bde282122", kill_on_drop: false }` [INFO] [stdout] 2a0457c9c3fd7618a8ae46ed99bfb79e940ce7f3a58816d7ce001e6bde282122