[INFO] cloning repository https://github.com/GermanS/otus-smart-prototype-2 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/GermanS/otus-smart-prototype-2" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGermanS%2Fotus-smart-prototype-2", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGermanS%2Fotus-smart-prototype-2'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 824c37c6e1f6f4649e6b2357bffa33763367daa8 [INFO] linting GermanS/otus-smart-prototype-2 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGermanS%2Fotus-smart-prototype-2" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/GermanS/otus-smart-prototype-2 [INFO] finished tweaking git repo https://github.com/GermanS/otus-smart-prototype-2 [INFO] tweaked toml for git repo https://github.com/GermanS/otus-smart-prototype-2 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/GermanS/otus-smart-prototype-2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/GermanS/otus-smart-prototype-2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22272372063a7b0efa3ce709992e658cd5b4837b6956533d20103df47ad20f81 [INFO] running `Command { std: "docker" "start" "-a" "22272372063a7b0efa3ce709992e658cd5b4837b6956533d20103df47ad20f81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22272372063a7b0efa3ce709992e658cd5b4837b6956533d20103df47ad20f81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22272372063a7b0efa3ce709992e658cd5b4837b6956533d20103df47ad20f81", kill_on_drop: false }` [INFO] [stdout] 22272372063a7b0efa3ce709992e658cd5b4837b6956533d20103df47ad20f81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 74cdcd9e6948b1885e29f51d8e0dce441de8d401a7233401f9eda33ddadbe960 [INFO] running `Command { std: "docker" "start" "-a" "74cdcd9e6948b1885e29f51d8e0dce441de8d401a7233401f9eda33ddadbe960", kill_on_drop: false }` [INFO] [stderr] Checking lesson_3 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `plugged_socket_room` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:206:39 [INFO] [stdout] | [INFO] [stdout] 205 | if plugged_socket_room.is_some() && plugged_thermo_room.is_some() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 206 | let plugged_socket_room = plugged_socket_room.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `plugged_thermo_room` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:207:39 [INFO] [stdout] | [INFO] [stdout] 205 | if plugged_socket_room.is_some() && plugged_thermo_room.is_some() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 206 | let plugged_socket_room = plugged_socket_room.unwrap(); [INFO] [stdout] 207 | let plugged_thermo_room = plugged_thermo_room.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `plugged_socket_room` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:206:39 [INFO] [stdout] | [INFO] [stdout] 205 | if plugged_socket_room.is_some() && plugged_thermo_room.is_some() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 206 | let plugged_socket_room = plugged_socket_room.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `plugged_thermo_room` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:207:39 [INFO] [stdout] | [INFO] [stdout] 205 | if plugged_socket_room.is_some() && plugged_thermo_room.is_some() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 206 | let plugged_socket_room = plugged_socket_room.unwrap(); [INFO] [stdout] 207 | let plugged_thermo_room = plugged_thermo_room.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | assert!(!hell.add(limb).is_err(), "Limb should not be added before"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hell.add(limb).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:261:17 [INFO] [stdout] | [INFO] [stdout] 261 | assert!(!hell.add(lust).is_err(), "Lust should not be added before"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hell.add(lust).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | !boiler.plug(Arc::new(thermo)).is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boiler.plug(Arc::new(thermo)).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | !boiler.plug(Arc::new(socket)).is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boiler.plug(Arc::new(socket)).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `Command { std: "docker" "inspect" "74cdcd9e6948b1885e29f51d8e0dce441de8d401a7233401f9eda33ddadbe960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74cdcd9e6948b1885e29f51d8e0dce441de8d401a7233401f9eda33ddadbe960", kill_on_drop: false }` [INFO] [stdout] 74cdcd9e6948b1885e29f51d8e0dce441de8d401a7233401f9eda33ddadbe960