[INFO] cloning repository https://github.com/Gamer069/mc_cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gamer069/mc_cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGamer069%2Fmc_cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGamer069%2Fmc_cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d73fbf8715ff383e2abcef3a3550cc2da6475298 [INFO] linting Gamer069/mc_cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGamer069%2Fmc_cli" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Gamer069/mc_cli [INFO] finished tweaking git repo https://github.com/Gamer069/mc_cli [INFO] tweaked toml for git repo https://github.com/Gamer069/mc_cli written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Gamer069/mc_cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Gamer069/mc_cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde-rename-rule v0.2.2 [INFO] [stderr] Downloaded serde-enum-str v0.3.2 [INFO] [stderr] Downloaded serde-attributes v0.2.1 [INFO] [stderr] Downloaded jars v0.1.1 [INFO] [stderr] Downloaded cli-table-derive v0.5.0 [INFO] [stderr] Downloaded cli-table v0.5.0 [INFO] [stderr] Downloaded serde-xml-rs v0.8.0 [INFO] [stderr] Downloaded oauth2-client v0.2.0 [INFO] [stderr] Downloaded http-api-client-endpoint v0.2.1 [INFO] [stderr] Downloaded oauth2-core v0.2.0 [INFO] [stderr] Downloaded oauth2-microsoft v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d54df0822477a9e00df3158d5ee0355e89d3f87095adf091d6e9fc9cd56b24aa [INFO] running `Command { std: "docker" "start" "-a" "d54df0822477a9e00df3158d5ee0355e89d3f87095adf091d6e9fc9cd56b24aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d54df0822477a9e00df3158d5ee0355e89d3f87095adf091d6e9fc9cd56b24aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d54df0822477a9e00df3158d5ee0355e89d3f87095adf091d6e9fc9cd56b24aa", kill_on_drop: false }` [INFO] [stdout] d54df0822477a9e00df3158d5ee0355e89d3f87095adf091d6e9fc9cd56b24aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df369549f5ed576d34b1e014f6070e40df12c572730f77faa7ec2b52122c879e [INFO] running `Command { std: "docker" "start" "-a" "df369549f5ed576d34b1e014f6070e40df12c572730f77faa7ec2b52122c879e", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Checking litemap v0.7.5 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling zerocopy v0.8.24 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling serde-rename-rule v0.2.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking base64ct v1.7.3 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling portable-atomic v1.11.0 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking dyn-clone v1.0.19 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking rustls-pki-types v1.11.0 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking clap_builder v4.5.37 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking xml-rs v0.8.26 [INFO] [stderr] Checking open v5.3.2 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking http-api-client-endpoint v0.2.1 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking uuid v1.16.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling openssl-sys v0.9.107 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling sys-info v0.9.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling cli-table-derive v0.5.0 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking tokio v1.45.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling serde-attributes v0.2.1 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling serde-enum-str v0.3.2 [INFO] [stderr] Checking clap v4.5.37 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking jars v0.1.1 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.14 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_qs v0.12.0 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking serde-xml-rs v0.8.0 [INFO] [stderr] Checking cli-table v0.5.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking oauth2-core v0.2.0 [INFO] [stderr] Checking oauth2-client v0.2.0 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Checking oauth2-microsoft v0.2.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.15 [INFO] [stderr] Checking mc_cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/vanilla.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | const VANILLA_MANIFEST: &'static str = "https://launchermeta.mojang.com/mc/game/version_manifest.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:12:30 [INFO] [stdout] | [INFO] [stdout] 12 | const FABRIC_GAME_VERSIONS: &'static str = "https://meta.fabricmc.net/v2/versions/game"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:13:32 [INFO] [stdout] | [INFO] [stdout] 13 | const FABRIC_LOADER_VERSIONS: &'static str = "https://meta.fabricmc.net/v2/versions/loader"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | const FABRIC_INTERMEDIARY_VERSIONS: &'static str = "https://meta.fabricmc.net/v2/versions/intermediary"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | const FABRIC_MAVEN: &'static str = "https://maven.fabricmc.net/"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:17:29 [INFO] [stdout] | [INFO] [stdout] 17 | const QUILT_GAME_VERSIONS: &'static str = "https://meta.quiltmc.org/v3/versions/game"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 18 | const QUILT_LOADER_VERSIONS: &'static str = "https://meta.quiltmc.org/v3/versions/loader"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | const QUILT_INTERMEDIARY_VERSIONS: &'static str = "https://meta.quiltmc.org/v3/versions/intermediary"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | const QUILT_MAVEN: &'static str = "https://maven.quiltmc.org/"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/liteloader.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | const LITELOADER_VERSIONS_JSON: &'static str = "https://dl.liteloader.com/versions/versions.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/vanilla.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | const VANILLA_MANIFEST: &'static str = "https://launchermeta.mojang.com/mc/game/version_manifest.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:12:30 [INFO] [stdout] | [INFO] [stdout] 12 | const FABRIC_GAME_VERSIONS: &'static str = "https://meta.fabricmc.net/v2/versions/game"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:13:32 [INFO] [stdout] | [INFO] [stdout] 13 | const FABRIC_LOADER_VERSIONS: &'static str = "https://meta.fabricmc.net/v2/versions/loader"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:14:38 [INFO] [stdout] | [INFO] [stdout] 14 | const FABRIC_INTERMEDIARY_VERSIONS: &'static str = "https://meta.fabricmc.net/v2/versions/intermediary"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 15 | const FABRIC_MAVEN: &'static str = "https://maven.fabricmc.net/"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:17:29 [INFO] [stdout] | [INFO] [stdout] 17 | const QUILT_GAME_VERSIONS: &'static str = "https://meta.quiltmc.org/v3/versions/game"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 18 | const QUILT_LOADER_VERSIONS: &'static str = "https://meta.quiltmc.org/v3/versions/loader"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | const QUILT_INTERMEDIARY_VERSIONS: &'static str = "https://meta.quiltmc.org/v3/versions/intermediary"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/fabric.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | const QUILT_MAVEN: &'static str = "https://maven.quiltmc.org/"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/liteloader.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | const LITELOADER_VERSIONS_JSON: &'static str = "https://dl.liteloader.com/versions/versions.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vanilla.rs:244:16 [INFO] [stdout] | [INFO] [stdout] 244 | if !text.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `text.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `lib.downloads.artifact` after checking its variant with `is_some` [INFO] [stdout] --> src/vanilla.rs:291:28 [INFO] [stdout] | [INFO] [stdout] 290 | if should_download && lib.downloads.artifact.is_some() { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] 291 | let artifact = lib.downloads.artifact.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/vanilla.rs:351:34 [INFO] [stdout] | [INFO] [stdout] 351 | ... .expect(&format!("Failed to write extracted file {}", file_path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write extracted file {}", file_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fabric.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return false; [INFO] [stdout] 53 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/fabric.rs:57:62 [INFO] [stdout] | [INFO] [stdout] 57 | let maven_path_with_domain = format!("{}{}", FABRIC_MAVEN.to_string(), maven_path); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt_version` after checking its variant with `is_some` [INFO] [stdout] --> src/fabric.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 201 | let ver = if opt_version.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = opt_version` [INFO] [stdout] 202 | get_ver(versions, opt_version.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vanilla.rs:244:16 [INFO] [stdout] | [INFO] [stdout] 244 | if !text.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `text.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `lib.downloads.artifact` after checking its variant with `is_some` [INFO] [stdout] --> src/vanilla.rs:291:28 [INFO] [stdout] | [INFO] [stdout] 290 | if should_download && lib.downloads.artifact.is_some() { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] 291 | let artifact = lib.downloads.artifact.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/vanilla.rs:351:34 [INFO] [stdout] | [INFO] [stdout] 351 | ... .expect(&format!("Failed to write extracted file {}", file_path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write extracted file {}", file_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return matches_rule && rule.action == "allow"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return matches_rule && rule.action == "allow"; [INFO] [stdout] 35 + matches_rule && rule.action == "allow" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return matches_rule && rule.action == "allow"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return matches_rule && rule.action == "allow"; [INFO] [stdout] 43 + matches_rule && rule.action == "allow" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rules.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | } else if arch == "x86" { [INFO] [stdout] | ____________________^ [INFO] [stdout] 69 | | if let Some(download) = &classifiers.natives_windows_32 { [INFO] [stdout] 70 | | downloads.push(download); [INFO] [stdout] 71 | | } [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 68 ~ } else if arch == "x86" [INFO] [stdout] 69 ~ && let Some(download) = &classifiers.natives_windows_32 { [INFO] [stdout] 70 | downloads.push(download); [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rules.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | } else if arch == "x86" { [INFO] [stdout] | ____________________^ [INFO] [stdout] 84 | | if let Some(download) = &classifiers.natives_linux_32 { [INFO] [stdout] 85 | | downloads.push(download); [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 83 ~ } else if arch == "x86" [INFO] [stdout] 84 ~ && let Some(download) = &classifiers.natives_linux_32 { [INFO] [stdout] 85 | downloads.push(download); [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fabric.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return false; [INFO] [stdout] 53 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/fabric.rs:57:62 [INFO] [stdout] | [INFO] [stdout] 57 | let maven_path_with_domain = format!("{}{}", FABRIC_MAVEN.to_string(), maven_path); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/liteloader.rs:52:61 [INFO] [stdout] | [INFO] [stdout] 52 | ... let ll = util::download_async(mp, ll_path.as_str(), &ll_jar_path.as_path(), "Downloaded ll jar".to_string()).await.expect("Fai... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ll_jar_path.as_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt_version` after checking its variant with `is_some` [INFO] [stdout] --> src/fabric.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 201 | let ver = if opt_version.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = opt_version` [INFO] [stdout] 202 | get_ver(versions, opt_version.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return matches_rule && rule.action == "allow"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return matches_rule && rule.action == "allow"; [INFO] [stdout] 35 + matches_rule && rule.action == "allow" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return matches_rule && rule.action == "allow"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return matches_rule && rule.action == "allow"; [INFO] [stdout] 43 + matches_rule && rule.action == "allow" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rules.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | } else if arch == "x86" { [INFO] [stdout] | ____________________^ [INFO] [stdout] 69 | | if let Some(download) = &classifiers.natives_windows_32 { [INFO] [stdout] 70 | | downloads.push(download); [INFO] [stdout] 71 | | } [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 68 ~ } else if arch == "x86" [INFO] [stdout] 69 ~ && let Some(download) = &classifiers.natives_windows_32 { [INFO] [stdout] 70 | downloads.push(download); [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rules.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 83 | } else if arch == "x86" { [INFO] [stdout] | ____________________^ [INFO] [stdout] 84 | | if let Some(download) = &classifiers.natives_linux_32 { [INFO] [stdout] 85 | | downloads.push(download); [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 83 ~ } else if arch == "x86" [INFO] [stdout] 84 ~ && let Some(download) = &classifiers.natives_linux_32 { [INFO] [stdout] 85 | downloads.push(download); [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/liteloader.rs:52:61 [INFO] [stdout] | [INFO] [stdout] 52 | ... let ll = util::download_async(mp, ll_path.as_str(), &ll_jar_path.as_path(), "Downloaded ll jar".to_string()).await.expect("Fai... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `ll_jar_path.as_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.64s [INFO] running `Command { std: "docker" "inspect" "df369549f5ed576d34b1e014f6070e40df12c572730f77faa7ec2b52122c879e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df369549f5ed576d34b1e014f6070e40df12c572730f77faa7ec2b52122c879e", kill_on_drop: false }` [INFO] [stdout] df369549f5ed576d34b1e014f6070e40df12c572730f77faa7ec2b52122c879e