[INFO] cloning repository https://github.com/Gabriel-Rosmart/loki [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gabriel-Rosmart/loki" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGabriel-Rosmart%2Floki", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGabriel-Rosmart%2Floki'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f0c94e11933ddb7984e6469347cc97da143d0a8 [INFO] linting Gabriel-Rosmart/loki against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGabriel-Rosmart%2Floki" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Gabriel-Rosmart/loki [INFO] finished tweaking git repo https://github.com/Gabriel-Rosmart/loki [INFO] tweaked toml for git repo https://github.com/Gabriel-Rosmart/loki written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Gabriel-Rosmart/loki on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Gabriel-Rosmart/loki already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.serde.feature [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tiny_http v0.12.0 [INFO] [stderr] Downloaded xml-rs v0.8.14 [INFO] [stderr] Downloaded chunked_transfer v1.4.1 [INFO] [stderr] Downloaded itoa v1.0.8 [INFO] [stderr] Downloaded serde v1.0.166 [INFO] [stderr] Downloaded ryu v1.0.14 [INFO] [stderr] Downloaded serde_derive v1.0.166 [INFO] [stderr] Downloaded tl v0.7.7 [INFO] [stderr] Downloaded proc-macro2 v1.0.63 [INFO] [stderr] Downloaded serde_json v1.0.100 [INFO] [stderr] Downloaded syn v2.0.22 [INFO] [stderr] Downloaded rust-stemmers v1.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7a296f50861f0c977264ae9497fcff0e0a2af29c686c20ed5abeecf8887a1bf [INFO] running `Command { std: "docker" "start" "-a" "a7a296f50861f0c977264ae9497fcff0e0a2af29c686c20ed5abeecf8887a1bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7a296f50861f0c977264ae9497fcff0e0a2af29c686c20ed5abeecf8887a1bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7a296f50861f0c977264ae9497fcff0e0a2af29c686c20ed5abeecf8887a1bf", kill_on_drop: false }` [INFO] [stdout] a7a296f50861f0c977264ae9497fcff0e0a2af29c686c20ed5abeecf8887a1bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2334aed58c6acfcfd760a30a0d0a82816e27c5080a0adbec525ea51b94d2b90f [INFO] running `Command { std: "docker" "start" "-a" "2334aed58c6acfcfd760a30a0d0a82816e27c5080a0adbec525ea51b94d2b90f", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.serde.feature [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling serde v1.0.166 [INFO] [stderr] Compiling serde_json v1.0.100 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking chunked_transfer v1.4.1 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking tl v0.7.7 [INFO] [stderr] Checking xml-rs v0.8.14 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Compiling serde_derive v1.0.166 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking rust-stemmers v1.2.0 [INFO] [stderr] Checking loki v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/fetching/fetcher.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | .filter(|file| Self::is_fetchable(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::is_fetchable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fetching/fetcher.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | && !(entry.metadata().unwrap().permissions().mode() & 0o111 != 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(entry.metadata().unwrap().permissions().mode() & 0o111 == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/fetching/fetcher.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | if let Some(ref extension) = self.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if let Some(ref extension) = self.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stdout] 40 + if let Some(extension) = self.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/indexer.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 82 | let file_content = Reader::read_file(&file); [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/reader.rs:15:55 [INFO] [stdout] | [INFO] [stdout] 15 | "xml" | "xhtml" => Ok(Self::read_xml_file(&file)), [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/reader.rs:16:52 [INFO] [stdout] | [INFO] [stdout] 16 | "html" | "htm" => Self::read_html_file(&file), [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/fetching/reader.rs:17:37 [INFO] [stdout] | [INFO] [stdout] 17 | _ => fs::read_to_string(&file), [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/fetching/reader.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / for event in event_reader.into_iter() { [INFO] [stdout] 28 | | if let Ok(e) = event { [INFO] [stdout] 29 | | if let XmlEvent::Characters(text) = e { [INFO] [stdout] 30 | | content.push_str(&text); [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/fetching/reader.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Ok(e) = event { [INFO] [stdout] 29 | | if let XmlEvent::Characters(text) = e { [INFO] [stdout] 30 | | content.push_str(&text); [INFO] [stdout] 31 | | } [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 ~ for e in event_reader.into_iter().flatten() { [INFO] [stdout] 28 + if let XmlEvent::Characters(text) = e { [INFO] [stdout] 29 + content.push_str(&text); [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/fetching/reader.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | / if let XmlEvent::Characters(text) = e { [INFO] [stdout] 30 | | content.push_str(&text); [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/fetching/reader.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | if let Ok(e) = event { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 29 | if let XmlEvent::Characters(text) = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/fetching/reader.rs:40:46 [INFO] [stdout] | [INFO] [stdout] 40 | let raw_content = fs::read_to_string(&filepath)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `into_owned` [INFO] [stdout] --> src/fetching/reader.rs:45:54 [INFO] [stdout] | [INFO] [stdout] 45 | buffer.push_str(&node.inner_text(&parser).into_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/reader.rs:45:46 [INFO] [stdout] | [INFO] [stdout] 45 | buffer.push_str(&node.inner_text(&parser).into_owned()); [INFO] [stdout] | ^^^^^^^ help: change this to: `parser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/fetching/fetcher.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | .filter(|file| Self::is_fetchable(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::is_fetchable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fetching/fetcher.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | && !(entry.metadata().unwrap().permissions().mode() & 0o111 != 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(entry.metadata().unwrap().permissions().mode() & 0o111 == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/fetching/fetcher.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | if let Some(ref extension) = self.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 - if let Some(ref extension) = self.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stdout] 40 + if let Some(extension) = self.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/indexer.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 82 | let file_content = Reader::read_file(&file); [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/reader.rs:15:55 [INFO] [stdout] | [INFO] [stdout] 15 | "xml" | "xhtml" => Ok(Self::read_xml_file(&file)), [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/reader.rs:16:52 [INFO] [stdout] | [INFO] [stdout] 16 | "html" | "htm" => Self::read_html_file(&file), [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/fetching/reader.rs:17:37 [INFO] [stdout] | [INFO] [stdout] 17 | _ => fs::read_to_string(&file), [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/fetching/reader.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / for event in event_reader.into_iter() { [INFO] [stdout] 28 | | if let Ok(e) = event { [INFO] [stdout] 29 | | if let XmlEvent::Characters(text) = e { [INFO] [stdout] 30 | | content.push_str(&text); [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/fetching/reader.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Ok(e) = event { [INFO] [stdout] 29 | | if let XmlEvent::Characters(text) = e { [INFO] [stdout] 30 | | content.push_str(&text); [INFO] [stdout] 31 | | } [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 ~ for e in event_reader.into_iter().flatten() { [INFO] [stdout] 28 + if let XmlEvent::Characters(text) = e { [INFO] [stdout] 29 + content.push_str(&text); [INFO] [stdout] 30 + } [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/fetching/reader.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | / if let XmlEvent::Characters(text) = e { [INFO] [stdout] 30 | | content.push_str(&text); [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/fetching/reader.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | if let Ok(e) = event { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 29 | if let XmlEvent::Characters(text) = e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/fetching/reader.rs:40:46 [INFO] [stdout] | [INFO] [stdout] 40 | let raw_content = fs::read_to_string(&filepath)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `into_owned` [INFO] [stdout] --> src/fetching/reader.rs:45:54 [INFO] [stdout] | [INFO] [stdout] 45 | buffer.push_str(&node.inner_text(&parser).into_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fetching/reader.rs:45:46 [INFO] [stdout] | [INFO] [stdout] 45 | buffer.push_str(&node.inner_text(&parser).into_owned()); [INFO] [stdout] | ^^^^^^^ help: change this to: `parser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:50:59 [INFO] [stdout] | [INFO] [stdout] 50 | let search_result = Searcher::search_term(&body, Arc::clone(&tf_idf_model)); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:50:59 [INFO] [stdout] | [INFO] [stdout] 50 | let search_result = Searcher::search_term(&body, Arc::clone(&tf_idf_model)); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.53s [INFO] running `Command { std: "docker" "inspect" "2334aed58c6acfcfd760a30a0d0a82816e27c5080a0adbec525ea51b94d2b90f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2334aed58c6acfcfd760a30a0d0a82816e27c5080a0adbec525ea51b94d2b90f", kill_on_drop: false }` [INFO] [stdout] 2334aed58c6acfcfd760a30a0d0a82816e27c5080a0adbec525ea51b94d2b90f