[INFO] cloning repository https://github.com/FreeMasen/duration_parsers [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FreeMasen/duration_parsers" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFreeMasen%2Fduration_parsers", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFreeMasen%2Fduration_parsers'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a34cbcce4aa7590fe9d257e2663cb495b7c78ea8 [INFO] linting FreeMasen/duration_parsers against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFreeMasen%2Fduration_parsers" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FreeMasen/duration_parsers [INFO] finished tweaking git repo https://github.com/FreeMasen/duration_parsers [INFO] tweaked toml for git repo https://github.com/FreeMasen/duration_parsers written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FreeMasen/duration_parsers on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FreeMasen/duration_parsers already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/crates/pest_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/crates/hand_rolled_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/crates/random_durations/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/crates/combine_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/crates/duration/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/crates/nom_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pest_generator v2.0.0 [INFO] [stderr] Downloaded proc-macro2 v0.4.20 [INFO] [stderr] Downloaded sha-1 v0.7.0 [INFO] [stderr] Downloaded quote v0.6.9 [INFO] [stderr] Downloaded either v1.5.0 [INFO] [stderr] Downloaded pest_derive v2.0.1 [INFO] [stderr] Downloaded pest_meta v2.0.3 [INFO] [stderr] Downloaded maplit v1.0.1 [INFO] [stderr] Downloaded memchr v2.1.1 [INFO] [stderr] Downloaded ascii v0.9.1 [INFO] [stderr] Downloaded ucd-trie v0.1.1 [INFO] [stderr] Downloaded combine v3.6.2 [INFO] [stderr] Downloaded libc v0.2.43 [INFO] [stderr] Downloaded pest v2.0.2 [INFO] [stderr] Downloaded syn v0.14.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0acd8180e72061a13e141e656824c3ae1497087bce73db10313d11261174f5b6 [INFO] running `Command { std: "docker" "start" "-a" "0acd8180e72061a13e141e656824c3ae1497087bce73db10313d11261174f5b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0acd8180e72061a13e141e656824c3ae1497087bce73db10313d11261174f5b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0acd8180e72061a13e141e656824c3ae1497087bce73db10313d11261174f5b6", kill_on_drop: false }` [INFO] [stdout] 0acd8180e72061a13e141e656824c3ae1497087bce73db10313d11261174f5b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15dd363a5c99278f319c557ec05572fca21298d9e634444ec8d47d19aaa7a1b1 [INFO] running `Command { std: "docker" "start" "-a" "15dd363a5c99278f319c557ec05572fca21298d9e634444ec8d47d19aaa7a1b1", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/nom_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/duration/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/pest_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/hand_rolled_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/random_durations/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/combine_duration_parser/Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking duration v0.1.0 (/opt/rustwide/workdir/crates/duration) [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking ascii v0.9.1 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking pest v2.0.2 [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Duration` [INFO] [stdout] --> crates/duration/src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> Self { [INFO] [stdout] 14 | | Duration { [INFO] [stdout] 15 | | years: None, [INFO] [stdout] 16 | | months: None, [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for Duration { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Duration` [INFO] [stdout] --> crates/duration/src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> Self { [INFO] [stdout] 14 | | Duration { [INFO] [stdout] 15 | | years: None, [INFO] [stdout] 16 | | months: None, [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for Duration { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hand_rolled_duration_parser v0.1.0 (/opt/rustwide/workdir/crates/hand_rolled_duration_parser) [INFO] [stderr] Checking rand v0.5.5 [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if date_part != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!date_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if time_part != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!time_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if date_part != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!date_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if time_part != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!time_part.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if c == 'Y' [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | || c == 'M' [INFO] [stdout] 40 | | || c == 'W' [INFO] [stdout] 41 | | || c == 'D' [INFO] [stdout] 42 | | || c == 'H' [INFO] [stdout] 43 | | || c == 'M' [INFO] [stdout] 44 | | || c == 'S' { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 44 - || c == 'S' { [INFO] [stdout] 38 + if !(c != 'Y' && c != 'M' && c != 'W' && c != 'D' && c != 'H' && c != 'S') { [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 44 - || c == 'S' { [INFO] [stdout] 38 + if c == 'Y' || c == 'M' || c == 'W' || c == 'D' || c == 'H' || c == 'S' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if c == 'Y' [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | || c == 'M' [INFO] [stdout] 40 | | || c == 'W' [INFO] [stdout] 41 | | || c == 'D' [INFO] [stdout] 42 | | || c == 'H' [INFO] [stdout] 43 | | || c == 'M' [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 38 + if !(c != 'Y' && c != 'M' && c != 'W' && c != 'D' && c != 'H') [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 38 + if c == 'Y' || c == 'M' || c == 'W' || c == 'D' || c == 'H' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if c == 'Y' [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | || c == 'M' [INFO] [stdout] 40 | | || c == 'W' [INFO] [stdout] 41 | | || c == 'D' [INFO] [stdout] 42 | | || c == 'H' [INFO] [stdout] 43 | | || c == 'M' [INFO] [stdout] 44 | | || c == 'S' { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 44 - || c == 'S' { [INFO] [stdout] 38 + if !(c != 'Y' && c != 'M' && c != 'W' && c != 'D' && c != 'H' && c != 'S') { [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 44 - || c == 'S' { [INFO] [stdout] 38 + if c == 'Y' || c == 'M' || c == 'W' || c == 'D' || c == 'H' || c == 'S' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/hand_rolled_duration_parser/src/lib.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if c == 'Y' [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | || c == 'M' [INFO] [stdout] 40 | | || c == 'W' [INFO] [stdout] 41 | | || c == 'D' [INFO] [stdout] 42 | | || c == 'H' [INFO] [stdout] 43 | | || c == 'M' [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 38 + if !(c != 'Y' && c != 'M' && c != 'W' && c != 'D' && c != 'H') [INFO] [stdout] | [INFO] [stdout] 38 - if c == 'Y' [INFO] [stdout] 39 - || c == 'M' [INFO] [stdout] 40 - || c == 'W' [INFO] [stdout] 41 - || c == 'D' [INFO] [stdout] 42 - || c == 'H' [INFO] [stdout] 43 - || c == 'M' [INFO] [stdout] 38 + if c == 'Y' || c == 'M' || c == 'W' || c == 'D' || c == 'H' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking combine v3.6.2 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Compiling quote v0.6.9 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking random_durations v0.1.0 (/opt/rustwide/workdir/crates/random_durations) [INFO] [stderr] Checking parsers v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return 1000 [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return 1000 [INFO] [stdout] 39 + 1000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / match arg.parse() { [INFO] [stdout] 35 | | Ok(u) => return u, [INFO] [stdout] 36 | | Err(_) => () [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(u) = arg.parse() { return u }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `single` is never used [INFO] [stdout] --> benches/main.rs:72:4 [INFO] [stdout] | [INFO] [stdout] 72 | fn single(b: &mut Bencher, f: &impl Fn(&str) -> Result) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `thousand` is never used [INFO] [stdout] --> benches/main.rs:78:4 [INFO] [stdout] | [INFO] [stdout] 78 | fn thousand(b: &mut Bencher, f: &impl Fn(&str) -> Result) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return 1000 [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return 1000 [INFO] [stdout] 39 + 1000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / match arg.parse() { [INFO] [stdout] 35 | | Ok(u) => return u, [INFO] [stdout] 36 | | Err(_) => () [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(u) = arg.parse() { return u }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking nom_duration_parser v0.1.0 (/opt/rustwide/workdir/crates/nom_duration_parser) [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> crates/nom_duration_parser/src/lib.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | for part in date_parts.unwrap_or(Vec::new()).iter().chain(time_parts.unwrap_or(Vec::new()).iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> crates/nom_duration_parser/src/lib.rs:22:74 [INFO] [stdout] | [INFO] [stdout] 22 | for part in date_parts.unwrap_or(Vec::new()).iter().chain(time_parts.unwrap_or(Vec::new()).iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> crates/nom_duration_parser/src/lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | c.is_digit(10) || c == '.' [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> crates/nom_duration_parser/src/lib.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | for part in date_parts.unwrap_or(Vec::new()).iter().chain(time_parts.unwrap_or(Vec::new()).iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> crates/nom_duration_parser/src/lib.rs:22:74 [INFO] [stdout] | [INFO] [stdout] 22 | for part in date_parts.unwrap_or(Vec::new()).iter().chain(time_parts.unwrap_or(Vec::new()).iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> crates/nom_duration_parser/src/lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | c.is_digit(10) || c == '.' [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking pest_duration_parser v0.1.0 (/opt/rustwide/workdir/crates/pest_duration_parser) [INFO] [stderr] Checking combine_duration_parser v0.1.0 (/opt/rustwide/workdir/crates/combine_duration_parser) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> crates/combine_duration_parser/src/lib.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / ( [INFO] [stdout] 50 | | many1(value_pair(false)) [INFO] [stdout] | | ________^________________________^ [INFO] [stdout] | ||________| [INFO] [stdout] | | [INFO] [stdout] 51 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - ( [INFO] [stdout] 50 - many1(value_pair(false)) [INFO] [stdout] 51 - ) [INFO] [stdout] 49 + many1(value_pair(false)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> crates/combine_duration_parser/src/lib.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / ( [INFO] [stdout] 50 | | many1(value_pair(false)) [INFO] [stdout] | | ________^________________________^ [INFO] [stdout] | ||________| [INFO] [stdout] | | [INFO] [stdout] 51 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - ( [INFO] [stdout] 50 - many1(value_pair(false)) [INFO] [stdout] 51 - ) [INFO] [stdout] 49 + many1(value_pair(false)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.09s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.1.1, syn v0.14.9 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "15dd363a5c99278f319c557ec05572fca21298d9e634444ec8d47d19aaa7a1b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15dd363a5c99278f319c557ec05572fca21298d9e634444ec8d47d19aaa7a1b1", kill_on_drop: false }` [INFO] [stdout] 15dd363a5c99278f319c557ec05572fca21298d9e634444ec8d47d19aaa7a1b1