[INFO] cloning repository https://github.com/FranLMSP/rust_boy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FranLMSP/rust_boy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFranLMSP%2Frust_boy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFranLMSP%2Frust_boy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4b47ae96a1a0f286a95bf2a1dea4f5b1a3711358 [INFO] linting FranLMSP/rust_boy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFranLMSP%2Frust_boy" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FranLMSP/rust_boy [INFO] finished tweaking git repo https://github.com/FranLMSP/rust_boy [INFO] tweaked toml for git repo https://github.com/FranLMSP/rust_boy written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FranLMSP/rust_boy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FranLMSP/rust_boy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pkg-config v0.3.22 [INFO] [stderr] Downloaded mio-misc v1.2.1 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.28 [INFO] [stderr] Downloaded pixels v0.7.0 [INFO] [stderr] Downloaded pollster v0.2.4 [INFO] [stderr] Downloaded gpu-descriptor v0.2.1 [INFO] [stderr] Downloaded winit_input_helper v0.10.0 [INFO] [stderr] Downloaded gpu-alloc v0.5.2 [INFO] [stderr] Downloaded wgpu-types v0.11.0 [INFO] [stderr] Downloaded arrayvec v0.7.1 [INFO] [stderr] Downloaded libloading v0.7.1 [INFO] [stderr] Downloaded minimal-lexical v0.1.4 [INFO] [stderr] Downloaded wgpu v0.11.0 [INFO] [stderr] Downloaded glow v0.11.0 [INFO] [stderr] Downloaded wgpu-core v0.11.2 [INFO] [stderr] Downloaded wgpu-hal v0.11.4 [INFO] [stderr] Downloaded naga v0.7.1 [INFO] [stderr] Downloaded ash v0.33.3+1.2.191 [INFO] [stderr] Downloaded libc v0.2.105 [INFO] [stderr] Downloaded profiling v1.0.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09c90e3ff291b3b008255dd940b8da4fc8d02ff329eee3608651aa1f2dce547a [INFO] running `Command { std: "docker" "start" "-a" "09c90e3ff291b3b008255dd940b8da4fc8d02ff329eee3608651aa1f2dce547a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09c90e3ff291b3b008255dd940b8da4fc8d02ff329eee3608651aa1f2dce547a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09c90e3ff291b3b008255dd940b8da4fc8d02ff329eee3608651aa1f2dce547a", kill_on_drop: false }` [INFO] [stdout] 09c90e3ff291b3b008255dd940b8da4fc8d02ff329eee3608651aa1f2dce547a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0055e70cca3e5fc0e25f929acfbb4b51d81ceb169da4b61aa3ff611d4f95e842 [INFO] running `Command { std: "docker" "start" "-a" "0055e70cca3e5fc0e25f929acfbb4b51d81ceb169da4b61aa3ff611d4f95e842", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Checking libloading v0.7.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Checking minimal-lexical v0.1.4 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Compiling wgpu-core v0.11.2 [INFO] [stderr] Checking gpu-alloc v0.5.2 [INFO] [stderr] Checking gpu-descriptor v0.2.1 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Checking ash v0.33.3+1.2.191 [INFO] [stderr] Checking wgpu-types v0.11.0 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking arrayvec v0.7.1 [INFO] [stderr] Checking inplace_it v0.3.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking profiling v1.0.3 [INFO] [stderr] Checking glow v0.11.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Compiling winit v0.25.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling cpal v0.13.4 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking pollster v0.2.4 [INFO] [stderr] Checking spirv v0.2.0+1.5.4 [INFO] [stderr] Checking wide v0.6.5 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking parking_lot_core v0.8.5 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking khronos-egl v4.1.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking xdg v2.4.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio-misc v1.2.1 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking ultraviolet v0.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking alsa v0.5.0 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking naga v0.7.1 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wgpu-hal v0.11.4 [INFO] [stderr] Checking wgpu v0.11.0 [INFO] [stderr] Checking pixels v0.7.0 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking winit_input_helper v0.10.0 [INFO] [stderr] Checking rmg-001 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/joypad.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | ) | ( [INFO] [stdout] | _____________^ [INFO] [stdout] 80 | | (!((direction && self.right) || (action && self.a)) as u8) [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_________^ help: remove them: `(!((direction && self.right) || (action && self.a)) as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/joypad.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | ) | ( [INFO] [stdout] | _____________^ [INFO] [stdout] 80 | | (!((direction && self.right) || (action && self.a)) as u8) [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_________^ help: remove them: `(!((direction && self.right) || (action && self.a)) as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `publisher`, `title`, `sgb_features`, and `has_timer` are never read [INFO] [stdout] --> src/rom.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 149 | pub struct ROMInfo { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 152 | publisher: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 153 | title: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | sgb_features: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | has_timer: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ROMInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Registers` [INFO] [stdout] --> src/cpu.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / pub fn new() -> Self { [INFO] [stdout] 79 | | Self { [INFO] [stdout] 80 | | a: 0x01, [INFO] [stdout] 81 | | f: 0xB0, // The first 4 lower bits are always set to 0 [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 77 + impl Default for Registers { [INFO] [stdout] 78 + fn default() -> Self { [INFO] [stdout] 79 + Self::new() [INFO] [stdout] 80 + } [INFO] [stdout] 81 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu.rs:841:5 [INFO] [stdout] | [INFO] [stdout] 841 | / pub fn new() -> Self { [INFO] [stdout] 842 | | Self { [INFO] [stdout] 843 | | registers: Registers::new(), [INFO] [stdout] 844 | | cycles: Cycles(0.0), [INFO] [stdout] ... | [INFO] [stdout] 854 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 840 + impl Default for CPU { [INFO] [stdout] 841 + fn default() -> Self { [INFO] [stdout] 842 + Self::new() [INFO] [stdout] 843 + } [INFO] [stdout] 844 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:850:26 [INFO] [stdout] | [INFO] [stdout] 850 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:850:59 [INFO] [stdout] | [INFO] [stdout] 850 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOGS").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:865:26 [INFO] [stdout] | [INFO] [stdout] 865 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:865:59 [INFO] [stdout] | [INFO] [stdout] 865 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOGS").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/cpu.rs:1060:56 [INFO] [stdout] | [INFO] [stdout] 1060 | OpcodeParameter::I8(val) => (true, val as i8), [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/cpu.rs:1061:106 [INFO] [stdout] | [INFO] [stdout] 1061 | OpcodeParameter::FlagRegisterReset_I8(flag, val) => (!self.registers.get_flag(flag), val as i8), [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/cpu.rs:1062:103 [INFO] [stdout] | [INFO] [stdout] 1062 | OpcodeParameter::FlagRegisterSet_I8(flag, val) => (self.registers.get_flag(flag), val as i8), [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1201:39 [INFO] [stdout] | [INFO] [stdout] 1201 | ... let res = (self.registers.get(reg1) as u16) + (self.registers.get(reg2) as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.registers.get(reg1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1201:75 [INFO] [stdout] | [INFO] [stdout] 1201 | ... let res = (self.registers.get(reg1) as u16) + (self.registers.get(reg2) as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.registers.get(reg2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1232:78 [INFO] [stdout] | [INFO] [stdout] 1232 | ... self.registers.set_flag(FlagRegister::Carry, (val1 as u16) + (val2 as u16) > 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `val1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1232:94 [INFO] [stdout] | [INFO] [stdout] 1232 | ... self.registers.set_flag(FlagRegister::Carry, (val1 as u16) + (val2 as u16) > 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `val2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> src/cpu.rs:1712:35 [INFO] [stdout] | [INFO] [stdout] 1712 | let val = (val << 4) | (val >> 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `val.rotate_right(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `#[warn(clippy::manual_rotate)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RGBA` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | struct RGBA(u8, u8, u8, u8); [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rgba` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ppu.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | pub fn get_pixel(&mut self, lcd_x: u8, lcd_y: u8, vram: &[u8], last_bg_index: u8, last_bg_priority: bool, lcd_control: u8, is_cgb: bool) -> Option<(Pixel, bool, u8)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | tile_number = tile_number & 0xFE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_number &= 0xFE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 250 | tile_number = tile_number | 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_number |= 0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | (address >= 0xFF51 && address <= 0xFF55) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF51..=0xFF55).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | (address >= 0xFF68 && address <= 0xFF6B) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF68..=0xFF6B).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | (address >= 0xFF40 && address <= 0xFF4F) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF40..=0xFF4F).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:585:23 [INFO] [stdout] | [INFO] [stdout] 585 | if x == 0 { [INFO] [stdout] | _______________________^ [INFO] [stdout] 586 | | addr += 4; [INFO] [stdout] 587 | | continue; [INFO] [stdout] 588 | | } else if x >= 160 + 8 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:588:36 [INFO] [stdout] | [INFO] [stdout] 588 | } else if x >= 160 + 8 { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 589 | | addr += 4; [INFO] [stdout] 590 | | continue; [INFO] [stdout] 591 | | } else if y == 0 { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:588:36 [INFO] [stdout] | [INFO] [stdout] 588 | } else if x >= 160 + 8 { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 589 | | addr += 4; [INFO] [stdout] 590 | | continue; [INFO] [stdout] 591 | | } else if y == 0 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:591:30 [INFO] [stdout] | [INFO] [stdout] 591 | } else if y == 0 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 592 | | addr += 4; [INFO] [stdout] 593 | | continue; [INFO] [stdout] 594 | | } else if y >= 144 + 16 { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:591:30 [INFO] [stdout] | [INFO] [stdout] 591 | } else if y == 0 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 592 | | addr += 4; [INFO] [stdout] 593 | | continue; [INFO] [stdout] 594 | | } else if y >= 144 + 16 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:594:37 [INFO] [stdout] | [INFO] [stdout] 594 | } else if y >= 144 + 16 { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 595 | | addr += 4; [INFO] [stdout] 596 | | continue; [INFO] [stdout] 597 | | } else if !long_sprites && y <= 8 { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:594:37 [INFO] [stdout] | [INFO] [stdout] 594 | } else if y >= 144 + 16 { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 595 | | addr += 4; [INFO] [stdout] 596 | | continue; [INFO] [stdout] 597 | | } else if !long_sprites && y <= 8 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:597:47 [INFO] [stdout] | [INFO] [stdout] 597 | } else if !long_sprites && y <= 8 { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 598 | | addr += 4; [INFO] [stdout] 599 | | continue; [INFO] [stdout] 600 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ppu.rs:637:13 [INFO] [stdout] | [INFO] [stdout] 637 | self.sprite_buffer.sort_by(|a, b| a.x().cmp(&b.x())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 637 - self.sprite_buffer.sort_by(|a, b| a.x().cmp(&b.x())); [INFO] [stdout] 637 + self.sprite_buffer.sort_by_key(|a| a.x()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ppu.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 649 - return None; [INFO] [stdout] 649 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:682:57 [INFO] [stdout] | [INFO] [stdout] 682 | LCDStatusModeFlag::HBlank => (byte & 0b11111100) | 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(byte & 0b11111100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ppu.rs:735:9 [INFO] [stdout] | [INFO] [stdout] 735 | return (byte1, byte2, attributes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 735 - return (byte1, byte2, attributes); [INFO] [stdout] 735 + (byte1, byte2, attributes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ppu.rs:695:57 [INFO] [stdout] | [INFO] [stdout] 695 | let tile_number = self.read_vram(tilemap_area + index as u16) as u16; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ppu.rs:697:83 [INFO] [stdout] | [INFO] [stdout] 697 | let attributes = BgAttributes::new(self.read_vram(tilemap_area + 0x2000 + index as u16)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:701:9 [INFO] [stdout] | [INFO] [stdout] 701 | tile_line = tile_line * 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_line *= 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/ppu.rs:707:24 [INFO] [stdout] | [INFO] [stdout] 707 | let base = (0x9000 as u16) as i16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `0x9000_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:743:9 [INFO] [stdout] | [INFO] [stdout] 743 | / if !self.cgb_mode { [INFO] [stdout] 744 | | if !self.background_priority || !self.window_enable { [INFO] [stdout] 745 | | self.last_bg_index = 0b00; [INFO] [stdout] 746 | | return None; [INFO] [stdout] 747 | | } [INFO] [stdout] 748 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 743 ~ if !self.cgb_mode [INFO] [stdout] 744 ~ && (!self.background_priority || !self.window_enable) { [INFO] [stdout] 745 | self.last_bg_index = 0b00; [INFO] [stdout] 746 | return None; [INFO] [stdout] 747 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Timer` [INFO] [stdout] --> src/timer.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Self { [INFO] [stdout] 25 | | divider: 0, [INFO] [stdout] 26 | | control: 0, [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for Timer { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/timer.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | address >= 0xFF04 && address <= 0xFF07 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF04..=0xFF07).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sound.rs:61:49 [INFO] [stdout] | [INFO] [stdout] 61 | let stream = device.build_output_stream(&config, move |data: &mut [f32], _| { [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/sound.rs:84:70 [INFO] [stdout] | [INFO] [stdout] 84 | let sample = match WAVE_DUTY_PATTERNS[duty_pattern as usize][self.duty_position as usize] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.duty_position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Sound` [INFO] [stdout] --> src/sound.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | if !env::var("SOUND_ENABLE").is_err() { [INFO] [stdout] 136 | | let host = cpal::default_host(); [INFO] [stdout] 137 | | let device = host.default_output_device().expect("no output device available"); [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 133 + impl Default for Sound { [INFO] [stdout] 134 + fn default() -> Self { [INFO] [stdout] 135 + Self::new() [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sound.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if !env::var("SOUND_ENABLE").is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("SOUND_ENABLE").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/sound.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | address >= 0xFF10 && address <= 0xFF3F [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF10..=0xFF3F).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.channel_two` after checking its variant with `is_some` [INFO] [stdout] --> src/sound.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 186 | if self.channel_two.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.channel_two` [INFO] [stdout] ... [INFO] [stdout] 189 | self.channel_two.as_mut().unwrap().cycle(duty, frequency); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rom.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | fn header_checksum(data: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn header_checksum(data: &Vec) -> bool { [INFO] [stdout] 23 + fn header_checksum(data: &[u8]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/rom.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / match load_save(rom.ram_mut(), &info_copy) { [INFO] [stdout] 80 | | Err(err) => eprintln!("Could not load save file: {}", err), [INFO] [stdout] 81 | | _ => {}, [INFO] [stdout] 82 | | }; [INFO] [stdout] | |_____^ help: try: `if let Err(err) = load_save(rom.ram_mut(), &info_copy) { eprintln!("Could not load save file: {}", err) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rom.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn save_file(ram: &Vec, info: &ROMInfo) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - pub fn save_file(ram: &Vec, info: &ROMInfo) -> std::io::Result<()> { [INFO] [stdout] 88 + pub fn save_file(ram: &[u8], info: &ROMInfo) -> std::io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/rom.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn load_save(ram: &mut Vec, info: &ROMInfo) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - pub fn load_save(ram: &mut Vec, info: &ROMInfo) -> std::io::Result<()> { [INFO] [stdout] 98 + pub fn load_save(ram: &mut [u8], info: &ROMInfo) -> std::io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/rom.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | NoMBC, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MBC` contains a capitalized acronym [INFO] [stdout] --> src/rom.rs:121:6 [INFO] [stdout] | [INFO] [stdout] 121 | enum MBC { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 221 | has_ram: match rom_type { [INFO] [stdout] | ______________________^ [INFO] [stdout] 222 | | 0x02 | 0x03 | 0x08 | 0x09 | 0x0C | 0x0D | 0x10 | 0x12 | [INFO] [stdout] 223 | | 0x13 | 0x1A | 0x1B | 0x1D | 0x1E | 0x22 | 0xFF => true, [INFO] [stdout] 224 | | _ => false, [INFO] [stdout] 225 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 221 ~ has_ram: matches!(rom_type, 0x02 | 0x03 | 0x08 | 0x09 | 0x0C | 0x0D | 0x10 | 0x12 | [INFO] [stdout] 222 ~ 0x13 | 0x1A | 0x1B | 0x1D | 0x1E | 0x22 | 0xFF), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:226:26 [INFO] [stdout] | [INFO] [stdout] 226 | has_battery: match rom_type { [INFO] [stdout] | __________________________^ [INFO] [stdout] 227 | | 0x03 | 0x06 | 0x09 | 0x0D | 0x0F | 0x10 | [INFO] [stdout] 228 | | 0x13 | 0x1B | 0x1E | 0x22 | 0xFF => true, [INFO] [stdout] 229 | | _ => false, [INFO] [stdout] 230 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 226 ~ has_battery: matches!(rom_type, 0x03 | 0x06 | 0x09 | 0x0D | 0x0F | 0x10 | [INFO] [stdout] 227 ~ 0x13 | 0x1B | 0x1E | 0x22 | 0xFF), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 231 | has_timer: match rom_type { [INFO] [stdout] | ________________________^ [INFO] [stdout] 232 | | 0x0F | 0x10 => true, [INFO] [stdout] 233 | | _ => false, [INFO] [stdout] 234 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 231 - has_timer: match rom_type { [INFO] [stdout] 232 - 0x0F | 0x10 => true, [INFO] [stdout] 233 - _ => false, [INFO] [stdout] 234 - }, [INFO] [stdout] 231 + has_timer: matches!(rom_type, 0x0F | 0x10), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:340:27 [INFO] [stdout] | [INFO] [stdout] 340 | let ram = vec![0; info.ram_size() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `info.ram_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:451:13 [INFO] [stdout] | [INFO] [stdout] 451 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 450 - }; [INFO] [stdout] 451 - return; [INFO] [stdout] 450 + }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:447:31 [INFO] [stdout] | [INFO] [stdout] 447 | self.ram_enable = match data & 0x0F { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 448 | | 0x0A => true, [INFO] [stdout] 449 | | _ => false, [INFO] [stdout] 450 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 447 - self.ram_enable = match data & 0x0F { [INFO] [stdout] 448 - 0x0A => true, [INFO] [stdout] 449 - _ => false, [INFO] [stdout] 450 - }; [INFO] [stdout] 447 + self.ram_enable = matches!(data & 0x0F, 0x0A); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:452:19 [INFO] [stdout] | [INFO] [stdout] 452 | } else if address >= 0x2000 && address <= 0x3FFF { // ROM bank number register [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..=0x3FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:454:19 [INFO] [stdout] | [INFO] [stdout] 454 | } else if address >= 0x4000 && address <= 0x5FFF { // ROM and RAM bank number register [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..=0x5FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:456:19 [INFO] [stdout] | [INFO] [stdout] 456 | } else if address >= 0x6000 && address <= 0x7FFF { // Banking mode select [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..=0x7FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | return 0xFF; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return 0xFF; [INFO] [stdout] 538 + 0xFF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:527:30 [INFO] [stdout] | [INFO] [stdout] 527 | return self.data[((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:533:39 [INFO] [stdout] | [INFO] [stdout] 533 | return match self.ram.get(address as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:595:27 [INFO] [stdout] | [INFO] [stdout] 595 | let ram = vec![0; info.ram_size() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `info.ram_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:628:30 [INFO] [stdout] | [INFO] [stdout] 628 | return self.data[((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:656:19 [INFO] [stdout] | [INFO] [stdout] 656 | } else if address >= 0x2000 && address <= 0x3FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..=0x3FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:658:19 [INFO] [stdout] | [INFO] [stdout] 658 | } else if address >= 0x4000 && address <= 0x5FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..=0x5FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:662:23 [INFO] [stdout] | [INFO] [stdout] 662 | } else if data >= 0x08 && data <= 0x0C { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x08..=0x0C).contains(&data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:666:19 [INFO] [stdout] | [INFO] [stdout] 666 | } else if address >= 0x6000 && address <= 0x7FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..=0x7FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:671:19 [INFO] [stdout] | [INFO] [stdout] 671 | } else if address >= 0xA000 && address <= 0xBFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xA000..=0xBFFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:716:27 [INFO] [stdout] | [INFO] [stdout] 716 | let ram = vec![0; info.ram_size() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `info.ram_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:750:9 [INFO] [stdout] | [INFO] [stdout] 750 | return 0xFF; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 750 - return 0xFF; [INFO] [stdout] 750 + 0xFF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:737:40 [INFO] [stdout] | [INFO] [stdout] 737 | return match self.data.get(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)) as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:756:19 [INFO] [stdout] | [INFO] [stdout] 756 | } else if address >= 0x2000 && address <= 0x2FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..=0x2FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:758:19 [INFO] [stdout] | [INFO] [stdout] 758 | } else if address >= 0x3000 && address <= 0x3FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:760:19 [INFO] [stdout] | [INFO] [stdout] 760 | } else if address >= 0x4000 && address <= 0x5FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..=0x5FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DMGRAM` [INFO] [stdout] --> src/ram.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | data: [0; 4096 * 2], [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for DMGRAM { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CGBRAM` [INFO] [stdout] --> src/ram.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / pub fn new() -> Self { [INFO] [stdout] 57 | | Self { [INFO] [stdout] 58 | | data: [0; 4096 * 8], [INFO] [stdout] 59 | | bank: 1, [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 55 + impl Default for CGBRAM { [INFO] [stdout] 56 + fn default() -> Self { [INFO] [stdout] 57 + Self::new() [INFO] [stdout] 58 + } [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Bus` [INFO] [stdout] --> src/bus.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / pub fn new() -> Self { [INFO] [stdout] 64 | | let args: Vec = std::env::args().collect(); [INFO] [stdout] 65 | | #[cfg(not(test))] [INFO] [stdout] 66 | | if args.len() < 2 { [INFO] [stdout] ... | [INFO] [stdout] 120 | | bus [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 62 + impl Default for Bus { [INFO] [stdout] 63 + fn default() -> Self { [INFO] [stdout] 64 + Self::new() [INFO] [stdout] 65 + } [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bus.rs:78:30 [INFO] [stdout] | [INFO] [stdout] 78 | let force_dmg_mode = !env::var("FORCE_DMG").is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("FORCE_DMG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bus.rs:70:34 [INFO] [stdout] | [INFO] [stdout] 70 | let rom = match load_rom(&args.get(1).unwrap_or(&"".to_string())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `args.get(1).unwrap_or(&"".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | return self.data[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self.data[address as usize]; [INFO] [stdout] 165 + self.data[address as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Interrupts` [INFO] [stdout] --> src/interrupts.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / pub fn new() -> Self { [INFO] [stdout] 56 | | Self { [INFO] [stdout] 57 | | interrupt_enable: 0, [INFO] [stdout] 58 | | interrupt_flag: 0, [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 54 + impl Default for Interrupts { [INFO] [stdout] 55 + fn default() -> Self { [INFO] [stdout] 56 + Self::new() [INFO] [stdout] 57 + } [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Joypad` [INFO] [stdout] --> src/joypad.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Self { [INFO] [stdout] 30 | | Self { [INFO] [stdout] 31 | | a: false, [INFO] [stdout] 32 | | b: false, [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for Joypad { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/joypad.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return data; [INFO] [stdout] 82 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Emulator` [INFO] [stdout] --> src/emulator.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> Self { [INFO] [stdout] 19 | | let bus = Bus::new(); [INFO] [stdout] 20 | | let cpu = match bus.cgb_mode { [INFO] [stdout] 21 | | true => CPU::new_cgb(), [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for Emulator { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/emulator.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / match save_file(self.bus.rom.ram(), self.bus.rom.info()) { [INFO] [stdout] 35 | | Err(err) => eprintln!("Could not save file: {}", err), [INFO] [stdout] 36 | | _ => {}, [INFO] [stdout] 37 | | }; [INFO] [stdout] | |_________^ help: try: `if let Err(err) = save_file(self.bus.rom.ram(), self.bus.rom.info()) { eprintln!("Could not save file: {}", err) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | !env::var("UNLOCK_FPS").is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("UNLOCK_FPS").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/render.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - *control_flow = ControlFlow::Exit; [INFO] [stdout] 107 - return; [INFO] [stdout] 106 + *control_flow = ControlFlow::Exit; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/render.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | / if pixels [INFO] [stdout] 102 | | .render() [INFO] [stdout] 103 | | .map_err(|e| error!("pixels.render() failed: {}", e)) [INFO] [stdout] 104 | | .is_err() [INFO] [stdout] ... | [INFO] [stdout] 107 | | return; [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ Event::RedrawRequested(_) [INFO] [stdout] 101 | if pixels [INFO] [stdout] ... [INFO] [stdout] 104 | .is_err() [INFO] [stdout] 105 ~ => { [INFO] [stdout] 106 | *control_flow = ControlFlow::Exit; [INFO] [stdout] 107 | return; [INFO] [stdout] 108 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Frames` [INFO] [stdout] --> src/frames.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | count: 0, [INFO] [stdout] 15 | | timer: Instant::now(), [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Frames { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `publisher`, `title`, `sgb_features`, `has_battery`, and `has_timer` are never read [INFO] [stdout] --> src/rom.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 149 | pub struct ROMInfo { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 152 | publisher: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 153 | title: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 156 | sgb_features: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 157 | has_ram: bool, [INFO] [stdout] 158 | has_battery: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 159 | has_timer: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ROMInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/rom.rs:333:8 [INFO] [stdout] | [INFO] [stdout] 332 | impl MBC1 { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 333 | fn new(data: Vec, info: ROMInfo) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/rom.rs:494:8 [INFO] [stdout] | [INFO] [stdout] 493 | impl MBC2 { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 494 | fn new(data: Vec, info: ROMInfo) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/rom.rs:588:8 [INFO] [stdout] | [INFO] [stdout] 587 | impl MBC3 { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 588 | fn new(data: Vec, info: ROMInfo) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/rom.rs:709:8 [INFO] [stdout] | [INFO] [stdout] 708 | impl MBC5 { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 709 | fn new(data: Vec, info: ROMInfo) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | assert_eq!(get_bit(0b00000001, BitIndex::I0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 116 - assert_eq!(get_bit(0b00000001, BitIndex::I0), true); [INFO] [stdout] 116 + assert!(get_bit(0b00000001, BitIndex::I0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | assert_eq!(get_bit(0b00000010, BitIndex::I1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 117 - assert_eq!(get_bit(0b00000010, BitIndex::I1), true); [INFO] [stdout] 117 + assert!(get_bit(0b00000010, BitIndex::I1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | assert_eq!(get_bit(0b00000100, BitIndex::I2), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 118 - assert_eq!(get_bit(0b00000100, BitIndex::I2), true); [INFO] [stdout] 118 + assert!(get_bit(0b00000100, BitIndex::I2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | assert_eq!(get_bit(0b00001000, BitIndex::I3), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 119 - assert_eq!(get_bit(0b00001000, BitIndex::I3), true); [INFO] [stdout] 119 + assert!(get_bit(0b00001000, BitIndex::I3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | assert_eq!(get_bit(0b00010000, BitIndex::I4), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 120 - assert_eq!(get_bit(0b00010000, BitIndex::I4), true); [INFO] [stdout] 120 + assert!(get_bit(0b00010000, BitIndex::I4)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | assert_eq!(get_bit(0b00100000, BitIndex::I5), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 121 - assert_eq!(get_bit(0b00100000, BitIndex::I5), true); [INFO] [stdout] 121 + assert!(get_bit(0b00100000, BitIndex::I5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | assert_eq!(get_bit(0b01000000, BitIndex::I6), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 122 - assert_eq!(get_bit(0b01000000, BitIndex::I6), true); [INFO] [stdout] 122 + assert!(get_bit(0b01000000, BitIndex::I6)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | assert_eq!(get_bit(0b10000000, BitIndex::I7), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 123 - assert_eq!(get_bit(0b10000000, BitIndex::I7), true); [INFO] [stdout] 123 + assert!(get_bit(0b10000000, BitIndex::I7)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | assert_eq!(get_bit(0b11111110, BitIndex::I0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 125 - assert_eq!(get_bit(0b11111110, BitIndex::I0), false); [INFO] [stdout] 125 + assert!(!get_bit(0b11111110, BitIndex::I0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | assert_eq!(get_bit(0b11111101, BitIndex::I1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 126 - assert_eq!(get_bit(0b11111101, BitIndex::I1), false); [INFO] [stdout] 126 + assert!(!get_bit(0b11111101, BitIndex::I1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | assert_eq!(get_bit(0b11111011, BitIndex::I2), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 127 - assert_eq!(get_bit(0b11111011, BitIndex::I2), false); [INFO] [stdout] 127 + assert!(!get_bit(0b11111011, BitIndex::I2)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | assert_eq!(get_bit(0b11110111, BitIndex::I3), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 128 - assert_eq!(get_bit(0b11110111, BitIndex::I3), false); [INFO] [stdout] 128 + assert!(!get_bit(0b11110111, BitIndex::I3)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | assert_eq!(get_bit(0b11101111, BitIndex::I4), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 129 - assert_eq!(get_bit(0b11101111, BitIndex::I4), false); [INFO] [stdout] 129 + assert!(!get_bit(0b11101111, BitIndex::I4)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | assert_eq!(get_bit(0b11011111, BitIndex::I5), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 130 - assert_eq!(get_bit(0b11011111, BitIndex::I5), false); [INFO] [stdout] 130 + assert!(!get_bit(0b11011111, BitIndex::I5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | assert_eq!(get_bit(0b10111111, BitIndex::I6), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 131 - assert_eq!(get_bit(0b10111111, BitIndex::I6), false); [INFO] [stdout] 131 + assert!(!get_bit(0b10111111, BitIndex::I6)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | assert_eq!(get_bit(0b01111111, BitIndex::I7), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 132 - assert_eq!(get_bit(0b01111111, BitIndex::I7), false); [INFO] [stdout] 132 + assert!(!get_bit(0b01111111, BitIndex::I7)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | assert_eq!(add_half_carry(0b10101010, 0b11111111), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 143 - assert_eq!(add_half_carry(0b10101010, 0b11111111), true); [INFO] [stdout] 143 + assert!(add_half_carry(0b10101010, 0b11111111)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | assert_eq!(add_half_carry(0b00000100, 0b00001100), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 144 - assert_eq!(add_half_carry(0b00000100, 0b00001100), true); [INFO] [stdout] 144 + assert!(add_half_carry(0b00000100, 0b00001100)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | assert_eq!(add_half_carry(0b00000100, 0b00000100), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 145 - assert_eq!(add_half_carry(0b00000100, 0b00000100), false); [INFO] [stdout] 145 + assert!(!add_half_carry(0b00000100, 0b00000100)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | assert_eq!(add_half_carry(0b00000100, 0b00001000), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 146 - assert_eq!(add_half_carry(0b00000100, 0b00001000), false); [INFO] [stdout] 146 + assert!(!add_half_carry(0b00000100, 0b00001000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | assert_eq!(add_half_carry(0b00001111, 0b00000001), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 147 - assert_eq!(add_half_carry(0b00001111, 0b00000001), true); [INFO] [stdout] 147 + assert!(add_half_carry(0b00001111, 0b00000001)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | assert_eq!(add_half_carry_16bit(0b1010101000000000, 0b1111111100000000), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 149 - assert_eq!(add_half_carry_16bit(0b1010101000000000, 0b1111111100000000), true); [INFO] [stdout] 149 + assert!(add_half_carry_16bit(0b1010101000000000, 0b1111111100000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | assert_eq!(add_half_carry_16bit(0b0000010000000000, 0b0000110000000000), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 150 - assert_eq!(add_half_carry_16bit(0b0000010000000000, 0b0000110000000000), true); [INFO] [stdout] 150 + assert!(add_half_carry_16bit(0b0000010000000000, 0b0000110000000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | assert_eq!(add_half_carry_16bit(0b0000010000000000, 0b0000010000000000), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 151 - assert_eq!(add_half_carry_16bit(0b0000010000000000, 0b0000010000000000), false); [INFO] [stdout] 151 + assert!(!add_half_carry_16bit(0b0000010000000000, 0b0000010000000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | assert_eq!(add_half_carry_16bit(0b0000010000000000, 0b0000100000000000), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 152 - assert_eq!(add_half_carry_16bit(0b0000010000000000, 0b0000100000000000), false); [INFO] [stdout] 152 + assert!(!add_half_carry_16bit(0b0000010000000000, 0b0000100000000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | assert_eq!(add_half_carry_16bit(0b0000111100000000, 0b0000000100000000), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 153 - assert_eq!(add_half_carry_16bit(0b0000111100000000, 0b0000000100000000), true); [INFO] [stdout] 153 + assert!(add_half_carry_16bit(0b0000111100000000, 0b0000000100000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | assert_eq!(sub_half_carry(0b00010000, 0b00001000), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 157 - assert_eq!(sub_half_carry(0b00010000, 0b00001000), true); [INFO] [stdout] 157 + assert!(sub_half_carry(0b00010000, 0b00001000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | assert_eq!(sub_half_carry(0b00000000, 0b00000001), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 158 - assert_eq!(sub_half_carry(0b00000000, 0b00000001), true); [INFO] [stdout] 158 + assert!(sub_half_carry(0b00000000, 0b00000001)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | assert_eq!(sub_half_carry(0b00001000, 0b00001000), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 159 - assert_eq!(sub_half_carry(0b00001000, 0b00001000), false); [INFO] [stdout] 159 + assert!(!sub_half_carry(0b00001000, 0b00001000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | assert_eq!(sub_half_carry_16bit(0b0001000000000000, 0b0000100000000000), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 161 - assert_eq!(sub_half_carry_16bit(0b0001000000000000, 0b0000100000000000), true); [INFO] [stdout] 161 + assert!(sub_half_carry_16bit(0b0001000000000000, 0b0000100000000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | assert_eq!(sub_half_carry_16bit(0b0000000000000000, 0b0000000100000000), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 162 - assert_eq!(sub_half_carry_16bit(0b0000000000000000, 0b0000000100000000), true); [INFO] [stdout] 162 + assert!(sub_half_carry_16bit(0b0000000000000000, 0b0000000100000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/utils.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | assert_eq!(sub_half_carry_16bit(0b0000100000000000, 0b0000100000000000), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 163 - assert_eq!(sub_half_carry_16bit(0b0000100000000000, 0b0000100000000000), false); [INFO] [stdout] 163 + assert!(!sub_half_carry_16bit(0b0000100000000000, 0b0000100000000000)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Registers` [INFO] [stdout] --> src/cpu.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / pub fn new() -> Self { [INFO] [stdout] 79 | | Self { [INFO] [stdout] 80 | | a: 0x01, [INFO] [stdout] 81 | | f: 0xB0, // The first 4 lower bits are always set to 0 [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 77 + impl Default for Registers { [INFO] [stdout] 78 + fn default() -> Self { [INFO] [stdout] 79 + Self::new() [INFO] [stdout] 80 + } [INFO] [stdout] 81 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu.rs:841:5 [INFO] [stdout] | [INFO] [stdout] 841 | / pub fn new() -> Self { [INFO] [stdout] 842 | | Self { [INFO] [stdout] 843 | | registers: Registers::new(), [INFO] [stdout] 844 | | cycles: Cycles(0.0), [INFO] [stdout] ... | [INFO] [stdout] 854 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 840 + impl Default for CPU { [INFO] [stdout] 841 + fn default() -> Self { [INFO] [stdout] 842 + Self::new() [INFO] [stdout] 843 + } [INFO] [stdout] 844 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:850:26 [INFO] [stdout] | [INFO] [stdout] 850 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:850:59 [INFO] [stdout] | [INFO] [stdout] 850 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOGS").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:865:26 [INFO] [stdout] | [INFO] [stdout] 865 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:865:59 [INFO] [stdout] | [INFO] [stdout] 865 | enable_logs: !env::var("CPU_LOG").is_err() || !env::var("CPU_LOGS").is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("CPU_LOGS").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/cpu.rs:1060:56 [INFO] [stdout] | [INFO] [stdout] 1060 | OpcodeParameter::I8(val) => (true, val as i8), [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/cpu.rs:1061:106 [INFO] [stdout] | [INFO] [stdout] 1061 | OpcodeParameter::FlagRegisterReset_I8(flag, val) => (!self.registers.get_flag(flag), val as i8), [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`) [INFO] [stdout] --> src/cpu.rs:1062:103 [INFO] [stdout] | [INFO] [stdout] 1062 | OpcodeParameter::FlagRegisterSet_I8(flag, val) => (self.registers.get_flag(flag), val as i8), [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1201:39 [INFO] [stdout] | [INFO] [stdout] 1201 | ... let res = (self.registers.get(reg1) as u16) + (self.registers.get(reg2) as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.registers.get(reg1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1201:75 [INFO] [stdout] | [INFO] [stdout] 1201 | ... let res = (self.registers.get(reg1) as u16) + (self.registers.get(reg2) as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.registers.get(reg2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1232:78 [INFO] [stdout] | [INFO] [stdout] 1232 | ... self.registers.set_flag(FlagRegister::Carry, (val1 as u16) + (val2 as u16) > 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `val1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/cpu.rs:1232:94 [INFO] [stdout] | [INFO] [stdout] 1232 | ... self.registers.set_flag(FlagRegister::Carry, (val1 as u16) + (val2 as u16) > 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `val2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: there is no need to manually implement bit rotation [INFO] [stdout] --> src/cpu.rs:1712:35 [INFO] [stdout] | [INFO] [stdout] 1712 | let val = (val << 4) | (val >> 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: this expression can be rewritten as: `val.rotate_right(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_rotate [INFO] [stdout] = note: `#[warn(clippy::manual_rotate)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:1973:9 [INFO] [stdout] | [INFO] [stdout] 1973 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1973 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 1973 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:1974:9 [INFO] [stdout] | [INFO] [stdout] 1974 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1974 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 1974 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:1975:9 [INFO] [stdout] | [INFO] [stdout] 1975 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1975 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 1975 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:1976:9 [INFO] [stdout] | [INFO] [stdout] 1976 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1976 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 1976 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2127:9 [INFO] [stdout] | [INFO] [stdout] 2127 | assert_eq!(cpu.ime, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2127 - assert_eq!(cpu.ime, false); [INFO] [stdout] 2127 + assert!(!cpu.ime); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2136:9 [INFO] [stdout] | [INFO] [stdout] 2136 | assert_eq!(cpu.ime, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2136 - assert_eq!(cpu.ime, true); [INFO] [stdout] 2136 + assert!(cpu.ime); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2148:9 [INFO] [stdout] | [INFO] [stdout] 2148 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2148 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2148 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2156:9 [INFO] [stdout] | [INFO] [stdout] 2156 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2156 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2156 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2167:9 [INFO] [stdout] | [INFO] [stdout] 2167 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2167 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2167 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2168:9 [INFO] [stdout] | [INFO] [stdout] 2168 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2168 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2168 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2169:9 [INFO] [stdout] | [INFO] [stdout] 2169 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2169 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2169 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2170:9 [INFO] [stdout] | [INFO] [stdout] 2170 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2170 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2170 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2182:9 [INFO] [stdout] | [INFO] [stdout] 2182 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2182 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2182 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2190:9 [INFO] [stdout] | [INFO] [stdout] 2190 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2190 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2190 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2343:9 [INFO] [stdout] | [INFO] [stdout] 2343 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2343 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2343 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2344:9 [INFO] [stdout] | [INFO] [stdout] 2344 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2344 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2344 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2345:9 [INFO] [stdout] | [INFO] [stdout] 2345 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2345 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2345 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2346:9 [INFO] [stdout] | [INFO] [stdout] 2346 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2346 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2346 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2354:9 [INFO] [stdout] | [INFO] [stdout] 2354 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2354 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2354 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2355:9 [INFO] [stdout] | [INFO] [stdout] 2355 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2355 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2355 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2356:9 [INFO] [stdout] | [INFO] [stdout] 2356 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2356 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2356 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2357:9 [INFO] [stdout] | [INFO] [stdout] 2357 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2357 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2357 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2368:9 [INFO] [stdout] | [INFO] [stdout] 2368 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2368 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2368 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2369:9 [INFO] [stdout] | [INFO] [stdout] 2369 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2369 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2369 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2370:9 [INFO] [stdout] | [INFO] [stdout] 2370 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2370 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2370 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2371:9 [INFO] [stdout] | [INFO] [stdout] 2371 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2371 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2371 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2382:9 [INFO] [stdout] | [INFO] [stdout] 2382 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2382 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2382 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2383:9 [INFO] [stdout] | [INFO] [stdout] 2383 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2383 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2383 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2384:9 [INFO] [stdout] | [INFO] [stdout] 2384 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2384 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2384 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2385:9 [INFO] [stdout] | [INFO] [stdout] 2385 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2385 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2385 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2392:9 [INFO] [stdout] | [INFO] [stdout] 2392 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2392 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2392 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2393:9 [INFO] [stdout] | [INFO] [stdout] 2393 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2393 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2393 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2394:9 [INFO] [stdout] | [INFO] [stdout] 2394 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2394 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2394 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2395:9 [INFO] [stdout] | [INFO] [stdout] 2395 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2395 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2395 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2402:9 [INFO] [stdout] | [INFO] [stdout] 2402 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2402 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2402 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2403:9 [INFO] [stdout] | [INFO] [stdout] 2403 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2403 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2403 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2404:9 [INFO] [stdout] | [INFO] [stdout] 2404 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2404 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2404 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2405:9 [INFO] [stdout] | [INFO] [stdout] 2405 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2405 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2405 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2417:9 [INFO] [stdout] | [INFO] [stdout] 2417 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2417 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2417 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2418:9 [INFO] [stdout] | [INFO] [stdout] 2418 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2418 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2418 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2419:9 [INFO] [stdout] | [INFO] [stdout] 2419 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2419 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2419 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2420:9 [INFO] [stdout] | [INFO] [stdout] 2420 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2420 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2420 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2428:9 [INFO] [stdout] | [INFO] [stdout] 2428 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2428 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2428 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2429:9 [INFO] [stdout] | [INFO] [stdout] 2429 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2429 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2429 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2430:9 [INFO] [stdout] | [INFO] [stdout] 2430 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2430 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2430 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2431:9 [INFO] [stdout] | [INFO] [stdout] 2431 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2431 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2431 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2442:9 [INFO] [stdout] | [INFO] [stdout] 2442 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2442 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2442 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2443:9 [INFO] [stdout] | [INFO] [stdout] 2443 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2443 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2443 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2444:9 [INFO] [stdout] | [INFO] [stdout] 2444 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2444 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2444 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2445:9 [INFO] [stdout] | [INFO] [stdout] 2445 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2445 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2445 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2456:9 [INFO] [stdout] | [INFO] [stdout] 2456 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2456 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2456 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2457:9 [INFO] [stdout] | [INFO] [stdout] 2457 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2457 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2457 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2458:9 [INFO] [stdout] | [INFO] [stdout] 2458 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2458 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2458 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2459:9 [INFO] [stdout] | [INFO] [stdout] 2459 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2459 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2459 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2466:9 [INFO] [stdout] | [INFO] [stdout] 2466 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2466 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2466 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2467:9 [INFO] [stdout] | [INFO] [stdout] 2467 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2467 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2467 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2468:9 [INFO] [stdout] | [INFO] [stdout] 2468 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2468 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2468 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2469:9 [INFO] [stdout] | [INFO] [stdout] 2469 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2469 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2469 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2476:9 [INFO] [stdout] | [INFO] [stdout] 2476 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2476 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2476 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2477:9 [INFO] [stdout] | [INFO] [stdout] 2477 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2477 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2477 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2478:9 [INFO] [stdout] | [INFO] [stdout] 2478 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2478 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2478 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2479:9 [INFO] [stdout] | [INFO] [stdout] 2479 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2479 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2479 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2491:9 [INFO] [stdout] | [INFO] [stdout] 2491 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2491 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2491 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2492:9 [INFO] [stdout] | [INFO] [stdout] 2492 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2492 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2492 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2493:9 [INFO] [stdout] | [INFO] [stdout] 2493 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2493 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2493 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2494:9 [INFO] [stdout] | [INFO] [stdout] 2494 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2494 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2494 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2502:9 [INFO] [stdout] | [INFO] [stdout] 2502 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2502 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2502 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2503:9 [INFO] [stdout] | [INFO] [stdout] 2503 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2503 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2503 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2504:9 [INFO] [stdout] | [INFO] [stdout] 2504 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2504 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2504 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2505:9 [INFO] [stdout] | [INFO] [stdout] 2505 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2505 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2505 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2516:9 [INFO] [stdout] | [INFO] [stdout] 2516 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2516 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2516 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2517:9 [INFO] [stdout] | [INFO] [stdout] 2517 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2517 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2517 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2518:9 [INFO] [stdout] | [INFO] [stdout] 2518 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2518 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2518 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2519:9 [INFO] [stdout] | [INFO] [stdout] 2519 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2519 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2519 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2530:9 [INFO] [stdout] | [INFO] [stdout] 2530 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2530 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2530 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2531:9 [INFO] [stdout] | [INFO] [stdout] 2531 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2531 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2531 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2532:9 [INFO] [stdout] | [INFO] [stdout] 2532 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2532 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2532 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2533:9 [INFO] [stdout] | [INFO] [stdout] 2533 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2533 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2533 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2540:9 [INFO] [stdout] | [INFO] [stdout] 2540 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2540 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2540 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2541:9 [INFO] [stdout] | [INFO] [stdout] 2541 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2541 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2541 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2542:9 [INFO] [stdout] | [INFO] [stdout] 2542 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2542 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2542 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2543:9 [INFO] [stdout] | [INFO] [stdout] 2543 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2543 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2543 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2550:9 [INFO] [stdout] | [INFO] [stdout] 2550 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2550 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2550 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2551:9 [INFO] [stdout] | [INFO] [stdout] 2551 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2551 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2551 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2552:9 [INFO] [stdout] | [INFO] [stdout] 2552 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2552 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2552 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2553:9 [INFO] [stdout] | [INFO] [stdout] 2553 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2553 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2553 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2563:9 [INFO] [stdout] | [INFO] [stdout] 2563 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2563 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2563 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2564:9 [INFO] [stdout] | [INFO] [stdout] 2564 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2564 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2564 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2565:9 [INFO] [stdout] | [INFO] [stdout] 2565 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2565 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2565 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2566:9 [INFO] [stdout] | [INFO] [stdout] 2566 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2566 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2566 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2572:9 [INFO] [stdout] | [INFO] [stdout] 2572 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2572 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2572 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2573:9 [INFO] [stdout] | [INFO] [stdout] 2573 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2573 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2573 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2574:9 [INFO] [stdout] | [INFO] [stdout] 2574 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2574 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2574 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2575:9 [INFO] [stdout] | [INFO] [stdout] 2575 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2575 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2575 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2581:9 [INFO] [stdout] | [INFO] [stdout] 2581 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2581 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2581 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2582:9 [INFO] [stdout] | [INFO] [stdout] 2582 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2582 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2582 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2583:9 [INFO] [stdout] | [INFO] [stdout] 2583 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2583 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2583 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2584:9 [INFO] [stdout] | [INFO] [stdout] 2584 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2584 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2584 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2591:9 [INFO] [stdout] | [INFO] [stdout] 2591 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2591 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2591 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2592:9 [INFO] [stdout] | [INFO] [stdout] 2592 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2592 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2592 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2593:9 [INFO] [stdout] | [INFO] [stdout] 2593 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2593 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2593 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2594:9 [INFO] [stdout] | [INFO] [stdout] 2594 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2594 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2594 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2601:9 [INFO] [stdout] | [INFO] [stdout] 2601 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2601 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2601 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2602:9 [INFO] [stdout] | [INFO] [stdout] 2602 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2602 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2602 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2603:9 [INFO] [stdout] | [INFO] [stdout] 2603 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2603 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2603 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2604:9 [INFO] [stdout] | [INFO] [stdout] 2604 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2604 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2604 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2611:9 [INFO] [stdout] | [INFO] [stdout] 2611 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2611 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2611 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2612:9 [INFO] [stdout] | [INFO] [stdout] 2612 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2612 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2612 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2613:9 [INFO] [stdout] | [INFO] [stdout] 2613 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2613 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2613 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2614:9 [INFO] [stdout] | [INFO] [stdout] 2614 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2614 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2614 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2624:9 [INFO] [stdout] | [INFO] [stdout] 2624 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2624 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2624 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2625:9 [INFO] [stdout] | [INFO] [stdout] 2625 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2625 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2625 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2626:9 [INFO] [stdout] | [INFO] [stdout] 2626 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2626 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2626 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2627:9 [INFO] [stdout] | [INFO] [stdout] 2627 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2627 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2627 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2637:9 [INFO] [stdout] | [INFO] [stdout] 2637 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2637 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2637 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2638:9 [INFO] [stdout] | [INFO] [stdout] 2638 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2638 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2638 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2639:9 [INFO] [stdout] | [INFO] [stdout] 2639 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2639 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2639 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2640:9 [INFO] [stdout] | [INFO] [stdout] 2640 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2640 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2640 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2650:9 [INFO] [stdout] | [INFO] [stdout] 2650 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2650 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2650 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2651:9 [INFO] [stdout] | [INFO] [stdout] 2651 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2651 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2651 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2652:9 [INFO] [stdout] | [INFO] [stdout] 2652 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2652 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2652 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2653:9 [INFO] [stdout] | [INFO] [stdout] 2653 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2653 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2653 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2666:9 [INFO] [stdout] | [INFO] [stdout] 2666 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2666 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2666 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2667:9 [INFO] [stdout] | [INFO] [stdout] 2667 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2667 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2667 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2668:9 [INFO] [stdout] | [INFO] [stdout] 2668 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2668 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2668 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2669:9 [INFO] [stdout] | [INFO] [stdout] 2669 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2669 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2669 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2677:9 [INFO] [stdout] | [INFO] [stdout] 2677 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2677 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2677 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2678:9 [INFO] [stdout] | [INFO] [stdout] 2678 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2678 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2678 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2679:9 [INFO] [stdout] | [INFO] [stdout] 2679 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2679 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2679 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2680:9 [INFO] [stdout] | [INFO] [stdout] 2680 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2680 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2680 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2692:9 [INFO] [stdout] | [INFO] [stdout] 2692 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2692 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2692 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2693:9 [INFO] [stdout] | [INFO] [stdout] 2693 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2693 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2693 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2694:9 [INFO] [stdout] | [INFO] [stdout] 2694 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2694 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2694 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2695:9 [INFO] [stdout] | [INFO] [stdout] 2695 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2695 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2695 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i8` is unnecessary [INFO] [stdout] --> src/cpu.rs:2724:72 [INFO] [stdout] | [INFO] [stdout] 2724 | cpu.exec(Opcode::ADD(OpcodeParameter::Register_I8(Register::B, -40 as i8)), &mut bus); [INFO] [stdout] | ^^^^^^^^^ help: try: `-40_i8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2741:9 [INFO] [stdout] | [INFO] [stdout] 2741 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2741 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2741 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2742:9 [INFO] [stdout] | [INFO] [stdout] 2742 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2742 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2742 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2743:9 [INFO] [stdout] | [INFO] [stdout] 2743 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2743 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2743 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2744:9 [INFO] [stdout] | [INFO] [stdout] 2744 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2744 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2744 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2756:9 [INFO] [stdout] | [INFO] [stdout] 2756 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2756 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2756 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2757:9 [INFO] [stdout] | [INFO] [stdout] 2757 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2757 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2757 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2758:9 [INFO] [stdout] | [INFO] [stdout] 2758 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2758 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2758 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2759:9 [INFO] [stdout] | [INFO] [stdout] 2759 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2759 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2759 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2770:9 [INFO] [stdout] | [INFO] [stdout] 2770 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2770 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2770 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2771:9 [INFO] [stdout] | [INFO] [stdout] 2771 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2771 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2771 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2772:9 [INFO] [stdout] | [INFO] [stdout] 2772 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2772 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2772 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2773:9 [INFO] [stdout] | [INFO] [stdout] 2773 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2773 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2773 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2784:9 [INFO] [stdout] | [INFO] [stdout] 2784 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2784 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2784 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2785:9 [INFO] [stdout] | [INFO] [stdout] 2785 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2785 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2785 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2786:9 [INFO] [stdout] | [INFO] [stdout] 2786 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2786 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2786 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2787:9 [INFO] [stdout] | [INFO] [stdout] 2787 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2787 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2787 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2798:9 [INFO] [stdout] | [INFO] [stdout] 2798 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2798 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2798 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2799:9 [INFO] [stdout] | [INFO] [stdout] 2799 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2799 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2799 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2800:9 [INFO] [stdout] | [INFO] [stdout] 2800 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2800 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2800 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2801:9 [INFO] [stdout] | [INFO] [stdout] 2801 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2801 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2801 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:2810:73 [INFO] [stdout] | [INFO] [stdout] 2810 | cpu.exec(Opcode::ADD(OpcodeParameter::Register_I8(Register::SP, (0xFF as u8) as i8)), &mut bus); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `0xFF_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2812:9 [INFO] [stdout] | [INFO] [stdout] 2812 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2812 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2812 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2813:9 [INFO] [stdout] | [INFO] [stdout] 2813 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2813 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2813 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2814:9 [INFO] [stdout] | [INFO] [stdout] 2814 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2814 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2814 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2815:9 [INFO] [stdout] | [INFO] [stdout] 2815 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2815 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2815 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:2824:73 [INFO] [stdout] | [INFO] [stdout] 2824 | cpu.exec(Opcode::ADD(OpcodeParameter::Register_I8(Register::SP, (0xFF as u8) as i8)), &mut bus); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `0xFF_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2826:9 [INFO] [stdout] | [INFO] [stdout] 2826 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2826 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2826 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2827:9 [INFO] [stdout] | [INFO] [stdout] 2827 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2827 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2827 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2828:9 [INFO] [stdout] | [INFO] [stdout] 2828 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2828 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2828 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2829:9 [INFO] [stdout] | [INFO] [stdout] 2829 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2829 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2829 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2836:9 [INFO] [stdout] | [INFO] [stdout] 2836 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2836 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2836 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2844:9 [INFO] [stdout] | [INFO] [stdout] 2844 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2844 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2844 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2856:9 [INFO] [stdout] | [INFO] [stdout] 2856 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2856 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2856 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2857:9 [INFO] [stdout] | [INFO] [stdout] 2857 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2857 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2857 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2858:9 [INFO] [stdout] | [INFO] [stdout] 2858 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2858 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2858 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2859:9 [INFO] [stdout] | [INFO] [stdout] 2859 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2859 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2859 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2870:9 [INFO] [stdout] | [INFO] [stdout] 2870 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2870 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2870 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2871:9 [INFO] [stdout] | [INFO] [stdout] 2871 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2871 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2871 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2872:9 [INFO] [stdout] | [INFO] [stdout] 2872 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2872 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2872 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2873:9 [INFO] [stdout] | [INFO] [stdout] 2873 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2873 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2873 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2885:9 [INFO] [stdout] | [INFO] [stdout] 2885 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2885 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2885 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2886:9 [INFO] [stdout] | [INFO] [stdout] 2886 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2886 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2886 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2887:9 [INFO] [stdout] | [INFO] [stdout] 2887 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2887 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2887 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2888:9 [INFO] [stdout] | [INFO] [stdout] 2888 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2888 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2888 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2903:9 [INFO] [stdout] | [INFO] [stdout] 2903 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2903 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2903 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2904:9 [INFO] [stdout] | [INFO] [stdout] 2904 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2904 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2904 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2905:9 [INFO] [stdout] | [INFO] [stdout] 2905 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2905 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2905 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2906:9 [INFO] [stdout] | [INFO] [stdout] 2906 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2906 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2906 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2917:9 [INFO] [stdout] | [INFO] [stdout] 2917 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2917 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2917 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2918:9 [INFO] [stdout] | [INFO] [stdout] 2918 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2918 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2918 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2919:9 [INFO] [stdout] | [INFO] [stdout] 2919 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2919 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2919 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2920:9 [INFO] [stdout] | [INFO] [stdout] 2920 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2920 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2920 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2931:9 [INFO] [stdout] | [INFO] [stdout] 2931 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2931 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2931 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2932:9 [INFO] [stdout] | [INFO] [stdout] 2932 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2932 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 2932 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2933:9 [INFO] [stdout] | [INFO] [stdout] 2933 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2933 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2933 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2934:9 [INFO] [stdout] | [INFO] [stdout] 2934 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2934 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2934 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2949:9 [INFO] [stdout] | [INFO] [stdout] 2949 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2949 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2949 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2950:9 [INFO] [stdout] | [INFO] [stdout] 2950 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2950 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2950 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2951:9 [INFO] [stdout] | [INFO] [stdout] 2951 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2951 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2951 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2952:9 [INFO] [stdout] | [INFO] [stdout] 2952 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2952 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2952 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2965:9 [INFO] [stdout] | [INFO] [stdout] 2965 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2965 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2965 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2966:9 [INFO] [stdout] | [INFO] [stdout] 2966 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2966 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2966 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2967:9 [INFO] [stdout] | [INFO] [stdout] 2967 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2967 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 2967 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2968:9 [INFO] [stdout] | [INFO] [stdout] 2968 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2968 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 2968 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2976:9 [INFO] [stdout] | [INFO] [stdout] 2976 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2976 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 2976 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2977:9 [INFO] [stdout] | [INFO] [stdout] 2977 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2977 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2977 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2978:9 [INFO] [stdout] | [INFO] [stdout] 2978 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2978 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 2978 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2979:9 [INFO] [stdout] | [INFO] [stdout] 2979 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2979 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 2979 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2989:9 [INFO] [stdout] | [INFO] [stdout] 2989 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2989 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2989 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2990:9 [INFO] [stdout] | [INFO] [stdout] 2990 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2990 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2990 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2997:9 [INFO] [stdout] | [INFO] [stdout] 2997 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2997 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 2997 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:2998:9 [INFO] [stdout] | [INFO] [stdout] 2998 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 2998 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 2998 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3009:9 [INFO] [stdout] | [INFO] [stdout] 3009 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3009 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3009 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3010:9 [INFO] [stdout] | [INFO] [stdout] 3010 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3010 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3010 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3011:9 [INFO] [stdout] | [INFO] [stdout] 3011 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3011 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3011 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3016:9 [INFO] [stdout] | [INFO] [stdout] 3016 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3016 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3016 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3017:9 [INFO] [stdout] | [INFO] [stdout] 3017 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3017 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3017 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3018:9 [INFO] [stdout] | [INFO] [stdout] 3018 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3018 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3018 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3025:9 [INFO] [stdout] | [INFO] [stdout] 3025 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3025 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3025 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3026:9 [INFO] [stdout] | [INFO] [stdout] 3026 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3026 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3026 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3027:9 [INFO] [stdout] | [INFO] [stdout] 3027 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3027 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3027 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3033:9 [INFO] [stdout] | [INFO] [stdout] 3033 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3033 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3033 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3034:9 [INFO] [stdout] | [INFO] [stdout] 3034 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3034 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3034 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3035:9 [INFO] [stdout] | [INFO] [stdout] 3035 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3035 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3035 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3046:9 [INFO] [stdout] | [INFO] [stdout] 3046 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3046 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3046 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3047:9 [INFO] [stdout] | [INFO] [stdout] 3047 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3047 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 3047 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3048:9 [INFO] [stdout] | [INFO] [stdout] 3048 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3048 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3048 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3054:9 [INFO] [stdout] | [INFO] [stdout] 3054 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3054 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3054 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3055:9 [INFO] [stdout] | [INFO] [stdout] 3055 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3055 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 3055 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3056:9 [INFO] [stdout] | [INFO] [stdout] 3056 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3056 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3056 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3064:9 [INFO] [stdout] | [INFO] [stdout] 3064 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3064 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3064 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3065:9 [INFO] [stdout] | [INFO] [stdout] 3065 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3065 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 3065 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3066:9 [INFO] [stdout] | [INFO] [stdout] 3066 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3066 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3066 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3072:9 [INFO] [stdout] | [INFO] [stdout] 3072 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3072 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3072 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3073:9 [INFO] [stdout] | [INFO] [stdout] 3073 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3073 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 3073 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3074:9 [INFO] [stdout] | [INFO] [stdout] 3074 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3074 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3074 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3086:9 [INFO] [stdout] | [INFO] [stdout] 3086 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3086 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3086 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3087:9 [INFO] [stdout] | [INFO] [stdout] 3087 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3087 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3087 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3088:9 [INFO] [stdout] | [INFO] [stdout] 3088 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3088 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3088 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3089:9 [INFO] [stdout] | [INFO] [stdout] 3089 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3089 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3089 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3097:9 [INFO] [stdout] | [INFO] [stdout] 3097 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3097 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3097 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3098:9 [INFO] [stdout] | [INFO] [stdout] 3098 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3098 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3098 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3099:9 [INFO] [stdout] | [INFO] [stdout] 3099 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3099 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3099 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3100:9 [INFO] [stdout] | [INFO] [stdout] 3100 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3100 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3100 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3112:9 [INFO] [stdout] | [INFO] [stdout] 3112 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3112 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3112 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3113:9 [INFO] [stdout] | [INFO] [stdout] 3113 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3113 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3113 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3114:9 [INFO] [stdout] | [INFO] [stdout] 3114 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3114 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3114 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3115:9 [INFO] [stdout] | [INFO] [stdout] 3115 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3115 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3115 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3123:9 [INFO] [stdout] | [INFO] [stdout] 3123 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3123 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3123 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3124:9 [INFO] [stdout] | [INFO] [stdout] 3124 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3124 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3124 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3125:9 [INFO] [stdout] | [INFO] [stdout] 3125 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3125 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3125 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3126:9 [INFO] [stdout] | [INFO] [stdout] 3126 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3126 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3126 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3137:9 [INFO] [stdout] | [INFO] [stdout] 3137 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3137 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3137 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3138:9 [INFO] [stdout] | [INFO] [stdout] 3138 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3138 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3138 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3139:9 [INFO] [stdout] | [INFO] [stdout] 3139 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3139 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3139 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3140:9 [INFO] [stdout] | [INFO] [stdout] 3140 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3140 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3140 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3146:9 [INFO] [stdout] | [INFO] [stdout] 3146 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3146 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3146 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3147:9 [INFO] [stdout] | [INFO] [stdout] 3147 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3147 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3147 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3148:9 [INFO] [stdout] | [INFO] [stdout] 3148 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3148 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3148 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3149:9 [INFO] [stdout] | [INFO] [stdout] 3149 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3149 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3149 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3155:9 [INFO] [stdout] | [INFO] [stdout] 3155 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3155 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3155 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3156:9 [INFO] [stdout] | [INFO] [stdout] 3156 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3156 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3156 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3157:9 [INFO] [stdout] | [INFO] [stdout] 3157 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3157 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3157 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3158:9 [INFO] [stdout] | [INFO] [stdout] 3158 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3158 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3158 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3166:9 [INFO] [stdout] | [INFO] [stdout] 3166 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3166 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3166 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3167:9 [INFO] [stdout] | [INFO] [stdout] 3167 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3167 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3167 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3168:9 [INFO] [stdout] | [INFO] [stdout] 3168 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3168 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3168 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3169:9 [INFO] [stdout] | [INFO] [stdout] 3169 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3169 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3169 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3180:9 [INFO] [stdout] | [INFO] [stdout] 3180 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3180 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3180 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3181:9 [INFO] [stdout] | [INFO] [stdout] 3181 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3181 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3181 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3182:9 [INFO] [stdout] | [INFO] [stdout] 3182 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3182 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3182 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3183:9 [INFO] [stdout] | [INFO] [stdout] 3183 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3183 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3183 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3189:9 [INFO] [stdout] | [INFO] [stdout] 3189 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3189 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3189 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3190:9 [INFO] [stdout] | [INFO] [stdout] 3190 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3190 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3190 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3191:9 [INFO] [stdout] | [INFO] [stdout] 3191 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3191 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3191 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3192:9 [INFO] [stdout] | [INFO] [stdout] 3192 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3192 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3192 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3198:9 [INFO] [stdout] | [INFO] [stdout] 3198 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3198 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3198 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3199:9 [INFO] [stdout] | [INFO] [stdout] 3199 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3199 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3199 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3200:9 [INFO] [stdout] | [INFO] [stdout] 3200 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3200 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3200 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3201:9 [INFO] [stdout] | [INFO] [stdout] 3201 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3201 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3201 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3209:9 [INFO] [stdout] | [INFO] [stdout] 3209 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3209 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3209 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3210:9 [INFO] [stdout] | [INFO] [stdout] 3210 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3210 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3210 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3211:9 [INFO] [stdout] | [INFO] [stdout] 3211 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3211 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3211 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3212:9 [INFO] [stdout] | [INFO] [stdout] 3212 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3212 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3212 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3224:9 [INFO] [stdout] | [INFO] [stdout] 3224 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3224 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3224 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3225:9 [INFO] [stdout] | [INFO] [stdout] 3225 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3225 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3225 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3226:9 [INFO] [stdout] | [INFO] [stdout] 3226 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3226 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3226 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3227:9 [INFO] [stdout] | [INFO] [stdout] 3227 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3227 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3227 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3235:9 [INFO] [stdout] | [INFO] [stdout] 3235 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3235 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3235 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3236:9 [INFO] [stdout] | [INFO] [stdout] 3236 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3236 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3236 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3237:9 [INFO] [stdout] | [INFO] [stdout] 3237 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3237 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3237 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3238:9 [INFO] [stdout] | [INFO] [stdout] 3238 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3238 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3238 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3246:9 [INFO] [stdout] | [INFO] [stdout] 3246 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3246 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3246 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3247:9 [INFO] [stdout] | [INFO] [stdout] 3247 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3247 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3247 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3248:9 [INFO] [stdout] | [INFO] [stdout] 3248 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3248 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3248 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3249:9 [INFO] [stdout] | [INFO] [stdout] 3249 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3249 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3249 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3259:9 [INFO] [stdout] | [INFO] [stdout] 3259 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3259 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3259 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3260:9 [INFO] [stdout] | [INFO] [stdout] 3260 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3260 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3260 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3261:9 [INFO] [stdout] | [INFO] [stdout] 3261 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3261 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3261 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3262:9 [INFO] [stdout] | [INFO] [stdout] 3262 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3262 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3262 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3274:9 [INFO] [stdout] | [INFO] [stdout] 3274 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3274 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3274 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3275:9 [INFO] [stdout] | [INFO] [stdout] 3275 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3275 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3275 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3276:9 [INFO] [stdout] | [INFO] [stdout] 3276 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3276 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3276 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3277:9 [INFO] [stdout] | [INFO] [stdout] 3277 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3277 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3277 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3285:9 [INFO] [stdout] | [INFO] [stdout] 3285 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3285 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3285 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3286:9 [INFO] [stdout] | [INFO] [stdout] 3286 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3286 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3286 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3287:9 [INFO] [stdout] | [INFO] [stdout] 3287 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3287 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3287 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3288:9 [INFO] [stdout] | [INFO] [stdout] 3288 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3288 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3288 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3296:9 [INFO] [stdout] | [INFO] [stdout] 3296 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3296 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3296 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3297:9 [INFO] [stdout] | [INFO] [stdout] 3297 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3297 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3297 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3298:9 [INFO] [stdout] | [INFO] [stdout] 3298 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3298 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3298 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3299:9 [INFO] [stdout] | [INFO] [stdout] 3299 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3299 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3299 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3309:9 [INFO] [stdout] | [INFO] [stdout] 3309 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3309 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3309 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3310:9 [INFO] [stdout] | [INFO] [stdout] 3310 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3310 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3310 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3311:9 [INFO] [stdout] | [INFO] [stdout] 3311 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3311 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3311 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3312:9 [INFO] [stdout] | [INFO] [stdout] 3312 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3312 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3312 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3327:9 [INFO] [stdout] | [INFO] [stdout] 3327 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3327 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3327 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3328:9 [INFO] [stdout] | [INFO] [stdout] 3328 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3328 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3328 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3329:9 [INFO] [stdout] | [INFO] [stdout] 3329 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3329 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3329 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3330:9 [INFO] [stdout] | [INFO] [stdout] 3330 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3330 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3330 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3345:9 [INFO] [stdout] | [INFO] [stdout] 3345 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3345 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3345 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3346:9 [INFO] [stdout] | [INFO] [stdout] 3346 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3346 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3346 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3347:9 [INFO] [stdout] | [INFO] [stdout] 3347 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3347 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3347 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3348:9 [INFO] [stdout] | [INFO] [stdout] 3348 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3348 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3348 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3359:9 [INFO] [stdout] | [INFO] [stdout] 3359 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3359 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3359 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3360:9 [INFO] [stdout] | [INFO] [stdout] 3360 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3360 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3360 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3361:9 [INFO] [stdout] | [INFO] [stdout] 3361 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3361 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3361 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3362:9 [INFO] [stdout] | [INFO] [stdout] 3362 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3362 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3362 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3370:9 [INFO] [stdout] | [INFO] [stdout] 3370 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3370 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3370 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3371:9 [INFO] [stdout] | [INFO] [stdout] 3371 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3371 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3371 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3372:9 [INFO] [stdout] | [INFO] [stdout] 3372 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3372 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3372 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3373:9 [INFO] [stdout] | [INFO] [stdout] 3373 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3373 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3373 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3382:9 [INFO] [stdout] | [INFO] [stdout] 3382 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3382 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3382 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3383:9 [INFO] [stdout] | [INFO] [stdout] 3383 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3383 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3383 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3384:9 [INFO] [stdout] | [INFO] [stdout] 3384 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3384 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3384 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3385:9 [INFO] [stdout] | [INFO] [stdout] 3385 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3385 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3385 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3396:9 [INFO] [stdout] | [INFO] [stdout] 3396 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3396 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3396 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3397:9 [INFO] [stdout] | [INFO] [stdout] 3397 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3397 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3397 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3398:9 [INFO] [stdout] | [INFO] [stdout] 3398 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3398 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3398 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3399:9 [INFO] [stdout] | [INFO] [stdout] 3399 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3399 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3399 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3407:9 [INFO] [stdout] | [INFO] [stdout] 3407 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3407 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3407 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3408:9 [INFO] [stdout] | [INFO] [stdout] 3408 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3408 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3408 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3409:9 [INFO] [stdout] | [INFO] [stdout] 3409 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3409 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3409 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3410:9 [INFO] [stdout] | [INFO] [stdout] 3410 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3410 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3410 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3420:9 [INFO] [stdout] | [INFO] [stdout] 3420 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3420 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3420 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3421:9 [INFO] [stdout] | [INFO] [stdout] 3421 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3421 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3421 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3422:9 [INFO] [stdout] | [INFO] [stdout] 3422 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3422 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3422 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3423:9 [INFO] [stdout] | [INFO] [stdout] 3423 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3423 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3423 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3434:9 [INFO] [stdout] | [INFO] [stdout] 3434 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3434 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3434 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3435:9 [INFO] [stdout] | [INFO] [stdout] 3435 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3435 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3435 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3436:9 [INFO] [stdout] | [INFO] [stdout] 3436 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3436 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3436 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3442:9 [INFO] [stdout] | [INFO] [stdout] 3442 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3442 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3442 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3443:9 [INFO] [stdout] | [INFO] [stdout] 3443 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3443 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3443 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3444:9 [INFO] [stdout] | [INFO] [stdout] 3444 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3444 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3444 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3452:9 [INFO] [stdout] | [INFO] [stdout] 3452 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3452 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3452 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3453:9 [INFO] [stdout] | [INFO] [stdout] 3453 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3453 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3453 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3454:9 [INFO] [stdout] | [INFO] [stdout] 3454 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3454 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3454 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3501:9 [INFO] [stdout] | [INFO] [stdout] 3501 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3501 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3501 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3502:9 [INFO] [stdout] | [INFO] [stdout] 3502 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3502 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3502 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3503:9 [INFO] [stdout] | [INFO] [stdout] 3503 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3503 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3503 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3504:9 [INFO] [stdout] | [INFO] [stdout] 3504 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3504 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3504 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3511:9 [INFO] [stdout] | [INFO] [stdout] 3511 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3511 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), true); [INFO] [stdout] 3511 + assert!(cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3512:9 [INFO] [stdout] | [INFO] [stdout] 3512 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3512 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3512 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3513:9 [INFO] [stdout] | [INFO] [stdout] 3513 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3513 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3513 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3514:9 [INFO] [stdout] | [INFO] [stdout] 3514 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3514 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3514 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3526:9 [INFO] [stdout] | [INFO] [stdout] 3526 | assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3526 - assert_eq!(cpu.registers.get_flag(FlagRegister::Zero), false); [INFO] [stdout] 3526 + assert!(!cpu.registers.get_flag(FlagRegister::Zero)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3527:9 [INFO] [stdout] | [INFO] [stdout] 3527 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3527 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3527 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3528:9 [INFO] [stdout] | [INFO] [stdout] 3528 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3528 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3528 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3529:9 [INFO] [stdout] | [INFO] [stdout] 3529 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3529 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3529 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3541:9 [INFO] [stdout] | [INFO] [stdout] 3541 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3541 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), true); [INFO] [stdout] 3541 + assert!(cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3542:9 [INFO] [stdout] | [INFO] [stdout] 3542 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3542 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), true); [INFO] [stdout] 3542 + assert!(cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3554:9 [INFO] [stdout] | [INFO] [stdout] 3554 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3554 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3554 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3555:9 [INFO] [stdout] | [INFO] [stdout] 3555 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3555 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3555 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3556:9 [INFO] [stdout] | [INFO] [stdout] 3556 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3556 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3556 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3565:9 [INFO] [stdout] | [INFO] [stdout] 3565 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3565 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3565 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3566:9 [INFO] [stdout] | [INFO] [stdout] 3566 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3566 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3566 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3567:9 [INFO] [stdout] | [INFO] [stdout] 3567 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3567 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), false); [INFO] [stdout] 3567 + assert!(!cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3579:9 [INFO] [stdout] | [INFO] [stdout] 3579 | assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3579 - assert_eq!(cpu.registers.get_flag(FlagRegister::Substract), false); [INFO] [stdout] 3579 + assert!(!cpu.registers.get_flag(FlagRegister::Substract)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3580:9 [INFO] [stdout] | [INFO] [stdout] 3580 | assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3580 - assert_eq!(cpu.registers.get_flag(FlagRegister::HalfCarry), false); [INFO] [stdout] 3580 + assert!(!cpu.registers.get_flag(FlagRegister::HalfCarry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/cpu.rs:3581:9 [INFO] [stdout] | [INFO] [stdout] 3581 | assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 3581 - assert_eq!(cpu.registers.get_flag(FlagRegister::Carry), true); [INFO] [stdout] 3581 + assert!(cpu.registers.get_flag(FlagRegister::Carry)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RGBA` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | struct RGBA(u8, u8, u8, u8); [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rgba` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ppu.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | pub fn get_pixel(&mut self, lcd_x: u8, lcd_y: u8, vram: &[u8], last_bg_index: u8, last_bg_priority: bool, lcd_control: u8, is_cgb: bool) -> Option<(Pixel, bool, u8)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | tile_number = tile_number & 0xFE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_number &= 0xFE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:250:21 [INFO] [stdout] | [INFO] [stdout] 250 | tile_number = tile_number | 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_number |= 0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | (address >= 0xFF51 && address <= 0xFF55) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF51..=0xFF55).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | (address >= 0xFF68 && address <= 0xFF6B) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF68..=0xFF6B).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | (address >= 0xFF40 && address <= 0xFF4F) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF40..=0xFF4F).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:585:23 [INFO] [stdout] | [INFO] [stdout] 585 | if x == 0 { [INFO] [stdout] | _______________________^ [INFO] [stdout] 586 | | addr += 4; [INFO] [stdout] 587 | | continue; [INFO] [stdout] 588 | | } else if x >= 160 + 8 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:588:36 [INFO] [stdout] | [INFO] [stdout] 588 | } else if x >= 160 + 8 { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 589 | | addr += 4; [INFO] [stdout] 590 | | continue; [INFO] [stdout] 591 | | } else if y == 0 { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:588:36 [INFO] [stdout] | [INFO] [stdout] 588 | } else if x >= 160 + 8 { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 589 | | addr += 4; [INFO] [stdout] 590 | | continue; [INFO] [stdout] 591 | | } else if y == 0 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:591:30 [INFO] [stdout] | [INFO] [stdout] 591 | } else if y == 0 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 592 | | addr += 4; [INFO] [stdout] 593 | | continue; [INFO] [stdout] 594 | | } else if y >= 144 + 16 { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:591:30 [INFO] [stdout] | [INFO] [stdout] 591 | } else if y == 0 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 592 | | addr += 4; [INFO] [stdout] 593 | | continue; [INFO] [stdout] 594 | | } else if y >= 144 + 16 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:594:37 [INFO] [stdout] | [INFO] [stdout] 594 | } else if y >= 144 + 16 { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 595 | | addr += 4; [INFO] [stdout] 596 | | continue; [INFO] [stdout] 597 | | } else if !long_sprites && y <= 8 { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ppu.rs:594:37 [INFO] [stdout] | [INFO] [stdout] 594 | } else if y >= 144 + 16 { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 595 | | addr += 4; [INFO] [stdout] 596 | | continue; [INFO] [stdout] 597 | | } else if !long_sprites && y <= 8 { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ppu.rs:597:47 [INFO] [stdout] | [INFO] [stdout] 597 | } else if !long_sprites && y <= 8 { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 598 | | addr += 4; [INFO] [stdout] 599 | | continue; [INFO] [stdout] 600 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ppu.rs:637:13 [INFO] [stdout] | [INFO] [stdout] 637 | self.sprite_buffer.sort_by(|a, b| a.x().cmp(&b.x())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 637 - self.sprite_buffer.sort_by(|a, b| a.x().cmp(&b.x())); [INFO] [stdout] 637 + self.sprite_buffer.sort_by_key(|a| a.x()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ppu.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 649 - return None; [INFO] [stdout] 649 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:682:57 [INFO] [stdout] | [INFO] [stdout] 682 | LCDStatusModeFlag::HBlank => (byte & 0b11111100) | 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(byte & 0b11111100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ppu.rs:735:9 [INFO] [stdout] | [INFO] [stdout] 735 | return (byte1, byte2, attributes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 735 - return (byte1, byte2, attributes); [INFO] [stdout] 735 + (byte1, byte2, attributes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ppu.rs:695:57 [INFO] [stdout] | [INFO] [stdout] 695 | let tile_number = self.read_vram(tilemap_area + index as u16) as u16; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ppu.rs:697:83 [INFO] [stdout] | [INFO] [stdout] 697 | let attributes = BgAttributes::new(self.read_vram(tilemap_area + 0x2000 + index as u16)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ppu.rs:701:9 [INFO] [stdout] | [INFO] [stdout] 701 | tile_line = tile_line * 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_line *= 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/ppu.rs:707:24 [INFO] [stdout] | [INFO] [stdout] 707 | let base = (0x9000 as u16) as i16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `0x9000_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:743:9 [INFO] [stdout] | [INFO] [stdout] 743 | / if !self.cgb_mode { [INFO] [stdout] 744 | | if !self.background_priority || !self.window_enable { [INFO] [stdout] 745 | | self.last_bg_index = 0b00; [INFO] [stdout] 746 | | return None; [INFO] [stdout] 747 | | } [INFO] [stdout] 748 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 743 ~ if !self.cgb_mode [INFO] [stdout] 744 ~ && (!self.background_priority || !self.window_enable) { [INFO] [stdout] 745 | self.last_bg_index = 0b00; [INFO] [stdout] 746 | return None; [INFO] [stdout] 747 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Timer` [INFO] [stdout] --> src/timer.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Self { [INFO] [stdout] 25 | | divider: 0, [INFO] [stdout] 26 | | control: 0, [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for Timer { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/timer.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | address >= 0xFF04 && address <= 0xFF07 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF04..=0xFF07).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | assert_eq!(timer.prev_result(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 125 - assert_eq!(timer.prev_result(), true); [INFO] [stdout] 125 + assert!(timer.prev_result()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | assert_eq!(interrupts.get(Interrupt::Timer), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 127 - assert_eq!(interrupts.get(Interrupt::Timer), false); [INFO] [stdout] 127 + assert!(!interrupts.get(Interrupt::Timer)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | assert_eq!(timer.prev_result(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 131 - assert_eq!(timer.prev_result(), true); [INFO] [stdout] 131 + assert!(timer.prev_result()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | assert_eq!(interrupts.get(Interrupt::Timer), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 133 - assert_eq!(interrupts.get(Interrupt::Timer), false); [INFO] [stdout] 133 + assert!(!interrupts.get(Interrupt::Timer)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | assert_eq!(timer.prev_result(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 137 - assert_eq!(timer.prev_result(), false); [INFO] [stdout] 137 + assert!(!timer.prev_result()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | assert_eq!(interrupts.get(Interrupt::Timer), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 138 - assert_eq!(interrupts.get(Interrupt::Timer), false); [INFO] [stdout] 138 + assert!(!interrupts.get(Interrupt::Timer)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/timer.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | assert_eq!(interrupts.get(Interrupt::Timer), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 151 - assert_eq!(interrupts.get(Interrupt::Timer), true); [INFO] [stdout] 151 + assert!(interrupts.get(Interrupt::Timer)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sound.rs:61:49 [INFO] [stdout] | [INFO] [stdout] 61 | let stream = device.build_output_stream(&config, move |data: &mut [f32], _| { [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/sound.rs:84:70 [INFO] [stdout] | [INFO] [stdout] 84 | let sample = match WAVE_DUTY_PATTERNS[duty_pattern as usize][self.duty_position as usize] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.duty_position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Sound` [INFO] [stdout] --> src/sound.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / pub fn new() -> Self { [INFO] [stdout] 135 | | if !env::var("SOUND_ENABLE").is_err() { [INFO] [stdout] 136 | | let host = cpal::default_host(); [INFO] [stdout] 137 | | let device = host.default_output_device().expect("no output device available"); [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 133 + impl Default for Sound { [INFO] [stdout] 134 + fn default() -> Self { [INFO] [stdout] 135 + Self::new() [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sound.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if !env::var("SOUND_ENABLE").is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("SOUND_ENABLE").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/sound.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | address >= 0xFF10 && address <= 0xFF3F [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xFF10..=0xFF3F).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.channel_two` after checking its variant with `is_some` [INFO] [stdout] --> src/sound.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 186 | if self.channel_two.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &mut self.channel_two` [INFO] [stdout] ... [INFO] [stdout] 189 | self.channel_two.as_mut().unwrap().cycle(duty, frequency); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/rom.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | NoMBC, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MBC` contains a capitalized acronym [INFO] [stdout] --> src/rom.rs:121:6 [INFO] [stdout] | [INFO] [stdout] 121 | enum MBC { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 221 | has_ram: match rom_type { [INFO] [stdout] | ______________________^ [INFO] [stdout] 222 | | 0x02 | 0x03 | 0x08 | 0x09 | 0x0C | 0x0D | 0x10 | 0x12 | [INFO] [stdout] 223 | | 0x13 | 0x1A | 0x1B | 0x1D | 0x1E | 0x22 | 0xFF => true, [INFO] [stdout] 224 | | _ => false, [INFO] [stdout] 225 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 221 ~ has_ram: matches!(rom_type, 0x02 | 0x03 | 0x08 | 0x09 | 0x0C | 0x0D | 0x10 | 0x12 | [INFO] [stdout] 222 ~ 0x13 | 0x1A | 0x1B | 0x1D | 0x1E | 0x22 | 0xFF), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:226:26 [INFO] [stdout] | [INFO] [stdout] 226 | has_battery: match rom_type { [INFO] [stdout] | __________________________^ [INFO] [stdout] 227 | | 0x03 | 0x06 | 0x09 | 0x0D | 0x0F | 0x10 | [INFO] [stdout] 228 | | 0x13 | 0x1B | 0x1E | 0x22 | 0xFF => true, [INFO] [stdout] 229 | | _ => false, [INFO] [stdout] 230 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 226 ~ has_battery: matches!(rom_type, 0x03 | 0x06 | 0x09 | 0x0D | 0x0F | 0x10 | [INFO] [stdout] 227 ~ 0x13 | 0x1B | 0x1E | 0x22 | 0xFF), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 231 | has_timer: match rom_type { [INFO] [stdout] | ________________________^ [INFO] [stdout] 232 | | 0x0F | 0x10 => true, [INFO] [stdout] 233 | | _ => false, [INFO] [stdout] 234 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 231 - has_timer: match rom_type { [INFO] [stdout] 232 - 0x0F | 0x10 => true, [INFO] [stdout] 233 - _ => false, [INFO] [stdout] 234 - }, [INFO] [stdout] 231 + has_timer: matches!(rom_type, 0x0F | 0x10), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:340:27 [INFO] [stdout] | [INFO] [stdout] 340 | let ram = vec![0; info.ram_size() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `info.ram_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:451:13 [INFO] [stdout] | [INFO] [stdout] 451 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 450 - }; [INFO] [stdout] 451 - return; [INFO] [stdout] 450 + }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/rom.rs:447:31 [INFO] [stdout] | [INFO] [stdout] 447 | self.ram_enable = match data & 0x0F { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 448 | | 0x0A => true, [INFO] [stdout] 449 | | _ => false, [INFO] [stdout] 450 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 447 - self.ram_enable = match data & 0x0F { [INFO] [stdout] 448 - 0x0A => true, [INFO] [stdout] 449 - _ => false, [INFO] [stdout] 450 - }; [INFO] [stdout] 447 + self.ram_enable = matches!(data & 0x0F, 0x0A); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:452:19 [INFO] [stdout] | [INFO] [stdout] 452 | } else if address >= 0x2000 && address <= 0x3FFF { // ROM bank number register [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..=0x3FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:454:19 [INFO] [stdout] | [INFO] [stdout] 454 | } else if address >= 0x4000 && address <= 0x5FFF { // ROM and RAM bank number register [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..=0x5FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:456:19 [INFO] [stdout] | [INFO] [stdout] 456 | } else if address >= 0x6000 && address <= 0x7FFF { // Banking mode select [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..=0x7FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | return 0xFF; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return 0xFF; [INFO] [stdout] 538 + 0xFF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:527:30 [INFO] [stdout] | [INFO] [stdout] 527 | return self.data[((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:533:39 [INFO] [stdout] | [INFO] [stdout] 533 | return match self.ram.get(address as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:595:27 [INFO] [stdout] | [INFO] [stdout] 595 | let ram = vec![0; info.ram_size() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `info.ram_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:628:30 [INFO] [stdout] | [INFO] [stdout] 628 | return self.data[((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:656:19 [INFO] [stdout] | [INFO] [stdout] 656 | } else if address >= 0x2000 && address <= 0x3FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..=0x3FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:658:19 [INFO] [stdout] | [INFO] [stdout] 658 | } else if address >= 0x4000 && address <= 0x5FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..=0x5FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:662:23 [INFO] [stdout] | [INFO] [stdout] 662 | } else if data >= 0x08 && data <= 0x0C { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x08..=0x0C).contains(&data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:666:19 [INFO] [stdout] | [INFO] [stdout] 666 | } else if address >= 0x6000 && address <= 0x7FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x6000..=0x7FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:671:19 [INFO] [stdout] | [INFO] [stdout] 671 | } else if address >= 0xA000 && address <= 0xBFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xA000..=0xBFFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:716:27 [INFO] [stdout] | [INFO] [stdout] 716 | let ram = vec![0; info.ram_size() as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `info.ram_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:750:9 [INFO] [stdout] | [INFO] [stdout] 750 | return 0xFF; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 750 - return 0xFF; [INFO] [stdout] 750 + 0xFF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/rom.rs:737:40 [INFO] [stdout] | [INFO] [stdout] 737 | return match self.data.get(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)) as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((self.rom_bank as usize * 0x4000) + (address as usize - 0x4000)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:756:19 [INFO] [stdout] | [INFO] [stdout] 756 | } else if address >= 0x2000 && address <= 0x2FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x2000..=0x2FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:758:19 [INFO] [stdout] | [INFO] [stdout] 758 | } else if address >= 0x3000 && address <= 0x3FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/rom.rs:760:19 [INFO] [stdout] | [INFO] [stdout] 760 | } else if address >= 0x4000 && address <= 0x5FFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x4000..=0x5FFF).contains(&address)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DMGRAM` [INFO] [stdout] --> src/ram.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | data: [0; 4096 * 2], [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for DMGRAM { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CGBRAM` [INFO] [stdout] --> src/ram.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / pub fn new() -> Self { [INFO] [stdout] 57 | | Self { [INFO] [stdout] 58 | | data: [0; 4096 * 8], [INFO] [stdout] 59 | | bank: 1, [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 55 + impl Default for CGBRAM { [INFO] [stdout] 56 + fn default() -> Self { [INFO] [stdout] 57 + Self::new() [INFO] [stdout] 58 + } [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Bus` [INFO] [stdout] --> src/bus.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / pub fn new() -> Self { [INFO] [stdout] 64 | | let args: Vec = std::env::args().collect(); [INFO] [stdout] 65 | | #[cfg(not(test))] [INFO] [stdout] 66 | | if args.len() < 2 { [INFO] [stdout] ... | [INFO] [stdout] 120 | | bus [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 62 + impl Default for Bus { [INFO] [stdout] 63 + fn default() -> Self { [INFO] [stdout] 64 + Self::new() [INFO] [stdout] 65 + } [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bus.rs:78:30 [INFO] [stdout] | [INFO] [stdout] 78 | let force_dmg_mode = !env::var("FORCE_DMG").is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("FORCE_DMG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bus.rs:70:34 [INFO] [stdout] | [INFO] [stdout] 70 | let rom = match load_rom(&args.get(1).unwrap_or(&"".to_string())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `args.get(1).unwrap_or(&"".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bus.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | return self.data[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self.data[address as usize]; [INFO] [stdout] 165 + self.data[address as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Interrupts` [INFO] [stdout] --> src/interrupts.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / pub fn new() -> Self { [INFO] [stdout] 56 | | Self { [INFO] [stdout] 57 | | interrupt_enable: 0, [INFO] [stdout] 58 | | interrupt_flag: 0, [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 54 + impl Default for Interrupts { [INFO] [stdout] 55 + fn default() -> Self { [INFO] [stdout] 56 + Self::new() [INFO] [stdout] 57 + } [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Joypad` [INFO] [stdout] --> src/joypad.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Self { [INFO] [stdout] 30 | | Self { [INFO] [stdout] 31 | | a: false, [INFO] [stdout] 32 | | b: false, [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for Joypad { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/joypad.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return data; [INFO] [stdout] 82 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Emulator` [INFO] [stdout] --> src/emulator.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> Self { [INFO] [stdout] 19 | | let bus = Bus::new(); [INFO] [stdout] 20 | | let cpu = match bus.cgb_mode { [INFO] [stdout] 21 | | true => CPU::new_cgb(), [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for Emulator { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | !env::var("UNLOCK_FPS").is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("UNLOCK_FPS").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/render.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - *control_flow = ControlFlow::Exit; [INFO] [stdout] 107 - return; [INFO] [stdout] 106 + *control_flow = ControlFlow::Exit; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/render.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | / if pixels [INFO] [stdout] 102 | | .render() [INFO] [stdout] 103 | | .map_err(|e| error!("pixels.render() failed: {}", e)) [INFO] [stdout] 104 | | .is_err() [INFO] [stdout] ... | [INFO] [stdout] 107 | | return; [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ Event::RedrawRequested(_) [INFO] [stdout] 101 | if pixels [INFO] [stdout] ... [INFO] [stdout] 104 | .is_err() [INFO] [stdout] 105 ~ => { [INFO] [stdout] 106 | *control_flow = ControlFlow::Exit; [INFO] [stdout] 107 | return; [INFO] [stdout] 108 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Frames` [INFO] [stdout] --> src/frames.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | count: 0, [INFO] [stdout] 15 | | timer: Instant::now(), [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Frames { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 45.41s [INFO] running `Command { std: "docker" "inspect" "0055e70cca3e5fc0e25f929acfbb4b51d81ceb169da4b61aa3ff611d4f95e842", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0055e70cca3e5fc0e25f929acfbb4b51d81ceb169da4b61aa3ff611d4f95e842", kill_on_drop: false }` [INFO] [stdout] 0055e70cca3e5fc0e25f929acfbb4b51d81ceb169da4b61aa3ff611d4f95e842