[INFO] cloning repository https://github.com/FlyingCowsCorporation/chat-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FlyingCowsCorporation/chat-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFlyingCowsCorporation%2Fchat-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFlyingCowsCorporation%2Fchat-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c71e50ca54b876aeebfee82b5015236a75942449 [INFO] linting FlyingCowsCorporation/chat-server against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFlyingCowsCorporation%2Fchat-server" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FlyingCowsCorporation/chat-server [INFO] finished tweaking git repo https://github.com/FlyingCowsCorporation/chat-server [INFO] tweaked toml for git repo https://github.com/FlyingCowsCorporation/chat-server written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FlyingCowsCorporation/chat-server on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FlyingCowsCorporation/chat-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded threadpool v1.7.1 [INFO] [stderr] Downloaded libc v0.2.48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae2a9a84b376bb93fde81cc5fe6b5ecb696e6b7cfa1385d8c0128c32ea2b1ada [INFO] running `Command { std: "docker" "start" "-a" "ae2a9a84b376bb93fde81cc5fe6b5ecb696e6b7cfa1385d8c0128c32ea2b1ada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae2a9a84b376bb93fde81cc5fe6b5ecb696e6b7cfa1385d8c0128c32ea2b1ada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae2a9a84b376bb93fde81cc5fe6b5ecb696e6b7cfa1385d8c0128c32ea2b1ada", kill_on_drop: false }` [INFO] [stdout] ae2a9a84b376bb93fde81cc5fe6b5ecb696e6b7cfa1385d8c0128c32ea2b1ada [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c1e742bcf5190db8b430ae2c74deaedcf2bcc634b601cfe6d4ecc3443d2eb3c [INFO] running `Command { std: "docker" "start" "-a" "6c1e742bcf5190db8b430ae2c74deaedcf2bcc634b601cfe6d4ecc3443d2eb3c", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking rust-practice v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `location` is never read [INFO] [stdout] --> src/http.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 141 | pub struct HttpRequestContent{ [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 142 | pub location : String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !request_str.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `request_str.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http.rs:94:36 [INFO] [stdout] | [INFO] [stdout] 94 | let captures = re.captures(&request_str); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `request_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/http.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | (&cap[1]).to_lowercase().to_owned(), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/http.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | (&cap[2]).to_owned(), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GET` contains a capitalized acronym [INFO] [stdout] --> src/http.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | GET(HttpRequestContent), [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Get` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POST` contains a capitalized acronym [INFO] [stdout] --> src/http.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | POST(HttpRequestContent), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Post` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `location` is never read [INFO] [stdout] --> src/http.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 141 | pub struct HttpRequestContent{ [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 142 | pub location : String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !request_str.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `request_str.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http.rs:94:36 [INFO] [stdout] | [INFO] [stdout] 94 | let captures = re.captures(&request_str); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `request_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/http.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | (&cap[1]).to_lowercase().to_owned(), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/http.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | (&cap[2]).to_owned(), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `cap[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GET` contains a capitalized acronym [INFO] [stdout] --> src/http.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | GET(HttpRequestContent), [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Get` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POST` contains a capitalized acronym [INFO] [stdout] --> src/http.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | POST(HttpRequestContent), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Post` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.33s [INFO] running `Command { std: "docker" "inspect" "6c1e742bcf5190db8b430ae2c74deaedcf2bcc634b601cfe6d4ecc3443d2eb3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c1e742bcf5190db8b430ae2c74deaedcf2bcc634b601cfe6d4ecc3443d2eb3c", kill_on_drop: false }` [INFO] [stdout] 6c1e742bcf5190db8b430ae2c74deaedcf2bcc634b601cfe6d4ecc3443d2eb3c