[INFO] cloning repository https://github.com/FleetAdmiralJakob/pascal-to-js-compiler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FleetAdmiralJakob/pascal-to-js-compiler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFleetAdmiralJakob%2Fpascal-to-js-compiler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFleetAdmiralJakob%2Fpascal-to-js-compiler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 634d5405c38badd8c499524869ea3bf54dc88f32 [INFO] linting FleetAdmiralJakob/pascal-to-js-compiler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFleetAdmiralJakob%2Fpascal-to-js-compiler" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FleetAdmiralJakob/pascal-to-js-compiler [INFO] finished tweaking git repo https://github.com/FleetAdmiralJakob/pascal-to-js-compiler [INFO] tweaked toml for git repo https://github.com/FleetAdmiralJakob/pascal-to-js-compiler written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FleetAdmiralJakob/pascal-to-js-compiler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FleetAdmiralJakob/pascal-to-js-compiler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b3ee860ccd34249b1f7fb093424c0faf5a2c829e1432c9886dcaa66a970033e [INFO] running `Command { std: "docker" "start" "-a" "0b3ee860ccd34249b1f7fb093424c0faf5a2c829e1432c9886dcaa66a970033e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b3ee860ccd34249b1f7fb093424c0faf5a2c829e1432c9886dcaa66a970033e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b3ee860ccd34249b1f7fb093424c0faf5a2c829e1432c9886dcaa66a970033e", kill_on_drop: false }` [INFO] [stdout] 0b3ee860ccd34249b1f7fb093424c0faf5a2c829e1432c9886dcaa66a970033e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ccaac02bc0b621c1afc7289c7c37ab38aff198a23516b2abd5a8ff2594b2030 [INFO] running `Command { std: "docker" "start" "-a" "0ccaac02bc0b621c1afc7289c7c37ab38aff198a23516b2abd5a8ff2594b2030", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking pascal-to-js-compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / return match (position_from, position_to) { [INFO] [stdout] 17 | | (Some(from_index), Some(to_index)) if from_index < to_index => { [INFO] [stdout] 18 | | let sliced_code = &code[from_index + 1..to_index]; [INFO] [stdout] 19 | | sliced_code.join("\n") [INFO] [stdout] 20 | | }, [INFO] [stdout] 21 | | _ => String::from(full_code), [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ match (position_from, position_to) { [INFO] [stdout] 17 + (Some(from_index), Some(to_index)) if from_index < to_index => { [INFO] [stdout] 18 + let sliced_code = &code[from_index + 1..to_index]; [INFO] [stdout] 19 + sliced_code.join("\n") [INFO] [stdout] 20 + }, [INFO] [stdout] 21 + _ => String::from(full_code), [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | if !(words[end_of_variable_declaration_position].to_lowercase() == "begin") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(words[end_of_variable_declaration_position].to_lowercase() != "begin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | let re = Regex::new(r"^\s*program\s+(\w+);?").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | for content in contents { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / return match (position_from, position_to) { [INFO] [stdout] 17 | | (Some(from_index), Some(to_index)) if from_index < to_index => { [INFO] [stdout] 18 | | let sliced_code = &code[from_index + 1..to_index]; [INFO] [stdout] 19 | | sliced_code.join("\n") [INFO] [stdout] 20 | | }, [INFO] [stdout] 21 | | _ => String::from(full_code), [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ match (position_from, position_to) { [INFO] [stdout] 17 + (Some(from_index), Some(to_index)) if from_index < to_index => { [INFO] [stdout] 18 + let sliced_code = &code[from_index + 1..to_index]; [INFO] [stdout] 19 + sliced_code.join("\n") [INFO] [stdout] 20 + }, [INFO] [stdout] 21 + _ => String::from(full_code), [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | if !(words[end_of_variable_declaration_position].to_lowercase() == "begin") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(words[end_of_variable_declaration_position].to_lowercase() != "begin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | let re = Regex::new(r"^\s*program\s+(\w+);?").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | for content in contents { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:188:41 [INFO] [stdout] | [INFO] [stdout] 188 | if let Some(captures) = Regex::new(r"^(?i)Writeln\((.*?)\);?$").unwrap().captures(trimmed_line) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | for (i, line) in main_code.lines().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:196:41 [INFO] [stdout] | [INFO] [stdout] 196 | if let Some(captures) = Regex::new(r"^(?i)Delay\((.*?)\);?$").unwrap().captures(trimmed_line) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | for (i, line) in main_code.lines().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:188:41 [INFO] [stdout] | [INFO] [stdout] 188 | if let Some(captures) = Regex::new(r"^(?i)Writeln\((.*?)\);?$").unwrap().captures(trimmed_line) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | for (i, line) in main_code.lines().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:196:41 [INFO] [stdout] | [INFO] [stdout] 196 | if let Some(captures) = Regex::new(r"^(?i)Delay\((.*?)\);?$").unwrap().captures(trimmed_line) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | for (i, line) in main_code.lines().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.06s [INFO] running `Command { std: "docker" "inspect" "0ccaac02bc0b621c1afc7289c7c37ab38aff198a23516b2abd5a8ff2594b2030", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ccaac02bc0b621c1afc7289c7c37ab38aff198a23516b2abd5a8ff2594b2030", kill_on_drop: false }` [INFO] [stdout] 0ccaac02bc0b621c1afc7289c7c37ab38aff198a23516b2abd5a8ff2594b2030