[INFO] cloning repository https://github.com/FishArmy100/Rust-Calculator
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FishArmy100/Rust-Calculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishArmy100%2FRust-Calculator", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishArmy100%2FRust-Calculator'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 4419a43451f4f1f1df303dacaca43a5439d776ab
[INFO] linting FishArmy100/Rust-Calculator against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishArmy100%2FRust-Calculator" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/FishArmy100/Rust-Calculator
[INFO] finished tweaking git repo https://github.com/FishArmy100/Rust-Calculator
[INFO] tweaked toml for git repo https://github.com/FishArmy100/Rust-Calculator written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/FishArmy100/Rust-Calculator on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/FishArmy100/Rust-Calculator already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] ba7078c41900f0c0a95e65055873aa3b477ec7fe34cc43e882e3332831bcbfbc
[INFO] running `Command { std: "docker" "start" "-a" "ba7078c41900f0c0a95e65055873aa3b477ec7fe34cc43e882e3332831bcbfbc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "ba7078c41900f0c0a95e65055873aa3b477ec7fe34cc43e882e3332831bcbfbc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ba7078c41900f0c0a95e65055873aa3b477ec7fe34cc43e882e3332831bcbfbc", kill_on_drop: false }`
[INFO] [stdout] ba7078c41900f0c0a95e65055873aa3b477ec7fe34cc43e882e3332831bcbfbc
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c2bb67f00f5d19c956818083f8b733dafd727640a89afd71848947a843e80388
[INFO] running `Command { std: "docker" "start" "-a" "c2bb67f00f5d19c956818083f8b733dafd727640a89afd71848947a843e80388", kill_on_drop: false }`
[INFO] [stderr]     Checking calculator v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lexing/lexer.rs:89:13
[INFO] [stdout]    |
[INFO] [stdout] 89 |             line: line,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lexing/lexer.rs:90:13
[INFO] [stdout]    |
[INFO] [stdout] 90 |             column: column
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `column`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lexing/lexer.rs:124:17
[INFO] [stdout]     |
[INFO] [stdout] 124 |                 token_type: token_type,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lexing/lexer.rs:125:17
[INFO] [stdout]     |
[INFO] [stdout] 125 |                 line: line,
[INFO] [stdout]     |                 ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lexing/lexer.rs:126:17
[INFO] [stdout]     |
[INFO] [stdout] 126 |                 column: column
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^ help: replace it with: `column`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `index` is never used
[INFO] [stdout]   --> src/lexing/string_reader.rs:31:12
[INFO] [stdout]    |
[INFO] [stdout]  9 | impl<'a> StringReader<'a>
[INFO] [stdout]    | ------------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 31 |     pub fn index(&self) -> usize
[INFO] [stdout]    |            ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: direct implementation of `ToString`
[INFO] [stdout]   --> src/lexing/lexer.rs:11:1
[INFO] [stdout]    |
[INFO] [stdout] 11 | / impl std::string::ToString for LexerError
[INFO] [stdout] 12 | | {
[INFO] [stdout] 13 | |     fn to_string(&self) -> String
[INFO] [stdout] ...  |
[INFO] [stdout] 17 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: prefer implementing `Display` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
[INFO] [stdout]    = note: `#[warn(clippy::to_string_trait_impl)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/lexing/lexer.rs:72:35
[INFO] [stdout]    |
[INFO] [stdout] 72 |             if !c.is_numeric() && !(c == '.')
[INFO] [stdout]    |                                   ^^^^^^^^^^^ help: try: `(c != '.')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lexing/lexer.rs:178:8
[INFO] [stdout]     |
[INFO] [stdout] 178 |     if errors.len() > 0
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!errors.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: direct implementation of `ToString`
[INFO] [stdout]   --> src/lexing/token.rs:18:1
[INFO] [stdout]    |
[INFO] [stdout] 18 | / impl std::string::ToString for TokenType
[INFO] [stdout] 19 | | {
[INFO] [stdout] 20 | |     fn to_string(&self) -> String 
[INFO] [stdout] ...  |
[INFO] [stdout] 38 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: prefer implementing `Display` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: direct implementation of `ToString`
[INFO] [stdout]   --> src/lexing/token.rs:47:1
[INFO] [stdout]    |
[INFO] [stdout] 47 | / impl std::string::ToString for Token
[INFO] [stdout] 48 | | {
[INFO] [stdout] 49 | |     fn to_string(&self) -> String 
[INFO] [stdout] ...  |
[INFO] [stdout] 53 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: prefer implementing `Display` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/lexing/string_reader.rs:73:24
[INFO] [stdout]    |
[INFO] [stdout] 73 |     pub fn create(src: &String) -> StringReader
[INFO] [stdout]    |                        ^^^^^^^     ^^^^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                        |
[INFO] [stdout]    |                        the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 73 |     pub fn create(src: &String) -> StringReader<'_>
[INFO] [stdout]    |                                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lexing/lexer.rs:89:13
[INFO] [stdout]    |
[INFO] [stdout] 89 |             line: line,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lexing/lexer.rs:90:13
[INFO] [stdout]    |
[INFO] [stdout] 90 |             column: column
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `column`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lexing/lexer.rs:124:17
[INFO] [stdout]     |
[INFO] [stdout] 124 |                 token_type: token_type,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lexing/lexer.rs:125:17
[INFO] [stdout]     |
[INFO] [stdout] 125 |                 line: line,
[INFO] [stdout]     |                 ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lexing/lexer.rs:126:17
[INFO] [stdout]     |
[INFO] [stdout] 126 |                 column: column
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^ help: replace it with: `column`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `index` is never used
[INFO] [stdout]   --> src/lexing/string_reader.rs:31:12
[INFO] [stdout]    |
[INFO] [stdout]  9 | impl<'a> StringReader<'a>
[INFO] [stdout]    | ------------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 31 |     pub fn index(&self) -> usize
[INFO] [stdout]    |            ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: direct implementation of `ToString`
[INFO] [stdout]   --> src/lexing/lexer.rs:11:1
[INFO] [stdout]    |
[INFO] [stdout] 11 | / impl std::string::ToString for LexerError
[INFO] [stdout] 12 | | {
[INFO] [stdout] 13 | |     fn to_string(&self) -> String
[INFO] [stdout] ...  |
[INFO] [stdout] 17 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: prefer implementing `Display` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
[INFO] [stdout]    = note: `#[warn(clippy::to_string_trait_impl)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/lexing/lexer.rs:72:35
[INFO] [stdout]    |
[INFO] [stdout] 72 |             if !c.is_numeric() && !(c == '.')
[INFO] [stdout]    |                                   ^^^^^^^^^^^ help: try: `(c != '.')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lexing/lexer.rs:178:8
[INFO] [stdout]     |
[INFO] [stdout] 178 |     if errors.len() > 0
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!errors.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: direct implementation of `ToString`
[INFO] [stdout]   --> src/lexing/token.rs:18:1
[INFO] [stdout]    |
[INFO] [stdout] 18 | / impl std::string::ToString for TokenType
[INFO] [stdout] 19 | | {
[INFO] [stdout] 20 | |     fn to_string(&self) -> String 
[INFO] [stdout] ...  |
[INFO] [stdout] 38 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: prefer implementing `Display` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: direct implementation of `ToString`
[INFO] [stdout]   --> src/lexing/token.rs:47:1
[INFO] [stdout]    |
[INFO] [stdout] 47 | / impl std::string::ToString for Token
[INFO] [stdout] 48 | | {
[INFO] [stdout] 49 | |     fn to_string(&self) -> String 
[INFO] [stdout] ...  |
[INFO] [stdout] 53 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: prefer implementing `Display` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]   --> src/lexing/string_reader.rs:73:24
[INFO] [stdout]    |
[INFO] [stdout] 73 |     pub fn create(src: &String) -> StringReader
[INFO] [stdout]    |                        ^^^^^^^     ^^^^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]    |                        |
[INFO] [stdout]    |                        the lifetime is elided here
[INFO] [stdout]    |
[INFO] [stdout]    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]    |
[INFO] [stdout] 73 |     pub fn create(src: &String) -> StringReader<'_>
[INFO] [stdout]    |                                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s
[INFO] running `Command { std: "docker" "inspect" "c2bb67f00f5d19c956818083f8b733dafd727640a89afd71848947a843e80388", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c2bb67f00f5d19c956818083f8b733dafd727640a89afd71848947a843e80388", kill_on_drop: false }`
[INFO] [stdout] c2bb67f00f5d19c956818083f8b733dafd727640a89afd71848947a843e80388