[INFO] cloning repository https://github.com/Fatalution/r-helper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Fatalution/r-helper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFatalution%2Fr-helper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFatalution%2Fr-helper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cd3ecc043ad2d8a457bd39a3240bcfbed32346bb [INFO] linting Fatalution/r-helper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFatalution%2Fr-helper" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Fatalution/r-helper [INFO] finished tweaking git repo https://github.com/Fatalution/r-helper [INFO] tweaked toml for git repo https://github.com/Fatalution/r-helper written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Fatalution/r-helper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Fatalution/r-helper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded windows-threading v0.2.0 [INFO] [stderr] Downloaded wgpu-core-deps-apple v25.0.0 [INFO] [stderr] Downloaded toml v0.9.5 [INFO] [stderr] Downloaded wgpu-core-deps-emscripten v25.0.0 [INFO] [stderr] Downloaded windows-future v0.3.0 [INFO] [stderr] Downloaded windows-implement v0.56.0 [INFO] [stderr] Downloaded const-str v0.5.7 [INFO] [stderr] Downloaded zvariant_derive v5.7.0 [INFO] [stderr] Downloaded wayland-sys v0.31.7 [INFO] [stderr] Downloaded emath v0.32.2 [INFO] [stderr] Downloaded windows-core v0.56.0 [INFO] [stderr] Downloaded polling v3.10.0 [INFO] [stderr] Downloaded zvariant v5.7.0 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.9 [INFO] [stderr] Downloaded epaint v0.32.2 [INFO] [stderr] Downloaded eframe v0.32.2 [INFO] [stderr] Downloaded zbus v5.11.0 [INFO] [stderr] Downloaded wayland-protocols v0.32.9 [INFO] [stderr] Downloaded wayland-backend v0.3.11 [INFO] [stderr] Downloaded wayland-client v0.31.11 [INFO] [stderr] Downloaded hidapi v2.6.3 [INFO] [stderr] Downloaded memmap2 v0.9.8 [INFO] [stderr] Downloaded wayland-scanner v0.31.7 [INFO] [stderr] Downloaded egui-wgpu v0.32.2 [INFO] [stderr] Downloaded objc2 v0.6.2 [INFO] [stderr] Downloaded zbus_macros v5.11.0 [INFO] [stderr] Downloaded egui-winit v0.32.2 [INFO] [stderr] Downloaded egui_glow v0.32.2 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.9 [INFO] [stderr] Downloaded gethostname v1.0.2 [INFO] [stderr] Downloaded egui v0.32.2 [INFO] [stderr] Downloaded windows-collections v0.3.0 [INFO] [stderr] Downloaded windows-interface v0.56.0 [INFO] [stderr] Downloaded zvariant_utils v3.2.1 [INFO] [stderr] Downloaded ecolor v0.32.2 [INFO] [stderr] Downloaded wayland-cursor v0.31.11 [INFO] [stderr] Downloaded windows-numerics v0.3.0 [INFO] [stderr] Downloaded epaint_default_fonts v0.32.2 [INFO] [stderr] Downloaded windows v0.62.0 [INFO] [stderr] Downloaded windows v0.56.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61d490eec2d8823f4e864554dfbcf5b3600f2a1629bcf7f6d49ef3d89cf244fe [INFO] running `Command { std: "docker" "start" "-a" "61d490eec2d8823f4e864554dfbcf5b3600f2a1629bcf7f6d49ef3d89cf244fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61d490eec2d8823f4e864554dfbcf5b3600f2a1629bcf7f6d49ef3d89cf244fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61d490eec2d8823f4e864554dfbcf5b3600f2a1629bcf7f6d49ef3d89cf244fe", kill_on_drop: false }` [INFO] [stdout] 61d490eec2d8823f4e864554dfbcf5b3600f2a1629bcf7f6d49ef3d89cf244fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e0dc58f3186367f9aea8ddb0ccc809aec4f580ec655bbabf995d81168d665407 [INFO] running `Command { std: "docker" "start" "-a" "e0dc58f3186367f9aea8ddb0ccc809aec4f580ec655bbabf995d81168d665407", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling winnow v0.7.13 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling find-msvc-tools v0.1.1 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Compiling cc v1.2.36 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking quote v1.0.40 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling indexmap v2.11.0 [INFO] [stderr] Checking syn v2.0.106 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Compiling xml-rs v0.8.27 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking accesskit v0.19.0 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking imgref v1.11.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking weezl v0.1.10 [INFO] [stderr] Checking bitstream-io v2.6.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking accesskit_consumer v0.28.0 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking pxfm v0.1.23 [INFO] [stderr] Checking epaint_default_fonts v0.32.2 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking polling v3.10.0 [INFO] [stderr] Checking gethostname v1.0.2 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking async-io v2.5.0 [INFO] [stderr] Compiling toml_parser v1.0.2 [INFO] [stderr] Compiling hidapi v2.6.3 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking async-signal v0.2.12 [INFO] [stderr] Compiling toml_writer v1.0.2 [INFO] [stderr] Compiling const_format_proc_macros v0.2.34 [INFO] [stderr] Checking async-process v2.4.0 [INFO] [stderr] Checking clap_builder v4.5.47 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking const-str v0.5.7 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking const_format v0.2.34 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking moxcms v0.7.5 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking av1-grain v0.2.4 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.32.2 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking ecolor v0.32.2 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking epaint v0.32.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking egui v0.32.2 [INFO] [stderr] Checking clap v4.5.47 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Compiling zvariant_utils v3.2.1 [INFO] [stderr] Compiling enumflags2 v0.7.12 [INFO] [stderr] Compiling quick-xml v0.36.2 [INFO] [stderr] Compiling toml_datetime v0.7.0 [INFO] [stderr] Compiling serde_spanned v1.0.0 [INFO] [stderr] Compiling toml v0.9.5 [INFO] [stderr] Checking ravif v0.11.20 [INFO] [stderr] Compiling zvariant_derive v5.7.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde-big-array v0.5.1 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking egui_glow v0.32.2 [INFO] [stderr] Compiling embed-resource v3.0.5 [INFO] [stderr] Compiling zvariant v5.7.0 [INFO] [stderr] Checking librazer v0.8.5 (/opt/rustwide/workdir/librazer) [INFO] [stderr] Compiling r-helper v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> librazer/src/device.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | .chain(Into::>::into(&report).into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 63 - .chain(Into::>::into(&report).into_iter()) [INFO] [stdout] 63 + .chain(Into::>::into(&report)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> librazer/src/device.rs:118:63 [INFO] [stdout] | [INFO] [stdout] 118 | .find(|supported| model_number_prefix.starts_with(&supported.model_number_prefix)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `supported.model_number_prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> librazer/src/device.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | .chain(Into::>::into(&report).into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 63 - .chain(Into::>::into(&report).into_iter()) [INFO] [stdout] 63 + .chain(Into::>::into(&report)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> librazer/src/device.rs:118:63 [INFO] [stdout] | [INFO] [stdout] 118 | .find(|supported| model_number_prefix.starts_with(&supported.model_number_prefix)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `supported.model_number_prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking zbus_xml v5.0.2 [INFO] [stderr] Compiling zbus_macros v5.11.0 [INFO] [stderr] Checking zbus-lockstep v0.5.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.1 [INFO] [stderr] Checking zbus v5.11.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.12.0 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.15.0 [INFO] [stderr] Checking accesskit_winit v0.27.0 [INFO] [stderr] Checking egui-winit v0.32.2 [INFO] [stderr] Checking eframe v0.32.2 [INFO] [stdout] warning: unused imports: `clean_display_string` and `execute_powershell_command` [INFO] [stdout] --> src/system/specs.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::utils::{clean_display_string, execute_powershell_command}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::Command` [INFO] [stdout] --> src/utils.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::process::Command; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `clean_display_string` and `execute_powershell_command` [INFO] [stdout] --> src/system/specs.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::utils::{clean_display_string, execute_powershell_command}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::Command` [INFO] [stdout] --> src/utils.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::process::Command; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APP_VERSION` is never used [INFO] [stdout] --> src/main.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | const APP_VERSION: &str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_powershell_command` is never used [INFO] [stdout] --> src/utils.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn execute_powershell_command(_script: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clean_display_string` is never used [INFO] [stdout] --> src/utils.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn clean_display_string(input: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APP_VERSION` is never used [INFO] [stdout] --> src/main.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | const APP_VERSION: &str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `execute_powershell_command` is never used [INFO] [stdout] --> src/utils.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn execute_powershell_command(_script: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clean_display_string` is never used [INFO] [stdout] --> src/utils.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn clean_display_string(input: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ui/fan.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn render_fan_section( [INFO] [stdout] 21 | | ui: &mut egui::Ui, [INFO] [stdout] 22 | | fan_speed: &str, [INFO] [stdout] 23 | | fan_actual_rpm: Option, [INFO] [stdout] ... | [INFO] [stdout] 28 | | max_fan_speed_enabled: bool, [INFO] [stdout] 29 | | ) -> (FanAction, bool) { [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ui/footer.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | .args(&["/c", "start", "https://github.com/Fatalution/r-helper"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/c", "start", "https://github.com/Fatalution/r-helper"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ui/footer.rs:36:38 [INFO] [stdout] | [INFO] [stdout] 36 | Command::new("cmd").args(&["/c", "start", "https://paypal.me/fatalutionDE"]).spawn(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/c", "start", "https://paypal.me/fatalutionDE"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ui/lighting.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | / impl Default for LightingAction { [INFO] [stdout] 38 | | fn default() -> Self { [INFO] [stdout] 39 | | Self { logo_mode: None, brightness: None, lights_always_on: false, slider_active: None } [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub struct LightingAction { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (14/7) [INFO] [stdout] --> src/ui/performance.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn render_performance_section( [INFO] [stdout] 27 | | ui: &mut egui::Ui, [INFO] [stdout] 28 | | current_performance_mode: &str, [INFO] [stdout] 29 | | ac_power: bool, [INFO] [stdout] ... | [INFO] [stdout] 40 | | no_device: bool, [INFO] [stdout] 41 | | ) -> PerformanceAction { [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/ui/performance.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / fn render_custom_boosts( [INFO] [stdout] 90 | | ui: &mut egui::Ui, [INFO] [stdout] 91 | | ac_power: bool, [INFO] [stdout] 92 | | current_cpu: CpuBoost, [INFO] [stdout] ... | [INFO] [stdout] 100 | | base_gpu: &[GpuBoost], [INFO] [stdout] 101 | | ) -> Option { [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/ui/performance.rs:274:49 [INFO] [stdout] | [INFO] [stdout] 274 | let base_vec: Vec = base_modes.iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ui/fan.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn render_fan_section( [INFO] [stdout] 21 | | ui: &mut egui::Ui, [INFO] [stdout] 22 | | fan_speed: &str, [INFO] [stdout] 23 | | fan_actual_rpm: Option, [INFO] [stdout] ... | [INFO] [stdout] 28 | | max_fan_speed_enabled: bool, [INFO] [stdout] 29 | | ) -> (FanAction, bool) { [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ui/footer.rs:20:27 [INFO] [stdout] | [INFO] [stdout] 20 | .args(&["/c", "start", "https://github.com/Fatalution/r-helper"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/c", "start", "https://github.com/Fatalution/r-helper"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ui/footer.rs:36:38 [INFO] [stdout] | [INFO] [stdout] 36 | Command::new("cmd").args(&["/c", "start", "https://paypal.me/fatalutionDE"]).spawn(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/c", "start", "https://paypal.me/fatalutionDE"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ui/lighting.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | / impl Default for LightingAction { [INFO] [stdout] 38 | | fn default() -> Self { [INFO] [stdout] 39 | | Self { logo_mode: None, brightness: None, lights_always_on: false, slider_active: None } [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub struct LightingAction { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:275:29 [INFO] [stdout] | [INFO] [stdout] 275 | reader.read(|d| command::get_keyboard_brightness(d), "keyboard brightness") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_keyboard_brightness` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:282:29 [INFO] [stdout] | [INFO] [stdout] 282 | reader.read(|d| command::get_perf_mode(d), "performance mode") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_perf_mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | reader.read(|d| command::get_lights_always_on(d), "lights always on") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_lights_always_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:324:29 [INFO] [stdout] | [INFO] [stdout] 324 | reader.read(|d| command::get_battery_care(d), "battery care") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_battery_care` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (14/7) [INFO] [stdout] --> src/ui/performance.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn render_performance_section( [INFO] [stdout] 27 | | ui: &mut egui::Ui, [INFO] [stdout] 28 | | current_performance_mode: &str, [INFO] [stdout] 29 | | ac_power: bool, [INFO] [stdout] ... | [INFO] [stdout] 40 | | no_device: bool, [INFO] [stdout] 41 | | ) -> PerformanceAction { [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/ui/performance.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / fn render_custom_boosts( [INFO] [stdout] 90 | | ui: &mut egui::Ui, [INFO] [stdout] 91 | | ac_power: bool, [INFO] [stdout] 92 | | current_cpu: CpuBoost, [INFO] [stdout] ... | [INFO] [stdout] 100 | | base_gpu: &[GpuBoost], [INFO] [stdout] 101 | | ) -> Option { [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/main.rs:424:5 [INFO] [stdout] | [INFO] [stdout] 424 | / match command::get_fan_actual_rpm(device, zone) { [INFO] [stdout] 425 | | Ok(rpm) => Some(rpm), [INFO] [stdout] 426 | | Err(_) => None, [INFO] [stdout] 427 | | } [INFO] [stdout] | |_____^ help: replace with: `command::get_fan_actual_rpm(device, zone).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/main.rs:431:5 [INFO] [stdout] | [INFO] [stdout] 431 | / match command::get_fan_rpm(device, zone) { [INFO] [stdout] 432 | | Ok(rpm) => Some(rpm), [INFO] [stdout] 433 | | Err(_) => None, [INFO] [stdout] 434 | | } [INFO] [stdout] | |_____^ help: replace with: `command::get_fan_rpm(device, zone).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/ui/performance.rs:274:49 [INFO] [stdout] | [INFO] [stdout] 274 | let base_vec: Vec = base_modes.iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/main.rs:618:16 [INFO] [stdout] | [INFO] [stdout] 618 | if let Err(_) = self.read_device_status() { [INFO] [stdout] | -------^^^^^^---------------------------- help: try: `if self.read_device_status().is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:899:28 [INFO] [stdout] | [INFO] [stdout] 899 | if let Ok(_) = command::set_fan_rpm(device, current_set_rpm, true) { [INFO] [stdout] | -------^^^^^------------------------------------------------------ help: try: `if command::set_fan_rpm(device, current_set_rpm, true).is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:275:29 [INFO] [stdout] | [INFO] [stdout] 275 | reader.read(|d| command::get_keyboard_brightness(d), "keyboard brightness") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_keyboard_brightness` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:282:29 [INFO] [stdout] | [INFO] [stdout] 282 | reader.read(|d| command::get_perf_mode(d), "performance mode") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_perf_mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:318:29 [INFO] [stdout] | [INFO] [stdout] 318 | reader.read(|d| command::get_lights_always_on(d), "lights always on") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_lights_always_on` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:324:29 [INFO] [stdout] | [INFO] [stdout] 324 | reader.read(|d| command::get_battery_care(d), "battery care") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `command::get_battery_care` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/main.rs:424:5 [INFO] [stdout] | [INFO] [stdout] 424 | / match command::get_fan_actual_rpm(device, zone) { [INFO] [stdout] 425 | | Ok(rpm) => Some(rpm), [INFO] [stdout] 426 | | Err(_) => None, [INFO] [stdout] 427 | | } [INFO] [stdout] | |_____^ help: replace with: `command::get_fan_actual_rpm(device, zone).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/main.rs:431:5 [INFO] [stdout] | [INFO] [stdout] 431 | / match command::get_fan_rpm(device, zone) { [INFO] [stdout] 432 | | Ok(rpm) => Some(rpm), [INFO] [stdout] 433 | | Err(_) => None, [INFO] [stdout] 434 | | } [INFO] [stdout] | |_____^ help: replace with: `command::get_fan_rpm(device, zone).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1185:25 [INFO] [stdout] | [INFO] [stdout] 1185 | / if self.device.is_some() { [INFO] [stdout] 1186 | | if self.last_state_check_time.elapsed().as_secs_f32() >= 3.0 { [INFO] [stdout] 1187 | | if let Err(_e) = self.check_device_state_changes() { [INFO] [stdout] ... | [INFO] [stdout] 1193 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1185 ~ if self.device.is_some() [INFO] [stdout] 1186 ~ && self.last_state_check_time.elapsed().as_secs_f32() >= 3.0 { [INFO] [stdout] 1187 | if let Err(_e) = self.check_device_state_changes() { [INFO] [stdout] ... [INFO] [stdout] 1191 | self.last_state_check_time = std::time::Instant::now(); [INFO] [stdout] 1192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1201:9 [INFO] [stdout] | [INFO] [stdout] 1201 | / if self.detecting_device && self.device.is_none() && self.device_detection_done { [INFO] [stdout] 1202 | | if std::time::Instant::now() >= self.min_detecting_until { [INFO] [stdout] 1203 | | self.detecting_device = false; [INFO] [stdout] 1204 | | } [INFO] [stdout] 1205 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1201 ~ if self.detecting_device && self.device.is_none() && self.device_detection_done [INFO] [stdout] 1202 ~ && std::time::Instant::now() >= self.min_detecting_until { [INFO] [stdout] 1203 | self.detecting_device = false; [INFO] [stdout] 1204 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:1335:38 [INFO] [stdout] | [INFO] [stdout] 1335 | app.base_window_height = initial_height as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `initial_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/main.rs:618:16 [INFO] [stdout] | [INFO] [stdout] 618 | if let Err(_) = self.read_device_status() { [INFO] [stdout] | -------^^^^^^---------------------------- help: try: `if self.read_device_status().is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:899:28 [INFO] [stdout] | [INFO] [stdout] 899 | if let Ok(_) = command::set_fan_rpm(device, current_set_rpm, true) { [INFO] [stdout] | -------^^^^^------------------------------------------------------ help: try: `if command::set_fan_rpm(device, current_set_rpm, true).is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1185:25 [INFO] [stdout] | [INFO] [stdout] 1185 | / if self.device.is_some() { [INFO] [stdout] 1186 | | if self.last_state_check_time.elapsed().as_secs_f32() >= 3.0 { [INFO] [stdout] 1187 | | if let Err(_e) = self.check_device_state_changes() { [INFO] [stdout] ... | [INFO] [stdout] 1193 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1185 ~ if self.device.is_some() [INFO] [stdout] 1186 ~ && self.last_state_check_time.elapsed().as_secs_f32() >= 3.0 { [INFO] [stdout] 1187 | if let Err(_e) = self.check_device_state_changes() { [INFO] [stdout] ... [INFO] [stdout] 1191 | self.last_state_check_time = std::time::Instant::now(); [INFO] [stdout] 1192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1201:9 [INFO] [stdout] | [INFO] [stdout] 1201 | / if self.detecting_device && self.device.is_none() && self.device_detection_done { [INFO] [stdout] 1202 | | if std::time::Instant::now() >= self.min_detecting_until { [INFO] [stdout] 1203 | | self.detecting_device = false; [INFO] [stdout] 1204 | | } [INFO] [stdout] 1205 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1201 ~ if self.detecting_device && self.device.is_none() && self.device_detection_done [INFO] [stdout] 1202 ~ && std::time::Instant::now() >= self.min_detecting_until { [INFO] [stdout] 1203 | self.detecting_device = false; [INFO] [stdout] 1204 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:1335:38 [INFO] [stdout] | [INFO] [stdout] 1335 | app.base_window_height = initial_height as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `initial_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 29s [INFO] running `Command { std: "docker" "inspect" "e0dc58f3186367f9aea8ddb0ccc809aec4f580ec655bbabf995d81168d665407", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0dc58f3186367f9aea8ddb0ccc809aec4f580ec655bbabf995d81168d665407", kill_on_drop: false }` [INFO] [stdout] e0dc58f3186367f9aea8ddb0ccc809aec4f580ec655bbabf995d81168d665407