[INFO] cloning repository https://github.com/Ext-DASH/four0three [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ext-DASH/four0three" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExt-DASH%2Ffour0three", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExt-DASH%2Ffour0three'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 33e2b14d88272815a40a7a874281f14deb9d67dd [INFO] linting Ext-DASH/four0three against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FExt-DASH%2Ffour0three" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ext-DASH/four0three [INFO] finished tweaking git repo https://github.com/Ext-DASH/four0three [INFO] tweaked toml for git repo https://github.com/Ext-DASH/four0three written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ext-DASH/four0three on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ext-DASH/four0three already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2bdf67c56ff68d1aed2dc718dab18e02874232b2769381ccc70b76e028ca1cd2 [INFO] running `Command { std: "docker" "start" "-a" "2bdf67c56ff68d1aed2dc718dab18e02874232b2769381ccc70b76e028ca1cd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2bdf67c56ff68d1aed2dc718dab18e02874232b2769381ccc70b76e028ca1cd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bdf67c56ff68d1aed2dc718dab18e02874232b2769381ccc70b76e028ca1cd2", kill_on_drop: false }` [INFO] [stdout] 2bdf67c56ff68d1aed2dc718dab18e02874232b2769381ccc70b76e028ca1cd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c3993cbed3aa4abf9f4fbdaff7402f3aaa7a18d6d0f565bf98f8f2a8aa8a1d9 [INFO] running `Command { std: "docker" "start" "-a" "9c3993cbed3aa4abf9f4fbdaff7402f3aaa7a18d6d0f565bf98f8f2a8aa8a1d9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking console v0.16.2 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Checking colored v3.1.1 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking indicatif v0.18.4 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking four0three v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | ResolvedPayloads { headers: header_payloads, ip_payloads: ip_payloads, url_payloads: url_payloads, oob_payloads: oob_payloads, ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | ResolvedPayloads { headers: header_payloads, ip_payloads: ip_payloads, url_payloads: url_payloads, oob_payloads: oob_payloads, ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:76 [INFO] [stdout] | [INFO] [stdout] 118 | ...oads, ip_payloads: ip_payloads, url_payloads: url_payloads, oob_payloads: oob_payloads, oob_domain_payloads: oob_domains, whites... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:104 [INFO] [stdout] | [INFO] [stdout] 118 | ...ds, url_payloads: url_payloads, oob_payloads: oob_payloads, oob_domain_payloads: oob_domains, whitespace_payloads: whitespace_pa... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oob_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:76 [INFO] [stdout] | [INFO] [stdout] 118 | ...oads, ip_payloads: ip_payloads, url_payloads: url_payloads, oob_payloads: oob_payloads, oob_domain_payloads: oob_domains, whites... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:166 [INFO] [stdout] | [INFO] [stdout] 118 | ...yloads: oob_domains, whitespace_payloads: whitespace_payloads, path_payload: path_payload } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `whitespace_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:104 [INFO] [stdout] | [INFO] [stdout] 118 | ...ds, url_payloads: url_payloads, oob_payloads: oob_payloads, oob_domain_payloads: oob_domains, whitespace_payloads: whitespace_pa... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oob_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:208 [INFO] [stdout] | [INFO] [stdout] 118 | ..._payloads: whitespace_payloads, path_payload: path_payload } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:166 [INFO] [stdout] | [INFO] [stdout] 118 | ...yloads: oob_domains, whitespace_payloads: whitespace_payloads, path_payload: path_payload } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `whitespace_payloads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handle_extra_payloads.rs:118:208 [INFO] [stdout] | [INFO] [stdout] 118 | ..._payloads: whitespace_payloads, path_payload: path_payload } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `overriden` is assigned to, but never used [INFO] [stdout] --> src/build_and_send_request_packet.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | let mut overriden = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_overriden` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `overriden` is never read [INFO] [stdout] --> src/build_and_send_request_packet.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | overriden = match scheme.unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `target` is never read [INFO] [stdout] --> src/print_init_and_status.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | let mut target = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `total` is never read [INFO] [stdout] --> src/main.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | let mut total = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `overriden` is assigned to, but never used [INFO] [stdout] --> src/build_and_send_request_packet.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | let mut overriden = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_overriden` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `overriden` is never read [INFO] [stdout] --> src/build_and_send_request_packet.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | overriden = match scheme.unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `target` is never read [INFO] [stdout] --> src/print_init_and_status.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | let mut target = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `total` is never read [INFO] [stdout] --> src/main.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 147 | let mut total = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/handle_extra_payloads.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn handle_extra_payloads( [INFO] [stdout] 7 | | oob_payload: &Option, [INFO] [stdout] 8 | | oob_domain: &Option, [INFO] [stdout] 9 | | extra_header: &Option, [INFO] [stdout] ... | [INFO] [stdout] 16 | | skip_ip: &bool, [INFO] [stdout] 17 | | skip_url: &bool) -> ResolvedPayloads { [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handle_extra_payloads.rs:67:58 [INFO] [stdout] | [INFO] [stdout] 67 | if !general_purpose::STANDARD.encode(&item).eq(&item.to_string()) { [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handle_extra_payloads.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 74 | if encode(&item).eq(&item.to_string()) { [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/build_and_send_request_packet.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | if !scheme.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `scheme.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `scheme` after checking its variant with `is_none` [INFO] [stdout] --> src/build_and_send_request_packet.rs:56:27 [INFO] [stdout] | [INFO] [stdout] 55 | if !scheme.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 56 | overriden = match scheme.unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/mutate_request.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn build_status_message( [INFO] [stdout] 10 | | verbose: bool, [INFO] [stdout] 11 | | one: &AtomicUsize, two_oh_two: &AtomicUsize, other_two: &AtomicUsize, [INFO] [stdout] 12 | | three_oh_one: &AtomicUsize, other_three: &AtomicUsize, [INFO] [stdout] 13 | | four_oh_one: &AtomicUsize, four_oh_three: &AtomicUsize, four_oh_four: &AtomicUsize, other_four: &AtomicUsize, [INFO] [stdout] 14 | | five_two_four: &AtomicUsize, other_five: &AtomicUsize, [INFO] [stdout] 15 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mutate_request.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 42 | other.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/mutate_request.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 87 | let insecure = insecure.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `insecure` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/mutate_request.rs:89:32 [INFO] [stdout] | [INFO] [stdout] 89 | let follow_redirects = follow_redirects.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `follow_redirects` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/mutate_request.rs:92:23 [INFO] [stdout] | [INFO] [stdout] 92 | let verbose = args.verbose.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `args.verbose` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/print_init_and_status.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let proxy = !args.burp.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `args.burp.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/print_init_and_status.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | target = format!("{}", req.url); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `req.url.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/print_init_and_status.rs:20:52 [INFO] [stdout] | [INFO] [stdout] 20 | target = format!("{}://{}", proto, no_proto.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.scheme_override` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 44 | if args.scheme_override.is_some() { [INFO] [stdout] | --------------------------------- help: try: `if let Some() = &args.scheme_override` [INFO] [stdout] 45 | scheme = match args.scheme_override.as_ref().unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let host = head_split.iter().filter(|h| h.contains("Host")).next().unwrap().replace("Host: ", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `head_split.iter().find(|h| h.contains("Host"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:156:40 [INFO] [stdout] | [INFO] [stdout] 156 | if let Some(matched) = re.find(&h) { [INFO] [stdout] | ^^ help: change this to: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | url_template_count = url_template_count * &finalized_payloads.url_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_template_count *= &finalized_payloads.url_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 183 | url_template_count = url_template_count * &finalized_payloads.url_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.url_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | ip_template_count = ip_template_count * &finalized_payloads.ip_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_template_count *= &finalized_payloads.ip_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:184:25 [INFO] [stdout] | [INFO] [stdout] 184 | ip_template_count = ip_template_count * &finalized_payloads.ip_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.ip_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | oob_template_count = oob_template_count * &finalized_payloads.oob_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oob_template_count *= &finalized_payloads.oob_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | oob_template_count = oob_template_count * &finalized_payloads.oob_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.oob_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | oob_domain_template_count = oob_domain_template_count * &finalized_payloads.oob_domain_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oob_domain_template_count *= &finalized_payloads.oob_domain_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:186:33 [INFO] [stdout] | [INFO] [stdout] 186 | oob_domain_template_count = oob_domain_template_count * &finalized_payloads.oob_domain_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.oob_domain_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | path_template_count = path_template_count * &finalized_payloads.path_payload.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_template_count *= &finalized_payloads.path_payload.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:187:27 [INFO] [stdout] | [INFO] [stdout] 187 | path_template_count = path_template_count * &finalized_payloads.path_payload.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.path_payload.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 188 | whitespace_template_count = whitespace_template_count * &finalized_payloads.whitespace_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `whitespace_template_count *= &finalized_payloads.whitespace_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:188:33 [INFO] [stdout] | [INFO] [stdout] 188 | whitespace_template_count = whitespace_template_count * &finalized_payloads.whitespace_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.whitespace_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/handle_extra_payloads.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn handle_extra_payloads( [INFO] [stdout] 7 | | oob_payload: &Option, [INFO] [stdout] 8 | | oob_domain: &Option, [INFO] [stdout] 9 | | extra_header: &Option, [INFO] [stdout] ... | [INFO] [stdout] 16 | | skip_ip: &bool, [INFO] [stdout] 17 | | skip_url: &bool) -> ResolvedPayloads { [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handle_extra_payloads.rs:67:58 [INFO] [stdout] | [INFO] [stdout] 67 | if !general_purpose::STANDARD.encode(&item).eq(&item.to_string()) { [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handle_extra_payloads.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 74 | if encode(&item).eq(&item.to_string()) { [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/build_and_send_request_packet.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | if !scheme.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `scheme.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `scheme` after checking its variant with `is_none` [INFO] [stdout] --> src/build_and_send_request_packet.rs:56:27 [INFO] [stdout] | [INFO] [stdout] 55 | if !scheme.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 56 | overriden = match scheme.unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/mutate_request.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn build_status_message( [INFO] [stdout] 10 | | verbose: bool, [INFO] [stdout] 11 | | one: &AtomicUsize, two_oh_two: &AtomicUsize, other_two: &AtomicUsize, [INFO] [stdout] 12 | | three_oh_one: &AtomicUsize, other_three: &AtomicUsize, [INFO] [stdout] 13 | | four_oh_one: &AtomicUsize, four_oh_three: &AtomicUsize, four_oh_four: &AtomicUsize, other_four: &AtomicUsize, [INFO] [stdout] 14 | | five_two_four: &AtomicUsize, other_five: &AtomicUsize, [INFO] [stdout] 15 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mutate_request.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 42 | other.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/mutate_request.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 87 | let insecure = insecure.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `insecure` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/mutate_request.rs:89:32 [INFO] [stdout] | [INFO] [stdout] 89 | let follow_redirects = follow_redirects.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `follow_redirects` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/mutate_request.rs:92:23 [INFO] [stdout] | [INFO] [stdout] 92 | let verbose = args.verbose.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `args.verbose` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/print_init_and_status.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let proxy = !args.burp.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `args.burp.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/print_init_and_status.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | target = format!("{}", req.url); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `req.url.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/print_init_and_status.rs:20:52 [INFO] [stdout] | [INFO] [stdout] 20 | target = format!("{}://{}", proto, no_proto.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.scheme_override` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 44 | if args.scheme_override.is_some() { [INFO] [stdout] | --------------------------------- help: try: `if let Some() = &args.scheme_override` [INFO] [stdout] 45 | scheme = match args.scheme_override.as_ref().unwrap().as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/main.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let host = head_split.iter().filter(|h| h.contains("Host")).next().unwrap().replace("Host: ", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `head_split.iter().find(|h| h.contains("Host"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:156:40 [INFO] [stdout] | [INFO] [stdout] 156 | if let Some(matched) = re.find(&h) { [INFO] [stdout] | ^^ help: change this to: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | url_template_count = url_template_count * &finalized_payloads.url_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_template_count *= &finalized_payloads.url_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 183 | url_template_count = url_template_count * &finalized_payloads.url_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.url_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | ip_template_count = ip_template_count * &finalized_payloads.ip_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_template_count *= &finalized_payloads.ip_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:184:25 [INFO] [stdout] | [INFO] [stdout] 184 | ip_template_count = ip_template_count * &finalized_payloads.ip_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.ip_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | oob_template_count = oob_template_count * &finalized_payloads.oob_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oob_template_count *= &finalized_payloads.oob_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | oob_template_count = oob_template_count * &finalized_payloads.oob_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.oob_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | oob_domain_template_count = oob_domain_template_count * &finalized_payloads.oob_domain_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oob_domain_template_count *= &finalized_payloads.oob_domain_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:186:33 [INFO] [stdout] | [INFO] [stdout] 186 | oob_domain_template_count = oob_domain_template_count * &finalized_payloads.oob_domain_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.oob_domain_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | path_template_count = path_template_count * &finalized_payloads.path_payload.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_template_count *= &finalized_payloads.path_payload.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:187:27 [INFO] [stdout] | [INFO] [stdout] 187 | path_template_count = path_template_count * &finalized_payloads.path_payload.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.path_payload.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 188 | whitespace_template_count = whitespace_template_count * &finalized_payloads.whitespace_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `whitespace_template_count *= &finalized_payloads.whitespace_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/main.rs:188:33 [INFO] [stdout] | [INFO] [stdout] 188 | whitespace_template_count = whitespace_template_count * &finalized_payloads.whitespace_payloads.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `finalized_payloads.whitespace_payloads.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 26s [INFO] running `Command { std: "docker" "inspect" "9c3993cbed3aa4abf9f4fbdaff7402f3aaa7a18d6d0f565bf98f8f2a8aa8a1d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c3993cbed3aa4abf9f4fbdaff7402f3aaa7a18d6d0f565bf98f8f2a8aa8a1d9", kill_on_drop: false }` [INFO] [stdout] 9c3993cbed3aa4abf9f4fbdaff7402f3aaa7a18d6d0f565bf98f8f2a8aa8a1d9